mirror of
https://github.com/mudler/LocalAI.git
synced 2026-10-30 18:19:33 -04:00
Ettore Di Giacinto
1dc3aeef87
A model's revision is published by administration and checked against on every inference request. Those were computed by separate code: the request path resolves through the loader, while each publisher hashed whatever ModelConfig it happened to hold. By then SetDefaults had folded in the GGUF guess and app-level options, so the published value was one no request would ever carry and the model became unroutable until the row was deleted by hand. Fixing the publishers one at a time did not hold. Three rounds each found another: the startup resync, then a saved edit and a toggle, then a rename and the peer-change path. ModelConfigLoader.RevisionFor is now the only way to obtain a revision, and the raw hash is unexported, so a caller outside this package cannot hash a config it holds. A publisher and a request agree by construction rather than by two implementations happening to match. The request path no longer falls back to hashing its merged config either: an unstamped config is routed without a revision rather than with a wrong one. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude Code:claude-opus-5 [golangci-lint]
56 lines
1.7 KiB
Go
56 lines
1.7 KiB
Go
package config
|
|
|
|
import (
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"encoding/json"
|
|
"errors"
|
|
|
|
pb "github.com/mudler/LocalAI/pkg/grpc/proto"
|
|
"google.golang.org/protobuf/proto"
|
|
)
|
|
|
|
// modelConfigRevision returns a stable revision of the persisted semantic
|
|
// configuration. ModelConfig's JSON tags exclude runtime-derived state and
|
|
// source bookkeeping, while encoding/json orders map keys deterministically.
|
|
//
|
|
// Deliberately unexported. It must only ever be called on a configuration as
|
|
// parsed from disk, before SetDefaults folds in the GGUF guess, the hardware
|
|
// defaults and app-level options. Callers outside this package cannot tell
|
|
// which they hold, and every time one hashed a defaulted or request-merged
|
|
// config it published a revision no inference request would carry, which makes
|
|
// the model unroutable. Use ModelConfigLoader.RevisionFor instead.
|
|
func modelConfigRevision(cfg *ModelConfig) (string, error) {
|
|
if cfg == nil {
|
|
return "", errors.New("model config is nil")
|
|
}
|
|
|
|
canonical, err := json.Marshal(cfg)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return sha256Hex(canonical), nil
|
|
}
|
|
|
|
// EffectiveModelOptionsHash returns a deterministic hash of materialized
|
|
// backend options without allowing protobuf marshaling to mutate caller state.
|
|
func EffectiveModelOptionsHash(opts *pb.ModelOptions) (string, error) {
|
|
if opts == nil {
|
|
return "", errors.New("model options are nil")
|
|
}
|
|
|
|
cloned := proto.Clone(opts).(*pb.ModelOptions)
|
|
canonical, err := (proto.MarshalOptions{Deterministic: true}).Marshal(cloned)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return sha256Hex(canonical), nil
|
|
}
|
|
|
|
func sha256Hex(value []byte) string {
|
|
digest := sha256.Sum256(value)
|
|
return hex.EncodeToString(digest[:])
|
|
}
|