mirror of
https://github.com/mudler/LocalAI.git
synced 2026-05-16 20:52:08 -04:00
* refactor(transcription): propagate request ctx through ModelTranscription* Replaces context.Background() with the HTTP request ctx so client disconnects start cancelling the gRPC call. No backend-side abort wiring yet — that comes in a later commit. Pure plumbing. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(cli): pass ctx to backend.ModelTranscription Follow-up toe65d3e1fwhich threaded ctx through ModelTranscription but missed the CLI caller. CLI commands have no request-scoped ctx, so context.Background() is correct here. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(audio): propagate request ctx into TTS, sound-gen, audio-transform Same ctx-plumbing pattern applied to the rest of the audio path. CLI callers use context.Background() since there is no request scope; HTTP callers use c.Request().Context(). Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(backend): propagate request ctx into biometric, detection, rerank, diarization paths Replaces remaining context.Background() sites in core/backend with the caller's ctx. After this commit, every core/backend/*.go entry point threads the request ctx end-to-end to the gRPC client. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(grpc): plumb ctx through AIModel.AudioTranscription{,Stream} Adds context.Context as first parameter to the AIModel interface methods that wrap whisper-style transcription. Server-side gRPC handler now forwards the per-RPC ctx (server-streaming uses stream.Context()). Whisper, Voxtral, vibevoice-cpp, and sherpa-onnx accept the parameter; none uses it yet — the actual cancellation primitive lands in the next commit so this is pure plumbing. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(whisper): add abort_callback hook in the C++ bridge Installs a std::atomic<int> flag, wires it into whisper_full_params.abort_callback, and exposes a set_abort(int) C symbol so Go can flip the flag from a goroutine watching the request context. transcribe() now distinguishes abort (return 2) from real whisper_full failure (return 1). Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(whisper): register set_abort symbol in the purego loader Adds the Go-side binding for the new C export so the next commit can call CppSetAbort(1) from a watcher goroutine on ctx.Done(). Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(whisper): honor ctx cancellation and return codes.Canceled A watcher goroutine watches ctx.Done() during AudioTranscription and calls CppSetAbort(1) on cancel. whisper_full sees abort_callback return true at the next compute graph step, returns non-zero, and the bridge returns 2 -> AudioTranscription maps that to codes.Canceled. Adds an opt-in test (gated on WHISPER_MODEL_PATH / WHISPER_AUDIO_PATH) that asserts cancellation latency under 5s and proves the abort flag resets cleanly so the next transcription succeeds. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(whisper): join the cancel watcher goroutine before returning Follow-up to85edf9d2. The previous commit used `defer close(done)` and called the watcher "joined synchronously" — but close() only signals, it does not block until the goroutine exits. That left a window where a late CppSetAbort(1) from a cancelled call could land on the next call, after its C-side g_abort reset but before whisper_full() began polling the abort callback, corrupting the second transcription. Switch to a sync.WaitGroup join so wg.Wait() blocks until the watcher has actually returned from its select. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(whisper): short-circuit pre-cancelled ctx in AudioTranscription If ctx is already Done() at entry, return codes.Canceled immediately instead of running the full transcription. The C-side g_abort reset happens at the start of transcribe() and would otherwise overwrite a watcher-set abort flag from an already-cancelled ctx, producing a spurious successful transcription on a request the client has already abandoned. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(tests/distributed): update testLLM mock for new AudioTranscription signature Phase B (93c48e19) added context.Context to AIModel.AudioTranscription but missed the testLLM mock in tests/e2e/distributed. CI golangci-lint caught it: *testLLM did not implement grpc.AIModel because the method signature lacked the ctx parameter, which broke the distributed test suite compilation and cascaded through every backend-build job that runs `go build ./...`. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(whisper): port cancellation test to Ginkgo/Gomega Project policy (.agents/coding-style.md, enforced by golangci-lint forbidigo) is that all Go tests must use Ginkgo v2 + Gomega — no stdlib testing patterns (t.Skip, t.Fatalf, etc.). Convert the cancellation test to a Describe/It block with Skip(...) for env gating and Expect/HaveOccurred for assertions. Same coverage: cancel mid-flight returns codes.Canceled within 5s and a follow-up transcription succeeds, proving the C-side g_abort flag resets cleanly. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
178 lines
4.7 KiB
C++
178 lines
4.7 KiB
C++
#include "gowhisper.h"
|
|
#include "ggml-backend.h"
|
|
#include "whisper.h"
|
|
#include <atomic>
|
|
#include <vector>
|
|
|
|
static struct whisper_vad_context *vctx;
|
|
static struct whisper_context *ctx;
|
|
static std::vector<float> flat_segs;
|
|
|
|
static std::atomic<int> g_abort{0};
|
|
|
|
static bool abort_cb(void * /*user_data*/) {
|
|
return g_abort.load(std::memory_order_relaxed) != 0;
|
|
}
|
|
|
|
extern "C" void set_abort(int v) {
|
|
g_abort.store(v, std::memory_order_relaxed);
|
|
}
|
|
|
|
static void ggml_log_cb(enum ggml_log_level level, const char *log,
|
|
void *data) {
|
|
const char *level_str;
|
|
|
|
if (!log) {
|
|
return;
|
|
}
|
|
|
|
switch (level) {
|
|
case GGML_LOG_LEVEL_DEBUG:
|
|
level_str = "DEBUG";
|
|
break;
|
|
case GGML_LOG_LEVEL_INFO:
|
|
level_str = "INFO";
|
|
break;
|
|
case GGML_LOG_LEVEL_WARN:
|
|
level_str = "WARN";
|
|
break;
|
|
case GGML_LOG_LEVEL_ERROR:
|
|
level_str = "ERROR";
|
|
break;
|
|
default: /* Potential future-proofing */
|
|
level_str = "?????";
|
|
break;
|
|
}
|
|
|
|
fprintf(stderr, "[%-5s] ", level_str);
|
|
fputs(log, stderr);
|
|
fflush(stderr);
|
|
}
|
|
|
|
int load_model(const char *const model_path) {
|
|
whisper_log_set(ggml_log_cb, nullptr);
|
|
ggml_backend_load_all();
|
|
|
|
struct whisper_context_params cparams = whisper_context_default_params();
|
|
|
|
ctx = whisper_init_from_file_with_params(model_path, cparams);
|
|
if (ctx == nullptr) {
|
|
fprintf(stderr, "error: Also failed to init model as transcriber\n");
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int load_model_vad(const char *const model_path) {
|
|
whisper_log_set(ggml_log_cb, nullptr);
|
|
ggml_backend_load_all();
|
|
|
|
struct whisper_vad_context_params vcparams =
|
|
whisper_vad_default_context_params();
|
|
|
|
// XXX: Overridden to false in upstream due to performance?
|
|
// vcparams.use_gpu = true;
|
|
|
|
vctx = whisper_vad_init_from_file_with_params(model_path, vcparams);
|
|
if (vctx == nullptr) {
|
|
fprintf(stderr, "error: Failed to init model as VAD\n");
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int vad(float pcmf32[], size_t pcmf32_len, float **segs_out,
|
|
size_t *segs_out_len) {
|
|
if (!whisper_vad_detect_speech(vctx, pcmf32, pcmf32_len)) {
|
|
fprintf(stderr, "error: failed to detect speech\n");
|
|
return 1;
|
|
}
|
|
|
|
struct whisper_vad_params params = whisper_vad_default_params();
|
|
struct whisper_vad_segments *segs =
|
|
whisper_vad_segments_from_probs(vctx, params);
|
|
size_t segn = whisper_vad_segments_n_segments(segs);
|
|
|
|
// fprintf(stderr, "Got segments %zd\n", segn);
|
|
|
|
flat_segs.clear();
|
|
|
|
for (int i = 0; i < segn; i++) {
|
|
flat_segs.push_back(whisper_vad_segments_get_segment_t0(segs, i));
|
|
flat_segs.push_back(whisper_vad_segments_get_segment_t1(segs, i));
|
|
}
|
|
|
|
// fprintf(stderr, "setting out variables: %p=%p -> %p, %p=%zx -> %zx\n",
|
|
// segs_out, *segs_out, flat_segs.data(), segs_out_len, *segs_out_len,
|
|
// flat_segs.size());
|
|
*segs_out = flat_segs.data();
|
|
*segs_out_len = flat_segs.size();
|
|
|
|
// fprintf(stderr, "freeing segs\n");
|
|
whisper_vad_free_segments(segs);
|
|
|
|
// fprintf(stderr, "returning\n");
|
|
return 0;
|
|
}
|
|
|
|
int transcribe(uint32_t threads, char *lang, bool translate, bool tdrz,
|
|
float pcmf32[], size_t pcmf32_len, size_t *segs_out_len, char *prompt) {
|
|
whisper_full_params wparams =
|
|
whisper_full_default_params(WHISPER_SAMPLING_GREEDY);
|
|
|
|
wparams.n_threads = threads;
|
|
if (*lang != '\0')
|
|
wparams.language = lang;
|
|
else {
|
|
wparams.language = nullptr;
|
|
}
|
|
|
|
wparams.translate = translate;
|
|
wparams.debug_mode = true;
|
|
wparams.print_progress = true;
|
|
wparams.tdrz_enable = tdrz;
|
|
wparams.initial_prompt = prompt;
|
|
|
|
// Reset stale abort flag from any prior cancelled call, then install the
|
|
// ggml abort hook so a subsequent set_abort(1) from Go aborts the next
|
|
// compute graph step.
|
|
g_abort.store(0, std::memory_order_relaxed);
|
|
wparams.abort_callback = abort_cb;
|
|
wparams.abort_callback_user_data = nullptr;
|
|
|
|
fprintf(stderr, "info: Enable tdrz: %d\n", tdrz);
|
|
fprintf(stderr, "info: Initial prompt: \"%s\"\n", prompt);
|
|
|
|
if (whisper_full(ctx, wparams, pcmf32, pcmf32_len)) {
|
|
if (g_abort.load(std::memory_order_relaxed)) {
|
|
return 2; // aborted by client
|
|
}
|
|
fprintf(stderr, "error: transcription failed\n");
|
|
return 1;
|
|
}
|
|
|
|
*segs_out_len = whisper_full_n_segments(ctx);
|
|
|
|
return 0;
|
|
}
|
|
|
|
const char *get_segment_text(int i) {
|
|
return whisper_full_get_segment_text(ctx, i);
|
|
}
|
|
|
|
int64_t get_segment_t0(int i) { return whisper_full_get_segment_t0(ctx, i); }
|
|
|
|
int64_t get_segment_t1(int i) { return whisper_full_get_segment_t1(ctx, i); }
|
|
|
|
int n_tokens(int i) { return whisper_full_n_tokens(ctx, i); }
|
|
|
|
int32_t get_token_id(int i, int j) {
|
|
return whisper_full_get_token_id(ctx, i, j);
|
|
}
|
|
|
|
bool get_segment_speaker_turn_next(int i) {
|
|
return whisper_full_get_segment_speaker_turn_next(ctx, i);
|
|
}
|