mirror of
https://github.com/mudler/LocalAI.git
synced 2026-07-30 09:57:57 -04:00
flock(2) on CIFS/SMB returns EACCES when another client holds the lock: the kernel maps STATUS_LOCK_NOT_GRANTED and STATUS_FILE_LOCK_CONFLICT to -EACCES and never produces EWOULDBLOCK on that path. gofrs/flock only recognises EWOULDBLOCK as contention, so TryLockContext returned a bare "permission denied" and Ensure aborted. Both replicas then fell back to legacy loading, which makes the worker download the whole repo in-band inside LoadModel and blow the remote-load deadline. Replace TryLockContext with an explicit wait loop over a new Locker interface, classifying EWOULDBLOCK/EAGAIN/EACCES/EBUSY as contention. EACCES is ambiguous at the syscall boundary but not here: the lock file is already open O_CREATE|O_RDWR, so a real permission problem would have failed the open with an *fs.PathError, and flock(2) documents no EACCES on Linux at all. The wait is bounded (DefaultLockWait, overridable via WithLockWait), so even a misclassification degrades to a delay. On timeout the committed result is re-checked before reporting the new ErrLockContended, so a peer that finished the work still wins. Locker also exists so the contention path is testable without a network filesystem: nothing in CI can make flock(2) return EACCES on demand. Raise the fallback to error for a managedArtifactBackends backend, via a shared config.LogArtifactFallback used by both call sites. For those backends the legacy path is not graceful degradation, and the operator otherwise sees only a timeout with no causal link. The fallback stays non-fatal. Drop the os.Chmod(layout.Lock, 0o600) after acquisition: flock.New already creates the file 0600, and the chmod was gratuitous risk on a nounix mount that ignores modes. Fixes #10981 Assisted-by: Claude Code:claude-opus-4-8[1m] [Read] [Edit] [Bash] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
489 lines
16 KiB
Go
489 lines
16 KiB
Go
package modelartifacts
|
|
|
|
import (
|
|
"context"
|
|
"crypto/sha1"
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path"
|
|
"path/filepath"
|
|
"strings"
|
|
"syscall"
|
|
"time"
|
|
|
|
"github.com/gofrs/flock"
|
|
"github.com/mudler/xlog"
|
|
|
|
"github.com/mudler/LocalAI/pkg/downloader"
|
|
hfapi "github.com/mudler/LocalAI/pkg/huggingface-api"
|
|
)
|
|
|
|
type SnapshotResolver interface {
|
|
ResolveSnapshot(context.Context, hfapi.SnapshotRequest) (hfapi.Snapshot, error)
|
|
}
|
|
|
|
// Locker is the cross-process exclusion primitive that keeps two replicas from
|
|
// materializing the same snapshot at once. It is an interface rather than a
|
|
// concrete *flock.Flock because the contention path has to be exercised without
|
|
// a network filesystem: no test environment can make flock(2) return the
|
|
// CIFS-specific errno this code must tolerate, and it is also the seam a
|
|
// database-backed lock would plug into for multi-node deployments.
|
|
type Locker interface {
|
|
TryLock() (bool, error)
|
|
Unlock() error
|
|
}
|
|
|
|
// ErrLockContended reports that a peer held the artifact lock for the whole
|
|
// wait window and never published a usable snapshot. It is deliberately
|
|
// distinct from an acquisition failure: the work is in progress elsewhere, so
|
|
// callers can say so rather than blaming the model.
|
|
var ErrLockContended = errors.New("artifact lock is held by another process")
|
|
|
|
const (
|
|
// DefaultLockWait bounds how long Ensure waits for a peer replica. It is
|
|
// generous because the peer may legitimately be downloading tens of
|
|
// gigabytes, and waiting is strictly cheaper than the fallback, which makes
|
|
// the backend download the same repo in-band.
|
|
DefaultLockWait = 30 * time.Minute
|
|
|
|
initialLockRetryInterval = 100 * time.Millisecond
|
|
maxLockRetryInterval = 5 * time.Second
|
|
)
|
|
|
|
type Manager struct {
|
|
resolver SnapshotResolver
|
|
huggingFaceToken string
|
|
newLocker func(string) Locker
|
|
lockWait time.Duration
|
|
}
|
|
|
|
type ManagerOption func(*Manager)
|
|
|
|
type Result struct {
|
|
Spec Spec
|
|
RelativePath string
|
|
Manifest Manifest
|
|
CacheHit bool
|
|
}
|
|
|
|
func WithHuggingFaceToken(token string) ManagerOption {
|
|
return func(manager *Manager) { manager.huggingFaceToken = token }
|
|
}
|
|
|
|
// WithLocker overrides how the artifact lock is created. The default is an
|
|
// flock(2) lock on the shared models directory.
|
|
func WithLocker(factory func(path string) Locker) ManagerOption {
|
|
return func(manager *Manager) {
|
|
if factory != nil {
|
|
manager.newLocker = factory
|
|
}
|
|
}
|
|
}
|
|
|
|
// WithLockWait bounds how long Ensure waits for a peer replica holding the
|
|
// artifact lock before giving up with ErrLockContended.
|
|
func WithLockWait(wait time.Duration) ManagerOption {
|
|
return func(manager *Manager) {
|
|
if wait > 0 {
|
|
manager.lockWait = wait
|
|
}
|
|
}
|
|
}
|
|
|
|
func NewManager(resolver SnapshotResolver, options ...ManagerOption) *Manager {
|
|
manager := &Manager{
|
|
resolver: resolver,
|
|
newLocker: func(path string) Locker { return flock.New(path) },
|
|
lockWait: DefaultLockWait,
|
|
}
|
|
for _, option := range options {
|
|
option(manager)
|
|
}
|
|
return manager
|
|
}
|
|
|
|
func NewDefaultManager(options ...ManagerOption) *Manager {
|
|
client := hfapi.NewClient()
|
|
client.SetBaseURL(strings.TrimRight(downloader.HF_ENDPOINT, "/") + "/api/models")
|
|
return NewManager(client, options...)
|
|
}
|
|
|
|
func committedResult(modelsPath string, spec Spec) (Result, bool) {
|
|
if spec.Resolved == nil || spec.Resolved.CacheKey == "" {
|
|
return Result{}, false
|
|
}
|
|
layout, err := LayoutFor(modelsPath, spec)
|
|
if err != nil {
|
|
return Result{}, false
|
|
}
|
|
manifest, err := ReadManifest(layout.Manifest)
|
|
if err != nil || manifest.Artifact.Resolved == nil || manifest.Artifact.Resolved.CacheKey != spec.Resolved.CacheKey {
|
|
return Result{}, false
|
|
}
|
|
specKey, err := CacheKey(spec)
|
|
if err != nil || specKey != spec.Resolved.CacheKey {
|
|
return Result{}, false
|
|
}
|
|
manifestKey, err := CacheKey(manifest.Artifact)
|
|
if err != nil || manifestKey != spec.Resolved.CacheKey || len(manifest.Files) == 0 {
|
|
return Result{}, false
|
|
}
|
|
for _, file := range manifest.Files {
|
|
info, err := os.Stat(filepath.Join(layout.Snapshot, filepath.FromSlash(file.Path)))
|
|
if err != nil || !info.Mode().IsRegular() || info.Size() != file.Size {
|
|
return Result{}, false
|
|
}
|
|
}
|
|
relative, err := RelativeSnapshotPath(spec.Resolved.CacheKey)
|
|
if err != nil {
|
|
return Result{}, false
|
|
}
|
|
return Result{Spec: spec, RelativePath: relative, Manifest: manifest, CacheHit: true}, true
|
|
}
|
|
|
|
func (m *Manager) Ensure(ctx context.Context, modelsPath string, spec Spec) (Result, error) {
|
|
if err := ctx.Err(); err != nil {
|
|
return Result{}, err
|
|
}
|
|
normalized, err := spec.Normalize()
|
|
if err != nil {
|
|
return Result{}, err
|
|
}
|
|
if cached, ok := committedResult(modelsPath, normalized); ok {
|
|
return cached, nil
|
|
}
|
|
if m == nil || m.resolver == nil {
|
|
return Result{}, fmt.Errorf("artifact materializer has no snapshot resolver")
|
|
}
|
|
token := ""
|
|
if normalized.Source.TokenEnv == HuggingFaceTokenEnv {
|
|
token = m.huggingFaceToken
|
|
if token == "" {
|
|
return Result{}, fmt.Errorf("artifact requires non-empty %s", HuggingFaceTokenEnv)
|
|
}
|
|
}
|
|
revision := normalized.Source.Revision
|
|
if normalized.Resolved != nil {
|
|
revision = normalized.Resolved.Revision
|
|
}
|
|
ReportProgress(ctx, ProgressEvent{Phase: PhaseResolving, Artifact: normalized.Name})
|
|
snapshot, err := m.resolver.ResolveSnapshot(ctx, hfapi.SnapshotRequest{
|
|
Repo: normalized.Source.Repo, Revision: revision, Token: token,
|
|
AllowPatterns: normalized.Source.AllowPatterns, IgnorePatterns: normalized.Source.IgnorePatterns,
|
|
})
|
|
if err != nil {
|
|
return Result{}, err
|
|
}
|
|
if normalized.Resolved != nil && (snapshot.Endpoint != normalized.Resolved.Endpoint || snapshot.ResolvedRevision != normalized.Resolved.Revision) {
|
|
return Result{}, fmt.Errorf("resolved artifact identity changed; reinstall the model")
|
|
}
|
|
normalized.Resolved = &Resolved{Endpoint: snapshot.Endpoint, Revision: snapshot.ResolvedRevision}
|
|
// A snapshot with exactly one file is a single-file model (e.g. a GGUF for
|
|
// llama.cpp/whisper). Record it so the load target resolves to the file
|
|
// itself rather than the snapshot directory. PrimaryFile is deliberately not
|
|
// part of the cache key: it is derived from the resolved contents, not the
|
|
// request identity.
|
|
if len(snapshot.Files) == 1 {
|
|
normalized.Resolved.PrimaryFile = snapshot.Files[0].Path
|
|
}
|
|
cacheKey, err := CacheKey(normalized)
|
|
if err != nil {
|
|
return Result{}, err
|
|
}
|
|
normalized.Resolved.CacheKey = cacheKey
|
|
layout, err := LayoutFor(modelsPath, normalized)
|
|
if err != nil {
|
|
return Result{}, err
|
|
}
|
|
if err := os.MkdirAll(filepath.Dir(layout.Lock), 0o750); err != nil {
|
|
return Result{}, err
|
|
}
|
|
artifactLock := m.newLocker(layout.Lock)
|
|
if err := m.acquireLock(ctx, artifactLock, layout.Lock); err != nil {
|
|
// A peer that held the lock for the whole window was very likely doing
|
|
// exactly this work. Its committed snapshot is the answer we wanted, so
|
|
// prefer it over reporting contention to a caller that would degrade to
|
|
// an in-band download.
|
|
if errors.Is(err, ErrLockContended) {
|
|
if cached, ok := committedResult(modelsPath, normalized); ok {
|
|
return cached, nil
|
|
}
|
|
}
|
|
return Result{}, err
|
|
}
|
|
defer func() {
|
|
if err := artifactLock.Unlock(); err != nil {
|
|
xlog.Warn("failed to unlock model artifact", "lock", layout.Lock, "error", err)
|
|
}
|
|
}()
|
|
if cached, ok := committedResult(modelsPath, normalized); ok {
|
|
return cached, nil
|
|
}
|
|
if err := removeInvalidFinal(layout); err != nil {
|
|
return Result{}, err
|
|
}
|
|
return m.materializeLocked(ctx, modelsPath, normalized, snapshot, token, layout)
|
|
}
|
|
|
|
// isLockContention reports whether a failed lock attempt means "somebody else
|
|
// holds it" rather than "this will never work".
|
|
//
|
|
// Only EWOULDBLOCK is portable, and it is the only errno gofrs/flock treats as
|
|
// contention. Network filesystems translate their own protocol status codes
|
|
// instead: CIFS/SMB maps STATUS_LOCK_NOT_GRANTED and STATUS_FILE_LOCK_CONFLICT
|
|
// to EACCES, and a busy share can surface EBUSY. Both look like hard errors and
|
|
// aborted materialization outright on a shared /models (#10981).
|
|
//
|
|
// EACCES is ambiguous at the syscall boundary, where it also spells "permission
|
|
// denied", but it is not ambiguous at this call site. The lock file was already opened
|
|
// O_CREATE|O_RDWR before we get here, so a genuine permission problem would
|
|
// have failed the open with an *fs.PathError naming the path. flock(2) itself
|
|
// documents no EACCES on Linux (EBADF, EINTR, EINVAL, ENOLCK, EWOULDBLOCK), so
|
|
// a bare EACCES from the lock call can only have come from a network
|
|
// filesystem's lock-conflict translation. The wait is bounded regardless, so
|
|
// even a misclassification degrades to a delay, not a hang.
|
|
func isLockContention(err error) bool {
|
|
return errors.Is(err, syscall.EWOULDBLOCK) ||
|
|
errors.Is(err, syscall.EAGAIN) ||
|
|
errors.Is(err, syscall.EACCES) ||
|
|
errors.Is(err, syscall.EBUSY)
|
|
}
|
|
|
|
// acquireLock blocks until the artifact lock is held, the context is done, or
|
|
// the wait window expires with ErrLockContended.
|
|
func (m *Manager) acquireLock(ctx context.Context, locker Locker, lockPath string) error {
|
|
wait := m.lockWait
|
|
if wait <= 0 {
|
|
wait = DefaultLockWait
|
|
}
|
|
deadline := time.Now().Add(wait)
|
|
interval := initialLockRetryInterval
|
|
waited := false
|
|
for {
|
|
if err := ctx.Err(); err != nil {
|
|
return err
|
|
}
|
|
locked, err := locker.TryLock()
|
|
if err != nil && !isLockContention(err) {
|
|
return err
|
|
}
|
|
if locked {
|
|
if waited {
|
|
xlog.Info("acquired the model artifact lock after waiting for another replica", "lock", lockPath)
|
|
}
|
|
return nil
|
|
}
|
|
if !waited {
|
|
waited = true
|
|
xlog.Info("another replica is materializing this model artifact; waiting for it", "lock", lockPath)
|
|
}
|
|
if time.Now().After(deadline) {
|
|
return fmt.Errorf("%w: %s", ErrLockContended, lockPath)
|
|
}
|
|
select {
|
|
case <-ctx.Done():
|
|
return ctx.Err()
|
|
case <-time.After(interval):
|
|
}
|
|
if interval < maxLockRetryInterval {
|
|
interval = min(interval*2, maxLockRetryInterval)
|
|
}
|
|
}
|
|
}
|
|
|
|
func removeInvalidFinal(layout Layout) error {
|
|
root, err := os.OpenRoot(layout.Root)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() { _ = root.Close() }()
|
|
relative, err := filepath.Rel(layout.Root, layout.Final)
|
|
if err != nil || filepath.Dir(relative) != "huggingface" || !cacheKeyPattern.MatchString(filepath.Base(relative)) {
|
|
return fmt.Errorf("refusing to remove invalid artifact path %q", layout.Final)
|
|
}
|
|
return root.RemoveAll(relative)
|
|
}
|
|
|
|
func (m *Manager) materializeLocked(ctx context.Context, modelsPath string, spec Spec, snapshot hfapi.Snapshot, token string, layout Layout) (Result, error) {
|
|
if err := os.MkdirAll(layout.Partial, 0o750); err != nil {
|
|
return Result{}, err
|
|
}
|
|
root, err := os.OpenRoot(layout.Partial)
|
|
if err != nil {
|
|
return Result{}, err
|
|
}
|
|
rootClosed := false
|
|
defer func() {
|
|
if !rootClosed {
|
|
_ = root.Close()
|
|
}
|
|
}()
|
|
if err := root.MkdirAll(".downloads", 0o750); err != nil {
|
|
return Result{}, err
|
|
}
|
|
if err := root.MkdirAll("snapshot", 0o750); err != nil {
|
|
return Result{}, err
|
|
}
|
|
totalBytes := int64(0)
|
|
if len(snapshot.Files) == 0 {
|
|
return Result{}, fmt.Errorf("resolved snapshot contains no selected files")
|
|
}
|
|
seenPaths := make(map[string]struct{}, len(snapshot.Files))
|
|
for _, file := range snapshot.Files {
|
|
if err := ValidateRelativeHubPath(file.Path); err != nil {
|
|
return Result{}, err
|
|
}
|
|
if file.Size < 0 || totalBytes > int64(^uint64(0)>>1)-file.Size {
|
|
return Result{}, fmt.Errorf("invalid aggregate snapshot size")
|
|
}
|
|
if _, exists := seenPaths[file.Path]; exists {
|
|
return Result{}, fmt.Errorf("duplicate Hub path %q", file.Path)
|
|
}
|
|
seenPaths[file.Path] = struct{}{}
|
|
totalBytes += file.Size
|
|
}
|
|
|
|
manifest := Manifest{Version: ManifestVersion, Artifact: spec, Files: make([]ManifestFile, 0, len(snapshot.Files))}
|
|
completedBytes := int64(0)
|
|
tasks := make([]downloader.FileTask, 0, len(snapshot.Files))
|
|
for index, file := range snapshot.Files {
|
|
if err := ctx.Err(); err != nil {
|
|
return Result{}, err
|
|
}
|
|
nameSum := sha256.Sum256([]byte(file.Path))
|
|
blobRel := path.Join(".downloads", hex.EncodeToString(nameSum[:]))
|
|
blobAbs := filepath.Join(layout.Partial, filepath.FromSlash(blobRel))
|
|
file := file
|
|
taskIndex := index
|
|
task := downloader.FileTask{
|
|
URI: downloader.URI(file.URL),
|
|
Destination: blobAbs,
|
|
SHA256: file.LFSOID,
|
|
FileIndex: taskIndex,
|
|
TotalFiles: len(snapshot.Files),
|
|
Options: []downloader.DownloadOption{
|
|
downloader.WithBearerToken(token),
|
|
downloader.WithTransferProgress(func(event downloader.TransferProgress) {
|
|
ReportProgress(ctx, ProgressEvent{
|
|
Phase: PhaseDownloading,
|
|
Artifact: spec.Name,
|
|
File: file.Path,
|
|
CurrentBytes: completedBytes + event.Written,
|
|
TotalBytes: totalBytes,
|
|
CompletedFiles: taskIndex,
|
|
TotalFiles: len(snapshot.Files),
|
|
})
|
|
}),
|
|
},
|
|
AfterDownload: func(string) error {
|
|
ReportProgress(ctx, ProgressEvent{
|
|
Phase: PhaseVerifying,
|
|
Artifact: spec.Name,
|
|
File: file.Path,
|
|
CurrentBytes: completedBytes + file.Size,
|
|
TotalBytes: totalBytes,
|
|
CompletedFiles: taskIndex,
|
|
TotalFiles: len(snapshot.Files),
|
|
})
|
|
entry, err := verifyDownloadedFile(blobAbs, file)
|
|
if err != nil {
|
|
_ = root.Remove(blobRel)
|
|
return err
|
|
}
|
|
destination := path.Join("snapshot", file.Path)
|
|
if err := root.MkdirAll(path.Dir(destination), 0o750); err != nil {
|
|
return err
|
|
}
|
|
_ = root.Remove(destination)
|
|
if err := root.Rename(blobRel, destination); err != nil {
|
|
return err
|
|
}
|
|
manifest.Files = append(manifest.Files, entry)
|
|
completedBytes += file.Size
|
|
return nil
|
|
},
|
|
}
|
|
tasks = append(tasks, task)
|
|
}
|
|
if err := downloader.DownloadFilesWithContext(ctx, tasks, nil); err != nil {
|
|
return Result{}, err
|
|
}
|
|
if err := root.RemoveAll(".downloads"); err != nil {
|
|
return Result{}, err
|
|
}
|
|
encoded, err := json.MarshalIndent(manifest, "", " ")
|
|
if err != nil {
|
|
return Result{}, err
|
|
}
|
|
if err := root.WriteFile("manifest.json.tmp", append(encoded, '\n'), 0o644); err != nil {
|
|
return Result{}, err
|
|
}
|
|
if err := root.Rename("manifest.json.tmp", "manifest.json"); err != nil {
|
|
return Result{}, err
|
|
}
|
|
if err := root.Close(); err != nil {
|
|
return Result{}, err
|
|
}
|
|
rootClosed = true
|
|
if err := os.MkdirAll(filepath.Dir(layout.Final), 0o750); err != nil {
|
|
return Result{}, err
|
|
}
|
|
ReportProgress(ctx, ProgressEvent{Phase: PhaseCommitting, Artifact: spec.Name, CurrentBytes: totalBytes, TotalBytes: totalBytes, CompletedFiles: len(snapshot.Files), TotalFiles: len(snapshot.Files)})
|
|
if err := os.Rename(layout.Partial, layout.Final); err != nil {
|
|
return Result{}, err
|
|
}
|
|
relative, err := RelativeSnapshotPath(spec.Resolved.CacheKey)
|
|
if err != nil {
|
|
return Result{}, err
|
|
}
|
|
return Result{Spec: spec, RelativePath: relative, Manifest: manifest}, nil
|
|
}
|
|
|
|
func verifyDownloadedFile(fileName string, source hfapi.SnapshotFile) (ManifestFile, error) {
|
|
file, err := os.Open(fileName)
|
|
if err != nil {
|
|
return ManifestFile{}, err
|
|
}
|
|
defer func() { _ = file.Close() }()
|
|
sha256Hash := sha256.New()
|
|
gitHash := sha1.New()
|
|
if _, err := fmt.Fprintf(gitHash, "blob %d%c", source.Size, byte(0)); err != nil {
|
|
return ManifestFile{}, err
|
|
}
|
|
if _, err := io.Copy(io.MultiWriter(sha256Hash, gitHash), file); err != nil {
|
|
return ManifestFile{}, err
|
|
}
|
|
info, err := file.Stat()
|
|
if err != nil {
|
|
return ManifestFile{}, err
|
|
}
|
|
if info.Size() != source.Size {
|
|
return ManifestFile{}, fmt.Errorf("size mismatch for %q", source.Path)
|
|
}
|
|
rawSHA256 := hex.EncodeToString(sha256Hash.Sum(nil))
|
|
if source.LFSOID != "" {
|
|
if decoded, err := hex.DecodeString(source.LFSOID); err != nil || len(decoded) != sha256.Size {
|
|
return ManifestFile{}, fmt.Errorf("invalid LFS SHA-256 for %q", source.Path)
|
|
}
|
|
if !strings.EqualFold(rawSHA256, source.LFSOID) {
|
|
return ManifestFile{}, fmt.Errorf("LFS SHA-256 mismatch for %q", source.Path)
|
|
}
|
|
} else if source.BlobOID != "" {
|
|
if decoded, err := hex.DecodeString(source.BlobOID); err != nil || len(decoded) != sha1.Size {
|
|
return ManifestFile{}, fmt.Errorf("invalid Git blob OID for %q", source.Path)
|
|
}
|
|
if !strings.EqualFold(hex.EncodeToString(gitHash.Sum(nil)), source.BlobOID) {
|
|
return ManifestFile{}, fmt.Errorf("Git blob OID mismatch for %q", source.Path)
|
|
}
|
|
}
|
|
return ManifestFile{
|
|
Path: source.Path, Size: source.Size, SHA256: rawSHA256,
|
|
BlobOID: source.BlobOID, LFSOID: source.LFSOID, XetHash: source.XetHash,
|
|
}, nil
|
|
}
|