mirror of
https://github.com/mudler/LocalAI.git
synced 2026-06-18 13:49:09 -04:00
* feat(config): add chat_template_kwargs model field + resolver Adds the ChatTemplateKwargs model-config map and RequestMetadata carrier, plus ResolveChatTemplateKwargs which layers the config map under coerced request metadata. Foundation for generic jinja chat-template kwargs (issue #10329). Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(backend): forward resolved chat_template_kwargs blob to backends gRPCPredictOpts now merges per-request client metadata over the server-derived enable_thinking/reasoning_effort (reaching all backends via the standalone keys) and serialises the resolved chat_template_kwargs map into a JSON blob for llama.cpp, written last so a client cannot clobber it. Issue #10329. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(http): wire request metadata to config.RequestMetadata The OpenAI request metadata field was parsed but unused; stamp it onto the per-request ModelConfig so gRPCPredictOpts forwards it as chat_template_kwargs overrides. Issue #10329. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(llama-cpp): generic chat_template_kwargs merge (drop per-key blocks) Replace the per-key enable_thinking/reasoning_effort handling in both the streaming and non-streaming chat paths with a single block that parses the chat_template_kwargs JSON blob resolved by the Go layer and merges every key into body_json. New jinja template levers (e.g. preserve_thinking) now need no C++ change. Issue #10329. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs: document custom chat_template_kwargs (model + per-request) Issue #10329. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(backend): pin reasoning_effort as a string in the chat_template_kwargs blob Issue #10329. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(http): e2e guard pinning chat_template_kwargs forwarded to gRPC Adds an ECHO_PREDICT_METADATA marker to the mock-backend that echoes the received PredictOptions.Metadata, and an app_test.go spec that drives a real /v1/chat/completions request (model chat_template_kwargs + per-request metadata override) and asserts the exact metadata + chat_template_kwargs blob the REST layer forwards to gRPC. Locks the REST->gRPC contract against regressions. Issue #10329. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(config): grandfather chat_template_kwargs in registry coverage chat_template_kwargs is a free-form map[string]any (like engine_args, already on the list), not a scalar the config UI registry can surface, so it is exempt from the registry-entry requirement. Fixes the TestAllFieldsHaveRegistryEntries failure introduced by the new field. Issue #10329. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
228 lines
9.1 KiB
Go
228 lines
9.1 KiB
Go
package backend
|
|
|
|
import (
|
|
"encoding/json"
|
|
|
|
"github.com/mudler/LocalAI/core/config"
|
|
"github.com/mudler/LocalAI/pkg/reasoning"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("grpcModelOpts EngineArgs", func() {
|
|
It("serialises engine_args as JSON preserving nested values", func() {
|
|
threads := 1
|
|
cfg := config.ModelConfig{
|
|
Threads: &threads,
|
|
LLMConfig: config.LLMConfig{
|
|
EngineArgs: map[string]any{
|
|
"data_parallel_size": 8,
|
|
"enable_expert_parallel": true,
|
|
"speculative_config": map[string]any{
|
|
"method": "ngram",
|
|
"num_speculative_tokens": 4,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.EngineArgs).NotTo(BeEmpty())
|
|
|
|
var round map[string]any
|
|
Expect(json.Unmarshal([]byte(opts.EngineArgs), &round)).To(Succeed())
|
|
Expect(round["data_parallel_size"]).To(BeEquivalentTo(8))
|
|
Expect(round["enable_expert_parallel"]).To(BeTrue())
|
|
Expect(round["speculative_config"]).To(HaveKeyWithValue("method", "ngram"))
|
|
})
|
|
|
|
It("leaves EngineArgs empty when unset", func() {
|
|
threads := 1
|
|
opts := grpcModelOpts(config.ModelConfig{Threads: &threads}, "/tmp/models")
|
|
Expect(opts.EngineArgs).To(BeEmpty())
|
|
})
|
|
})
|
|
|
|
// Guards the DisableReasoning -> enable_thinking metadata conversion that the
|
|
// per-request reasoning_effort feature (issue #10072) relies on: the request
|
|
// merge sets ReasoningConfig.DisableReasoning, and gRPCPredictOpts is where it
|
|
// becomes the gRPC PredictOptions.Metadata the backend reads.
|
|
var _ = Describe("gRPCPredictOpts enable_thinking metadata", func() {
|
|
// withReasoning builds a fully-defaulted config (gRPCPredictOpts dereferences
|
|
// many pointer fields) and overrides only the reasoning toggle.
|
|
withReasoning := func(disable *bool) config.ModelConfig {
|
|
cfg := config.ModelConfig{}
|
|
cfg.SetDefaults()
|
|
cfg.ReasoningConfig = reasoning.Config{DisableReasoning: disable}
|
|
return cfg
|
|
}
|
|
disabled := true
|
|
enabled := false
|
|
|
|
It("emits enable_thinking=false when reasoning is disabled", func() {
|
|
opts := gRPCPredictOpts(withReasoning(&disabled), "/tmp/models")
|
|
Expect(opts.Metadata).To(HaveKeyWithValue("enable_thinking", "false"))
|
|
})
|
|
|
|
It("emits enable_thinking=true when reasoning is enabled", func() {
|
|
opts := gRPCPredictOpts(withReasoning(&enabled), "/tmp/models")
|
|
Expect(opts.Metadata).To(HaveKeyWithValue("enable_thinking", "true"))
|
|
})
|
|
|
|
It("omits enable_thinking when reasoning is unset", func() {
|
|
opts := gRPCPredictOpts(withReasoning(nil), "/tmp/models")
|
|
Expect(opts.Metadata).ToNot(HaveKey("enable_thinking"))
|
|
})
|
|
})
|
|
|
|
// Guards forwarding the effective reasoning_effort into PredictOptions.Metadata,
|
|
// where the backend passes it to the jinja chat template (chat_template_kwargs)
|
|
// so models like gpt-oss / LFM2.5 honor it.
|
|
var _ = Describe("gRPCPredictOpts reasoning_effort metadata", func() {
|
|
withEffort := func(effort string) config.ModelConfig {
|
|
cfg := config.ModelConfig{}
|
|
cfg.SetDefaults()
|
|
cfg.ReasoningEffort = effort
|
|
return cfg
|
|
}
|
|
|
|
It("forwards reasoning_effort when set", func() {
|
|
opts := gRPCPredictOpts(withEffort("none"), "/tmp/models")
|
|
Expect(opts.Metadata).To(HaveKeyWithValue("reasoning_effort", "none"))
|
|
})
|
|
|
|
It("omits reasoning_effort when empty", func() {
|
|
opts := gRPCPredictOpts(withEffort(""), "/tmp/models")
|
|
Expect(opts.Metadata).ToNot(HaveKey("reasoning_effort"))
|
|
})
|
|
})
|
|
|
|
var _ = Describe("grpcModelOpts NBatch", func() {
|
|
scoreUsecase := config.FLAG_SCORE
|
|
threads := 1
|
|
ctx := 4096
|
|
|
|
It("defaults to 512 for an ordinary model", func() {
|
|
cfg := config.ModelConfig{Threads: &threads, LLMConfig: config.LLMConfig{ContextSize: &ctx}}
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.NBatch).To(BeEquivalentTo(512))
|
|
})
|
|
|
|
It("sizes the batch to the context window for score models", func() {
|
|
// Score models decode the whole prompt+candidate in one
|
|
// llama_decode; n_batch must cover it or the backend aborts.
|
|
cfg := config.ModelConfig{Threads: &threads, LLMConfig: config.LLMConfig{ContextSize: &ctx}, KnownUsecases: &scoreUsecase}
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.NBatch).To(BeEquivalentTo(4096))
|
|
})
|
|
|
|
It("keeps an explicit batch over the score default", func() {
|
|
cfg := config.ModelConfig{Threads: &threads, LLMConfig: config.LLMConfig{ContextSize: &ctx}, KnownUsecases: &scoreUsecase}
|
|
cfg.Batch = 1024
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.NBatch).To(BeEquivalentTo(1024))
|
|
})
|
|
|
|
It("sizes the batch to the context window for embedding models", func() {
|
|
// Embedding/rerank pool over the whole sequence in one physical batch
|
|
// (n_ubatch); without this the input is capped at the 512 default and
|
|
// the backend returns "input is too large to process".
|
|
embeddings := true
|
|
cfg := config.ModelConfig{Threads: &threads, LLMConfig: config.LLMConfig{ContextSize: &ctx}}
|
|
cfg.Embeddings = &embeddings
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.NBatch).To(BeEquivalentTo(4096))
|
|
})
|
|
|
|
It("sizes the batch to the context window for rerank models", func() {
|
|
reranking := true
|
|
cfg := config.ModelConfig{Threads: &threads, LLMConfig: config.LLMConfig{ContextSize: &ctx}}
|
|
cfg.Reranking = &reranking
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.NBatch).To(BeEquivalentTo(4096))
|
|
})
|
|
|
|
It("does not raise the batch when a score model's context is below the default", func() {
|
|
small := 256
|
|
cfg := config.ModelConfig{Threads: &threads, LLMConfig: config.LLMConfig{ContextSize: &small}, KnownUsecases: &scoreUsecase}
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.NBatch).To(BeEquivalentTo(512))
|
|
})
|
|
|
|
It("sizes the batch to the effective 4096 default for a score model with no explicit context_size", func() {
|
|
// The crash case: the backend defaults n_ctx to 4096, so n_batch must
|
|
// follow even when context_size is unset — otherwise n_batch stays 512
|
|
// against a 4096 window and the score decode hits the GGML_ASSERT.
|
|
cfg := config.ModelConfig{Threads: &threads, KnownUsecases: &scoreUsecase}
|
|
Expect(cfg.ContextSize).To(BeNil())
|
|
opts := grpcModelOpts(cfg, "/tmp/models")
|
|
Expect(opts.NBatch).To(BeEquivalentTo(4096))
|
|
Expect(opts.ContextSize).To(BeEquivalentTo(4096), "n_batch must match the effective n_ctx the backend receives")
|
|
})
|
|
})
|
|
|
|
// Guards the generic chat_template_kwargs forwarding: the model config map plus any
|
|
// per-request metadata overrides are merged, coerced, and serialised into the
|
|
// backend metadata blob that llama.cpp reads. Client metadata also overrides the
|
|
// server-derived standalone enable_thinking key (cross-backend consistency).
|
|
var _ = Describe("gRPCPredictOpts chat_template_kwargs metadata", func() {
|
|
baseCfg := func() config.ModelConfig {
|
|
cfg := config.ModelConfig{}
|
|
cfg.SetDefaults()
|
|
return cfg
|
|
}
|
|
|
|
It("serialises the config map into the chat_template_kwargs blob", func() {
|
|
cfg := baseCfg()
|
|
cfg.ChatTemplateKwargs = map[string]any{"preserve_thinking": true}
|
|
opts := gRPCPredictOpts(cfg, "/tmp/models")
|
|
Expect(opts.Metadata).To(HaveKey("chat_template_kwargs"))
|
|
var blob map[string]any
|
|
Expect(json.Unmarshal([]byte(opts.Metadata["chat_template_kwargs"]), &blob)).To(Succeed())
|
|
Expect(blob).To(HaveKeyWithValue("preserve_thinking", true))
|
|
})
|
|
|
|
It("serialises reasoning_effort into the blob as a JSON string", func() {
|
|
cfg := baseCfg()
|
|
cfg.ReasoningEffort = "high"
|
|
opts := gRPCPredictOpts(cfg, "/tmp/models")
|
|
Expect(opts.Metadata).To(HaveKey("chat_template_kwargs"))
|
|
var blob map[string]any
|
|
Expect(json.Unmarshal([]byte(opts.Metadata["chat_template_kwargs"]), &blob)).To(Succeed())
|
|
// reasoning_effort must remain a string in the blob (jinja templates that
|
|
// key on the level read a string), unlike enable_thinking which is a bool.
|
|
Expect(blob["reasoning_effort"]).To(BeAssignableToTypeOf(""))
|
|
Expect(blob).To(HaveKeyWithValue("reasoning_effort", "high"))
|
|
})
|
|
|
|
It("lets client request metadata override the server-derived enable_thinking key", func() {
|
|
cfg := baseCfg()
|
|
disable := true
|
|
cfg.ReasoningConfig = reasoning.Config{DisableReasoning: &disable} // server: enable_thinking=false
|
|
cfg.RequestMetadata = map[string]string{"enable_thinking": "true"} // client overrides
|
|
opts := gRPCPredictOpts(cfg, "/tmp/models")
|
|
// standalone key (Python backends) reflects the client override
|
|
Expect(opts.Metadata).To(HaveKeyWithValue("enable_thinking", "true"))
|
|
// blob (llama.cpp) reflects it too, as a real bool
|
|
var blob map[string]any
|
|
Expect(json.Unmarshal([]byte(opts.Metadata["chat_template_kwargs"]), &blob)).To(Succeed())
|
|
Expect(blob).To(HaveKeyWithValue("enable_thinking", true))
|
|
})
|
|
|
|
It("does not let a client clobber the blob via a chat_template_kwargs metadata key", func() {
|
|
cfg := baseCfg()
|
|
cfg.ChatTemplateKwargs = map[string]any{"preserve_thinking": true}
|
|
cfg.RequestMetadata = map[string]string{"chat_template_kwargs": "{\"preserve_thinking\": false}"}
|
|
opts := gRPCPredictOpts(cfg, "/tmp/models")
|
|
var blob map[string]any
|
|
Expect(json.Unmarshal([]byte(opts.Metadata["chat_template_kwargs"]), &blob)).To(Succeed())
|
|
Expect(blob).To(HaveKeyWithValue("preserve_thinking", true))
|
|
})
|
|
|
|
It("omits the blob when there is nothing to forward", func() {
|
|
opts := gRPCPredictOpts(baseCfg(), "/tmp/models")
|
|
Expect(opts.Metadata).ToNot(HaveKey("chat_template_kwargs"))
|
|
})
|
|
})
|