mirror of
https://github.com/mudler/LocalAI.git
synced 2026-11-06 12:33:16 -05:00
Ettore Di Giacinto
15e2321d50
Bindings saved before permissions were enforced have no capabilities, so they deny files from senders, triggers, memory writes and talk-back, and the owner could only fix that through the REST API. The shared connector page now has a section for it, so every connector add-on gets it: a switch and a description for each capability with the sensitive ones marked, the role matrix (never a sensitive capability, never above the ceiling), pairing with a code shown once, the approved channels for talk-back, and a read-only view of the access check with the latest decisions. A binding with no capability shows a notice that says why the features are off, with an "Allow the usual" button that turns on the non-sensitive everyday set. The kinds endpoint returns the closed list of capabilities with a title, a description and the sensitive and usual flags. The field is additive. Assisted-by: Claude:claude-sonnet-5-5 go node playwright swag
132 lines
7.5 KiB
JavaScript
132 lines
7.5 KiB
JavaScript
import { test, expect } from './coverage-fixtures.js'
|
||
import { mockChat } from './chat-fixtures.js'
|
||
import { installStudioAddons } from './studio-addon.js'
|
||
import { connectorApi } from './connector-fixtures.js'
|
||
|
||
// The page of the Slack add-on (the real built bundle, inside the add-on
|
||
// shell) with the core API stubbed: both tokens go in as one secret and are
|
||
// checked on save, people and channels are two lists of one allowlist, and
|
||
// the setup shows the app manifest.
|
||
|
||
const PAGE = '/app/addons/slack/apps'
|
||
const NEWCOMER = { id: 'U042', name: 'Newcomer', count: 2, allowed: false, first: '2026-10-27T08:00:00Z', last: '2026-10-27T08:05:00Z' }
|
||
const BINDING = { id: 'b1', name: 'Team app', kind: 'slack', agent_id: 'a1', enabled: true, accept_any: false, allow: ['U001', 'C001'], has_token: true }
|
||
const api = (page, initial = []) => connectorApi(page, initial, 'slack', [NEWCOMER])
|
||
|
||
test.describe('Slack add-on', () => {
|
||
test.beforeEach(async ({ page }) => {
|
||
await mockChat(page)
|
||
await installStudioAddons(page, { ids: ['slack'] })
|
||
})
|
||
|
||
test('creates a binding with both tokens, people and channels, and checks the tokens', async ({ page }) => {
|
||
const a = api(page)
|
||
await a.install()
|
||
await page.route(/\/api\/chats\/connectors\/[^/?]+\/test$/, r => r.fulfill({ json: { bot_id: 'UBOT', bot_username: 'localai (Acme)' } }))
|
||
await page.goto(PAGE)
|
||
|
||
await expect(page.getByText('No Slack apps yet.')).toBeVisible()
|
||
await page.getByRole('button', { name: 'New Slack app' }).click()
|
||
await page.getByLabel('Name', { exact: true }).fill('Team app')
|
||
await expect(page.getByTestId('connector-thread-context')).toHaveCount(0)
|
||
await page.getByLabel('Bot token').fill('xoxb-secret-bot')
|
||
await expect(page.getByTestId('token-problem')).toContainText('Type both tokens')
|
||
await expect(page.getByRole('button', { name: 'Save' })).toBeDisabled()
|
||
await page.getByLabel('App-level token').fill('xapp-secret-app')
|
||
await expect(page.getByTestId('token-problem')).toHaveCount(0)
|
||
await page.getByLabel('Agent', { exact: true }).selectOption('a1')
|
||
await page.getByRole('textbox', { name: 'Allowed people +' }).fill('U001')
|
||
await page.getByRole('textbox', { name: 'Allowed people +' }).press('Enter')
|
||
await page.getByRole('textbox', { name: 'Allowed channels +' }).fill('C001')
|
||
await page.getByRole('textbox', { name: 'Allowed channels +' }).press('Enter')
|
||
await expect(page.getByTestId('connector-allow')).toContainText('U001')
|
||
await expect(page.getByTestId('connector-allow')).not.toContainText('C001')
|
||
await expect(page.getByTestId('connector-allow-channels')).toContainText('C001')
|
||
await page.getByRole('button', { name: 'Save' }).click()
|
||
|
||
await expect(page.getByTestId('connector-row')).toContainText('Team app')
|
||
await expect(page.getByTestId('connector-row')).toContainText('Accepts: 2 listed entries')
|
||
await expect(page.getByText('Connected to localai (Acme).')).toBeVisible()
|
||
const body = a.s.calls.find(c => c.method === 'POST' && c.url === '/api/chats/connectors').body
|
||
expect(body).toMatchObject({ kind: 'slack', name: 'Team app', token: 'xoxb-secret-bot xapp-secret-app', agent_id: 'a1', allow: ['U001', 'C001'] })
|
||
expect(body).not.toHaveProperty('bot_token')
|
||
// The host always reads the thread of a mention: no setting is offered or sent.
|
||
expect(body).not.toHaveProperty('thread_context')
|
||
await expect(page.locator('body')).not.toContainText('secret-bot')
|
||
})
|
||
|
||
test('a token the platform refuses is saved and the reason is shown', async ({ page }) => {
|
||
await api(page).install()
|
||
await page.route(/\/api\/chats\/connectors\/[^/?]+\/test$/, r => r.fulfill({ status: 502, json: { error: { message: 'the platform refused the bot token' } } }))
|
||
await page.goto(PAGE)
|
||
await page.getByRole('button', { name: 'New Slack app' }).click()
|
||
await page.getByLabel('Name', { exact: true }).fill('Team app')
|
||
await page.getByLabel('Bot token').fill('xoxb-1')
|
||
await page.getByLabel('App-level token').fill('xapp-2')
|
||
await page.getByLabel('Agent', { exact: true }).selectOption('a1')
|
||
await page.getByRole('button', { name: 'Save' }).click()
|
||
await expect(page.getByRole('alert')).toContainText('Saved. The token check failed: the platform refused the bot token')
|
||
await expect(page.getByTestId('connector-row')).toHaveCount(1)
|
||
})
|
||
|
||
test('an edit keeps the stored tokens unless both are typed, and keeps both lists', async ({ page }) => {
|
||
const a = api(page, [BINDING])
|
||
await a.install()
|
||
await page.goto(PAGE)
|
||
await page.getByRole('button', { name: 'Edit' }).click()
|
||
await expect(page.getByLabel('Bot token')).toHaveValue('')
|
||
await expect(page.getByLabel('App-level token')).toHaveAttribute('placeholder', /Saved/)
|
||
await expect(page.getByTestId('connector-allow-channels')).toContainText('C001')
|
||
await page.getByRole('button', { name: 'C001 ×' }).click()
|
||
await page.getByRole('button', { name: 'Save' }).click()
|
||
const put = a.s.calls.find(c => c.method === 'PUT')
|
||
expect(put.url).toBe('/api/chats/connectors/b1')
|
||
expect('token' in put.body).toBe(false)
|
||
expect(put.body.allow).toEqual(['U001'])
|
||
})
|
||
|
||
test('shows how to make the Slack app, with its manifest', async ({ page }) => {
|
||
await api(page).install()
|
||
await page.goto(PAGE)
|
||
const setup = page.getByTestId('slack-setup')
|
||
await setup.getByText('How to make the Slack app').click()
|
||
await expect(setup).toContainText('connections:write')
|
||
await expect(setup.getByLabel('Slack app manifest')).toContainText('socket_mode_enabled: true')
|
||
})
|
||
|
||
test('tests the tokens, shows the sender log and allows a sender', async ({ page }) => {
|
||
const a = api(page, [BINDING])
|
||
await a.install()
|
||
await page.route(/\/api\/chats\/connectors\/[^/?]+\/test$/, r => r.fulfill({ json: { bot_id: 'UBOT', bot_username: 'localai (Acme)' } }))
|
||
await page.goto(PAGE)
|
||
await page.getByRole('button', { name: 'Test' }).click()
|
||
await expect(page.getByText('Connected to localai (Acme).')).toBeVisible()
|
||
await page.getByRole('button', { name: 'Senders' }).click()
|
||
await expect(page.getByTestId('sender-log')).toContainText('Newcomer · 2 messages · U042')
|
||
await page.getByRole('button', { name: 'Allow', exact: true }).click()
|
||
await expect(page.getByTestId('sender-log')).toContainText('Accepted')
|
||
expect(a.s.calls.some(c => c.url === '/api/chats/connectors/b1/senders/U042/allow')).toBe(true)
|
||
})
|
||
|
||
test('a token the server refuses on save keeps the form open with the reason', async ({ page }) => {
|
||
const a = api(page)
|
||
await a.install()
|
||
await page.route(/\/api\/chats\/connectors(\?.*)?$/, r => {
|
||
if (r.request().method() !== 'POST') return r.fallback()
|
||
return r.fulfill({ status: 400, json: { error: { message: 'the platform refused the bot token' } } })
|
||
})
|
||
await page.goto(PAGE)
|
||
await page.getByRole('button', { name: 'New Slack app' }).click()
|
||
await page.getByLabel('Name', { exact: true }).fill('Team app')
|
||
await page.getByLabel('Bot token').fill('xoxb-1')
|
||
await page.getByLabel('App-level token').fill('xapp-2')
|
||
await page.getByLabel('Agent', { exact: true }).selectOption('a1')
|
||
await page.getByTestId('connector-reply').selectOption('progress')
|
||
await page.getByRole('button', { name: 'Save' }).click()
|
||
await expect(page.getByRole('alert')).toContainText('the platform refused the bot token')
|
||
await expect(page.getByRole('form')).toBeVisible()
|
||
await expect(page.getByTestId('connector-row')).toHaveCount(0)
|
||
expect(a.s.items).toHaveLength(0)
|
||
})
|
||
})
|