mirror of
https://github.com/mudler/LocalAI.git
synced 2026-10-28 09:08:54 -04:00
mudler-agentandEttore Di Giacinto
756b019ce4
fix(httpclient): validate redirect targets and pin dialed addresses for user URLs Clients that fetch user-supplied URLs followed redirects without checking the target, so a public host could send them to a loopback, link-local or private address. The host was also resolved twice, once to validate it and once to connect, so a changing DNS answer could bypass the check. Add httpclient.WithExternalOnly. It validates every redirect hop against the external URL policy and, for the default transport, resolves the host, refuses it if any address is non-public, and dials the validated address. Environment proxies are not used for such clients. Move the policy (ValidateExternalURL, IsPublicIP) into pkg/httpclient so it can be used without an import cycle; pkg/utils keeps delegating to it. IsPublicIP now also refuses 100.64.0.0/10, 0.0.0.0/8, 192.0.0.0/24, 198.18.0.0/15, 240.0.0.0/4, multicast, and NAT64 addresses that wrap a non-public IPv4 address. Use the option for the base64, image, audio and video downloads, and drop the video client's own per-hop check. Assisted-by: Claude Code:claude-haiku-5-5 Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
117 lines
3.7 KiB
Go
117 lines
3.7 KiB
Go
package utils_test
|
|
|
|
import (
|
|
. "github.com/mudler/LocalAI/pkg/utils"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("utils/urlfetch tests", func() {
|
|
Context("ValidateExternalURL", func() {
|
|
It("allows valid external HTTPS URLs", func() {
|
|
err := ValidateExternalURL("https://example.com/image.png")
|
|
Expect(err).To(BeNil())
|
|
})
|
|
|
|
It("allows valid external HTTP URLs", func() {
|
|
err := ValidateExternalURL("http://example.com/image.png")
|
|
Expect(err).To(BeNil())
|
|
})
|
|
|
|
It("blocks localhost", func() {
|
|
err := ValidateExternalURL("http://localhost/secret")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
It("blocks 127.0.0.1", func() {
|
|
err := ValidateExternalURL("http://127.0.0.1/secret")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
It("blocks private 10.x.x.x range", func() {
|
|
err := ValidateExternalURL("http://10.0.0.1/secret")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
It("blocks private 172.16.x.x range", func() {
|
|
err := ValidateExternalURL("http://172.16.0.1/secret")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
It("blocks private 192.168.x.x range", func() {
|
|
err := ValidateExternalURL("http://192.168.1.1/secret")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
It("blocks link-local 169.254.x.x (AWS metadata)", func() {
|
|
err := ValidateExternalURL("http://169.254.169.254/latest/meta-data/")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
It("blocks unsupported schemes", func() {
|
|
err := ValidateExternalURL("ftp://example.com/file")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("unsupported URL scheme"))
|
|
})
|
|
|
|
It("blocks file:// scheme", func() {
|
|
err := ValidateExternalURL("file:///etc/passwd")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("unsupported URL scheme"))
|
|
})
|
|
|
|
It("blocks URLs with no hostname", func() {
|
|
err := ValidateExternalURL("http:///path")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("no hostname"))
|
|
})
|
|
|
|
It("blocks .local hostnames", func() {
|
|
err := ValidateExternalURL("http://myservice.local/api")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
It("blocks metadata.google.internal", func() {
|
|
err := ValidateExternalURL("http://metadata.google.internal/computeMetadata/v1/")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("metadata"))
|
|
})
|
|
|
|
It("blocks 0.0.0.0", func() {
|
|
err := ValidateExternalURL("http://0.0.0.0/")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
|
|
DescribeTable("blocks non-public ranges that net.IP does not flag",
|
|
func(rawURL string) {
|
|
err := ValidateExternalURL(rawURL)
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
},
|
|
Entry("shared address space (RFC 6598)", "http://100.64.0.1/x"),
|
|
Entry("shared address space, upper end", "http://100.127.255.254/x"),
|
|
Entry("this network 0.0.0.0/8", "http://0.1.2.3/x"),
|
|
Entry("benchmarking range", "http://198.18.0.1/x"),
|
|
Entry("IPv4-mapped shared address space", "http://[::ffff:100.64.0.1]/x"),
|
|
)
|
|
|
|
It("allows a public address next to the shared address space", func() {
|
|
Expect(ValidateExternalURL("http://100.128.0.1/x")).To(Succeed())
|
|
})
|
|
|
|
It("blocks IPv6 loopback ::1", func() {
|
|
err := ValidateExternalURL("http://[::1]/secret")
|
|
Expect(err).ToNot(BeNil())
|
|
Expect(err.Error()).To(ContainSubstring("internal"))
|
|
})
|
|
})
|
|
})
|