mirror of
https://github.com/mudler/LocalAI.git
synced 2026-11-06 12:33:16 -05:00
Ettore Di Giacinto
0c08e17a30
A tool that shadows bash can now declare an execution descriptor: its class, a title and a note for the model, and the skill kinds whose runtime it supplies. The host reads it to build its text and to decide which skills need isolated execution, instead of knowing add-on IDs. The field is optional and needs manifest API 2. The host now speaks API 2 and still accepts add-ons that declare only API 1, so manifests that declare nothing new keep working unchanged. Assisted-by: Claude Code:claude-sonnet-5-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
78 lines
3.3 KiB
Go
78 lines
3.3 KiB
Go
// SPDX-License-Identifier: MIT
|
|
package contract
|
|
|
|
import (
|
|
"encoding/json"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("The execution descriptor of a commands tool", func() {
|
|
const schema = `{"type":"object","properties":{"command":{"type":"string"}},"required":["command"],"additionalProperties":false}`
|
|
manifestWith := func(e *ExecutionDescriptor, api VersionRange) Manifest {
|
|
m, err := ParseManifest(fixture())
|
|
Expect(err).NotTo(HaveOccurred())
|
|
m.API = api
|
|
m.Capabilities = Capabilities{
|
|
Tools: []string{"run"},
|
|
Actions: true,
|
|
ToolDefinitions: []ToolDefinition{{Name: "run", Description: "Run a command.", Kind: ToolKindAction,
|
|
InputSchema: json.RawMessage(schema), Shadows: "bash", Execution: e}},
|
|
}
|
|
return m
|
|
}
|
|
host := func() HostCompatibility {
|
|
h := compatible()
|
|
h.SDK = 0
|
|
h.API, h.APIMin = HostAPIVersion, HostAPIMin
|
|
return h
|
|
}
|
|
commands := &ExecutionDescriptor{Class: ExecutionClassCommands, Title: "Runbox", Note: "It has python3 and jq."}
|
|
|
|
It("is valid for a tool that shadows bash when the manifest accepts API 2", func() {
|
|
Expect(ValidateManifest(manifestWith(commands, VersionRange{Min: 1, Max: 2}), host())).To(Succeed())
|
|
})
|
|
It("needs the manifest to accept API 2", func() {
|
|
Expect(ValidateManifest(manifestWith(commands, VersionRange{Min: 1, Max: 1}), host())).NotTo(Succeed())
|
|
})
|
|
It("is refused on a tool that does not shadow bash, with another class or with bad text", func() {
|
|
m := manifestWith(commands, VersionRange{Min: 1, Max: 2})
|
|
m.Capabilities.ToolDefinitions[0].Shadows = ""
|
|
Expect(ValidateManifest(m, host())).NotTo(Succeed())
|
|
for _, bad := range []*ExecutionDescriptor{
|
|
{Class: "pages"},
|
|
{Class: ExecutionClassCommands, Title: "<b>Runbox</b>"},
|
|
{Class: ExecutionClassCommands, Note: string(make([]rune, MaxExecutionNoteChars+1))},
|
|
{Class: ExecutionClassCommands, Skills: &ExecutionSkills{ProvidesRuntimeFor: []string{"games"}}},
|
|
} {
|
|
Expect(ValidateManifest(manifestWith(bad, VersionRange{Min: 1, Max: 2}), host())).NotTo(Succeed())
|
|
}
|
|
})
|
|
|
|
It("keeps a manifest of API 1 valid on a host that speaks API 2, and refuses one that needs API 3", func() {
|
|
Expect(ValidateManifest(manifestWith(nil, VersionRange{Min: 1, Max: 1}), host())).To(Succeed())
|
|
Expect(ValidateManifest(manifestWith(nil, VersionRange{Min: 3, Max: 3}), host())).NotTo(Succeed())
|
|
})
|
|
|
|
Describe("IsolatedSkills", func() {
|
|
skills := []SkillDefinition{{Name: "docx", Shadows: "docx"}, {Name: "runbox-tips"}}
|
|
defs := func(e *ExecutionDescriptor) []ToolDefinition {
|
|
return manifestWith(e, VersionRange{Min: 1, Max: 2}).Capabilities.ToolDefinitions
|
|
}
|
|
It("names the document skills of a provider that declares it supplies their runtime", func() {
|
|
e := &ExecutionDescriptor{Class: ExecutionClassCommands, Skills: &ExecutionSkills{ProvidesRuntimeFor: []string{SkillKindDocuments}}}
|
|
Expect(IsolatedSkills(defs(e), skills)).To(Equal([]string{"docx"}))
|
|
})
|
|
It("fails closed for a commands tool without a descriptor", func() {
|
|
Expect(IsolatedSkills(defs(nil), skills)).To(Equal([]string{"docx"}))
|
|
})
|
|
It("names nothing for a descriptor that does not supply the runtime of documents", func() {
|
|
Expect(IsolatedSkills(defs(commands), skills)).To(BeEmpty())
|
|
})
|
|
It("names nothing for an add-on without a commands tool", func() {
|
|
Expect(IsolatedSkills(nil, skills)).To(BeEmpty())
|
|
})
|
|
})
|
|
})
|