mirror of
https://github.com/mudler/LocalAI.git
synced 2026-09-12 22:33:54 -04:00
Ettore Di Giacinto
7b66df6651
None was introduced by this branch and all three are in test code, which is what made them survive: every suite passed on every run and only the race detector said otherwise. A known-failing -race run is worse than a noisy one, because a real race raised by production code lands in the same report and is read as one of these. galleryop: gatedModelManager guarded the recorded names and not the gate channel itself. A spec frees the parked worker by closing the gate and installing a fresh one, on the spec goroutine, while the worker goroutine reads the field to park on it. The channel is now read and replaced under the same mutex, and cleanup closes idempotently. pkg/model: two specs swapped xlog's package logger to capture output and swapped it back on cleanup. xlog.SetLogger writes an unsynchronised global, so the restore raced with the backend process watcher, which logs while a process is stopping; the captured bytes.Buffer was written by that goroutine and read by an Eventually at the same time. SetLogger is now called once for the whole test binary, from init, before a goroutine exists to race with, and a spec swaps the DESTINATION under a mutex through a routing slog.Handler. Per-spec level filtering is preserved deliberately: one of these specs asserts that a debug emission is filtered OUT and would pass vacuously against a handler that recorded everything. openai: fakeTransport appended to its event and audio logs from the response and turn coordinators' goroutines while a spec ranged over them. Both are behind a mutex and are read through snapshot accessors; the fields are renamed so a raw read from another spec file does not compile. Assisted-by: Claude Opus 5 [claude-code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
33 lines
1.1 KiB
Go
33 lines
1.1 KiB
Go
package model
|
|
|
|
import (
|
|
"log/slog"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/mudler/LocalAI/pkg/system"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("backend process exit diagnostics", func() {
|
|
It("includes the exit code and final stderr line for an unexpected exit", func() {
|
|
tmpDir := GinkgoT().TempDir()
|
|
backendPath := filepath.Join(tmpDir, "failing-backend")
|
|
Expect(os.WriteFile(backendPath, []byte("#!/bin/sh\necho 'first diagnostic' >&2\necho 'fatal metal pipeline error' >&2\nexit 42\n"), 0o700)).To(Succeed())
|
|
|
|
captured := captureLogs(slog.LevelWarn)
|
|
DeferCleanup(stopCapturingLogs)
|
|
|
|
loader := NewModelLoader(&system.SystemState{Model: system.Model{ModelsPath: tmpDir}})
|
|
process, err := loader.startProcess(backendPath, "test-model", "127.0.0.1:65535")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Eventually(process.Done()).Should(BeClosed())
|
|
Eventually(captured.String).Should(And(
|
|
ContainSubstring("Backend process exited unexpectedly"),
|
|
ContainSubstring("exitCode=42"),
|
|
ContainSubstring(`stderr="fatal metal pipeline error"`),
|
|
))
|
|
})
|
|
})
|