mirror of
https://github.com/mudler/LocalAI.git
synced 2026-07-30 18:09:05 -04:00
Review follow-up on the Darwin Metal build. The OpenMP fallback was silent. If brew --prefix libomp ever comes back empty, CI produced a green Metal package with 108 #pragma omp directives across ~30 files compiled out, and clang says nothing about an ignored omp pragma without -Wsource-uses-openmp, so the only trace was one absent flag inside a set -x cmake line. That regression would have been blamed on Metal. It now warns. The @rpath arm of the dylib walk had no live candidate when it was written, on the reasoning that a Metal build links ggml statically. The OpenMP fix in the same commit made libomp.dylib one, and whether Homebrew records it as an absolute opt path or as @rpath/libomp.dylib is not observable from Linux. The walk now expands @rpath, @loader_path and @executable_path against the object's own LC_RPATH entries, and only fails when nothing on disk answers, printing the rpath list with the error so a failure on a machine nobody can attach to explains itself. Also: ADDITIONAL_LIBS now go through the closure rather than a bare cp, so they are deduplicated and their own dependencies bundled; build/darwin/lib is created explicitly instead of relying on package.sh pre-creating it; the libomp probe uses nested ifneq rather than $(and ...), which needs GNU make 3.81 and would otherwise expand empty and take the OFF branch on an older make; and -DOpenMP_ROOT is quoted like its CUDA sibling. Verified with a Linux harness that runs the script verbatim against a stubbed otool: a level-2 transitive dep, an @rpath dep reachable only through LC_RPATH, and an ADDITIONAL_LIBS dep are all bundled, a dependency cycle terminates, system libraries are skipped, the packaged tree has assets/ at the root beside grpc-server with the dylibs in lib/, and both failure paths exit non-zero. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
248 lines
11 KiB
Bash
Executable File
248 lines
11 KiB
Bash
Executable File
#!/bin/bash
|
|
# Darwin/Metal build for the audio-cpp backend.
|
|
#
|
|
# Modelled on scripts/build/ds4-darwin.sh rather than llama-cpp-darwin.sh:
|
|
# audio-cpp is a single grpc-server, like ds4 and privacy-filter, whereas
|
|
# llama-cpp ships three binaries and splits its ggml objects between the package
|
|
# root and lib/. One deliberate departure from BOTH of those scripts, and from
|
|
# privacy-filter-darwin.sh in particular:
|
|
#
|
|
# THIS SCRIPT DOES NOT REASSEMBLE THE PACKAGE. It runs the backend's own
|
|
# `make package` and copies the result.
|
|
#
|
|
# privacy-filter-darwin.sh hand-assembles build/darwin and never calls its
|
|
# package.sh. Copied here that would silently drop assets/, and assets/ is what
|
|
# makes the "bundled:silero_vad" / "bundled:marblenet_vad" model paths resolve
|
|
# with nothing downloaded - the only zero-download path this backend has.
|
|
# backend/cpp/audio-cpp/package.sh already produces the exact layout the image
|
|
# needs, and its Darwin branch stops right before the Linux-only loader/ldd work
|
|
# and hands over to this script. Reusing it means the Linux and Darwin packages
|
|
# cannot drift.
|
|
#
|
|
# What this script adds on top of package.sh is the part that is genuinely
|
|
# macOS-only: walking otool -L to bundle the non-system dylibs the binary needs.
|
|
set -euo pipefail
|
|
set -x
|
|
|
|
IMAGE_NAME="${IMAGE_NAME:-localai/audio-cpp-darwin}"
|
|
PLATFORMARCH="${PLATFORMARCH:-darwin/arm64}"
|
|
|
|
# NATIVE=false matches ds4-darwin.sh and the backend Makefile's own default: the
|
|
# image is published for every Apple Silicon Mac, not just the CI runner's, so
|
|
# the CPU kernels must not be compiled for the build host's exact ISA.
|
|
pushd backend/cpp/audio-cpp
|
|
make NATIVE=false grpc-server package
|
|
popd
|
|
|
|
rm -rf build/darwin
|
|
mkdir -p build/darwin backend-images
|
|
# -a, not -r: package.sh may have left symlink chains among the ggml objects
|
|
# (libggml.dylib -> libggml.0.dylib -> ...), and the SONAME the binary asks for
|
|
# has to keep naming a file here.
|
|
cp -a backend/cpp/audio-cpp/package/. build/darwin/
|
|
# lib/ arrives from package.sh, which mkdir -p's an empty one. Do not rely on
|
|
# that: everything below copies into it, and if package.sh ever stops
|
|
# pre-creating it the first copy fails with an opaque BSD-cp message instead of
|
|
# any of the assertions this script otherwise leans on.
|
|
mkdir -p build/darwin/lib
|
|
|
|
# THE LAYOUT ASSERTION - the Darwin half of the one in
|
|
# backend/cpp/audio-cpp/package.sh, and the reason that one is written at such
|
|
# length. run.sh's Darwin branch execs grpc-server directly, so
|
|
# _NSGetExecutablePath names the package ROOT. Two independent consumers read
|
|
# that directory: ggml's backend registry, which discovers dlopened
|
|
# libggml-cpu-* objects by scanning it, and resolve_model_path(), which expands
|
|
# "bundled:<name>" to <exe dir>/assets/<name>. Tidying assets/ or the ggml
|
|
# objects into lib/, which is where the llama-cpp layout would put them,
|
|
# produces a package that builds, publishes, and then fails at run time with
|
|
# "model path does not exist: <pkg>/lib/assets/...". Fail here instead.
|
|
for required in grpc-server run.sh assets/silero_vad assets/marblenet_vad; do
|
|
if [ ! -e "build/darwin/$required" ]; then
|
|
echo "audio-cpp-darwin.sh: missing from the package root: $required" >&2
|
|
echo "audio-cpp-darwin.sh: grpc-server, run.sh, the ggml dylibs and" >&2
|
|
echo "audio-cpp-darwin.sh: assets/ all have to sit in ONE directory," >&2
|
|
echo "audio-cpp-darwin.sh: because run.sh execs the binary from there" >&2
|
|
echo "audio-cpp-darwin.sh: and both the ggml backend scan and the" >&2
|
|
echo "audio-cpp-darwin.sh: bundled: asset lookup are relative to it." >&2
|
|
exit 1
|
|
fi
|
|
done
|
|
|
|
# Bundle the FULL dylib closure, not just grpc-server's direct dependencies.
|
|
#
|
|
# ds4-darwin.sh and llama-cpp-darwin.sh walk one level. That is enough only
|
|
# while every indirect dependency happens to be linked directly by the binary
|
|
# too. It is not enough here: Homebrew's grpc++ pulls libgrpc, ~40 libabsl_*,
|
|
# libupb, libcares, libre2 and OpenSSL, and grpc-server links few of those
|
|
# itself. A missing one resolves on the build host (the install names are
|
|
# absolute Homebrew paths) and fails on a user's Mac that has no Homebrew grpc,
|
|
# which is exactly the failure a bundled package exists to prevent. The Linux
|
|
# side already does a full ldd closure in package.sh; this is its equivalent.
|
|
#
|
|
# Leaf-name deduplication is what makes DYLD_LIBRARY_PATH work: run.sh exports
|
|
# lib/ and the package root, and dyld searches those by leaf name BEFORE
|
|
# falling back to the absolute install name recorded in the binary.
|
|
#
|
|
# /bin/bash on macOS is 3.2, so no associative arrays: the seen-set is a
|
|
# space-delimited string matched with `case`.
|
|
BUNDLED_LEAVES=" "
|
|
UNRESOLVED=0
|
|
|
|
# The LC_RPATH entries recorded in an object, one per line.
|
|
object_rpaths() {
|
|
otool -l "$1" | awk '/LC_RPATH/ { f = 1 } f && $1 == "path" { print $2; f = 0 }'
|
|
}
|
|
|
|
# Resolve an @rpath / @loader_path / @executable_path dependency to a real file,
|
|
# printing the path and returning 0, or returning 1 if nothing matches.
|
|
#
|
|
# This is not hypothetical any more. The Metal build links ggml statically, so
|
|
# no ggml object arrives as an @rpath dep, but the OpenMP hint in the backend
|
|
# Makefile makes libomp.dylib a dependency, and whether it is recorded as an
|
|
# absolute /opt/homebrew/opt/libomp path or as @rpath/libomp.dylib is a property
|
|
# of Homebrew's fix_dynamic_linkage that cannot be observed from Linux. Skipping
|
|
# it (what ds4-darwin.sh does with a non-existent path) would ship a package
|
|
# missing its OpenMP runtime; failing without expanding rpaths first would turn
|
|
# a resolvable dependency into a red build.
|
|
resolve_at_path_dep() {
|
|
local object="$1" dep="$2"
|
|
local objdir rpath candidate
|
|
objdir=$(dirname "$object")
|
|
case "$dep" in
|
|
@loader_path/*)
|
|
candidate="$objdir/${dep#@loader_path/}"
|
|
if [ -e "$candidate" ]; then printf '%s\n' "$candidate"; return 0; fi
|
|
;;
|
|
@executable_path/*)
|
|
# At run time the executable is grpc-server at the package root.
|
|
candidate="build/darwin/${dep#@executable_path/}"
|
|
if [ -e "$candidate" ]; then printf '%s\n' "$candidate"; return 0; fi
|
|
;;
|
|
@rpath/*)
|
|
while read -r rpath; do
|
|
case "$rpath" in
|
|
@loader_path) rpath="$objdir" ;;
|
|
@loader_path/*) rpath="$objdir/${rpath#@loader_path/}" ;;
|
|
@executable_path) rpath="build/darwin" ;;
|
|
@executable_path/*) rpath="build/darwin/${rpath#@executable_path/}" ;;
|
|
esac
|
|
candidate="$rpath/${dep#@rpath/}"
|
|
if [ -e "$candidate" ]; then printf '%s\n' "$candidate"; return 0; fi
|
|
done < <(object_rpaths "$object")
|
|
;;
|
|
esac
|
|
return 1
|
|
}
|
|
|
|
# Copy one dylib into lib/ and walk its own dependencies. A no-op if a file of
|
|
# the same leaf name is already bundled, which is both the deduplication and the
|
|
# cycle guard: mutual dependencies terminate because the second visit finds the
|
|
# leaf already recorded.
|
|
bundle_dylib() {
|
|
local path="$1"
|
|
local leaf
|
|
leaf=$(basename "$path")
|
|
case "$BUNDLED_LEAVES" in
|
|
*" $leaf "*) return 0 ;;
|
|
esac
|
|
BUNDLED_LEAVES="${BUNDLED_LEAVES}${leaf} "
|
|
# -L dereferences: Homebrew's unversioned names are symlinks into the
|
|
# Cellar, and copying the link would land a dangling relative symlink. The
|
|
# binary asks for whatever install name is recorded, so the file has to
|
|
# exist under that leaf.
|
|
cp -fLv "$path" build/darwin/lib/
|
|
bundle_dylib_closure "$path"
|
|
}
|
|
|
|
bundle_dylib_closure() {
|
|
local object="$1"
|
|
local dep leaf src
|
|
while read -r dep; do
|
|
case "$dep" in
|
|
*.dylib) ;;
|
|
*) continue ;;
|
|
esac
|
|
leaf=$(basename "$dep")
|
|
case "$BUNDLED_LEAVES" in
|
|
*" $leaf "*) continue ;;
|
|
esac
|
|
|
|
case "$dep" in
|
|
@*)
|
|
# Already inside the package (the ggml objects package.sh copies
|
|
# to the root would land here): record and walk in place.
|
|
if [ -e "build/darwin/$leaf" ]; then
|
|
BUNDLED_LEAVES="${BUNDLED_LEAVES}${leaf} "
|
|
bundle_dylib_closure "build/darwin/$leaf"
|
|
elif [ -e "build/darwin/lib/$leaf" ]; then
|
|
BUNDLED_LEAVES="${BUNDLED_LEAVES}${leaf} "
|
|
bundle_dylib_closure "build/darwin/lib/$leaf"
|
|
elif src=$(resolve_at_path_dep "$object" "$dep"); then
|
|
bundle_dylib "$src"
|
|
else
|
|
# Nothing on disk answers this, so dyld will not find it
|
|
# either. Print the rpath list with it: this fails on a
|
|
# machine nobody can attach to, and without the rpaths the
|
|
# log says only that something was missing.
|
|
echo "audio-cpp-darwin.sh: unresolved dependency of ${object}: ${dep}" >&2
|
|
echo "audio-cpp-darwin.sh: LC_RPATH entries of ${object}:" >&2
|
|
object_rpaths "$object" | sed 's/^/audio-cpp-darwin.sh: /' >&2
|
|
UNRESOLVED=1
|
|
fi
|
|
continue
|
|
;;
|
|
esac
|
|
|
|
# System dylibs live in the dyld shared cache and have no file on disk.
|
|
# That absence is the filter that keeps libSystem, libc++ and the
|
|
# frameworks out of the package; there is no allow-list to maintain.
|
|
[ -e "$dep" ] || continue
|
|
|
|
bundle_dylib "$dep"
|
|
done < <(otool -L "$object" | awk 'NR > 1 { print $1 }')
|
|
# Explicit, because `set -e` would abort on whatever status the loop
|
|
# happened to end on.
|
|
return 0
|
|
}
|
|
|
|
# Apple Silicon: pick up Homebrew-installed protobuf utf8_validity if present
|
|
# (same as ds4-darwin.sh - it is a transitive dep otool may not surface).
|
|
# Unlike ds4-darwin.sh these go through bundle_dylib rather than a bare cp, so
|
|
# they are seeded into the seen-set (no duplicate copy when the walk reaches
|
|
# them) and their own non-system dependencies are bundled too.
|
|
if [[ "$(uname -s)" == "Darwin" && "$(uname -m)" == "arm64" ]]; then
|
|
ADDITIONAL_LIBS=${ADDITIONAL_LIBS:-$(ls /opt/homebrew/Cellar/protobuf/**/lib/libutf8_validity*.dylib 2>/dev/null || true)}
|
|
else
|
|
ADDITIONAL_LIBS=${ADDITIONAL_LIBS:-""}
|
|
fi
|
|
for file in $ADDITIONAL_LIBS; do
|
|
bundle_dylib "$file"
|
|
done
|
|
|
|
bundle_dylib_closure build/darwin/grpc-server
|
|
if compgen -G "build/darwin/*.dylib" > /dev/null; then
|
|
for object in build/darwin/*.dylib; do
|
|
bundle_dylib_closure "$object"
|
|
done
|
|
fi
|
|
|
|
echo "Bundled libraries:"
|
|
ls -la build/darwin/lib
|
|
|
|
if [ "$UNRESOLVED" -ne 0 ]; then
|
|
echo "audio-cpp-darwin.sh: refusing to package: see the unresolved dependencies above." >&2
|
|
exit 1
|
|
fi
|
|
|
|
# Nothing above rewrites an install name or otherwise edits grpc-server, which
|
|
# matters on Apple Silicon: the linker ad-hoc signs the binary, and any
|
|
# in-place edit would invalidate that signature and make the package
|
|
# unlaunchable. cp preserves it.
|
|
./local-ai util create-oci-image \
|
|
build/darwin/. \
|
|
--output ./backend-images/audio-cpp.tar \
|
|
--image-name "$IMAGE_NAME" \
|
|
--platform "$PLATFORMARCH"
|
|
|
|
rm -rf build/darwin
|