mirror of
https://github.com/mudler/LocalAI.git
synced 2026-09-22 14:14:54 -04:00
* feat(credentials): parse and match download credential rules Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep secrets out of parse errors and tighten URL matching Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(credentials): resolve secrets lazily and authenticate HTTP per hop Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): redact secrets in nested and store formatting Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(credentials): add registry keychain and oras credential adapters Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): match repository rules for Docker Hub in the oras adapter Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(downloads): authenticate HTTP downloads and gallery reads from the credentials store Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(oci): authenticate registry pulls, resumes, blobs and cosign from the credentials store Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(cli): load download credentials from --credentials-file Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(credentials): correct the local-network registry rules Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep secrets out of match and YAML parse errors A match that fails to parse is no longer quoted in the Parse error, since it may be a URL with a token in it. Userinfo is detected before the scheme check, so ftp://user:token@host is refused as userinfo, and a match with a query string or fragment is refused because it can never apply and a query string is where signed URLs carry their token. Every YAML decode error is now redacted, not only type errors: quoted scalars such as a secret under a mismatched !!int tag are replaced and unquoted map keys are cut off. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(downloads): make auth errors name the real cause and never retry unresolved secrets AuthError now appends its cause, so a registry's DENIED or UNAUTHORIZED detail reaches the operator. HTTP auth errors print only the status text in place of the cause, because the downloader builds that cause from the requested URL, which can carry a signed query string. Registry pulls say that docker config credentials were tried too, and a download that carried a caller-provided credential (WithBearerToken, or an explicit authorization on gallery reads) reports that credential as rejected instead of blaming the store. The Range probe for a leftover partial file now returns an unresolved secret as a permanent error, like the download request already did. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep oras pulls anonymous on a broken docker helper and close bodies When docker config names a credsStore helper that cannot run, the oras credential func now logs at debug and returns no credential, so public pulls keep working as they did before the adapter existed. The transport closes the request body when a rule's secret cannot be resolved, as the RoundTripper contract requires. The redirect spec now uses a custom header rule on the origin, which net/http would not strip on its own, to prove the transport does not carry credentials to the next hop. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(oci): cover FetchImageBlob authentication against a private registry FetchImageBlob now has a spec that pulls a layer blob by digest from a basic-auth registry through the oras credential adapter, and one that shows the same fetch fails when no rule matches. oras only speaks HTTPS here, so the registry serves TLS and the spec points http.DefaultTransport, which retry.DefaultClient falls back to, at the test server's client for its duration instead of adding a transport seam to production code. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(credentials): document auth error wording, ollama manifests and registry tokens The errors section now lists the registry and provided-credential messages and says the server's reason is appended. ollama:// manifests are fetched without credentials, so only blob downloads use the file. GHCR, Docker Hub and Quay need basic auth with the token as password, and match rules must not carry a query string or fragment. The backend gallery docs and the container troubleshooting section now point to the private sources page. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): document trusted file path The credentials path comes from operator configuration. Mark the file read with a scoped G304 explanation to resolve the gosec false positive. Assisted-by: Codex:gpt-6 gosec --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: localai-org-maint-bot <306269227+localai-org-maint-bot@users.noreply.github.com>
208 lines
7.3 KiB
Go
208 lines
7.3 KiB
Go
package oci
|
|
|
|
import (
|
|
"context"
|
|
"encoding/base64"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/google/go-containerregistry/pkg/authn"
|
|
"github.com/google/go-containerregistry/pkg/name"
|
|
"github.com/google/go-containerregistry/pkg/registry"
|
|
"github.com/google/go-containerregistry/pkg/v1/random"
|
|
"github.com/google/go-containerregistry/pkg/v1/remote"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
|
|
"github.com/mudler/LocalAI/pkg/credentials"
|
|
)
|
|
|
|
const (
|
|
registryUser = "bot"
|
|
registryPass = "s3cret"
|
|
)
|
|
|
|
// requireBasicAuth fronts a registry the way a private registry behaves: every
|
|
// request without the right credentials gets a basic-auth challenge.
|
|
func requireBasicAuth(inner http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
if u, p, ok := r.BasicAuth(); !ok || u != registryUser || p != registryPass {
|
|
w.Header().Set("WWW-Authenticate", `Basic realm="localai-test"`)
|
|
w.WriteHeader(http.StatusUnauthorized)
|
|
return
|
|
}
|
|
inner.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
func useCredentials(doc string) {
|
|
s, err := credentials.Parse([]byte(doc), func(string) (string, bool) { return "", false })
|
|
Expect(err).NotTo(HaveOccurred())
|
|
prev := credentials.SetDefault(s)
|
|
DeferCleanup(func() { credentials.SetDefault(prev) })
|
|
}
|
|
|
|
// isolateDockerConfig stops the test host's docker or podman login from
|
|
// satisfying a spec, and returns the directory that holds config.json.
|
|
func isolateDockerConfig() string {
|
|
home := GinkgoT().TempDir()
|
|
dockerDir := filepath.Join(home, ".docker")
|
|
Expect(os.MkdirAll(dockerDir, 0o700)).To(Succeed())
|
|
GinkgoT().Setenv("HOME", home)
|
|
GinkgoT().Setenv("DOCKER_CONFIG", dockerDir)
|
|
GinkgoT().Setenv("REGISTRY_AUTH_FILE", filepath.Join(home, "no-such-auth.json"))
|
|
GinkgoT().Setenv("XDG_RUNTIME_DIR", home)
|
|
return dockerDir
|
|
}
|
|
|
|
func pushPrivateImage(serverURL, repoPath string) string {
|
|
imageRef := strings.TrimPrefix(serverURL, "http://") + "/" + repoPath + ":latest"
|
|
ref, err := name.ParseReference(imageRef)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
img, err := random.Image(4096, 1)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(remote.Write(ref, img, remote.WithAuth(&authn.Basic{Username: registryUser, Password: registryPass}))).To(Succeed())
|
|
return imageRef
|
|
}
|
|
|
|
var _ = Describe("registry credentials", Serial, func() {
|
|
var (
|
|
server *httptest.Server
|
|
dockerDir string
|
|
imageRef string
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
dockerDir = isolateDockerConfig()
|
|
server = httptest.NewServer(requireBasicAuth(registry.New()))
|
|
DeferCleanup(server.Close)
|
|
imageRef = pushPrivateImage(server.URL, "acme/backend")
|
|
})
|
|
|
|
It("pulls a private image with a credentials rule", func() {
|
|
useCredentials(fmt.Sprintf("- match: %s/acme\n username: %s\n password: %s\n allow_insecure: true\n", server.URL, registryUser, registryPass))
|
|
|
|
_, err := GetImage(imageRef, "", nil, nil)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
digest, err := GetImageDigest(imageRef, "", nil, nil)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(digest).To(HavePrefix("sha256:"))
|
|
})
|
|
|
|
It("reports that no rule matches when the registry demands auth", func() {
|
|
useCredentials("")
|
|
|
|
_, err := GetImage(imageRef, "", nil, nil)
|
|
var authErr *credentials.AuthError
|
|
Expect(errors.As(err, &authErr)).To(BeTrue(), "got %v", err)
|
|
Expect(authErr.Match).To(BeEmpty())
|
|
Expect(authErr.Status).To(Equal(http.StatusUnauthorized))
|
|
})
|
|
|
|
It("names the rule the registry rejected", func() {
|
|
rule := server.URL + "/acme"
|
|
useCredentials(fmt.Sprintf("- match: %s\n username: %s\n password: not-it\n allow_insecure: true\n", rule, registryUser))
|
|
|
|
_, err := GetImageDigest(imageRef, "", nil, nil)
|
|
var authErr *credentials.AuthError
|
|
Expect(errors.As(err, &authErr)).To(BeTrue(), "got %v", err)
|
|
Expect(authErr.Match).To(Equal(rule))
|
|
Expect(err.Error()).NotTo(ContainSubstring("not-it"))
|
|
})
|
|
|
|
It("still authenticates from docker config when no rule matches", func() {
|
|
host := strings.TrimPrefix(server.URL, "http://")
|
|
encoded := base64.StdEncoding.EncodeToString([]byte(registryUser + ":" + registryPass))
|
|
Expect(os.WriteFile(filepath.Join(dockerDir, "config.json"),
|
|
[]byte(fmt.Sprintf(`{"auths":{%q:{"auth":%q}}}`, host, encoded)), 0o600)).To(Succeed())
|
|
useCredentials("")
|
|
|
|
_, err := GetImage(imageRef, "", nil, nil)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
})
|
|
|
|
It("authenticates the Range requests that resume an interrupted layer", func() {
|
|
reg := &droppingBlobRegistry{inner: requireBasicAuth(registry.New())}
|
|
dropping := httptest.NewServer(reg)
|
|
DeferCleanup(dropping.Close)
|
|
prev := layerRetryBackoff
|
|
layerRetryBackoff = func(int) time.Duration { return 0 }
|
|
DeferCleanup(func() { layerRetryBackoff = prev })
|
|
|
|
ref := pushPrivateImage(dropping.URL, "acme/backend")
|
|
useCredentials(fmt.Sprintf("- match: %s/acme\n username: %s\n password: %s\n allow_insecure: true\n", dropping.URL, registryUser, registryPass))
|
|
|
|
pulled, err := GetImage(ref, "", nil, nil)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
tarPath := filepath.Join(GinkgoT().TempDir(), "image.tar")
|
|
Expect(DownloadOCIImageTar(context.Background(), pulled, ref, tarPath, nil)).To(Succeed())
|
|
|
|
reg.mu.Lock()
|
|
defer reg.mu.Unlock()
|
|
Expect(reg.rangeRequests).NotTo(BeEmpty())
|
|
})
|
|
})
|
|
|
|
var _ = Describe("FetchImageBlob registry credentials", Serial, func() {
|
|
var (
|
|
server *httptest.Server
|
|
repo string
|
|
digest string
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
isolateDockerConfig()
|
|
// oras only speaks HTTPS unless a repository opts into plain HTTP,
|
|
// which FetchImageBlob does not, so the registry has to serve TLS.
|
|
server = httptest.NewTLSServer(requireBasicAuth(registry.New()))
|
|
DeferCleanup(server.Close)
|
|
|
|
// FetchImageBlob builds its oras client on retry.DefaultClient, whose
|
|
// transport falls back to http.DefaultTransport on every request.
|
|
// Swapping it for the test server's client is the only way to trust
|
|
// the test certificate without a production seam; the spec is Serial
|
|
// so nothing else sees the swap.
|
|
prev := http.DefaultTransport
|
|
http.DefaultTransport = server.Client().Transport
|
|
DeferCleanup(func() { http.DefaultTransport = prev })
|
|
|
|
repo = strings.TrimPrefix(server.URL, "https://") + "/acme/model"
|
|
ref, err := name.ParseReference(repo + ":latest")
|
|
Expect(err).NotTo(HaveOccurred())
|
|
img, err := random.Image(4096, 1)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(remote.Write(ref, img,
|
|
remote.WithAuth(&authn.Basic{Username: registryUser, Password: registryPass}),
|
|
remote.WithTransport(server.Client().Transport))).To(Succeed())
|
|
layers, err := img.Layers()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
d, err := layers[0].Digest()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
digest = d.String()
|
|
})
|
|
|
|
It("fetches a private blob with a credentials rule", func() {
|
|
useCredentials(fmt.Sprintf("- match: %s/acme\n username: %s\n password: %s\n", server.URL, registryUser, registryPass))
|
|
|
|
dst := filepath.Join(GinkgoT().TempDir(), "blob")
|
|
Expect(FetchImageBlob(context.Background(), repo, digest, dst, nil)).To(Succeed())
|
|
info, err := os.Stat(dst)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(info.Size()).To(BeNumerically(">", 0))
|
|
})
|
|
|
|
It("fails to fetch a private blob when no rule matches", func() {
|
|
useCredentials("")
|
|
|
|
dst := filepath.Join(GinkgoT().TempDir(), "blob")
|
|
err := FetchImageBlob(context.Background(), repo, digest, dst, nil)
|
|
Expect(err).To(MatchError(ContainSubstring("basic credential not found")))
|
|
})
|
|
})
|