mirror of
https://github.com/mudler/LocalAI.git
synced 2026-05-29 11:07:18 -04:00
* refactor(distributed): extract PickBestReplica from FindAndLockNodeWithModel Lifts the replica-selection policy (in_flight ASC, last_used ASC, available_vram DESC) out of the SQL ORDER BY into a pure Go function in the new replicapicker.go. The SQL clause keeps its FOR UPDATE atomicity and remains the production path used by SmartRouter; PickBestReplica is the canonical implementation that the future per-frontend rotating replica cache (TODO referenced from pkg/model) will call against an in-memory snapshot without paying a DB round-trip per inference. A new registry_test mirror spec seeds a multi-tier scenario and asserts both layers pick the same replica, so any future tweak to either side fails the test until the other side is updated. No behavior change. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude:claude-opus-4-7 [Claude Code] * fix(distributed): route per inference request and cache probeHealth Two related fixes that together restore load balancing across loaded replicas of the same model. 1. ModelLoader.Load and LoadModel bypass the local *Model cache when modelRouter is set. The cached *Model wraps an InFlightTrackingClient bound to a single (nodeID, replicaIndex) — reusing it pinned every subsequent request to whichever node won the very first pick, so FindAndLockNodeWithModel's round-robin never got a chance to run even after the reconciler scaled the model out to a second node. In distributed mode SmartRouter.Route now runs per request, and PickBestReplica picks the least-loaded replica each time. SmartRouter has its own coalescing (advisory DB lock for first-time loads + singleflight on backend.install RPC) so concurrent first requests for a not-yet-loaded model still produce a single worker side install. 2. SmartRouter.probeHealth memoizes successful gRPC HealthCheck results in a new probeCache (probe_cache.go) with a 30s TTL. With per-request routing every inference call hits probeHealth, and llama.cpp-style backends serialize HealthCheck behind active Predict — so a burst of incoming requests stalled on the probe to a node already mid-stream, tripping the 2s timeout and falling through to the install path. singleflight collapses N concurrent first-time probes for the same (node, addr) into one round-trip, failed probes invalidate the entry so the staleness-recovery path still triggers, and the TTL matches pkg/model/model.go's healthCheckTTL so the single-process and distributed paths share a staleness budget. The background HealthMonitor still reaps actually-dead backends within ~45s. The bypass introduces one short FindAndLockNodeWithModel transaction per inference. A TODO in pkg/model/loader.go documents the future per modelID rotating-replica cache that would reuse PickBestReplica against an in-memory snapshot and skip the DB round-trip for hot paths. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude:claude-opus-4-7 [Claude Code] --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
423 lines
12 KiB
Go
423 lines
12 KiB
Go
package model
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"maps"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
pb "github.com/mudler/LocalAI/pkg/grpc/proto"
|
|
"github.com/mudler/LocalAI/pkg/system"
|
|
"github.com/mudler/LocalAI/pkg/utils"
|
|
|
|
"github.com/mudler/xlog"
|
|
)
|
|
|
|
// new idea: what if we declare a struct of these here, and use a loop to check?
|
|
|
|
// TODO: Split ModelLoader and TemplateLoader? Just to keep things more organized. Left together to share a mutex until I look into that. Would split if we separate directories for .bin/.yaml and .tmpl
|
|
// ModelUnloadHook is called when a model is about to be unloaded.
|
|
// The model name is passed as the argument.
|
|
type ModelUnloadHook func(modelName string)
|
|
|
|
// RemoteModelUnloader handles unloading models from remote backend nodes.
|
|
// In distributed mode, this is implemented by the SmartRouter.
|
|
// When ShutdownModel is called for a model with no local process,
|
|
// RemoteModelUnloader.UnloadRemoteModel is called to tell the remote node to free it.
|
|
type RemoteModelUnloader interface {
|
|
UnloadRemoteModel(modelName string) error
|
|
}
|
|
|
|
// ModelRouter is a callback that routes model loading to a remote node
|
|
// instead of starting a local process. When set on the ModelLoader,
|
|
// grpcModel() will delegate to this function before attempting local loading.
|
|
type ModelRouter func(ctx context.Context, backend, modelID, modelName, modelFile string,
|
|
opts *pb.ModelOptions, parallel bool) (*Model, error)
|
|
|
|
type ModelLoader struct {
|
|
ModelPath string
|
|
mu sync.Mutex
|
|
store ModelStore
|
|
loading map[string]chan struct{} // tracks models currently being loaded
|
|
wd *WatchDog
|
|
externalBackends map[string]string
|
|
lruEvictionMaxRetries int // Maximum number of retries when waiting for busy models
|
|
lruEvictionRetryInterval time.Duration // Interval between retries when waiting for busy models
|
|
onUnloadHooks []ModelUnloadHook
|
|
remoteUnloader RemoteModelUnloader
|
|
modelRouter ModelRouter // distributed mode: route to remote node
|
|
backendLogs *BackendLogStore
|
|
backendLoggingEnabled atomic.Bool
|
|
}
|
|
|
|
// NewModelLoader creates a new ModelLoader instance.
|
|
// LRU eviction is now managed through the WatchDog component.
|
|
func NewModelLoader(system *system.SystemState) *ModelLoader {
|
|
nml := &ModelLoader{
|
|
ModelPath: system.Model.ModelsPath,
|
|
store: NewInMemoryModelStore(),
|
|
loading: make(map[string]chan struct{}),
|
|
externalBackends: make(map[string]string),
|
|
lruEvictionMaxRetries: 30, // Default: 30 retries
|
|
lruEvictionRetryInterval: 1 * time.Second, // Default: 1 second
|
|
backendLogs: NewBackendLogStore(1000),
|
|
}
|
|
|
|
return nml
|
|
}
|
|
|
|
// GetLoadingCount returns the number of models currently being loaded
|
|
func (ml *ModelLoader) GetLoadingCount() int {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
return len(ml.loading)
|
|
}
|
|
|
|
// OnModelUnload registers a hook that is called when a model is unloaded.
|
|
func (ml *ModelLoader) OnModelUnload(hook ModelUnloadHook) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
ml.onUnloadHooks = append(ml.onUnloadHooks, hook)
|
|
}
|
|
|
|
func (ml *ModelLoader) SetWatchDog(wd *WatchDog) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
ml.wd = wd
|
|
}
|
|
|
|
// SetRemoteUnloader sets the handler for unloading models on remote nodes.
|
|
// In distributed mode, this should be set to the SmartRouter adapter.
|
|
func (ml *ModelLoader) SetRemoteUnloader(u RemoteModelUnloader) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
ml.remoteUnloader = u
|
|
}
|
|
|
|
// SetModelRouter sets the distributed model router callback.
|
|
// When set, grpcModel() will delegate to this function before attempting local loading.
|
|
func (ml *ModelLoader) SetModelRouter(r ModelRouter) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
ml.modelRouter = r
|
|
}
|
|
|
|
// SetModelStore replaces the default in-memory model store.
|
|
// In distributed mode this is called with a DistributedModelStore.
|
|
func (ml *ModelLoader) SetModelStore(s ModelStore) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
ml.store = s
|
|
}
|
|
|
|
func (ml *ModelLoader) GetWatchDog() *WatchDog {
|
|
return ml.wd
|
|
}
|
|
|
|
func (ml *ModelLoader) BackendLogs() *BackendLogStore {
|
|
return ml.backendLogs
|
|
}
|
|
|
|
func (ml *ModelLoader) SetBackendLoggingEnabled(enabled bool) {
|
|
ml.backendLoggingEnabled.Store(enabled)
|
|
}
|
|
|
|
func (ml *ModelLoader) BackendLoggingEnabled() bool {
|
|
return ml.backendLoggingEnabled.Load()
|
|
}
|
|
|
|
// SetLRUEvictionRetrySettings updates the LRU eviction retry settings
|
|
func (ml *ModelLoader) SetLRUEvictionRetrySettings(maxRetries int, retryInterval time.Duration) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
ml.lruEvictionMaxRetries = maxRetries
|
|
ml.lruEvictionRetryInterval = retryInterval
|
|
}
|
|
|
|
func (ml *ModelLoader) ExistsInModelPath(s string) bool {
|
|
return utils.ExistsInPath(ml.ModelPath, s)
|
|
}
|
|
|
|
func (ml *ModelLoader) SetExternalBackend(name, uri string) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
ml.externalBackends[name] = uri
|
|
}
|
|
|
|
func (ml *ModelLoader) DeleteExternalBackend(name string) {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
delete(ml.externalBackends, name)
|
|
}
|
|
|
|
func (ml *ModelLoader) GetExternalBackend(name string) string {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
return ml.externalBackends[name]
|
|
}
|
|
|
|
func (ml *ModelLoader) GetAllExternalBackends(o *Options) map[string]string {
|
|
backends := make(map[string]string)
|
|
maps.Copy(backends, ml.externalBackends)
|
|
if o != nil {
|
|
maps.Copy(backends, o.externalBackends)
|
|
}
|
|
return backends
|
|
}
|
|
|
|
var knownFilesToSkip []string = []string{
|
|
"MODEL_CARD",
|
|
"README",
|
|
"README.md",
|
|
}
|
|
|
|
var knownModelsNameSuffixToSkip []string = []string{
|
|
".tmpl",
|
|
".keep",
|
|
".yaml",
|
|
".yml",
|
|
".json",
|
|
".txt",
|
|
".pt",
|
|
".onnx",
|
|
".md",
|
|
".MD",
|
|
".DS_Store",
|
|
".",
|
|
".safetensors",
|
|
".bin",
|
|
".gguf",
|
|
".ggml",
|
|
".ckpt",
|
|
".zip",
|
|
".tag",
|
|
".partial",
|
|
".tar.gz",
|
|
}
|
|
|
|
const retryTimeout = time.Duration(2 * time.Minute)
|
|
|
|
func (ml *ModelLoader) ListFilesInModelPath() ([]string, error) {
|
|
files, err := os.ReadDir(ml.ModelPath)
|
|
if err != nil {
|
|
return []string{}, err
|
|
}
|
|
|
|
models := []string{}
|
|
FILE:
|
|
for _, file := range files {
|
|
|
|
for _, skip := range knownFilesToSkip {
|
|
if strings.EqualFold(file.Name(), skip) {
|
|
continue FILE
|
|
}
|
|
}
|
|
|
|
// Skip templates, YAML, .keep, .json, and .DS_Store files
|
|
for _, skip := range knownModelsNameSuffixToSkip {
|
|
if strings.HasSuffix(file.Name(), skip) {
|
|
continue FILE
|
|
}
|
|
}
|
|
|
|
// Skip directories
|
|
if file.IsDir() {
|
|
continue
|
|
}
|
|
|
|
models = append(models, file.Name())
|
|
}
|
|
|
|
return models, nil
|
|
}
|
|
|
|
func (ml *ModelLoader) ListLoadedModels() []*Model {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
|
|
models := []*Model{}
|
|
ml.store.Range(func(_ string, m *Model) bool {
|
|
models = append(models, m)
|
|
return true
|
|
})
|
|
|
|
return models
|
|
}
|
|
|
|
func (ml *ModelLoader) LoadModel(modelID, modelName string, loader func(string, string, string) (*Model, error)) (*Model, error) {
|
|
ml.mu.Lock()
|
|
distributed := ml.modelRouter != nil
|
|
ml.mu.Unlock()
|
|
|
|
if distributed {
|
|
// Distributed mode: SmartRouter must run per inference request so
|
|
// PickBestReplica (core/services/nodes/replicapicker.go) picks the
|
|
// least-loaded replica each time. The cached *Model returned from a
|
|
// previous call holds a client wrapper bound to one (nodeID,
|
|
// replicaIndex), so reusing it pins every subsequent request to the
|
|
// node that won the very first pick — defeating per-replica load
|
|
// balancing. Bypass the cache and the loading-coalesce map; the
|
|
// router does its own coalescing for first-time loads (advisory DB
|
|
// lock + singleflight on backend.install RPC), so concurrent first
|
|
// requests still produce a single worker-side install.
|
|
//
|
|
// TODO(distributed-cache): if profiling shows the per-request
|
|
// FindAndLockNodeWithModel SELECT FOR UPDATE becomes a hot path
|
|
// under burst load, replace this branch with a per-modelID cache
|
|
// that holds a *list* of replicas (refreshed every ~5s in
|
|
// background) and picks per call via PickBestReplica against
|
|
// locally-tracked in-flight counters. Same policy, no DB round-trip
|
|
// per inference. Trade-off: cross-frontend in-flight visibility
|
|
// becomes eventually consistent, acceptable for 1-3 frontend
|
|
// deployments.
|
|
modelFile := filepath.Join(ml.ModelPath, modelName)
|
|
model, err := loader(modelID, modelName, modelFile)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to route model with internal loader: %s", err)
|
|
}
|
|
if model == nil {
|
|
return nil, fmt.Errorf("loader didn't return a model")
|
|
}
|
|
// Record the latest mapping so DistributedModelStore.Range, shutdown,
|
|
// and listing endpoints see a representative entry. The DB is the
|
|
// source of truth for cluster-wide state; the local store is just a
|
|
// stub for in-process callers.
|
|
ml.mu.Lock()
|
|
ml.store.Set(modelID, model)
|
|
ml.mu.Unlock()
|
|
return model, nil
|
|
}
|
|
|
|
ml.mu.Lock()
|
|
|
|
// Check if we already have a loaded model
|
|
if model := ml.checkIsLoaded(modelID); model != nil {
|
|
ml.mu.Unlock()
|
|
return model, nil
|
|
}
|
|
|
|
// Check if another goroutine is already loading this model
|
|
if loadingChan, isLoading := ml.loading[modelID]; isLoading {
|
|
ml.mu.Unlock()
|
|
// Wait for the other goroutine to finish loading
|
|
xlog.Debug("Waiting for model to be loaded by another request", "modelID", modelID)
|
|
<-loadingChan
|
|
// Now check if the model is loaded
|
|
ml.mu.Lock()
|
|
model := ml.checkIsLoaded(modelID)
|
|
ml.mu.Unlock()
|
|
if model != nil {
|
|
return model, nil
|
|
}
|
|
// If still not loaded, the other goroutine failed - we'll try again
|
|
return ml.LoadModel(modelID, modelName, loader)
|
|
}
|
|
|
|
// Mark this model as loading (create a channel that will be closed when done)
|
|
loadingChan := make(chan struct{})
|
|
ml.loading[modelID] = loadingChan
|
|
ml.mu.Unlock()
|
|
|
|
// Ensure we clean up the loading state when done
|
|
defer func() {
|
|
ml.mu.Lock()
|
|
delete(ml.loading, modelID)
|
|
close(loadingChan)
|
|
ml.mu.Unlock()
|
|
}()
|
|
|
|
// Load the model (this can take a long time, no lock held)
|
|
modelFile := filepath.Join(ml.ModelPath, modelName)
|
|
xlog.Debug("Loading model in memory from file", "file", modelFile)
|
|
|
|
model, err := loader(modelID, modelName, modelFile)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to load model with internal loader: %s", err)
|
|
}
|
|
|
|
if model == nil {
|
|
return nil, fmt.Errorf("loader didn't return a model")
|
|
}
|
|
|
|
// Add to models map
|
|
ml.mu.Lock()
|
|
ml.store.Set(modelID, model)
|
|
ml.mu.Unlock()
|
|
|
|
return model, nil
|
|
}
|
|
|
|
func (ml *ModelLoader) ShutdownModel(modelName string) error {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
|
|
return ml.deleteProcess(modelName)
|
|
}
|
|
|
|
func (ml *ModelLoader) CheckIsLoaded(s string) *Model {
|
|
ml.mu.Lock()
|
|
defer ml.mu.Unlock()
|
|
return ml.checkIsLoaded(s)
|
|
}
|
|
|
|
func (ml *ModelLoader) checkIsLoaded(s string) *Model {
|
|
m, ok := ml.store.Get(s)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
xlog.Debug("Model already loaded in memory", "model", s)
|
|
|
|
// Skip the gRPC health check if the model was recently verified.
|
|
// This avoids serializing concurrent requests behind ml.mu while each
|
|
// one does a network round-trip (especially costly in distributed mode).
|
|
if m.IsRecentlyHealthy() {
|
|
xlog.Debug("Model health check cached, skipping gRPC probe", "model", s)
|
|
return m
|
|
}
|
|
|
|
client := m.GRPC(false, ml.wd)
|
|
|
|
xlog.Debug("Checking model availability", "model", s)
|
|
cTimeout, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
|
|
defer cancel()
|
|
|
|
alive, err := client.HealthCheck(cTimeout)
|
|
if !alive {
|
|
xlog.Warn("GRPC Model not responding", "error", err)
|
|
xlog.Warn("Deleting the process in order to recreate it")
|
|
process := m.Process()
|
|
if process == nil {
|
|
// Remote/distributed model — no local process to check.
|
|
// Only evict on definitive connection errors (node is down).
|
|
// Timeouts may mean the node is busy, so keep the model cached.
|
|
if isConnectionError(err) {
|
|
xlog.Warn("Remote model unreachable (connection error), removing from cache", "model", s, "error", err)
|
|
if delErr := ml.deleteProcess(s); delErr != nil {
|
|
xlog.Error("error cleaning up remote model", "error", delErr, "model", s)
|
|
}
|
|
return nil
|
|
}
|
|
xlog.Warn("Remote model health check failed (possible timeout), keeping cached", "model", s, "error", err)
|
|
return m
|
|
}
|
|
if !process.IsAlive() {
|
|
xlog.Debug("GRPC Process is not responding", "model", s)
|
|
// stop and delete the process, this forces to re-load the model and re-create again the service
|
|
err := ml.deleteProcess(s)
|
|
if err != nil {
|
|
xlog.Error("error stopping process", "error", err, "process", s)
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
m.MarkHealthy()
|
|
return m
|
|
}
|