mirror of
https://github.com/mudler/LocalAI.git
synced 2026-07-05 13:57:28 -04:00
38350d363e
qwen3-tts-cpp, omnivoice-cpp, acestep-cpp and vibevoice-cpp shipped rocm-* variants that silently ran on CPU ([Load] backend: CPU). Two coupled defects: - The Makefiles passed -DGGML_HIPBLAS=ON, but the vendored ggml only understands -DGGML_HIP=ON (GGML_HIPBLAS was removed upstream), so the ggml-hip backend target was never created and no GPU code was built. - The CMake foreach that links the ggml GPU backends into the module listed blas/cuda/metal/vulkan but not hip, so even a built ggml-hip would not have been linked and its static backend registration would never run. CUDA users were unaffected because cublas passes the correct GGML_CUDA=ON and the foreach already links cuda. Mirror the proven llama-cpp hipblas block (ROCm clang CC/CXX + AMDGPU_TARGETS) and add hip to each foreach. Upstream picks the best device via ggml_backend_init_best(), so no runtime flag is needed once HIP is compiled and linked. Assisted-by: Claude:claude-opus-4-8[1m] [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
80 lines
3.5 KiB
CMake
80 lines
3.5 KiB
CMake
cmake_minimum_required(VERSION 3.18)
|
|
project(govibevoicecpp LANGUAGES C CXX)
|
|
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
|
|
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
|
|
|
|
set(VIBEVOICE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/sources/vibevoice.cpp)
|
|
|
|
# Override upstream's CMAKE_CUDA_ARCHITECTURES before add_subdirectory.
|
|
if(NOT DEFINED CMAKE_CUDA_ARCHITECTURES)
|
|
set(CMAKE_CUDA_ARCHITECTURES "75-virtual;80-virtual;86-real;89-real")
|
|
endif()
|
|
|
|
# Force-disable upstream tests/examples — we only need libvibevoice.
|
|
set(VIBEVOICE_BUILD_TESTS OFF CACHE BOOL "" FORCE)
|
|
set(VIBEVOICE_BUILD_EXAMPLES OFF CACHE BOOL "" FORCE)
|
|
set(VIBEVOICE_BUILD_SERVER OFF CACHE BOOL "" FORCE)
|
|
|
|
# vibevoice.cpp's top-level CMakeLists already adds third_party/ggml as a
|
|
# subdirectory — no need to add it explicitly here, just include the
|
|
# whole project.
|
|
add_subdirectory(${VIBEVOICE_DIR} vibevoice EXCLUDE_FROM_ALL)
|
|
|
|
add_library(govibevoicecpp MODULE cpp/govibevoicecpp.cpp)
|
|
|
|
# libvibevoice is STATIC; without --whole-archive the linker GCs the
|
|
# vv_capi_* symbols (purego dlopens them by name, nothing in our
|
|
# translation unit references them). Force the static archive's
|
|
# entire contents into the MODULE so dlsym finds vv_capi_load etc.
|
|
#
|
|
# Link the `vibevoice` TARGET (not a bare archive path) so CMake builds
|
|
# libvibevoice.a first and tracks the dependency: the upstream project is added
|
|
# with EXCLUDE_FROM_ALL, so without a target-level link there is no rule to
|
|
# build it. Passing only $<TARGET_FILE:vibevoice> as a path on Apple left the
|
|
# build with "No rule to make target 'vibevoice/libvibevoice.a'" (issue #10267).
|
|
# force_load is then applied as a separate link option.
|
|
if(APPLE)
|
|
target_link_libraries(govibevoicecpp PRIVATE vibevoice)
|
|
target_link_options(govibevoicecpp PRIVATE "-Wl,-force_load,$<TARGET_FILE:vibevoice>")
|
|
elseif(MSVC)
|
|
target_link_libraries(govibevoicecpp PRIVATE vibevoice)
|
|
set_property(TARGET govibevoicecpp APPEND PROPERTY LINK_FLAGS "/WHOLEARCHIVE:vibevoice")
|
|
else()
|
|
target_link_libraries(govibevoicecpp PRIVATE
|
|
-Wl,--whole-archive vibevoice -Wl,--no-whole-archive)
|
|
endif()
|
|
|
|
target_include_directories(govibevoicecpp PRIVATE ${VIBEVOICE_DIR}/include)
|
|
target_include_directories(govibevoicecpp SYSTEM PRIVATE ${VIBEVOICE_DIR}/third_party/ggml/include)
|
|
|
|
# Link GPU backends if available — vibevoice's own CMake already links
|
|
# these to the libvibevoice STATIC library, but we re-link them on the
|
|
# MODULE so resolved symbols include all backend kernels.
|
|
foreach(backend blas cuda hip metal vulkan)
|
|
if(TARGET ggml-${backend})
|
|
target_link_libraries(govibevoicecpp PRIVATE ggml-${backend})
|
|
string(TOUPPER ${backend} BACKEND_UPPER)
|
|
target_compile_definitions(govibevoicecpp PRIVATE VIBEVOICE_HAVE_${BACKEND_UPPER})
|
|
if(backend STREQUAL "cuda")
|
|
find_package(CUDAToolkit QUIET)
|
|
if(CUDAToolkit_FOUND)
|
|
target_link_libraries(govibevoicecpp PRIVATE CUDA::cudart)
|
|
endif()
|
|
endif()
|
|
endif()
|
|
endforeach()
|
|
|
|
if(MSVC)
|
|
target_compile_options(govibevoicecpp PRIVATE /W4 /wd4100 /wd4505)
|
|
else()
|
|
target_compile_options(govibevoicecpp PRIVATE -Wall -Wextra -Wshadow
|
|
-Wno-unused-parameter -Wno-unused-function -Wno-sign-conversion)
|
|
endif()
|
|
|
|
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
|
|
target_link_libraries(govibevoicecpp PRIVATE stdc++fs)
|
|
endif()
|
|
|
|
set_property(TARGET govibevoicecpp PROPERTY CXX_STANDARD 17)
|
|
set_target_properties(govibevoicecpp PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR})
|