mirror of
https://github.com/mudler/LocalAI.git
synced 2026-11-06 04:23:15 -05:00
* feat(addons): model execution status observations Keep observation lifetimes explicit before runtime integration. The pure reducer rejects retries and stale replies using exact binding identity. Cover all eleven trace families, the complete transition matrix and bounded histories with safety and liveness checks. Assisted-by: nib:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): visualize execution status traces Generate a self-contained viewer from the real reducer and shared traces. Check independent expectations, coverage and bounded invariants before exporting data. Detect stale artifacts and nondeterministic generation without maintaining a second reducer in JavaScript. Assisted-by: nib:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): honor the viewer artifact root Keep default viewer output under SDD_LOCAL_ROOT when configured.\nLet go generate use the same default without forcing a source artifact.\nRetain the portable fallback and explicit output and check semantics. Assisted-by: nib:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): add typed extension contracts Validate optional home commands, execution bindings and requested host operations without changing manifest versions or granting authority. Decode bounded execution status payloads conservatively and document strict staging compatibility for older hosts. Assisted-by: nib:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): reject noncanonical extension keys Reject case aliases before typed decoding can override canonical fields or bypass presence checks. Keep locale maps outside exact-key checks. Add regression coverage for status, declaration objects, and nested entries. All status errors return unknown readiness and isolation. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): reject root enums for status tools Status tools must accept the empty object. The supported schema enums contain only strings, so a root enum excludes every object. Reject root enums only for execution status bindings. Cover incompatible root constraints and optional properties without changing shared validation. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): project typed home commands Resolve declared home destinations and display metadata in the installed Apps view. Pin packaged command icons to immutable asset URLs. Cover strict declaration transport, immutable receipts, exact health echo, and process restart. Keep legacy packages and disabled installed intent. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): preserve typed lifecycle declarations Copy execution and host-operation declarations from installed receipts. The existing capability completeness test exposes the missing fields. Exercise real staged Manager upgrades, activation rollback and recovery. Check installed Apps metadata through pinned mTLS frontends for each actor. Verify mutation isolation and name receipt replay coverage accurately. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): stabilize fixture archive digests Map iteration changes tar entry order between identical publishes. Sort fixture filenames so unchanged packages retain their digest. Check repeated publish bytes, digests and lexical archive entry order with and without a manifest transform. Register the regression case. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): resolve explicit host policy grants Load strict administrator policy files once before application startup. Honor explicit empty overrides without reading ignored policy files. Copy programmatic and manager grants to isolate startup authority. Keep the legacy CLI fallback until the official deployment policy ships. The generic resolver already defaults to empty grants. Verify config, CLI, hostops and execution-status checks with GOMAXPROCS=2, -p=2 and -ldflags="-s -w" to fit the available build disk. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): select explicit deployment grants Move official host grants out of the generic executable into reviewed host deployment policy. Stock Docker explicitly selects the shipped file; unconfigured binaries and nil or empty programmatic grants grant nothing. Document the standalone upgrade break and deliberate operator selection. Do not infer consent from installed addons or merge explicit overrides. Guard policy packaging and generic configuration boundaries with tests. Verify executionstatus, viewer -check, config, CLI, packaging and root architecture tests with auth, GOMAXPROCS=2 and bounded build parallelism. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): gate activation on required host ops Refuse unmet required requests before package publication or runtime withdrawal. Keep installed intent unavailable when startup grants change. Optional requests permit degraded operation and never create authority. Carry bounded admin diagnostics through Apps and the owner carrier. Keep startup policy immutable and broker authorization authoritative. Verify executionstatus, viewer -check, lifecycle, packages, updates, hostops, Apps and gateway offline with auth and bounded parallelism. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(addons): guard host operation registry parity Compare startup admission names against real builtin registrations so registry drift cannot silently change request satisfaction. Cover dynamic progress and stop operations and connector inbound. Reject missing, extra, duplicate and case-changed names with negative controls. Record both regression cases in the suite inventory. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): fence status observation effects Keep observation ownership in admitted runtime operations. Deny all correlated callbacks before dispatch, including inbound-class callbacks. Reject status outputs before callers can open or adopt artifact handles. Retain bounded denial correlations until the runtime endpoint closes so late callbacks cannot recover ordinary authority. Preserve independent ordinary operations and document the dedicated read API for T9. Verify the status model, viewer, and race-enabled gateway, hostops and runtime suites with the pinned offline environment. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): drain callbacks before retirement Server.Close does not wait for active callback requests. Clearing retired observation correlations first can restore inbound authority. Stop endpoint admission before closing connections. Drain admitted requests before releasing correlations, and refuse dispatch after Stop. Keep locks out of handlers and cleanup waits so cancellation cannot deadlock teardown. Cover pending inbound callbacks, decoded authorization paused across Stop, and handlers that ignore cancellation. Preserve ordinary authorized work on other endpoints. Document delayed reclamation under the existing bound. Verify the status model and viewer, then race-test gateway, hostops, runtime, the model and root architecture checks with auth enabled. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): bind owner status to exact clients Add authenticated, versioned status reads over the owner carrier. Revalidate actor permissions and provider selection before dispatch and before returning an observation. Keep status separate from authority. Admit the captured client against its immutable identity under the withdrawal lock. Never dispatch an old binding through a replacement. Generate runtime operation IDs on the owner and retain the T8 effect fence. Cover forged identities, strict DTOs, stale replies, restart ordering, wire discriminators, and unchanged model exclusion of uiOnly tools. Document the T10 callback and request-shell integration requirements. Verify the model and viewer, then race-test gateway, runtime, tools, and the model with auth enabled. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(addons): compose owner status with runtime Exercise installed addon processes through the authenticated mTLS carrier. Keep runtime clients real while channel barriers control lookup ordering. Reject captured clients after same-generation replacement before dispatch. Reject completed status reads when replacement precedes owner consumption. Prove fresh bindings succeed and record named tools and host operation IDs. Verify the model and viewer, then race-test gateway, runtime, tools, the model, and the protocol fixture package with auth enabled. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(studio): scope execution status observations Run the execution status reducer within one explicit request lifetime. Coalesce consumers without retries and withdraw stale or canceled reads. Keep owner admission and production lifecycle integration separate for review before wiring the shell into requests and turns. Assisted-by: OpenAI:ChatGPT Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(studio): isolate consumer cancellation Consumer cancellation during validation must not withdraw a valid observation from other consumers. Return unknown locally before shared invalidation, while preserving parent closure and freshness failures. Cover cancellation and deterministic deadline expiry with one-read reducer traces and live-consumer checks. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): track selection mutation epochs Detect selection ABA at config and owner mutation boundaries. Clone provider pins for Studio readers and share synchronized selection state across config value copies. Track lifecycle publication, candidate rollback and recovery transitions. Keep reads and unchanged publications stable. These lifetime epochs do not replace current-incarnation checks or grant execution authority. Verify race tests for config and the add-on Manager, plus application compilation with auth tags. Request binding remains separate work. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): expose owner binding transport Add a host-only binding API with an optional owner resolver. Forward conversation claims over authenticated mTLS with strict versioned DTOs. Compare full bindings during validation and deny missing resolvers. Keep ordinary tool execution unchanged through an optional backend. Test trusted resolver fixtures, stale bindings, denial and compatibility. Application authority and store revisions remain a separate milestone. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(studio): fence selection snapshots with epochs Read actor-scoped records and opaque mutation tokens under store locks. Invalidate tokens after successful eligibility changes, including ABA. Keep reads, rejected writes and turn history from invalidating tokens. Clone mutable records so callers cannot bypass mutation tracking. Support authoritative revisions only for memory-only JSON stores. File stores lack exclusive ownership; GORM lacks persisted revisions. Fail closed for both rather than trust frontend-local state. Ordinary chats remain unchanged; application integration stays separate. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(studio): enforce persistent JSON ownership Acquire lifetime sidecar locks before loading or repairing JSON data. Enable selection revisions only under cooperating exclusive ownership. Close drains operations before releasing ownership and rejects later use. Clean up unpublished stores when application initialization fails. Retain published locks through Shutdown because HTTP users may remain live. Document coordinated upgrades and the advisory local-filesystem boundary. Keep GORM revisions unsupported pending a separate approved design. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Codex:gpt-5 * test(application): isolate warning log capture Run warning assertions in isolated test subprocesses. The suite leaves background log producers running, which race with global logger changes. Keep the parent logger unchanged and check child exits and completion markers. Preserve pin persistence and ownership warning assertions. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(studio): resolve local owner execution bindings Resolve execution providers from owner-held chat and agent snapshots. Fence bindings with selection epochs, mutation tokens and live runtime identity. Recompute every component during status authorization. Keep named-user and SQL observations unavailable until authoritative access and shared selection revisions can detect ABA changes. Drain restart test producers before releasing JSON store ownership. Register six product resolver cases in the gateway suite inventory. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(studio): bound product scopes to chat turns Keep request-local product state alive through tool calls, checkpoints and persistence. Give chat priming its own scope instead of seeding the next turn with a closed observation. Exercise one reducer read per scope across prompt and tool consumers. Check closure of pending reads on normal completion and interruption. Provider wiring and safety projection remain separate work. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(studio): consume typed execution providers Replace the Sandbox-specific status heuristic with owner-bound typed reads. Share one reducer observation across turn consumers and close it at the outer scope boundary. Keep priming and standalone requests independent. Sandbox exposes a separate callback-free typed read while preserving its private Settings payload. Unknown backends never imply isolation. Provider isolation does not prove host network-policy enforcement. Local-owner JSON bindings are supported. Named-user and SQL bindings remain explicitly unavailable and fail closed. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(application): isolate auth startup lifetime Shutdown does not join every background producer. Auth startup tests can therefore delete their temporary directory while a writer remains. Run each case in a bounded child process. The parent waits for child exit before deleting the fixture, preserving every startup assertion. Production shutdown and JSON ownership retention remain unchanged. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(ui): resolve installed Home app commands Project Home navigation from installed addon declarations, not product IDs. Reserve native and skill names and suppress every colliding addon alias. Re-read the authenticated registry before navigation and reject stale actors, generations, immutable entries and destinations. Keep mounted consumers polling through disabled and failed states. Abort pending reads on actor changes and ignore replies from obsolete request epochs. Studio declares its own alias. Preserve legacy redirects and pin migration. Add unit coverage, localized Home copy and command lifecycle documentation. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): accept resolved Home command metadata Apps resolves inherited titles beyond the explicit manifest label cap. Bound resolved labels to 147 Unicode characters, including secondary pages. Keep the backend's 60-character limit for explicit manifest labels. Match packaged icon paths to the contract's ASCII alphabet and image types. Accept dotted names while rejecting traversal, encodings and foreign assets. Verify 68 focused cases, 657 total cases, lint, i18n checks and the UI build. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): bind safety notices to actual providers Warn for addon host execution and unknown isolation without changing tool permissions or built-in host consent. Reset dismissal when the admitted binding, observation, actor or chat context changes. Expose presentation-only status identity from the admitted request. Keep configured network policy visible when enforcement is unverified. Render bounded provider explanations as escaped React text. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): isolate command status across sessions Invalidate command observations when actors or authentication sessions change, before effects can expose a previous actor’s reply. Keep actual host execution warnings generic instead of recommending Sandbox installation or repair. Cover both regressions with source-hook lifecycle tests and provider notice assertions. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): declare audited host requests Declare actual official hostclient operations without inferring requests from deployment grants. Keep optional settings and egress checks separate from required workspace and job operations. Verify all twelve manifests through strict package fixtures and assert that requests never self-grant. Guard generic provider and Home dispatch without banning historical routes, native Studio, or deployment policy. Document the audited operations and unresolved named-user and SQL gaps. Refresh Sandbox catalog metadata for its existing typed status tool. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(addons): wire exact extension inventories and real provider selection Run contract, official packaging and root architecture gates through actual report inventories. Exercise two installed execution providers through the real owner resolver and distinguish callback pass-through coverage. Share strict report validation with focused-scope handling and missing/skipped artifact self-tests; document direct evidence and remaining harness limits. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): expire registry reads on auth refresh Bind registry authority to the actual authentication session epoch. Same-user refresh now rejects old polls and pending Home navigation before effect cleanup, even when permissions and metadata stay unchanged. Exercise both races through the production registry provider harness. Verify 59 focused tests, 669 total tests, lint, i18n, and the UI build. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(studio): resolve current execution selection Use existing principal-scoped chat and agent reads for advisory status. Revalidate current named credentials instead of requiring historical SQL revisions. Local-owner mode also works with the existing GORM store. Remove resolver nonces and historical revision prerequisites. Keep exact runtime binding and existing status admission hooks. Document current-read consistency without promising revoke-and-restore detection. Verify the SQLite regression fails before the fix. Two separate full race runs pass: application 262 specs (3 skips), auth 257, gateway 115, tools 91. Cover named chat, API key and session credentials and current-state denial. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(addons): drop selection revision tracking Use current selection comparisons for advisory status instead of mutation history. Keep actor, credential and conversation identity explicit in the model. Hash current inputs at the gateway without exposing raw store data. Remove unused epochs, revision interfaces and JSON ownership lifetimes. Preserve current authorization, runtime identity, mutexes and atomic writes. Document current-read semantics without historical ABA guarantees. Verify all affected packages with the race detector and auth tag. Check the trace viewer, prerequisite self-tests and 18 chat-command unit tests. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): scope Apps reads and provider status Bind Apps replies and registry ingestion to their originating auth session. Reject late replies before effect cleanup on refresh or account switch. Use selected-provider command DTOs in the composer instead of private Sandbox discovery. Keep unknown isolation unknown and remove specific add-on installation recommendations from the affected native surfaces. Test production Apps, registry, switches and composer paths with controlled cleanup and two arbitrary providers. Update the matching feature docs. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): guard composer and session publication Remove the deleted Sandbox variable from the full composer render. Report unknown command isolation explicitly in the about card. Bind Apps records and admin action results to their originating actor and actual authentication epoch before cleanup can run. Reject stale request admission and verification without changing server authorization. Add full-component render and pending session-transition regressions. Enable no-undef for the production composer in normal UI lint. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): expire cancelled upgrade reconciliation Bind cancellation reconciliation to the initiating session authority. Discard status replies after expiry without publishing old outcomes. Match the exact operation identity before clearing a held action. Cover pending cancellation reads, expiry before reads, and preservation of a newer attempt with the same action key. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): bind background upgrades to auth lifetime Keep background upgrade authority in AuthProvider, independent of views. Expire pending observations before auth consumers render or logout waits. Preserve same-session navigation and exact-operation cleanup. Cover cancellation, completion, and verification after the origin unmounts with actual provider transitions and the real upgrade store. Thread captured authority through Activity retries and document expiry. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(addons): remove implicit sidebar pins Start every account without implicit Studio or Talk pins. Preserve saved user selections and durable explicit pins across reopen and frontends. Remove startup seeding, seed metadata APIs, and first-install exceptions. Apply equal retention to all absent IDs without dropping database tables. Keep store initialization, cached errors, and the leader sweep unchanged. Verify genuine RED regressions before removal. Race checks pass for all 42 pin specs, 10 focused application specs, and 10 pin endpoint specs. Update pin documentation; renamed specs have no exact inventory entries. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(addons): declare typed model destinations Let installed addons own model launch destinations without teaching core about addon identities or private routes. Keep native chat and completion outside the declaration vocabulary. Validate strict keys, unique capabilities, declared pages and SDK route bounds. Carry cloned typed metadata through Apps using the shared contract type, and add owning Studio, Talk, Face and Voice declarations. Verify strict contract RED before implementation, then 1276 passing specs across contract, Apps, packages, runtime, protocol, config and manager. Verify 178 packaging and architecture specs and exact carrier inventories. Frontend dispatch and route cleanup remain a separate milestone. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(ui): resolve declared model launch actions Resolve installed model actions through the shared addon registry. Keep native chat and completion launches, and never promote absent providers. Refresh actor-filtered Apps before navigation and reject stale authority, provider metadata, generation, immutable entry and destination claims. Use named menu choices for collisions without loading addon modules. Remove unreleased addon-specific redirects and migrate browser fixtures to canonical declared pages. Preserve native chat handoff and addon-local navigation adapters. Update user documentation and historical plans. Verify three production UI consumers fail against their previous code, then pass all 13 mocked-HTTP browser regressions. Verify 696 host unit cases, full quiet lint, targeted no-undef, locales, inline styles and build. Full backend/browser integration remains outside these mocked-HTTP checks. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): validate Ginkgo hooks before focus Ginkgo emits null container hierarchies for suite hooks. Require hooks\nto pass before applying focus only to It cases. Normalize null\nhierarchies without weakening exact required-case comparisons.\n\nRun reporter regressions in prerequisites. Register the declared uiOnly\ntool case and remove an update fixture case excluded by the existing\nmanager focus. Both inventories match the complete CI case output.\n\nVerify 12 reporter regressions, 39 prerequisite cases, three existing\nreports, and fresh runtime, tools and focused update manager suites. Assisted-by: Codex:gpt-5 [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): restore Go CI contract checks Align route fixtures with explicit pins and declared network controls. Keep network enforcement unknown instead of inferring it from isolation. Propagate viewer output errors and select output paths with CLI arguments. Check test writes and use Ginkgo assertions without copying atomic state. Register the three migrated binding cases in the exact suite inventory. Document two narrow security false positives for administrator file access and symbolic credentials in reducer traces. Focused race tests pass. The available golangci-lint reports zero issues in affected packages. Assisted-by: OpenAI ChatGPT [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(ui): align browser coverage with addon contracts The generic provider refactor removes implicit install advice and private Sandbox discovery. Update browser fixtures to use the installed command metadata and typed execution observations without restoring those paths. Keep command warnings, consent, disabled switches and privacy assertions. Home now holds a live command consumer. Exercise polling shutdown on a route without that consumer, after its lazy transition finishes. Preserve the bounded cadence, error backoff and disable-stop assertions. Restore the remembered-voices link through the addon's compatibility router. Cover native migrations and NotFound for removed generator aliases. Validation: 293 affected browser cases and three native service cases pass. The gallery command passes all 74 inventoried cases. Full UI units, quiet lint, locale parity, production build and diff checks pass. Assisted-by: OpenAI ChatGPT [functions] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(addons): bind status to owner provider policy Resolve typed status with the same current owner pins as execution. Fail closed on owner policy outages and fingerprint authoritative pins. Exercise CAS updates, conflicts, stale bindings, and policy outages. Retain host settings when the named-account fixture replaces its gateway. Refresh exact gateway and Apps inventories from passing reports. Validation: the new regression fails before the fix. All 16 focused binding and policy cases pass. Gateway passes 361 exact cases and Apps passes 265 exact cases across their configured package reports. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(addons): share qualified tool identities Use one formatter and contract-component parser for add-on identities. Keep callable names bounded to 64 characters while recognizing long unavailable stand-ins without granting dispatch authority. Validate selected execution names and their provider ID at the owner binding boundary. The real adapter already emits canonical identities. Update exact importer and case inventories from passing reports. Migrate the binding backend test to Ginkgo and check shutdown errors reported by lint in the affected packages. Validation: behavioral RED proves malformed stand-in acceptance and plain selected-name acceptance. Affected full race suites pass: tools 94 and Studio 638, with zero skips. Application passes 275 of 278; three existing PostgreSQL cases skip without their configured URL. All 12 owner-binding cases pass and match the exact inventory. Scoped golangci-lint reports no issues. Assisted-by: Codex:gpt-5 golangci-lint Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(addons): share execution declarations Share pure declaration predicates across manifest validation, gateway observations, and owner bindings. Keep authorization and exact-runtime admission checks local. Reuse the strict manifest schema validator so raw status definitions fail closed without changing manifest acceptance. Share the workspace-operation prefix scan without changing grant sources. Add declaration parity and workspace-prefix tables and update exact inventories from passing reports. Validation: two new gateway cases fail before the fix; all 14 pass after. Race tests pass: contract 245, gateway 136, tools 94, and focused application binding/workspace cases 22. Scoped golangci-lint: 0 issues. Assisted-by: Codex:gpt-5 golangci-lint Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(addons): retain document skill cases Match the contract inventory to the passing report after rebasing.\nKeep the new document-provider case and updated reserved-name cases. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: OpenAI:gpt-6.1-sol * test(addons): follow owner-managed upgrades Accepted upgrades belong to the owner and cannot be cancelled by UI. Exercise observer expiry during reads, completion and verification. Supply the real upgrade store to source-executed auth harnesses so logout reaches its synchronous authority invalidation. Match whole-package inventories to fresh Manager and gateway reports. Assisted-by: Codex:gpt-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
1415 lines
49 KiB
Go
1415 lines
49 KiB
Go
// SPDX-License-Identifier: MIT
|
|
// Package addons owns durable addon intent on one explicitly designated host.
|
|
package addons
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"regexp"
|
|
"slices"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"syscall"
|
|
"time"
|
|
|
|
"github.com/mudler/xlog"
|
|
|
|
"github.com/mudler/LocalAI/core/services/addons/apps"
|
|
"github.com/mudler/LocalAI/core/services/addons/catalog"
|
|
"github.com/mudler/LocalAI/core/services/addons/packages"
|
|
"github.com/mudler/LocalAI/core/services/addons/recovery"
|
|
addonruntime "github.com/mudler/LocalAI/core/services/addons/runtime"
|
|
"github.com/mudler/LocalAI/core/services/addons/updates"
|
|
"github.com/mudler/LocalAI/pkg/addons/contract"
|
|
)
|
|
|
|
var (
|
|
ErrConfiguration = errors.New("invalid addon owner configuration")
|
|
ErrNotOwner = errors.New("addon owner unavailable on this replica")
|
|
ErrOwnerBusy = errors.New("addon storage already owned")
|
|
ErrForbidden = errors.New("addon administration denied")
|
|
ErrConflict = errors.New("conflicting addon lifecycle command")
|
|
ErrOperationFailed = errors.New("addon operation failed; use a new operation ID for an explicit retry")
|
|
ErrRecoveryRequired = errors.New("addon journal requires reconciliation")
|
|
// ErrStaleGeneration is a denial: the caller acted on a generation that is
|
|
// no longer the installed one. Nothing was recorded.
|
|
ErrStaleGeneration = errors.New("addon generation changed")
|
|
// ErrStaleInstalled is a denial of an explicit upgrade: the installed
|
|
// package is not the one the caller checked. Nothing was recorded.
|
|
ErrStaleInstalled = errors.New("installed add-on changed since the update was checked")
|
|
// ErrCandidateChanged is a denial of an explicit upgrade: the library no
|
|
// longer resolves to the candidate the caller checked. Nothing was recorded.
|
|
ErrCandidateChanged = errors.New("update candidate changed since it was checked")
|
|
// ErrTransitionConflict is a denial: the same upgrade, from the same
|
|
// installed package to the same candidate, is recorded under another
|
|
// operation ID and has not failed.
|
|
ErrTransitionConflict = errors.New("this upgrade is already recorded under another operation ID")
|
|
// ErrIncompatible is a denial: the candidate cannot run on this host.
|
|
ErrIncompatible = errors.New("update candidate is not compatible with this host")
|
|
// ErrIntegrity is a denial: the library lists the installed immutable
|
|
// version with another digest. It is never an update.
|
|
ErrIntegrity = errors.New("library rewrote an immutable version")
|
|
// ErrCheckFailed is a denial: the owner could not tell what the library
|
|
// offers, so nothing was started. It is not an unknown outcome.
|
|
ErrCheckFailed = errors.New("update check failed")
|
|
)
|
|
|
|
// Codes of the cause of a failed install or upgrade. A cause is typed so that
|
|
// an administrator is told which step failed without reading the server log.
|
|
const (
|
|
// CauseLibraryUnavailable: the library could not be read.
|
|
CauseLibraryUnavailable = "library_unavailable"
|
|
// CauseLibraryConflict: two enabled libraries list the same add-on.
|
|
CauseLibraryConflict = "library_conflict"
|
|
// CauseReleaseNotFound: the library does not list the requested release
|
|
// for this platform.
|
|
CauseReleaseNotFound = "release_not_found"
|
|
// CausePackageFetch: the package could not be downloaded or staged.
|
|
CausePackageFetch = "package_fetch_failed"
|
|
// CauseInstallStorage: the verified package could not be written to disk.
|
|
CauseInstallStorage = "install_storage_failed"
|
|
)
|
|
|
|
// FailureCause is the typed cause of a failed operation. Its text is fixed and
|
|
// safe to show; the underlying error stays in the server log.
|
|
type FailureCause struct {
|
|
Code string
|
|
detail error
|
|
}
|
|
|
|
func (c *FailureCause) Error() string { return "addon operation failed: " + c.Code }
|
|
|
|
// These hooks are contracts for the runtime/migration tasks. This manager does
|
|
// not claim to drain processes, back up databases, or execute migrations.
|
|
type Drainer interface {
|
|
Drain(context.Context, string) error
|
|
}
|
|
type Backupper interface {
|
|
Backup(context.Context, string) error
|
|
}
|
|
type Migrator interface {
|
|
Migrate(context.Context, string, Generation) error
|
|
}
|
|
|
|
type Manager struct {
|
|
// One lock also serializes journal publication across addons. No operation can
|
|
// overtake another operation on the same addon, including reconciliation.
|
|
mu sync.Mutex
|
|
upgradeMu sync.Mutex
|
|
upgradeViews map[string]upgradeSnapshot
|
|
upgradeCtx context.Context
|
|
upgradeCancel context.CancelFunc
|
|
upgradeWG sync.WaitGroup
|
|
upgradeActive, upgradeClosing bool
|
|
// opMu serializes Submit and Reconcile as whole operations, so mu can be
|
|
// released around a slow fetch without letting another operation in.
|
|
opMu sync.Mutex
|
|
toolCache map[string]toolDeclaration
|
|
config OwnerConfig
|
|
catalog catalog.Catalog
|
|
installer *packages.Installer
|
|
admin catalog.AdminCheck
|
|
release func() error
|
|
closed, uncertain bool
|
|
journal journal
|
|
boundary func(string) error
|
|
runtimeRecoveryRequired bool
|
|
runtime *addonruntime.Supervisor
|
|
instances map[string]addonruntime.Instance
|
|
// startFailed holds the last start error of each enabled add-on whose
|
|
// process is not running. It is an observation, never durable intent: a
|
|
// restart tries again, and one add-on that cannot start never stops the
|
|
// owner or fails the commands of another add-on.
|
|
startFailed map[string]error
|
|
// canceled holds the upgrades whose request was canceled while the
|
|
// candidate started. The package is already published and the last good
|
|
// generation runs again; the same operation ID continues from here.
|
|
// In memory only: a restart marks the intent failed and starts the
|
|
// journaled generation.
|
|
canceled map[string]packages.PackageReceipt
|
|
// restoreTimeout bounds the work that puts the last good generation back
|
|
// and does not depend on the request. Zero means the default.
|
|
restoreTimeout time.Duration
|
|
// scanner reads the size of data directories outside mu.
|
|
scanner storageScanner
|
|
// recovery backs up, migrates and restores add-on data. Nil means plain
|
|
// upgrades only.
|
|
recovery *recovery.Recovery
|
|
// quiesced holds the add-ons that recovery keeps stopped, whatever the
|
|
// journal says. It is an observation, never durable intent.
|
|
quiesced map[string]bool
|
|
// updates is the owner's update check. Nil means no checks and no pinned
|
|
// upgrades.
|
|
updates *updates.Checker
|
|
// autoFailures holds, per add-on, the candidate digest of the last
|
|
// automatic upgrade that failed. In memory only: a restart tries again.
|
|
autoMu sync.Mutex
|
|
autoFailures map[string]string
|
|
// skillSync keeps the chats' skill layer in step with the installed
|
|
// packages. Nil until the chats' files exist (see SetSkillSync).
|
|
skillSync SkillSync
|
|
// hostOps is the host setting of the host operation prefixes of each
|
|
// add-on. The apps list reads it to decide which host controls it draws.
|
|
hostOps map[string][]string
|
|
hostOpsSet bool
|
|
}
|
|
|
|
// SetHostOps sets the host operation grants of the add-ons (the host setting,
|
|
// read at startup). The apps list draws a host control only for an add-on
|
|
// whose grants entitle it. The first call selects an immutable startup snapshot;
|
|
// subsequent calls do not reload policy. Call before attaching the runtime.
|
|
func (m *Manager) SetHostOps(ops map[string][]string) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if m.hostOpsSet {
|
|
return
|
|
}
|
|
m.hostOpsSet = true
|
|
m.hostOps = make(map[string][]string, len(ops))
|
|
for id, prefixes := range ops {
|
|
m.hostOps[id] = slices.Clone(prefixes)
|
|
}
|
|
}
|
|
|
|
// SkillSync copies the skills of an add-on package into the chats' skill layer
|
|
// (receipt set), or removes them (receipt nil). It runs on the owner only, which
|
|
// holds the verified package. A failure is logged and never fails the lifecycle
|
|
// operation: skills are help for a chat, the add-on works without them.
|
|
type SkillSync func(ctx context.Context, addonID string, receipt *packages.PackageReceipt) error
|
|
|
|
// SetSkillSync sets the skill copy and runs it once for every add-on the
|
|
// journal knows: the current package of an installed one, a removal for the
|
|
// others. It is how the owner reconciles the skill layer at start.
|
|
func (m *Manager) SetSkillSync(ctx context.Context, sync SkillSync) {
|
|
m.opMu.Lock()
|
|
defer m.opMu.Unlock()
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
m.skillSync = sync
|
|
if sync == nil || m.check(ctx) != nil {
|
|
return
|
|
}
|
|
ids := make([]string, 0, len(m.journal.Addons))
|
|
for id := range m.journal.Addons {
|
|
ids = append(ids, id)
|
|
}
|
|
sort.Strings(ids)
|
|
for _, id := range ids {
|
|
m.syncSkills(ctx, id)
|
|
}
|
|
}
|
|
|
|
// InstalledSkillIDs returns the installed add-ons whose current package ships
|
|
// skills, sorted.
|
|
func (m *Manager) InstalledSkillIDs(ctx context.Context) ([]string, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return nil, e
|
|
}
|
|
var out []string
|
|
for id, st := range m.journal.Addons {
|
|
if r, ok := currentReceipt(st); ok && st.Installed && len(r.Skills) > 0 {
|
|
out = append(out, id)
|
|
}
|
|
}
|
|
sort.Strings(out)
|
|
return out, nil
|
|
}
|
|
|
|
// syncSkills runs the skill copy for one add-on from the journal: its current
|
|
// package while installed, a removal otherwise. The caller holds mu.
|
|
func (m *Manager) syncSkills(ctx context.Context, id string) {
|
|
if m.skillSync == nil {
|
|
return
|
|
}
|
|
var receipt *packages.PackageReceipt
|
|
if st := m.journal.Addons[id]; st.Installed {
|
|
if r, ok := currentReceipt(st); ok {
|
|
receipt = &r
|
|
}
|
|
}
|
|
if e := m.skillSync(ctx, id, receipt); e != nil {
|
|
xlog.Warn("Could not copy the skills of an add-on", "addon", id, "error", e)
|
|
}
|
|
}
|
|
|
|
func NewManager(ctx context.Context, cfg OwnerConfig, c catalog.Catalog, i *packages.Installer, admin catalog.AdminCheck) (*Manager, error) {
|
|
if e := cfg.validate(); e != nil {
|
|
return nil, e
|
|
}
|
|
m := &Manager{config: cfg, catalog: c, installer: i, admin: admin, upgradeViews: map[string]upgradeSnapshot{}}
|
|
m.upgradeCtx, m.upgradeCancel = context.WithCancel(context.Background())
|
|
if cfg.InstanceID != cfg.OwnerID {
|
|
return m, nil
|
|
}
|
|
if i == nil || admin == nil || filepath.Clean(i.Root) != filepath.Join(cfg.Root, "packages") {
|
|
return nil, ErrConfiguration
|
|
}
|
|
release, e := (OwnerGuard{Config: cfg}).Acquire(ctx)
|
|
if e != nil {
|
|
return nil, e
|
|
}
|
|
m.release = release
|
|
if e = m.load(); e != nil {
|
|
_ = release()
|
|
return nil, e
|
|
}
|
|
m.refreshUpgradeViews()
|
|
return m, nil
|
|
}
|
|
func (m *Manager) Close() error {
|
|
m.upgradeMu.Lock()
|
|
m.upgradeClosing = true
|
|
m.upgradeCancel()
|
|
m.upgradeMu.Unlock()
|
|
m.upgradeWG.Wait()
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if m.closed && m.release == nil {
|
|
return nil
|
|
}
|
|
m.closed = true
|
|
if m.updates != nil {
|
|
// In-flight update checks end and are waited for before the owner
|
|
// lets go of its storage.
|
|
m.updates.Close()
|
|
}
|
|
if m.runtime != nil {
|
|
if e := m.runtime.Close(context.Background()); e != nil {
|
|
return e
|
|
}
|
|
}
|
|
if m.release != nil {
|
|
e := m.release()
|
|
if e == nil {
|
|
m.release = nil
|
|
}
|
|
return e
|
|
}
|
|
return nil
|
|
}
|
|
func (m *Manager) check(ctx context.Context) error {
|
|
if e := ctx.Err(); e != nil {
|
|
return e
|
|
}
|
|
if m.closed || m.release == nil {
|
|
return ErrNotOwner
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// addonID matches a well-formed add-on or source ID that no host route uses.
|
|
var addonID idMatcher
|
|
|
|
// sourceIDPattern matches a library ID, which is never a path segment of a route.
|
|
var sourceIDPattern = regexp.MustCompile(`^[a-z][a-z0-9-]{0,63}$`)
|
|
|
|
type idMatcher struct{}
|
|
|
|
func (idMatcher) MatchString(s string) bool { return contract.ValidAddonID(s) }
|
|
|
|
func (m *Manager) Status(ctx context.Context, id string) (Status, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return Status{}, e
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return Status{}, ErrRecoveryRequired
|
|
}
|
|
s := copyStatus(m.journal.Addons[id])
|
|
s.AddonID = id
|
|
s.ObservedHealth = "stopped"
|
|
s.StartEligible = s.Installed && s.DesiredEnabled
|
|
if m.admission(id) != nil {
|
|
s.StartEligible = false
|
|
s.ObservedHealth = "unavailable"
|
|
}
|
|
for _, op := range m.journal.Operations {
|
|
if op.Command.AddonID == id && op.Status.Phase != string(lifecycleCompleted) && op.Status.Phase != string(lifecycleFailed) {
|
|
s.StartEligible = false
|
|
}
|
|
}
|
|
if m.quiesced[id] || m.dataBlocked(id) {
|
|
s.StartEligible = false
|
|
}
|
|
if m.runtime != nil {
|
|
registrations, e := m.runtime.Registry.Snapshot(ctx)
|
|
if e != nil {
|
|
return Status{}, e
|
|
}
|
|
for _, r := range registrations {
|
|
if r.AddonID == id && r.Generation == s.Generation {
|
|
s.ObservedHealth = "ready"
|
|
}
|
|
}
|
|
}
|
|
return s, nil
|
|
}
|
|
func (m *Manager) Submit(ctx context.Context, actor contract.Actor, cmd LifecycleCommand) (OperationStatus, error) {
|
|
return m.submit(ctx, actor, cmd, false)
|
|
}
|
|
|
|
// submit is the one lifecycle path. The owner's automatic upgrade passes
|
|
// owner true: the owner acts on its own setting, so no administrator is asked.
|
|
// Everything after that gate is shared with the manual upgrade.
|
|
func (m *Manager) submit(ctx context.Context, actor contract.Actor, cmd LifecycleCommand, owner bool) (OperationStatus, error) {
|
|
m.opMu.Lock()
|
|
defer m.opMu.Unlock()
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return OperationStatus{}, e
|
|
}
|
|
if !owner && (m.admin == nil || m.admin(ctx, actor) != nil) {
|
|
return OperationStatus{}, ErrForbidden
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return OperationStatus{}, ErrRecoveryRequired
|
|
}
|
|
var op journalOperation
|
|
resumed := false
|
|
accepted := false
|
|
if !addonID.MatchString(cmd.AddonID) || cmd.OperationID == "" || len(cmd.OperationID) > 256 {
|
|
return OperationStatus{}, ErrConflict
|
|
}
|
|
if old, ok := m.journal.Operations[cmd.OperationID]; ok {
|
|
if old.Command != cmd || old.Actor != actor {
|
|
return OperationStatus{}, ErrConflict
|
|
}
|
|
if old.Async && old.Status.Phase == string(lifecycleAccepted) {
|
|
if ctx.Value(upgradeExecutionKey{}) != m {
|
|
return old.Status, ErrRecoveryRequired
|
|
}
|
|
accepted = true
|
|
op = old
|
|
} else if old.Status.Phase == string(lifecycleFailed) {
|
|
// The answer stays the failure, but the add-on must not stay
|
|
// down because the failing attempt could not put it back.
|
|
if e := m.syncRuntime(ctx, cmd.AddonID); e != nil {
|
|
return old.Status, e
|
|
}
|
|
return old.Status, ErrOperationFailed
|
|
}
|
|
if accepted {
|
|
// Accepted work continues exactly once under the owner worker.
|
|
} else if _, again := m.canceled[cmd.OperationID]; again && old.Status.Phase == string(lifecycleIntent) {
|
|
resumed = true
|
|
op = old
|
|
} else {
|
|
if old.Status.Phase != string(lifecycleCompleted) {
|
|
return old.Status, ErrRecoveryRequired
|
|
}
|
|
return old.Status, m.syncFor(ctx, cmd.AddonID)
|
|
}
|
|
}
|
|
pinned := cmd.ExpectedDigest != "" || cmd.CandidateDigest != ""
|
|
if pinned && (cmd.Action != "upgrade" || cmd.ExpectedDigest == "" || cmd.CandidateDigest == "") {
|
|
return OperationStatus{}, ErrConflict
|
|
}
|
|
if pinned && !resumed && !accepted {
|
|
// The same transition under another operation ID is a duplicate,
|
|
// whether the first one is in flight or done. Only a failed attempt
|
|
// leaves the transition open for a new one.
|
|
for id, other := range m.journal.Operations {
|
|
c := other.Command
|
|
if id != cmd.OperationID && c.Action == "upgrade" && c.AddonID == cmd.AddonID && c.ExpectedDigest == cmd.ExpectedDigest && c.CandidateDigest == cmd.CandidateDigest && other.Status.Phase != string(lifecycleFailed) {
|
|
return OperationStatus{}, ErrTransitionConflict
|
|
}
|
|
}
|
|
}
|
|
if !resumed && !accepted {
|
|
for _, other := range m.journal.Operations {
|
|
if other.Command.AddonID == cmd.AddonID && other.Status.Phase != string(lifecycleCompleted) && other.Status.Phase != string(lifecycleFailed) {
|
|
return OperationStatus{}, ErrRecoveryRequired
|
|
}
|
|
}
|
|
}
|
|
next := copyStatus(m.journal.Addons[cmd.AddonID])
|
|
// release is the candidate an explicit upgrade resolved at execution.
|
|
var release *catalog.Release
|
|
switch cmd.Action {
|
|
case "install":
|
|
if next.Installed && !resumed {
|
|
return OperationStatus{}, ErrConflict
|
|
}
|
|
// Set once, here: the default provider of a shadowed tool or skill is
|
|
// the oldest install, so an upgrade must not move it.
|
|
if next.InstalledAt == "" || !next.Installed {
|
|
next.InstalledAt = time.Now().UTC().Format(time.RFC3339)
|
|
}
|
|
case "upgrade", "enable", "disable", "uninstall":
|
|
if !next.Installed {
|
|
return OperationStatus{}, ErrConflict
|
|
}
|
|
// A caller that names the generation it saw must not change a newer
|
|
// one. This precedes the intent record, so a stale request leaves
|
|
// nothing behind and cannot block the addon.
|
|
if (cmd.Action == "enable" || cmd.Action == "disable") && cmd.Generation != 0 && cmd.Generation != next.Generation {
|
|
return OperationStatus{}, ErrStaleGeneration
|
|
}
|
|
if pinned && !resumed {
|
|
r, e := m.checkPins(ctx, cmd, next)
|
|
if e != nil {
|
|
return OperationStatus{}, e
|
|
}
|
|
release = &r
|
|
}
|
|
default:
|
|
return OperationStatus{}, ErrConflict
|
|
}
|
|
if accepted {
|
|
phase, _ := upgradeTransition(lifecyclePhase(op.Status.Phase), upgradeStart)
|
|
op.Status.Phase = string(phase)
|
|
m.journal.Operations[cmd.OperationID] = op
|
|
if e := m.persist(string(lifecycleRunning)); e != nil {
|
|
return op.Status, e
|
|
}
|
|
} else if !resumed {
|
|
op = journalOperation{Command: cmd, Actor: actor, Status: OperationStatus{OperationID: cmd.OperationID, AddonID: cmd.AddonID, Phase: string(lifecycleIntent)}}
|
|
m.journal.Operations[cmd.OperationID] = op
|
|
if e := m.persist(string(lifecycleIntent)); e != nil {
|
|
return op.Status, e
|
|
}
|
|
}
|
|
// fail ends the operation. A cause that is an SDK refusal keeps its text for
|
|
// the administrator, and so does a package that failed verification; the
|
|
// returned error still matches ErrOperationFailed.
|
|
fail := func(cause ...error) (OperationStatus, error) {
|
|
// The client gets a typed cause or the generic error; the operator
|
|
// gets the underlying error here, which would otherwise be lost.
|
|
xlog.Warn("Addon operation failed", "action", cmd.Action, "addonId", cmd.AddonID, "operationId", cmd.OperationID, "causes", describeCauses(cause))
|
|
op.Status.Stage = m.journal.Operations[cmd.OperationID].Status.Stage
|
|
op.Status.Phase = string(lifecycleFailed)
|
|
op.Status.FailureCode = "upgrade_failed"
|
|
for _, c := range cause {
|
|
if errors.Is(c, context.Canceled) || errors.Is(c, context.DeadlineExceeded) {
|
|
op.Status.FailureCode = "interrupted"
|
|
}
|
|
if errors.Is(c, recovery.ErrNeedsRecovery) {
|
|
op.Status.FailureCode = "recovery_required"
|
|
}
|
|
}
|
|
m.journal.Operations[cmd.OperationID] = op
|
|
if e := m.persist(string(lifecycleFailed)); e != nil {
|
|
return op.Status, e
|
|
}
|
|
for _, c := range cause {
|
|
var refusal *contract.SDKRefusal
|
|
if errors.As(c, &refusal) {
|
|
return op.Status, fmt.Errorf("%w: %w", ErrOperationFailed, refusal)
|
|
}
|
|
if errors.Is(c, packages.ErrPackage) {
|
|
// The package is not what its library entry says. The text of
|
|
// ErrPackage is fixed, so it is safe to show.
|
|
return op.Status, fmt.Errorf("%w: %w", ErrOperationFailed, packages.ErrPackage)
|
|
}
|
|
var admission *HostRequirementsRefusal
|
|
if errors.As(c, &admission) {
|
|
return op.Status, fmt.Errorf("%w: %w", ErrOperationFailed, admission)
|
|
}
|
|
var typed *FailureCause
|
|
if errors.As(c, &typed) {
|
|
return op.Status, fmt.Errorf("%w: %w", ErrOperationFailed, typed)
|
|
}
|
|
}
|
|
return op.Status, ErrOperationFailed
|
|
}
|
|
if next.Identity == "" {
|
|
next.AddonID = cmd.AddonID
|
|
next.Identity = m.config.StorageID + ":" + cmd.AddonID
|
|
next.DataDirectory = filepath.Join(m.config.Root, "data", cmd.AddonID)
|
|
next.GrantsPath = filepath.Join(m.config.Root, "metadata", cmd.AddonID, "grants.json")
|
|
}
|
|
switch cmd.Action {
|
|
case "install", "upgrade":
|
|
receipt, published := m.canceled[cmd.OperationID]
|
|
delete(m.canceled, cmd.OperationID)
|
|
if !published {
|
|
// Resolving a release and staging a package fetch and verify over
|
|
// the network and the disk. They touch neither the journal nor
|
|
// the runtime, so the state lock is released: reads stay
|
|
// available, and opMu keeps every other operation out.
|
|
var r catalog.Release
|
|
var resolveErr error
|
|
if e := m.upgradeStage(cmd.OperationID, "preparing-package"); e != nil {
|
|
return op.Status, e
|
|
}
|
|
m.mu.Unlock()
|
|
if release != nil {
|
|
r = *release
|
|
} else {
|
|
r, resolveErr = m.resolveRelease(ctx, cmd)
|
|
}
|
|
var staged packages.StagedPackage
|
|
var stageErr error
|
|
if resolveErr == nil {
|
|
staged, stageErr = m.installer.Stage(ctx, r, nil)
|
|
}
|
|
m.mu.Lock()
|
|
if resolveErr != nil {
|
|
return fail(resolveErr, &FailureCause{Code: resolveCauseCode(resolveErr), detail: resolveErr})
|
|
}
|
|
if stageErr != nil {
|
|
return fail(stageErr, &FailureCause{Code: CausePackageFetch, detail: stageErr})
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return op.Status, ErrRecoveryRequired
|
|
}
|
|
if e := m.admit(staged.Receipt()); e != nil {
|
|
op.Status.HostOperations = summaryPointer(m.requests(staged.Receipt()))
|
|
if discardErr := m.installer.Discard(staged); discardErr != nil {
|
|
xlog.Warn("Could not discard refused addon stage", "addon", cmd.AddonID, "error", discardErr)
|
|
}
|
|
return fail(e)
|
|
}
|
|
op.Status.HostOperations = summaryPointer(m.requests(staged.Receipt()))
|
|
var e error
|
|
if release != nil {
|
|
// An explicit upgrade never changes the trusted identity,
|
|
// the library or the channel, whatever the add-on holds.
|
|
if last, ok := lastReceipt(m.journal.Addons[cmd.AddonID]); !ok || recovery.CheckCompatible(last, staged.Receipt()) != nil || staged.Receipt().Digest != cmd.CandidateDigest {
|
|
return fail()
|
|
}
|
|
}
|
|
if m.recovery != nil && m.recovery.HasData(cmd.AddonID) {
|
|
// Retained data is only handed to the same trusted identity
|
|
// and never to an older data format: this holds for an
|
|
// upgrade and for a reinstall alike.
|
|
if last, ok := lastReceipt(m.journal.Addons[cmd.AddonID]); ok && recovery.CheckCompatible(last, staged.Receipt()) != nil {
|
|
return fail()
|
|
}
|
|
if cmd.Action != "upgrade" {
|
|
// A reinstall has no running generation to back up, and
|
|
// the candidate would migrate the retained data when it
|
|
// starts. Only an upgrade takes a verified backup first.
|
|
if last, ok := lastReceipt(m.journal.Addons[cmd.AddonID]); ok && recovery.FormatChanged(last, staged.Receipt()) {
|
|
return fail()
|
|
}
|
|
}
|
|
if cmd.Action == "upgrade" {
|
|
return m.upgradeWithRecovery(ctx, cmd, op, &next, staged, fail)
|
|
}
|
|
}
|
|
if e = m.upgradeStage(cmd.OperationID, "committing-package"); e != nil {
|
|
return op.Status, e
|
|
}
|
|
receipt, e = m.installer.Commit(ctx, staged)
|
|
if e != nil {
|
|
return fail(&FailureCause{Code: CauseInstallStorage, detail: fmt.Errorf("commit: %w", e)})
|
|
}
|
|
// Installer publication alone is not a power-loss durability promise. Flush
|
|
// every immutable file and directory before journaling its generation.
|
|
if e = syncPackage(receipt.Directory); e != nil {
|
|
return fail(&FailureCause{Code: CauseInstallStorage, detail: fmt.Errorf("sync package: %w", e)})
|
|
}
|
|
if m.boundary != nil {
|
|
if e = m.boundary("published"); e != nil {
|
|
m.uncertain = true
|
|
return op.Status, e
|
|
}
|
|
}
|
|
}
|
|
next.Generation++
|
|
next.Generations = append(next.Generations, Generation{Number: next.Generation, Receipt: receipt})
|
|
next.Installed = true
|
|
// A new generation of a running add-on must prove it can start before
|
|
// it replaces the last good one in the journal. When it cannot, the
|
|
// last good generation runs again and the operation fails.
|
|
if cmd.Action == "upgrade" {
|
|
if e := m.startCandidate(ctx, cmd.AddonID, m.journal.Addons[cmd.AddonID], receipt, next.Generation); e != nil {
|
|
if ctx.Err() != nil {
|
|
// The caller went away, which says nothing about the
|
|
// candidate. Keep the operation open so the same ID
|
|
// can continue; the last good generation is running.
|
|
if m.canceled == nil {
|
|
m.canceled = map[string]packages.PackageReceipt{}
|
|
}
|
|
m.canceled[cmd.OperationID] = receipt
|
|
return op.Status, e
|
|
}
|
|
return fail()
|
|
}
|
|
}
|
|
case "enable":
|
|
if e := m.admission(cmd.AddonID); e != nil {
|
|
return fail(e)
|
|
}
|
|
// Data that needs recovery is not served: it is restored or purged first.
|
|
if m.dataBlocked(cmd.AddonID) {
|
|
return fail()
|
|
}
|
|
next.DesiredEnabled = true
|
|
case "disable":
|
|
next.DesiredEnabled = false
|
|
case "uninstall":
|
|
next.Installed = false
|
|
next.DesiredEnabled = false
|
|
}
|
|
if e := os.MkdirAll(filepath.Dir(next.GrantsPath), 0700); e != nil {
|
|
return fail(&FailureCause{Code: CauseInstallStorage, detail: fmt.Errorf("create the grants folder: %w", e)})
|
|
}
|
|
op.Next = &next
|
|
op.Status.Generation = next.Generation
|
|
op.Status.Phase = string(lifecyclePrepared)
|
|
m.journal.Operations[cmd.OperationID] = op
|
|
if e := m.persist(string(lifecyclePrepared)); e != nil {
|
|
return op.Status, e
|
|
}
|
|
result, e := m.apply(op)
|
|
if e != nil {
|
|
if m.runtime != nil {
|
|
m.runtimeRecoveryRequired = true
|
|
_ = m.runtime.Close(context.Background())
|
|
}
|
|
return result, e
|
|
}
|
|
switch cmd.Action {
|
|
case "install", "upgrade", "uninstall":
|
|
m.syncSkills(ctx, cmd.AddonID)
|
|
}
|
|
return result, m.syncFor(ctx, cmd.AddonID)
|
|
}
|
|
|
|
// describeCauses is the text of the errors a failed operation had, for the log.
|
|
func describeCauses(causes []error) string {
|
|
var parts []string
|
|
for _, c := range causes {
|
|
var typed *FailureCause
|
|
if errors.As(c, &typed) && typed.detail != nil {
|
|
parts = append(parts, typed.Code+": "+typed.detail.Error())
|
|
} else if c != nil {
|
|
parts = append(parts, c.Error())
|
|
}
|
|
}
|
|
if len(parts) == 0 {
|
|
return "no cause recorded (a check refused the operation)"
|
|
}
|
|
return strings.Join(parts, "; ")
|
|
}
|
|
|
|
// resolveCauseCode is the cause code of a release that could not be resolved.
|
|
func resolveCauseCode(e error) string {
|
|
switch {
|
|
case errors.Is(e, catalog.ErrNotFound):
|
|
return CauseReleaseNotFound
|
|
case errors.Is(e, catalog.ErrConflict), errors.Is(e, catalog.ErrShadowed):
|
|
return CauseLibraryConflict
|
|
}
|
|
return CauseLibraryUnavailable
|
|
}
|
|
|
|
// resolveRelease finds the release a command names. The library cache is
|
|
// filled by a refresh at startup, which runs in the background and can fail
|
|
// once (a slow start, a library that is not up yet) and leave the cache empty
|
|
// until someone refreshes. An install must not depend on that: when the cache
|
|
// has nothing for the library, read the library once now and look again.
|
|
func (m *Manager) resolveRelease(ctx context.Context, cmd LifecycleCommand) (catalog.Release, error) {
|
|
r, e := m.catalog.Resolve(ctx, cmd.SourceID, cmd.AddonID, cmd.Version)
|
|
if e == nil || !(errors.Is(e, catalog.ErrUnavailable) || errors.Is(e, catalog.ErrRefresh)) || m.catalog.Sources == nil {
|
|
return r, e
|
|
}
|
|
if _, rerr := m.catalog.Sources.Refresh(ctx, cmd.SourceID); rerr != nil {
|
|
return catalog.Release{}, fmt.Errorf("%w (library read on demand: %w)", e, rerr)
|
|
}
|
|
return m.catalog.Resolve(ctx, cmd.SourceID, cmd.AddonID, cmd.Version)
|
|
}
|
|
|
|
func (m *Manager) apply(op journalOperation) (OperationStatus, error) {
|
|
m.journal.Addons[op.Command.AddonID] = copyStatus(*op.Next)
|
|
op.Status.Phase = string(lifecycleApplied)
|
|
m.journal.Operations[op.Command.OperationID] = op
|
|
if e := m.persist(string(lifecycleApplied)); e != nil {
|
|
return op.Status, e
|
|
}
|
|
op.Status.Phase = string(lifecycleCompleted)
|
|
op.Next = nil
|
|
m.journal.Operations[op.Command.OperationID] = op
|
|
return op.Status, m.persist(string(lifecycleCompleted))
|
|
}
|
|
func (m *Manager) Reconcile(ctx context.Context) error {
|
|
m.opMu.Lock()
|
|
defer m.opMu.Unlock()
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return e
|
|
}
|
|
// A supervisor closed after an uncertain publication cannot be reused.
|
|
// Keep ownership fenced until Close succeeds and a new manager reconciles.
|
|
if m.runtimeRecoveryRequired {
|
|
return ErrRecoveryRequired
|
|
}
|
|
if e := m.load(); e != nil {
|
|
return e
|
|
}
|
|
m.uncertain = false
|
|
if e := m.cleanStages(); e != nil {
|
|
return e
|
|
}
|
|
for id, op := range m.journal.Operations {
|
|
if e := ctx.Err(); e != nil {
|
|
return e
|
|
}
|
|
switch lifecyclePhase(op.Status.Phase) {
|
|
case lifecycleAccepted, lifecycleRunning, lifecycleIntent:
|
|
op.Status.Phase = string(lifecycleFailed)
|
|
op.Status.FailureCode = "interrupted"
|
|
m.journal.Operations[id] = op
|
|
if e := m.persist(string(lifecycleFailed)); e != nil {
|
|
return e
|
|
}
|
|
case lifecyclePrepared, lifecycleApplied:
|
|
if op.Next == nil {
|
|
return ErrConfiguration
|
|
}
|
|
if _, e := m.apply(op); e != nil {
|
|
return e
|
|
}
|
|
case lifecycleCompleted, lifecycleFailed:
|
|
default:
|
|
return ErrConfiguration
|
|
}
|
|
}
|
|
m.reconcileData(ctx)
|
|
for id, op := range m.journal.Operations {
|
|
if op.Async && op.Status.Phase == string(lifecycleFailed) && m.dataBlocked(op.Command.AddonID) {
|
|
op.Status.FailureCode = "recovery_required"
|
|
m.journal.Operations[id] = op
|
|
}
|
|
}
|
|
if e := m.persist("reconciled"); e != nil {
|
|
return e
|
|
}
|
|
return m.syncRuntime(ctx, "")
|
|
}
|
|
func syncPackage(root string) error {
|
|
var dirs []string
|
|
e := filepath.Walk(root, func(path string, info os.FileInfo, e error) error {
|
|
if e != nil {
|
|
return e
|
|
}
|
|
if info.IsDir() {
|
|
dirs = append(dirs, path)
|
|
return nil
|
|
}
|
|
f, e := os.Open(path) // #nosec G122,G304 -- the tree is owned by this process and locked; the walk only normalises its own files
|
|
if e != nil {
|
|
return e
|
|
}
|
|
e = f.Sync()
|
|
return errors.Join(e, f.Close())
|
|
})
|
|
if e != nil {
|
|
return e
|
|
}
|
|
dirs = append([]string{filepath.Dir(root)}, dirs...)
|
|
for n := len(dirs) - 1; n >= 0; n-- {
|
|
f, e := os.Open(dirs[n])
|
|
if e != nil {
|
|
return e
|
|
}
|
|
e = f.Sync()
|
|
e = errors.Join(e, f.Close())
|
|
if e != nil {
|
|
return e
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Only unpublished Installer staging is collectible. An unreferenced published
|
|
// package may be the result of a crash before prepared; retain it for inspection.
|
|
func (m *Manager) cleanStages() error {
|
|
root, e := openPackageRoot(m.installer.Root)
|
|
if os.IsNotExist(e) {
|
|
return nil
|
|
}
|
|
if e != nil {
|
|
return e
|
|
}
|
|
defer func() { _ = root.Close() }()
|
|
entries, e := fs.ReadDir(root.FS(), ".")
|
|
if e != nil {
|
|
return e
|
|
}
|
|
for _, entry := range entries {
|
|
if !strings.HasPrefix(entry.Name(), "stage-") {
|
|
continue
|
|
}
|
|
if e = fs.WalkDir(root.FS(), entry.Name(), func(path string, d fs.DirEntry, err error) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !d.IsDir() {
|
|
return nil
|
|
}
|
|
// Descriptor chmod avoids following a link swapped in after WalkDir.
|
|
f, err := root.OpenFile(path, os.O_RDONLY|syscall.O_NOFOLLOW|syscall.O_DIRECTORY, 0)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return errors.Join(f.Chmod(0700), f.Close()) // #nosec G122 -- the tree is owned by this process and locked; the walk only normalises its own files
|
|
}); e != nil {
|
|
return e
|
|
}
|
|
if e = root.RemoveAll(entry.Name()); e != nil {
|
|
return e
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Pin each ancestor and reject links, including the package root, before any
|
|
// enumeration or mutation. Root operations keep later path races contained.
|
|
func openPackageRoot(path string) (*os.Root, error) {
|
|
root, err := os.OpenRoot(string(filepath.Separator))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
for _, part := range strings.Split(strings.TrimPrefix(filepath.Clean(path), string(filepath.Separator)), string(filepath.Separator)) {
|
|
info, e := root.Lstat(part)
|
|
if e != nil {
|
|
_ = root.Close()
|
|
return nil, e
|
|
}
|
|
if !info.IsDir() {
|
|
_ = root.Close()
|
|
return nil, ErrConfiguration
|
|
}
|
|
next, e := root.OpenRoot(part)
|
|
_ = root.Close()
|
|
if e != nil {
|
|
return nil, e
|
|
}
|
|
pinned, e := next.Stat(".")
|
|
if e != nil || !os.SameFile(info, pinned) {
|
|
_ = next.Close()
|
|
return nil, ErrConfiguration
|
|
}
|
|
root = next
|
|
}
|
|
return root, nil
|
|
}
|
|
|
|
// AttachRuntime is owner-only. Durable reconciliation precedes process execution.
|
|
func (m *Manager) AttachRuntime(ctx context.Context, s *addonruntime.Supervisor) error {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return e
|
|
}
|
|
if m.uncertain || m.runtime != nil || s == nil {
|
|
return ErrConflict
|
|
}
|
|
m.hostOpsSet = true // An omitted startup policy is an immutable empty grant set.
|
|
m.runtime = s
|
|
m.instances = map[string]addonruntime.Instance{}
|
|
m.startFailed = map[string]error{}
|
|
m.reconcileData(ctx)
|
|
return m.syncRuntime(ctx, "")
|
|
}
|
|
|
|
// syncFor synchronizes the runtime and reports the start failure of the one
|
|
// add-on a command is about. The other add-ons keep their own state.
|
|
func (m *Manager) syncFor(ctx context.Context, id string) error {
|
|
if e := m.syncRuntime(ctx, id); e != nil {
|
|
return e
|
|
}
|
|
return m.startFailed[id]
|
|
}
|
|
|
|
// startCandidate stops the running generation of an enabled add-on and starts
|
|
// the one that an upgrade published. If the candidate does not become ready,
|
|
// the previous generation is started again, so a failed upgrade never leaves
|
|
// the add-on stopped on a generation that never ran. Without a running
|
|
// instance there is nothing to replace and nothing to prove here.
|
|
func (m *Manager) startCandidate(ctx context.Context, id string, prev Status, receipt packages.PackageReceipt, number uint64) error {
|
|
if e := m.admit(receipt); e != nil {
|
|
return e
|
|
}
|
|
if m.runtime == nil || !prev.Installed || !prev.DesiredEnabled {
|
|
return nil
|
|
}
|
|
instance, running := m.instances[id]
|
|
if !running || instance.Generation != prev.Generation {
|
|
return nil
|
|
}
|
|
// Stopping and restoring belong to the owner, not to the request: a
|
|
// cancellation must not leave the last good generation stopped, and the
|
|
// old and the new process never run at once.
|
|
detached, release := m.detached(ctx)
|
|
defer release()
|
|
if e := m.runtime.Stop(detached, instance); e != nil {
|
|
return e
|
|
}
|
|
delete(m.instances, id)
|
|
started, e := m.runtime.Start(ctx, receipt, number)
|
|
if e == nil {
|
|
m.instances[id] = started
|
|
delete(m.startFailed, id)
|
|
return nil
|
|
}
|
|
for _, g := range prev.Generations {
|
|
if g.Number != prev.Generation {
|
|
continue
|
|
}
|
|
back, be := m.runtime.Start(detached, g.Receipt, g.Number)
|
|
if be == nil {
|
|
m.instances[id] = back
|
|
delete(m.startFailed, id)
|
|
continue
|
|
}
|
|
// Recorded so that the next command on this add-on, with any
|
|
// operation ID, tries the journaled generation again.
|
|
m.startFailed[id] = be
|
|
}
|
|
return e
|
|
}
|
|
|
|
// detached returns a bounded context that a canceled request cannot cancel.
|
|
func (m *Manager) detached(ctx context.Context) (context.Context, context.CancelFunc) {
|
|
d := m.restoreTimeout
|
|
if d <= 0 {
|
|
d = 2 * time.Minute
|
|
}
|
|
return context.WithTimeout(context.WithoutCancel(ctx), d)
|
|
}
|
|
|
|
// syncRuntime makes the running processes match the journal. A start failure
|
|
// is recorded per add-on and does not fail the call: only the add-on named by
|
|
// target is tried again when it already failed, so an unrelated command never
|
|
// waits for a broken add-on. A cancelled context and a failure to stop a
|
|
// process are returned.
|
|
func (m *Manager) syncRuntime(ctx context.Context, target string) error {
|
|
if m.runtimeRecoveryRequired {
|
|
return ErrRecoveryRequired
|
|
}
|
|
if m.runtime == nil {
|
|
return nil
|
|
}
|
|
for id, instance := range m.instances {
|
|
if m.quiesced[id] {
|
|
continue
|
|
}
|
|
state := m.journal.Addons[id]
|
|
if !state.Installed || !state.DesiredEnabled || state.Generation != instance.Generation {
|
|
if e := m.runtime.Stop(ctx, instance); e != nil {
|
|
return e
|
|
}
|
|
delete(m.instances, id)
|
|
}
|
|
}
|
|
type launch struct {
|
|
id string
|
|
generation Generation
|
|
instance addonruntime.Instance
|
|
err error
|
|
}
|
|
var launches []*launch
|
|
for id, state := range m.journal.Addons {
|
|
if !state.Installed || !state.DesiredEnabled {
|
|
delete(m.startFailed, id)
|
|
continue
|
|
}
|
|
if _, ok := m.instances[id]; ok {
|
|
continue
|
|
}
|
|
if _, failed := m.startFailed[id]; failed && id != target {
|
|
continue
|
|
}
|
|
if e := m.admission(id); e != nil {
|
|
m.startFailed[id] = e
|
|
continue
|
|
}
|
|
if m.quiesced[id] || m.dataBlocked(id) {
|
|
continue
|
|
}
|
|
for _, generation := range state.Generations {
|
|
if generation.Number == state.Generation {
|
|
launches = append(launches, &launch{id: id, generation: generation})
|
|
break
|
|
}
|
|
}
|
|
}
|
|
// Each add-on is a separate process that takes seconds to be ready, so
|
|
// they start side by side. The bound keeps a host with many add-ons from
|
|
// forking them all at once. The results are applied below, in the order of
|
|
// the journal, by this goroutine alone: the workers touch nothing of the
|
|
// manager.
|
|
slices.SortFunc(launches, func(a, b *launch) int { return strings.Compare(a.id, b.id) })
|
|
slots := make(chan struct{}, startConcurrency)
|
|
var wg sync.WaitGroup
|
|
for _, l := range launches {
|
|
wg.Add(1)
|
|
slots <- struct{}{}
|
|
go func() {
|
|
defer func() { <-slots; wg.Done() }()
|
|
l.instance, l.err = m.runtime.Start(ctx, l.generation.Receipt, l.generation.Number)
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
var cancelled error
|
|
for _, l := range launches {
|
|
if l.err != nil {
|
|
if ctx.Err() != nil {
|
|
cancelled = l.err
|
|
continue
|
|
}
|
|
m.startFailed[l.id] = l.err
|
|
continue
|
|
}
|
|
delete(m.startFailed, l.id)
|
|
m.instances[l.id] = l.instance
|
|
}
|
|
return cancelled
|
|
}
|
|
|
|
// startConcurrency bounds how many add-on processes start at the same time.
|
|
const startConcurrency = 4
|
|
|
|
// Runtime returns the current ready incarnation, not the lifecycle stop handle
|
|
// retained in instances. Authorization and operation replay decisions remain the
|
|
// caller's responsibility; this accessor never dispatches or retries an operation.
|
|
func (m *Manager) Runtime(ctx context.Context, id string) (addonruntime.Instance, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return addonruntime.Instance{}, e
|
|
}
|
|
state := m.journal.Addons[id]
|
|
if m.admission(id) != nil {
|
|
return addonruntime.Instance{}, addonruntime.ErrRuntime
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired || m.runtime == nil || !state.Installed || !state.DesiredEnabled {
|
|
return addonruntime.Instance{}, addonruntime.ErrRuntime
|
|
}
|
|
return m.runtime.Current(ctx, id, state.Generation)
|
|
}
|
|
|
|
// ConnectorKind is a kind of connector binding that a running add-on serves.
|
|
type ConnectorKind struct {
|
|
AddonID string
|
|
contract.ConnectorKind
|
|
}
|
|
|
|
// ConnectorKinds lists the connector kinds of the add-ons that run now. An
|
|
// add-on that is installed but not ready serves none, and a process that does
|
|
// not own the runtime serves none.
|
|
func (m *Manager) ConnectorKinds(ctx context.Context) ([]ConnectorKind, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return nil, e
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired || m.runtime == nil {
|
|
return nil, addonruntime.ErrRuntime
|
|
}
|
|
registrations, e := m.runtime.Registry.Snapshot(ctx)
|
|
if e != nil {
|
|
return nil, e
|
|
}
|
|
var out []ConnectorKind
|
|
for _, r := range registrations {
|
|
if r.Capabilities.Connector == nil {
|
|
continue
|
|
}
|
|
for _, k := range r.Capabilities.Connector.Kinds {
|
|
out = append(out, ConnectorKind{AddonID: r.AddonID, ConnectorKind: k})
|
|
}
|
|
}
|
|
sort.Slice(out, func(i, j int) bool { return out[i].AddonID+"/"+out[i].ID < out[j].AddonID+"/"+out[j].ID })
|
|
return out, nil
|
|
}
|
|
|
|
// Connector calls the connector route of a running add-on.
|
|
func (m *Manager) Connector(ctx context.Context, addonID string, req contract.ConnectorRequest) (contract.ConnectorResponse, error) {
|
|
instance, e := m.Runtime(ctx, addonID)
|
|
if e != nil {
|
|
return contract.ConnectorResponse{}, e
|
|
}
|
|
cr, ok := instance.Client.(contract.ConnectorRuntime)
|
|
if !ok {
|
|
return contract.ConnectorResponse{}, addonruntime.ErrRuntime
|
|
}
|
|
return cr.Connector(ctx, req)
|
|
}
|
|
|
|
// OperationStatus only observes lifecycle intent. It never resumes a command or
|
|
// infers runtime completion from a completed journal publication.
|
|
func (m *Manager) OperationStatus(ctx context.Context, actor contract.Actor, id string) (OperationStatus, error) {
|
|
m.upgradeMu.Lock()
|
|
view, found := m.upgradeViews[id]
|
|
closing := m.upgradeClosing
|
|
m.upgradeMu.Unlock()
|
|
if found {
|
|
if closing {
|
|
return OperationStatus{}, ErrNotOwner
|
|
}
|
|
if m.admin == nil || m.admin(ctx, actor) != nil {
|
|
return OperationStatus{}, ErrForbidden
|
|
}
|
|
if view.Actor != actor {
|
|
return OperationStatus{}, ErrOperationNotFound
|
|
}
|
|
if err := ctx.Err(); err != nil {
|
|
return OperationStatus{}, err
|
|
}
|
|
return view.Status, nil
|
|
}
|
|
// A slow lifecycle publication must not strand disconnected status readers.
|
|
for !m.mu.TryLock() {
|
|
timer := time.NewTimer(10 * time.Millisecond)
|
|
select {
|
|
case <-ctx.Done():
|
|
timer.Stop()
|
|
return OperationStatus{}, ctx.Err()
|
|
case <-timer.C:
|
|
}
|
|
}
|
|
defer m.mu.Unlock()
|
|
if err := m.check(ctx); err != nil {
|
|
return OperationStatus{}, err
|
|
}
|
|
if m.admin == nil || m.admin(ctx, actor) != nil {
|
|
return OperationStatus{}, ErrForbidden
|
|
}
|
|
op, ok := m.journal.Operations[id]
|
|
if !ok || op.Actor.UserID == "" || op.Actor.CredentialID == "" || (op.Actor.Mode != "named-user" && op.Actor.Mode != "local-owner") || op.Actor != actor {
|
|
return OperationStatus{}, ErrOperationNotFound
|
|
}
|
|
result := OperationStatus{OperationID: id, AddonID: op.Status.AddonID, Phase: op.Status.Phase, Generation: op.Status.Generation, RuntimeState: "not-observed", HostOperations: copyRequestSummary(op.Status.HostOperations)}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
result.RuntimeState = string(lifecycleRecovery)
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
var ErrOperationNotFound = errors.New("addon lifecycle operation not found")
|
|
|
|
// Apps returns the apps the actor may see. The owner decides who is an
|
|
// administrator from its own check, never from the request; a check that
|
|
// cannot answer yields the reader's view, which has fewer rights.
|
|
//
|
|
// Visibility in version one: an addon that is installed and desired-enabled is
|
|
// visible to every authenticated caller who holds the addons feature, which
|
|
// the gateway checks first. No per-addon ACL exists; data access stays under
|
|
// per-resource ACLs on every call. An administrator also sees installed addons
|
|
// that are disabled, so a stopped addon can be started.
|
|
func (m *Manager) Apps(ctx context.Context, actor contract.Actor) ([]apps.App, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return nil, e
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return nil, ErrRecoveryRequired
|
|
}
|
|
isAdmin := m.admin != nil && m.admin(ctx, actor) == nil
|
|
snaps := make([]apps.Snapshot, 0, len(m.journal.Addons))
|
|
for id, st := range m.journal.Addons {
|
|
receipt, ok := currentReceipt(st)
|
|
if !ok {
|
|
continue
|
|
}
|
|
snap := apps.Snapshot{AddonID: id, InstalledAt: st.InstalledAt, Installed: st.Installed, Enabled: st.DesiredEnabled, Generation: st.Generation, State: addonruntime.StateStopped, Receipt: receipt, HostOps: m.hostOps[id]}
|
|
if st.DesiredEnabled && m.runtime != nil {
|
|
snap.State = m.runtime.State(id, st.Generation)
|
|
}
|
|
summary := m.requests(receipt)
|
|
snap.HostOperations = summaryPointer(summary)
|
|
if len(summary.MissingRequired) != 0 {
|
|
snap.Unavailable = true
|
|
snap.State = "failed"
|
|
}
|
|
// The apps list answers from the check cache only: it never
|
|
// evaluates and never reaches a library.
|
|
if m.updates != nil {
|
|
if cached, ok := m.updates.Cached(id, receipt.Digest, st.Generation); ok && cached.State == updates.UpdateAvailable {
|
|
snap.UpdatePending = true
|
|
}
|
|
}
|
|
snaps = append(snaps, snap)
|
|
}
|
|
return apps.Build(snaps, isAdmin), nil
|
|
}
|
|
|
|
// InstalledIDs returns the identifiers of every installed addon, enabled or
|
|
// not, sorted. It is for the host's own housekeeping (the pin sweep); it takes
|
|
// no actor and returns no detail.
|
|
func (m *Manager) InstalledIDs(ctx context.Context) ([]string, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return nil, e
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return nil, ErrRecoveryRequired
|
|
}
|
|
out := make([]string, 0, len(m.journal.Addons))
|
|
for id, st := range m.journal.Addons {
|
|
if st.Installed {
|
|
out = append(out, id)
|
|
}
|
|
}
|
|
sort.Strings(out)
|
|
return out, nil
|
|
}
|
|
|
|
func currentReceipt(st Status) (packages.PackageReceipt, bool) {
|
|
for _, g := range st.Generations {
|
|
if g.Number == st.Generation {
|
|
return g.Receipt, true
|
|
}
|
|
}
|
|
return packages.PackageReceipt{}, false
|
|
}
|
|
|
|
// AppAsset returns the package of an enabled addon whose current installed
|
|
// package has the given digest, and its generation. The digest is the bare
|
|
// lower-case hex of the package digest. A disabled, uninstalled or replaced
|
|
// package is the same denial for every caller, administrators included: a page
|
|
// that is still open must not be able to fetch code the owner has withdrawn.
|
|
func (m *Manager) AppAsset(ctx context.Context, actor contract.Actor, id, digest string) (packages.PackageReceipt, uint64, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return packages.PackageReceipt{}, 0, e
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return packages.PackageReceipt{}, 0, ErrRecoveryRequired
|
|
}
|
|
st, ok := m.journal.Addons[id]
|
|
if !ok || !addonID.MatchString(id) || !st.Installed || !st.DesiredEnabled || st.Generation == 0 || len(digest) != 64 {
|
|
return packages.PackageReceipt{}, 0, ErrForbidden
|
|
}
|
|
receipt, ok := currentReceipt(st)
|
|
if !ok || m.admit(receipt) != nil || receipt.Manifest.Capabilities.UI == nil || receipt.Digest != "sha256:"+digest {
|
|
return packages.PackageReceipt{}, 0, ErrForbidden
|
|
}
|
|
return receipt, st.Generation, nil
|
|
}
|
|
|
|
// AppIcon returns the receipt of an app the actor may see when the generation
|
|
// is the installed one and the package has a verified icon. Every other case
|
|
// is the same denial, so the answer reveals nothing about hidden addons.
|
|
func (m *Manager) AppIcon(ctx context.Context, actor contract.Actor, id string, generation uint64) (packages.PackageReceipt, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return packages.PackageReceipt{}, e
|
|
}
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return packages.PackageReceipt{}, ErrRecoveryRequired
|
|
}
|
|
st, ok := m.journal.Addons[id]
|
|
if !ok || !addonID.MatchString(id) || !st.Installed || generation == 0 || generation != st.Generation {
|
|
return packages.PackageReceipt{}, ErrForbidden
|
|
}
|
|
if !st.DesiredEnabled && (m.admin == nil || m.admin(ctx, actor) != nil) {
|
|
return packages.PackageReceipt{}, ErrForbidden
|
|
}
|
|
receipt, ok := currentReceipt(st)
|
|
if !ok || receipt.Icon == nil || receipt.Manifest.Capabilities.UI == nil || receipt.Manifest.Capabilities.UI.Icon != receipt.Icon.Path {
|
|
return packages.PackageReceipt{}, ErrForbidden
|
|
}
|
|
return receipt, nil
|
|
}
|
|
|
|
// toolDeclaration is the declared tool set of one installed generation.
|
|
type toolDeclaration struct {
|
|
generation uint64
|
|
tools []string
|
|
}
|
|
|
|
// DeclaredTools returns the tools the manifest of the current installed
|
|
// generation declares. It answers from the in-memory journal, cached per
|
|
// generation, and fails when the add-on is not installed, the generation is
|
|
// not the installed one (ErrForbidden, a denial), or when the journal is
|
|
// uncertain or runtime recovery is required (ErrRecoveryRequired), the
|
|
// manager is closed (ErrNotOwner) or the context is done (its error), which
|
|
// are unavailable conditions.
|
|
func (m *Manager) DeclaredTools(ctx context.Context, id string, generation uint64) ([]string, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return nil, e
|
|
}
|
|
st, ok := m.journal.Addons[id]
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return nil, ErrRecoveryRequired
|
|
}
|
|
if !ok || !st.Installed || generation == 0 || st.Generation != generation {
|
|
return nil, ErrForbidden
|
|
}
|
|
if m.admission(id) != nil {
|
|
return nil, ErrForbidden
|
|
}
|
|
if c, ok := m.toolCache[id]; ok && c.generation == generation {
|
|
return c.tools, nil
|
|
}
|
|
receipt, ok := currentReceipt(st)
|
|
if !ok {
|
|
return nil, ErrForbidden
|
|
}
|
|
if m.toolCache == nil {
|
|
m.toolCache = map[string]toolDeclaration{}
|
|
}
|
|
tools := append([]string{}, receipt.Manifest.Capabilities.Tools...)
|
|
m.toolCache[id] = toolDeclaration{generation: generation, tools: tools}
|
|
return tools, nil
|
|
}
|
|
|
|
// DeclaredCapabilities returns the capabilities of the manifest of the current
|
|
// installed generation: the declared tools, their definitions, the admin tools
|
|
// and the resource mapping. It answers like DeclaredTools: a stale or unknown
|
|
// generation is a denial, an uncertain journal is unavailable. The UI-only
|
|
// resource management endpoints are its only reader of the admin tools.
|
|
func (m *Manager) DeclaredCapabilities(ctx context.Context, id string, generation uint64) (contract.Capabilities, error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
if e := m.check(ctx); e != nil {
|
|
return contract.Capabilities{}, e
|
|
}
|
|
st, ok := m.journal.Addons[id]
|
|
if m.uncertain || m.runtimeRecoveryRequired {
|
|
return contract.Capabilities{}, ErrRecoveryRequired
|
|
}
|
|
if !ok || !st.Installed || generation == 0 || st.Generation != generation {
|
|
return contract.Capabilities{}, ErrForbidden
|
|
}
|
|
receipt, ok := currentReceipt(st)
|
|
if !ok {
|
|
return contract.Capabilities{}, ErrForbidden
|
|
}
|
|
if m.admit(receipt) != nil {
|
|
return contract.Capabilities{}, ErrForbidden
|
|
}
|
|
c := receipt.Manifest.Capabilities
|
|
out := contract.Capabilities{Service: c.Service, Tools: append([]string(nil), c.Tools...), AdminTools: append([]string(nil), c.AdminTools...), Actions: c.Actions, Undo: c.Undo}
|
|
out.ToolDefinitions = append([]contract.ToolDefinition(nil), c.ToolDefinitions...)
|
|
out.SkillDefinitions = append([]contract.SkillDefinition(nil), c.SkillDefinitions...)
|
|
if c.ExecutionProvider != nil {
|
|
p := *c.ExecutionProvider
|
|
p.Tools = slices.Clone(p.Tools)
|
|
out.ExecutionProvider = &p
|
|
}
|
|
if c.HostOperations != nil {
|
|
h := *c.HostOperations
|
|
h.Required = slices.Clone(h.Required)
|
|
h.Optional = slices.Clone(h.Optional)
|
|
out.HostOperations = &h
|
|
}
|
|
if c.Resources != nil {
|
|
r := *c.Resources
|
|
out.Resources = &r
|
|
}
|
|
return out, nil
|
|
}
|