Files
LocalAI/core/services/studio/session/chattools.go
T
mudler-agentandEttore Di Giacinto 7904b3d0ab feat(addons): declare typed host capabilities (#13034)
* feat(addons): model execution status observations

Keep observation lifetimes explicit before runtime integration. The pure
reducer rejects retries and stale replies using exact binding identity.

Cover all eleven trace families, the complete transition matrix and
bounded histories with safety and liveness checks.

Assisted-by: nib:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): visualize execution status traces

Generate a self-contained viewer from the real reducer and shared traces.
Check independent expectations, coverage and bounded invariants before
exporting data. Detect stale artifacts and nondeterministic generation
without maintaining a second reducer in JavaScript.

Assisted-by: nib:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): honor the viewer artifact root

Keep default viewer output under SDD_LOCAL_ROOT when configured.\nLet go generate use the same default without forcing a source artifact.\nRetain the portable fallback and explicit output and check semantics.

Assisted-by: nib:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): add typed extension contracts

Validate optional home commands, execution bindings and requested host
operations without changing manifest versions or granting authority.
Decode bounded execution status payloads conservatively and document
strict staging compatibility for older hosts.

Assisted-by: nib:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): reject noncanonical extension keys

Reject case aliases before typed decoding can override canonical fields
or bypass presence checks. Keep locale maps outside exact-key checks.

Add regression coverage for status, declaration objects, and nested
entries. All status errors return unknown readiness and isolation.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): reject root enums for status tools

Status tools must accept the empty object. The supported schema enums
contain only strings, so a root enum excludes every object.

Reject root enums only for execution status bindings. Cover incompatible
root constraints and optional properties without changing shared validation.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): project typed home commands

Resolve declared home destinations and display metadata in the installed
Apps view. Pin packaged command icons to immutable asset URLs.

Cover strict declaration transport, immutable receipts, exact health echo,
and process restart. Keep legacy packages and disabled installed intent.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): preserve typed lifecycle declarations

Copy execution and host-operation declarations from installed receipts.
The existing capability completeness test exposes the missing fields.

Exercise real staged Manager upgrades, activation rollback and recovery.
Check installed Apps metadata through pinned mTLS frontends for each actor.
Verify mutation isolation and name receipt replay coverage accurately.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): stabilize fixture archive digests

Map iteration changes tar entry order between identical publishes.
Sort fixture filenames so unchanged packages retain their digest.

Check repeated publish bytes, digests and lexical archive entry order
with and without a manifest transform. Register the regression case.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): resolve explicit host policy grants

Load strict administrator policy files once before application startup.
Honor explicit empty overrides without reading ignored policy files.
Copy programmatic and manager grants to isolate startup authority.

Keep the legacy CLI fallback until the official deployment policy ships.
The generic resolver already defaults to empty grants.

Verify config, CLI, hostops and execution-status checks with GOMAXPROCS=2,
-p=2 and -ldflags="-s -w" to fit the available build disk.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): select explicit deployment grants

Move official host grants out of the generic executable into reviewed
host deployment policy. Stock Docker explicitly selects the shipped file;
unconfigured binaries and nil or empty programmatic grants grant nothing.

Document the standalone upgrade break and deliberate operator selection.
Do not infer consent from installed addons or merge explicit overrides.
Guard policy packaging and generic configuration boundaries with tests.

Verify executionstatus, viewer -check, config, CLI, packaging and root
architecture tests with auth, GOMAXPROCS=2 and bounded build parallelism.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): gate activation on required host ops

Refuse unmet required requests before package publication or runtime
withdrawal. Keep installed intent unavailable when startup grants change.
Optional requests permit degraded operation and never create authority.

Carry bounded admin diagnostics through Apps and the owner carrier.
Keep startup policy immutable and broker authorization authoritative.

Verify executionstatus, viewer -check, lifecycle, packages, updates,
hostops, Apps and gateway offline with auth and bounded parallelism.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): guard host operation registry parity

Compare startup admission names against real builtin registrations so
registry drift cannot silently change request satisfaction.

Cover dynamic progress and stop operations and connector inbound.
Reject missing, extra, duplicate and case-changed names with negative
controls. Record both regression cases in the suite inventory.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): fence status observation effects

Keep observation ownership in admitted runtime operations. Deny all
correlated callbacks before dispatch, including inbound-class callbacks.
Reject status outputs before callers can open or adopt artifact handles.

Retain bounded denial correlations until the runtime endpoint closes so
late callbacks cannot recover ordinary authority. Preserve independent
ordinary operations and document the dedicated read API for T9.

Verify the status model, viewer, and race-enabled gateway, hostops and
runtime suites with the pinned offline environment.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): drain callbacks before retirement

Server.Close does not wait for active callback requests. Clearing retired
observation correlations first can restore inbound authority.

Stop endpoint admission before closing connections. Drain admitted requests
before releasing correlations, and refuse dispatch after Stop. Keep locks
out of handlers and cleanup waits so cancellation cannot deadlock teardown.

Cover pending inbound callbacks, decoded authorization paused across Stop,
and handlers that ignore cancellation. Preserve ordinary authorized work
on other endpoints. Document delayed reclamation under the existing bound.

Verify the status model and viewer, then race-test gateway, hostops,
runtime, the model and root architecture checks with auth enabled.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): bind owner status to exact clients

Add authenticated, versioned status reads over the owner carrier.
Revalidate actor permissions and provider selection before dispatch and
before returning an observation. Keep status separate from authority.

Admit the captured client against its immutable identity under the
withdrawal lock. Never dispatch an old binding through a replacement.
Generate runtime operation IDs on the owner and retain the T8 effect fence.

Cover forged identities, strict DTOs, stale replies, restart ordering,
wire discriminators, and unchanged model exclusion of uiOnly tools.
Document the T10 callback and request-shell integration requirements.

Verify the model and viewer, then race-test gateway, runtime, tools,
and the model with auth enabled.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): compose owner status with runtime

Exercise installed addon processes through the authenticated mTLS carrier.
Keep runtime clients real while channel barriers control lookup ordering.

Reject captured clients after same-generation replacement before dispatch.
Reject completed status reads when replacement precedes owner consumption.
Prove fresh bindings succeed and record named tools and host operation IDs.

Verify the model and viewer, then race-test gateway, runtime, tools,
the model, and the protocol fixture package with auth enabled.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(studio): scope execution status observations

Run the execution status reducer within one explicit request lifetime.
Coalesce consumers without retries and withdraw stale or canceled reads.

Keep owner admission and production lifecycle integration separate for
review before wiring the shell into requests and turns.

Assisted-by: OpenAI:ChatGPT
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(studio): isolate consumer cancellation

Consumer cancellation during validation must not withdraw a valid
observation from other consumers. Return unknown locally before shared
invalidation, while preserving parent closure and freshness failures.

Cover cancellation and deterministic deadline expiry with one-read
reducer traces and live-consumer checks.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): track selection mutation epochs

Detect selection ABA at config and owner mutation boundaries. Clone
provider pins for Studio readers and share synchronized selection state
across config value copies.

Track lifecycle publication, candidate rollback and recovery transitions.
Keep reads and unchanged publications stable. These lifetime epochs do
not replace current-incarnation checks or grant execution authority.

Verify race tests for config and the add-on Manager, plus application
compilation with auth tags. Request binding remains separate work.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): expose owner binding transport

Add a host-only binding API with an optional owner resolver. Forward
conversation claims over authenticated mTLS with strict versioned DTOs.
Compare full bindings during validation and deny missing resolvers.

Keep ordinary tool execution unchanged through an optional backend.
Test trusted resolver fixtures, stale bindings, denial and compatibility.
Application authority and store revisions remain a separate milestone.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(studio): fence selection snapshots with epochs

Read actor-scoped records and opaque mutation tokens under store locks.
Invalidate tokens after successful eligibility changes, including ABA.
Keep reads, rejected writes and turn history from invalidating tokens.
Clone mutable records so callers cannot bypass mutation tracking.

Support authoritative revisions only for memory-only JSON stores.
File stores lack exclusive ownership; GORM lacks persisted revisions.
Fail closed for both rather than trust frontend-local state.
Ordinary chats remain unchanged; application integration stays separate.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(studio): enforce persistent JSON ownership

Acquire lifetime sidecar locks before loading or repairing JSON data.
Enable selection revisions only under cooperating exclusive ownership.

Close drains operations before releasing ownership and rejects later use.
Clean up unpublished stores when application initialization fails.
Retain published locks through Shutdown because HTTP users may remain live.

Document coordinated upgrades and the advisory local-filesystem boundary.
Keep GORM revisions unsupported pending a separate approved design.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Codex:gpt-5

* test(application): isolate warning log capture

Run warning assertions in isolated test subprocesses. The suite leaves
background log producers running, which race with global logger changes.

Keep the parent logger unchanged and check child exits and completion
markers. Preserve pin persistence and ownership warning assertions.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(studio): resolve local owner execution bindings

Resolve execution providers from owner-held chat and agent snapshots.
Fence bindings with selection epochs, mutation tokens and live runtime
identity. Recompute every component during status authorization.

Keep named-user and SQL observations unavailable until authoritative
access and shared selection revisions can detect ABA changes.

Drain restart test producers before releasing JSON store ownership.
Register six product resolver cases in the gateway suite inventory.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(studio): bound product scopes to chat turns

Keep request-local product state alive through tool calls, checkpoints
and persistence. Give chat priming its own scope instead of seeding the
next turn with a closed observation.

Exercise one reducer read per scope across prompt and tool consumers.
Check closure of pending reads on normal completion and interruption.
Provider wiring and safety projection remain separate work.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(studio): consume typed execution providers

Replace the Sandbox-specific status heuristic with owner-bound typed reads.
Share one reducer observation across turn consumers and close it at the
outer scope boundary. Keep priming and standalone requests independent.

Sandbox exposes a separate callback-free typed read while preserving its
private Settings payload. Unknown backends never imply isolation.
Provider isolation does not prove host network-policy enforcement.

Local-owner JSON bindings are supported. Named-user and SQL bindings
remain explicitly unavailable and fail closed.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(application): isolate auth startup lifetime

Shutdown does not join every background producer. Auth startup tests
can therefore delete their temporary directory while a writer remains.

Run each case in a bounded child process. The parent waits for child
exit before deleting the fixture, preserving every startup assertion.
Production shutdown and JSON ownership retention remain unchanged.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): resolve installed Home app commands

Project Home navigation from installed addon declarations, not product IDs.
Reserve native and skill names and suppress every colliding addon alias.

Re-read the authenticated registry before navigation and reject stale
actors, generations, immutable entries and destinations. Keep mounted
consumers polling through disabled and failed states. Abort pending reads
on actor changes and ignore replies from obsolete request epochs.

Studio declares its own alias. Preserve legacy redirects and pin migration.
Add unit coverage, localized Home copy and command lifecycle documentation.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): accept resolved Home command metadata

Apps resolves inherited titles beyond the explicit manifest label cap.
Bound resolved labels to 147 Unicode characters, including secondary pages.
Keep the backend's 60-character limit for explicit manifest labels.

Match packaged icon paths to the contract's ASCII alphabet and image types.
Accept dotted names while rejecting traversal, encodings and foreign assets.

Verify 68 focused cases, 657 total cases, lint, i18n checks and the UI build.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): bind safety notices to actual providers

Warn for addon host execution and unknown isolation without changing tool
permissions or built-in host consent. Reset dismissal when the admitted
binding, observation, actor or chat context changes.

Expose presentation-only status identity from the admitted request.
Keep configured network policy visible when enforcement is unverified.
Render bounded provider explanations as escaped React text.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): isolate command status across sessions

Invalidate command observations when actors or authentication sessions
change, before effects can expose a previous actor’s reply.

Keep actual host execution warnings generic instead of recommending
Sandbox installation or repair. Cover both regressions with source-hook
lifecycle tests and provider notice assertions.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): declare audited host requests

Declare actual official hostclient operations without inferring requests
from deployment grants. Keep optional settings and egress checks separate
from required workspace and job operations.

Verify all twelve manifests through strict package fixtures and assert
that requests never self-grant. Guard generic provider and Home dispatch
without banning historical routes, native Studio, or deployment policy.

Document the audited operations and unresolved named-user and SQL gaps.
Refresh Sandbox catalog metadata for its existing typed status tool.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): wire exact extension inventories and real provider selection

Run contract, official packaging and root architecture gates through actual report inventories. Exercise two installed execution providers through the real owner resolver and distinguish callback pass-through coverage. Share strict report validation with focused-scope handling and missing/skipped artifact self-tests; document direct evidence and remaining harness limits.

Assisted-by: Codex:gpt-5

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): expire registry reads on auth refresh

Bind registry authority to the actual authentication session epoch.
Same-user refresh now rejects old polls and pending Home navigation
before effect cleanup, even when permissions and metadata stay unchanged.

Exercise both races through the production registry provider harness.
Verify 59 focused tests, 669 total tests, lint, i18n, and the UI build.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(studio): resolve current execution selection

Use existing principal-scoped chat and agent reads for advisory status.
Revalidate current named credentials instead of requiring historical SQL
revisions. Local-owner mode also works with the existing GORM store.

Remove resolver nonces and historical revision prerequisites. Keep exact
runtime binding and existing status admission hooks. Document current-read
consistency without promising revoke-and-restore detection.

Verify the SQLite regression fails before the fix. Two separate full race
runs pass: application 262 specs (3 skips), auth 257, gateway 115, tools 91.
Cover named chat, API key and session credentials and current-state denial.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* refactor(addons): drop selection revision tracking

Use current selection comparisons for advisory status instead of mutation
history. Keep actor, credential and conversation identity explicit in the
model. Hash current inputs at the gateway without exposing raw store data.

Remove unused epochs, revision interfaces and JSON ownership lifetimes.
Preserve current authorization, runtime identity, mutexes and atomic writes.
Document current-read semantics without historical ABA guarantees.

Verify all affected packages with the race detector and auth tag. Check
the trace viewer, prerequisite self-tests and 18 chat-command unit tests.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): scope Apps reads and provider status

Bind Apps replies and registry ingestion to their originating auth session.
Reject late replies before effect cleanup on refresh or account switch.

Use selected-provider command DTOs in the composer instead of private
Sandbox discovery. Keep unknown isolation unknown and remove specific
add-on installation recommendations from the affected native surfaces.

Test production Apps, registry, switches and composer paths with controlled
cleanup and two arbitrary providers. Update the matching feature docs.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): guard composer and session publication

Remove the deleted Sandbox variable from the full composer render.
Report unknown command isolation explicitly in the about card.

Bind Apps records and admin action results to their originating actor
and actual authentication epoch before cleanup can run. Reject stale
request admission and verification without changing server authorization.

Add full-component render and pending session-transition regressions.
Enable no-undef for the production composer in normal UI lint.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): expire cancelled upgrade reconciliation

Bind cancellation reconciliation to the initiating session authority.
Discard status replies after expiry without publishing old outcomes.
Match the exact operation identity before clearing a held action.

Cover pending cancellation reads, expiry before reads, and preservation
of a newer attempt with the same action key.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): bind background upgrades to auth lifetime

Keep background upgrade authority in AuthProvider, independent of views.
Expire pending observations before auth consumers render or logout waits.
Preserve same-session navigation and exact-operation cleanup.

Cover cancellation, completion, and verification after the origin unmounts
with actual provider transitions and the real upgrade store.
Thread captured authority through Activity retries and document expiry.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* refactor(addons): remove implicit sidebar pins

Start every account without implicit Studio or Talk pins. Preserve saved
user selections and durable explicit pins across reopen and frontends.

Remove startup seeding, seed metadata APIs, and first-install exceptions.
Apply equal retention to all absent IDs without dropping database tables.
Keep store initialization, cached errors, and the leader sweep unchanged.

Verify genuine RED regressions before removal. Race checks pass for all
42 pin specs, 10 focused application specs, and 10 pin endpoint specs.
Update pin documentation; renamed specs have no exact inventory entries.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): declare typed model destinations

Let installed addons own model launch destinations without teaching core
about addon identities or private routes. Keep native chat and completion
outside the declaration vocabulary.

Validate strict keys, unique capabilities, declared pages and SDK route
bounds. Carry cloned typed metadata through Apps using the shared
contract type, and add owning Studio, Talk, Face and Voice declarations.

Verify strict contract RED before implementation, then 1276 passing
specs across contract, Apps, packages, runtime, protocol, config and manager.
Verify 178 packaging and architecture specs and exact carrier inventories.
Frontend dispatch and route cleanup remain a separate milestone.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* refactor(ui): resolve declared model launch actions

Resolve installed model actions through the shared addon registry. Keep
native chat and completion launches, and never promote absent providers.

Refresh actor-filtered Apps before navigation and reject stale authority,
provider metadata, generation, immutable entry and destination claims.
Use named menu choices for collisions without loading addon modules.

Remove unreleased addon-specific redirects and migrate browser fixtures
to canonical declared pages. Preserve native chat handoff and addon-local
navigation adapters. Update user documentation and historical plans.

Verify three production UI consumers fail against their previous code,
then pass all 13 mocked-HTTP browser regressions. Verify 696 host unit
cases, full quiet lint, targeted no-undef, locales, inline styles and build.
Full backend/browser integration remains outside these mocked-HTTP checks.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): validate Ginkgo hooks before focus

Ginkgo emits null container hierarchies for suite hooks. Require hooks\nto pass before applying focus only to It cases. Normalize null\nhierarchies without weakening exact required-case comparisons.\n\nRun reporter regressions in prerequisites. Register the declared uiOnly\ntool case and remove an update fixture case excluded by the existing\nmanager focus. Both inventories match the complete CI case output.\n\nVerify 12 reporter regressions, 39 prerequisite cases, three existing\nreports, and fresh runtime, tools and focused update manager suites.

Assisted-by: Codex:gpt-5 [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): restore Go CI contract checks

Align route fixtures with explicit pins and declared network controls.
Keep network enforcement unknown instead of inferring it from isolation.

Propagate viewer output errors and select output paths with CLI arguments.
Check test writes and use Ginkgo assertions without copying atomic state.
Register the three migrated binding cases in the exact suite inventory.

Document two narrow security false positives for administrator file access
and symbolic credentials in reducer traces. Focused race tests pass.
The available golangci-lint reports zero issues in affected packages.

Assisted-by: OpenAI ChatGPT [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): align browser coverage with addon contracts

The generic provider refactor removes implicit install advice and private
Sandbox discovery. Update browser fixtures to use the installed command
metadata and typed execution observations without restoring those paths.
Keep command warnings, consent, disabled switches and privacy assertions.

Home now holds a live command consumer. Exercise polling shutdown on a
route without that consumer, after its lazy transition finishes. Preserve
the bounded cadence, error backoff and disable-stop assertions.

Restore the remembered-voices link through the addon's compatibility
router. Cover native migrations and NotFound for removed generator aliases.

Validation: 293 affected browser cases and three native service cases pass.
The gallery command passes all 74 inventoried cases. Full UI units, quiet
lint, locale parity, production build and diff checks pass.

Assisted-by: OpenAI ChatGPT [functions]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): bind status to owner provider policy

Resolve typed status with the same current owner pins as execution.
Fail closed on owner policy outages and fingerprint authoritative pins.

Exercise CAS updates, conflicts, stale bindings, and policy outages.
Retain host settings when the named-account fixture replaces its gateway.
Refresh exact gateway and Apps inventories from passing reports.

Validation: the new regression fails before the fix. All 16 focused
binding and policy cases pass. Gateway passes 361 exact cases and Apps
passes 265 exact cases across their configured package reports.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* refactor(addons): share qualified tool identities

Use one formatter and contract-component parser for add-on identities.
Keep callable names bounded to 64 characters while recognizing long
unavailable stand-ins without granting dispatch authority.

Validate selected execution names and their provider ID at the owner
binding boundary. The real adapter already emits canonical identities.
Update exact importer and case inventories from passing reports.

Migrate the binding backend test to Ginkgo and check shutdown errors
reported by lint in the affected packages.

Validation: behavioral RED proves malformed stand-in acceptance and
plain selected-name acceptance. Affected full race suites pass: tools
94 and Studio 638, with zero skips. Application passes 275 of 278;
three existing PostgreSQL cases skip without their configured URL. All 12 owner-binding cases
pass and match the exact inventory. Scoped golangci-lint reports no issues.

Assisted-by: Codex:gpt-5 golangci-lint
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* refactor(addons): share execution declarations

Share pure declaration predicates across manifest validation, gateway
observations, and owner bindings. Keep authorization and exact-runtime
admission checks local. Reuse the strict manifest schema validator so
raw status definitions fail closed without changing manifest acceptance.

Share the workspace-operation prefix scan without changing grant sources.
Add declaration parity and workspace-prefix tables and update exact
inventories from passing reports.

Validation: two new gateway cases fail before the fix; all 14 pass after.
Race tests pass: contract 245, gateway 136, tools 94, and focused
application binding/workspace cases 22. Scoped golangci-lint: 0 issues.

Assisted-by: Codex:gpt-5 golangci-lint
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): retain document skill cases

Match the contract inventory to the passing report after rebasing.\nKeep the new document-provider case and updated reserved-name cases.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

Assisted-by: OpenAI:gpt-6.1-sol

* test(addons): follow owner-managed upgrades

Accepted upgrades belong to the owner and cannot be cancelled by UI.
Exercise observer expiry during reads, completion and verification.
Supply the real upgrade store to source-executed auth harnesses so
logout reaches its synchronous authority invalidation.

Match whole-package inventories to fresh Manager and gateway reports.

Assisted-by: Codex:gpt-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

---------

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
2026-11-02 23:50:40 +00:00

594 lines
20 KiB
Go

package session
import (
"context"
"crypto/sha256"
"encoding/hex"
"encoding/json"
"errors"
"fmt"
"log/slog"
"regexp"
"runtime/debug"
"sort"
"strconv"
"strings"
"sync"
"unicode/utf8"
"github.com/mudler/LocalAI/core/services/studio/workspace/workfiles"
)
// TurnTools are the host-side tools a product adds to a chat for one turn.
type TurnTools struct {
// Tools run on the host, not in the sandbox. They are added to the six
// sandbox tools.
Tools []Tool
// Note is one line for the model at the start of the turn, for example
// "unavailable this turn: github (cannot connect)". It is not stored as a
// user message.
Note string
// Prompt is a block added to the system prompt for this turn, for example
// an index of skills. It goes after the product's SystemPrompt. A changed
// Prompt restarts the harness from its saved state, as a changed set of
// tools does; an unchanged one does not. It is cut at 32 KiB on a line
// boundary. When ChatTools fails, the turn has no Prompt.
Prompt string
// RefreshKey is opaque. The sandbox of a chat is refreshed before a turn
// when the key differs from the key of the turn before and both are not
// empty: the guest then sees the files that changed in the workspace, and
// its processes end. Set it to a value that changes only when the files
// that Prompt names changed. A turn whose hook failed, was stopped, or
// returned an empty key keeps the previous key. The first turn of a chat
// that was opened again never refreshes.
RefreshKey string
// WorkFolder asks the chat to name its work folder in the prompt
// (workfiles.Prompt): the chat takes the name of its chat folder for it
// when it has none yet. The folders are made when something is saved
// there, so a chat that saves nothing leaves no folder behind.
WorkFolder bool
}
const (
// maxNoteLen is how much of a Note the model gets.
maxNoteLen = 400
// maxPromptLen is how much of a Prompt the model gets.
maxPromptLen = 32 << 10
// noteChatToolsFailed is the note when the product's hook failed.
noteChatToolsFailed = "connector tools are unavailable this turn."
)
var hostToolNameRE = regexp.MustCompile(`^[A-Za-z0-9_.-]{1,64}$`)
// sandboxToolNames are the names the six sandbox tools use.
var sandboxToolNames = func() map[string]bool {
m := map[string]bool{}
for _, t := range NewTools(nil) {
m[t.Name] = true
}
return m
}()
// hostTools is the set of host-side tools of a chat. The harness is started
// with stable wrappers that look the current closure up by name, so that a
// new closure for an unchanged tool needs no harness restart.
type hostTools struct {
defs []Tool // what the running harness was started with (Run is a wrapper)
cur map[string]Tool // the closures of the current turn
prompt string // the TurnTools.Prompt that the running harness was started with
fp string // fingerprint of defs and prompt
key string // the last non-empty TurnTools.RefreshKey
}
// capPrompt cuts a prompt block to maxPromptLen bytes on a line boundary. A
// block whose first line is longer than the limit is cut on a rune boundary.
func capPrompt(s string, log *slog.Logger, chat string) string {
return capPromptAt(s, maxPromptLen, log, chat)
}
// turnPrompt is the prompt block of tt, capped, with the block that names the
// work folder last when tt asks for it. reserve takes a folder name for a
// chat that has none; without it such a chat gets no block (opening a chat
// must not name its folder: only a turn does).
func (c *Chat) turnPrompt(ctx context.Context, tt TurnTools, reserve bool) string {
if !tt.WorkFolder {
return capPrompt(tt.Prompt, c.m.log, c.id)
}
block := c.workFolderBlock(ctx, reserve)
if block == "" {
return capPrompt(tt.Prompt, c.m.log, c.id)
}
// The block goes last and is never the part that is cut.
return strings.TrimSpace(capPromptAt(tt.Prompt, maxPromptLen-len(block)-2, c.m.log, c.id) + "\n\n" + block)
}
// capPromptAt is capPrompt with a limit of n bytes.
func capPromptAt(s string, n int, log *slog.Logger, chat string) string {
if len(s) <= n {
return s
}
cut := s[:n]
if i := strings.LastIndexByte(cut, '\n'); i > 0 {
cut = cut[:i]
}
cut = strings.ToValidUTF8(cut, "")
log.Warn("session: the turn prompt is over the limit and was cut", "chat", chat, "bytes", len(s), "kept", len(cut))
return cut
}
// fingerprint hashes the sorted names, descriptions and schemas of the tools
// and the prompt block.
func fingerprint(tools []Tool, prompt string) string {
sorted := append([]Tool(nil), tools...)
sort.Slice(sorted, func(i, j int) bool { return sorted[i].Name < sorted[j].Name })
h := sha256.New()
for _, t := range sorted {
_, _ = fmt.Fprintf(h, "%d:%s\n%d:%s\n%d:%s\n", len(t.Name), t.Name, len(t.Description), t.Description, len(t.Schema), t.Schema)
}
_, _ = fmt.Fprintf(h, "prompt\n%d:%s\n", len(prompt), prompt)
return hex.EncodeToString(h.Sum(nil))
}
// acceptHostTools drops what the harness could not take: a name that collides
// with a tool of the session's own sandbox (only when the session has one) or
// with another host tool, a name the tool server refuses, a missing Run, a
// schema that is not a JSON object. Without a session sandbox the names are
// free: the product's own bash takes "bash".
func acceptHostTools(tools []Tool, log *slog.Logger, chat string, sandboxed bool) []Tool {
var out []Tool
seen := map[string]bool{}
for _, tool := range tools {
var schema map[string]any
switch {
case sandboxed && sandboxToolNames[tool.Name]:
log.Warn("session: a host tool has the name of a sandbox tool and was dropped", "chat", chat, "tool", tool.Name)
case !hostToolNameRE.MatchString(tool.Name) || tool.Run == nil:
log.Warn("session: a host tool has no usable name or no Run and was dropped", "chat", chat)
case seen[tool.Name]:
log.Warn("session: two host tools have one name; the second was dropped", "chat", chat, "tool", tool.Name)
case json.Unmarshal(tool.Schema, &schema) != nil || schema == nil:
log.Warn("session: a host tool has a schema that is not an object and was dropped", "chat", chat, "tool", tool.Name)
default:
seen[tool.Name] = true
out = append(out, tool)
}
}
return out
}
// oneLine makes a note a single line of bounded length.
func oneLine(s string) string {
s = strings.Join(strings.Fields(s), " ")
if len(s) > maxNoteLen {
s = strings.ToValidUTF8(s[:maxNoteLen], "")
}
return s
}
// callChatTools runs the product's hook. A panic is an error.
func callChatTools(ctx context.Context, f func(context.Context, Access) (TurnTools, error), x Access, log *slog.Logger) (tt TurnTools, err error) {
defer func() {
if r := recover(); r != nil {
log.Error("session: ChatTools panicked", "panic", fmt.Sprint(r), "stack", string(debug.Stack()))
tt, err = TurnTools{}, errors.New("ChatTools panicked")
}
}()
return f(ctx, x)
}
// hostWrappers returns the tools the harness is started with for the current
// host tool set. Each looks the closure of the current turn up by name.
func (c *Chat) hostWrappers() []Tool {
c.hostMu.Lock()
defs := append([]Tool(nil), c.host.defs...)
c.hostMu.Unlock()
out := make([]Tool, len(defs))
for i, d := range defs {
name := d.Name
d.Run = func(ctx context.Context, args json.RawMessage) (string, error) {
c.hostMu.Lock()
cur, ok := c.host.cur[name]
c.hostMu.Unlock()
if !ok {
return "", errors.New("not granted")
}
slot := &cardSlot{}
res, err := cur.Run(context.WithValue(ctx, cardSlotKey{}, slot), args)
if err == nil {
c.addPendingCard(name, res, slot.get())
}
return res, err
}
out[i] = d
}
return out
}
// mandatoryChatToolsError recognizes policy failures without coupling the session
// to the product that owns the policy. Wrapping must not make a failure optional.
func mandatoryChatToolsError(err error) bool {
var mandatory interface{ Mandatory() bool }
return errors.As(err, &mandatory) && mandatory.Mandatory()
}
// applyChatTools runs at the start of a turn. It asks the product for the host
// tools and the prompt block, remembers the closures for this turn, and
// restarts the harness from its saved state when the set of tools (names,
// descriptions, schemas) or the prompt block differs from the one the harness
// runs with. It returns the note for the model, and whether the turn must
// refresh the sandbox: the RefreshKey changed from a non-empty earlier key.
// A mandatory failure aborts the turn; optional failures retain the sandbox
// fallback. A stopped hook changes nothing and never asks for a refresh.
//
// The turn is already reserved (the chat is running), so nothing else changes
// the harness. A change that arrives while a turn runs is seen at the next turn.
func (c *Chat) applyChatTools(ctx context.Context) (note string, refresh bool, policyErr error) {
f := c.m.o.ChatTools
if f == nil {
return "", false, nil
}
c.accMu.RLock()
x := c.acc
c.accMu.RUnlock()
tt, err := callChatTools(ctx, f, x, c.m.log)
if ctx.Err() != nil {
// The turn was stopped while the hook ran. Its result is partial: keep
// the state of the last turn, so that the next turn does not see a change.
return "", false, nil
}
note = oneLine(tt.Note)
var tools []Tool
prompt := ""
if err != nil {
if mandatoryChatToolsError(err) {
return "", false, err
}
c.m.log.Warn("session: ChatTools failed; the turn runs with the sandbox tools", "chat", c.id, "error", err)
note = noteChatToolsFailed
} else {
tools = acceptHostTools(tt.Tools, c.m.log, c.id, c.m.o.Sandbox != nil)
prompt = c.turnPrompt(ctx, tt, true)
}
fp := fingerprint(tools, prompt)
cur := make(map[string]Tool, len(tools))
defs := make([]Tool, len(tools))
for i, t := range tools {
cur[t.Name] = t
defs[i] = Tool{Name: t.Name, Description: t.Description, Schema: t.Schema}
}
c.hostMu.Lock()
prev := c.host.fp
if prev == "" { // no host tool has been set yet
prev = fingerprint(nil, "")
}
changed := fp != prev
if err == nil && tt.RefreshKey != "" {
refresh = c.host.key != "" && tt.RefreshKey != c.host.key
c.host.key = tt.RefreshKey
}
c.host.cur = cur
if changed {
c.host.defs, c.host.prompt, c.host.fp = defs, prompt, fp
}
c.hostMu.Unlock()
if !changed {
return note, refresh, nil
}
// Run the swap and the fallback to the end even when the turn is stopped:
// stopping must not leave the chat without a harness.
ctx = context.WithoutCancel(ctx)
// A message that arrives during the swap is queued, not injected.
c.mu.Lock()
c.swapping = true
c.mu.Unlock()
c.injectMu.Lock()
c.injectMu.Unlock() //nolint:staticcheck // barrier: waits for the injects in flight
defer func() {
c.mu.Lock()
c.swapping = false
c.mu.Unlock()
}()
if err := c.swapHarness(ctx); err != nil {
c.m.log.Error("session: the harness did not restart with the new host tools", "chat", c.id, "error", err)
// Go on without them; this ends the chat only if the plain restart fails too.
c.hostMu.Lock()
c.host.defs, c.host.cur, c.host.prompt, c.host.fp = nil, nil, "", fingerprint(nil, "")
c.hostMu.Unlock()
if err := c.restartHarness(ctx); err != nil {
return note, false, nil
}
return noteChatToolsFailed, false, nil
}
return note, refresh, nil
}
// cardSlotKey is the context key of the slot that SetToolCard fills.
type cardSlotKey struct{}
// cardSlot holds the card that one host tool call set.
type cardSlot struct {
mu sync.Mutex
card *ToolCard
files []ToolFile
more int
}
func (s *cardSlot) set(c ToolCard) { s.mu.Lock(); s.card = &c; s.mu.Unlock() }
func (s *cardSlot) setFiles(f []ToolFile) {
s.mu.Lock()
defer s.mu.Unlock()
s.files, s.more = append([]ToolFile(nil), f...), 0
if len(s.files) > MaxToolFiles {
s.files, s.more = s.files[:MaxToolFiles], len(s.files)-MaxToolFiles
}
}
// get returns the card of the call: the one the tool set, with the files on
// it. Files and no card make a FilesCardKind card.
func (s *cardSlot) get() *ToolCard {
s.mu.Lock()
defer s.mu.Unlock()
if len(s.files) == 0 {
return s.card
}
var c ToolCard
if s.card != nil {
c = *s.card
} else {
var newest int64
for _, f := range s.files {
newest = max(newest, f.Rev)
}
c = ToolCard{Kind: FilesCardKind, ID: strconv.FormatInt(newest, 10)}
}
c.Files, c.FilesMore = s.files, s.more
return &c
}
// SetToolCard is called by a host tool inside Run. It records the card for the
// call in progress: the chat puts it on the tool_end event and on the tool
// entry of that call. It does nothing outside a host tool's Run, and the card
// is used only when Run returns no error. A card whose Kind is not 1 to 32
// characters of [a-z0-9_], or whose ID is not 1 to 128 printable ASCII
// characters, is dropped and logged. The card is for the product's interface:
// the model never sees it and the tool text does not change.
func SetToolCard(ctx context.Context, c ToolCard) {
if s, ok := ctx.Value(cardSlotKey{}).(*cardSlot); ok {
s.set(c)
}
}
// SetToolFiles is called by a host tool inside Run, like SetToolCard, to put
// the user's files that the call changed on its card. It keeps the card the
// tool sets with SetToolCard (before or after), so a call can say both who
// served it and what it changed. A later call replaces the files; the first
// MaxToolFiles are kept and the rest counted. Files with a bad path or op are
// dropped when the card is checked.
func SetToolFiles(ctx context.Context, files []ToolFile) {
if s, ok := ctx.Value(cardSlotKey{}).(*cardSlot); ok {
s.setFiles(files)
}
}
// maxPendingCards bounds the cards that wait for their tool_end event.
const maxPendingCards = 64
// pendingCard is a successful host call whose tool_end event has not arrived
// yet. card is nil when the call set none (or a bad one): the slot still
// exists, so that the end of such a call cannot take the card of another call.
type pendingCard struct {
name, output string
card *ToolCard
}
// validCard tells whether c is within the documented limits.
func validCard(c ToolCard) bool {
if n := len(c.Kind); n < 1 || n > 32 {
return false
}
for i := 0; i < len(c.Kind); i++ {
if b := c.Kind[i]; !(b >= 'a' && b <= 'z' || b >= '0' && b <= '9' || b == '_') {
return false
}
}
if n := len(c.ID); n < 1 || n > 128 {
return false
}
for i := 0; i < len(c.ID); i++ {
if b := c.ID[i]; b < 0x20 || b > 0x7e {
return false
}
}
return true
}
// Limits of the app of a card.
const (
maxAppServer = 200
maxAppURI = 2048
maxAppInput = 16 << 10
maxAppResult = 256 << 10
)
// cleanCard returns a copy of c that is within the documented limits, and
// whether the card is valid at all. A card with an app whose reference is bad is
// invalid. An input or a result that is too long, or not JSON, is dropped and
// the app is marked cut: the reference is still of use.
func cleanCard(c ToolCard) (ToolCard, bool) {
if !validCard(c) {
return ToolCard{}, false
}
c.Files, c.FilesMore = cleanFiles(c.Files, c.FilesMore)
classifyCard(&c)
if c.App == nil {
return c, true
}
a := *c.App
if a.Server == "" || len(a.Server) > maxAppServer || len(a.Tool) > maxAppServer ||
!strings.HasPrefix(a.ResourceURI, "ui://") || len(a.ResourceURI) > maxAppURI {
return ToolCard{}, false
}
for _, r := range a.Server + a.Tool + a.ResourceURI {
if r < 0x21 && r != ' ' || r == 0x7f {
return ToolCard{}, false
}
}
a.Visibility = append([]string(nil), a.Visibility...)
if a.Input = bounded(a.Input, maxAppInput); a.Input == nil && c.App.Input != nil {
a.Cut = true
}
if a.Result = bounded(a.Result, maxAppResult); a.Result == nil && c.App.Result != nil {
a.Cut = true
}
c.App = &a
return c, true
}
// classifyCard puts the kind of each file on a card: the interface shows a
// working file apart from what the user asked for, and reads the kind from
// the card instead of guessing it from the path.
func classifyCard(c *ToolCard) {
for i := range c.Files {
c.Files[i].Kind = workfiles.Kind(c.Files[i].Path)
}
c.FileKind = ""
if c.Kind == ChangeCardKind {
if _, p, ok := strings.Cut(c.ID, ":"); ok && p != "" {
c.FileKind = workfiles.Kind(p)
}
}
}
// cleanFiles keeps the files of a card that have a usable path and op, at most
// MaxToolFiles. A dropped file is counted in more: the card still says that
// the call changed it.
func cleanFiles(in []ToolFile, more int) ([]ToolFile, int) {
if len(in) == 0 {
return nil, max(more, 0)
}
out := make([]ToolFile, 0, min(len(in), MaxToolFiles))
for _, f := range in {
ok := len(out) < MaxToolFiles && f.Path != "" && f.Path[0] == '/' && len(f.Path) <= maxToolFilePath &&
utf8.ValidString(f.Path) && f.Rev > 0 &&
(f.Op == ToolFileCreated || f.Op == ToolFileChanged || f.Op == ToolFileDeleted)
for _, r := range f.Path {
if r < 0x20 || r == 0x7f {
ok = false
break
}
}
if !ok {
more++
continue
}
out = append(out, f)
}
if len(out) == 0 {
out = nil
}
return out, max(more, 0)
}
// bounded returns raw when it is valid JSON of at most max bytes, else nil.
func bounded(raw json.RawMessage, max int) json.RawMessage {
if len(raw) == 0 || len(raw) > max || !json.Valid(raw) {
return nil
}
return append(json.RawMessage(nil), raw...)
}
// addPendingCard records a successful host tool call until the harness reports
// its end, with the card it set (nil when none). It logs a bad card without its
// contents and keeps the call with no card.
func (c *Chat) addPendingCard(name, output string, card *ToolCard) {
var keep *ToolCard
if card != nil {
if cp, ok := cleanCard(*card); ok {
keep = &cp
} else {
c.m.log.Warn("session: a host tool set an invalid card and it was dropped", "chat", c.id, "tool", name)
}
}
c.cardMu.Lock()
defer c.cardMu.Unlock()
if len(c.cards) >= maxPendingCards {
c.cards = append(c.cards[:0], c.cards[1:]...)
}
c.cards = append(c.cards, pendingCard{name: name, output: CapText(output, maxOutput), card: keep})
}
// takeCard removes the pending call of a tool_end and returns its card (nil
// when the call set none): the first call whose name and capped output match,
// else the oldest call of that name.
func (c *Chat) takeCard(name, output string) *ToolCard {
c.cardMu.Lock()
defer c.cardMu.Unlock()
pick := -1
for i, p := range c.cards {
if p.name != name {
continue
}
if p.output == output {
pick = i
break
}
if pick < 0 {
pick = i
}
}
if pick < 0 {
return nil
}
card := c.cards[pick].card
c.cards = append(c.cards[:pick], c.cards[pick+1:]...)
return card
}
// clearCards forgets the pending cards, at the start and the end of a turn.
func (c *Chat) clearCards() {
c.cardMu.Lock()
c.cards = nil
c.cardMu.Unlock()
}
// primeChatTools asks the ChatTools hook once before the harness starts, so a
// chat opens with its host tools and its first turn needs no restart. Mandatory
// failures prevent harness startup; optional failures are retried by the turn hook.
func (c *Chat) primeChatTools(ctx context.Context) error {
f := c.m.o.ChatTools
if f == nil {
return nil
}
c.accMu.RLock()
x := c.acc
c.accMu.RUnlock()
if scope := c.m.o.ProductScope; scope != nil {
var closeScope func()
ctx, closeScope = scope(ctx, x)
defer closeScope()
}
tt, err := callChatTools(ctx, f, x, c.m.log)
if mandatoryChatToolsError(err) {
return err
}
if err != nil || ctx.Err() != nil {
return nil
}
tools := acceptHostTools(tt.Tools, c.m.log, c.id, c.m.o.Sandbox != nil)
prompt := c.turnPrompt(ctx, tt, false)
cur := make(map[string]Tool, len(tools))
defs := make([]Tool, len(tools))
for i, t := range tools {
cur[t.Name] = t
defs[i] = Tool{Name: t.Name, Description: t.Description, Schema: t.Schema}
}
c.hostMu.Lock()
c.host.cur, c.host.defs, c.host.prompt, c.host.fp = cur, defs, prompt, fingerprint(tools, prompt)
if tt.RefreshKey != "" {
c.host.key = tt.RefreshKey
}
c.hostMu.Unlock()
return nil
}