mirror of
https://github.com/mudler/LocalAI.git
synced 2026-11-04 11:33:22 -05:00
The document scrolled again on the gallery. The screen-reader spans in the table rows are position: absolute, and nothing above them was positioned, so they resolved against the viewport, escaped the table scroller and the pinned shell, and stretched the document to about twice the window height. Make the table scroller and the full-height page the containing block, so the spans are clipped with the rows. The tabs and filters were also packed tight. Raise the view tabs to 40px with an accent underline on the current one, space the facet chips and toggles apart, give toggles, chips, density and state segments a hit area of at least 36px (40 to 44px on phones), and leave more air between the filter rows. Existing --dk-* tokens only. Add a spec that checks the document height equals the window height while the table still overflows. Assisted-by: Claude:claude-sonnet-5-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
102 lines
4.8 KiB
JavaScript
102 lines
4.8 KiB
JavaScript
import { test, expect } from './coverage-fixtures.js'
|
|
import { mockLedger } from './ledger-fixtures.js'
|
|
|
|
// The split view is meant to scroll inside itself. It is easy to regress into
|
|
// scrolling the document instead, because the shell's height rules are floors
|
|
// (min-height: 100dvh) rather than ceilings, so any tall pane silently grows
|
|
// the whole column and takes the rail with it.
|
|
// A description long enough that the detail pane must overflow, which is the
|
|
// only condition under which the bug shows.
|
|
const LONG = Array.from({ length: 60 }, (_, i) =>
|
|
`Paragraph ${i + 1}. This entry carries a long description so the detail pane has more content than the viewport can hold.`,
|
|
).join('\n\n')
|
|
|
|
const MOCK = {
|
|
models: [
|
|
{ name: 'long-model', description: LONG, backend: 'llama-cpp', installed: false, tags: ['llm'] },
|
|
{ name: 'short-model', description: 'Short.', backend: 'llama-cpp', installed: false, tags: ['llm'] },
|
|
],
|
|
allBackends: ['llama-cpp'], allTags: ['llm'],
|
|
availableModels: 2, installedModels: 0, totalPages: 1, currentPage: 1,
|
|
}
|
|
|
|
test.describe('Models Explore - the view scrolls, not the page', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.route('**/api/models*', (route) =>
|
|
route.fulfill({ contentType: 'application/json', body: JSON.stringify(MOCK) }))
|
|
await page.route('**/api/resources', (route) =>
|
|
route.fulfill({
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({ aggregate: { total_memory: 12 * 1024 ** 3, gpu_count: 1 } }),
|
|
}))
|
|
})
|
|
|
|
test('a long detail scrolls the pane and leaves the page height alone', async ({ page }) => {
|
|
await page.setViewportSize({ width: 1400, height: 900 })
|
|
await page.goto('/app/models')
|
|
await expect(page.locator('[data-testid="discover-rail-item"]').first()).toBeVisible({ timeout: 10_000 })
|
|
// Resources load independently of the gallery; the fits toggle takes a
|
|
// row from the rail, so include it before measuring selection's effect.
|
|
await expect(page.getByText('Fits in GPU', { exact: true })).toBeVisible()
|
|
|
|
const pageHeight = () => page.evaluate(() => document.documentElement.scrollHeight)
|
|
const railHeight = () => page.evaluate(
|
|
() => document.querySelector('.ledger-wrap')?.getBoundingClientRect().height,
|
|
)
|
|
|
|
const beforePage = await pageHeight()
|
|
const beforeRail = await railHeight()
|
|
|
|
await page.locator('[data-testid="discover-rail-item"]').first().click()
|
|
await expect(page.locator('[data-testid="discover-back"]')).toBeVisible()
|
|
|
|
// Selecting something must not make the document taller, and must not
|
|
// stretch the rail to match the pane.
|
|
expect(await pageHeight()).toBe(beforePage)
|
|
// Sub-pixel: layout can settle a fraction differently without the rail
|
|
// having grown. A pixel of tolerance keeps this about the bug it guards.
|
|
expect(Math.abs((await railHeight()) - beforeRail)).toBeLessThan(1)
|
|
|
|
// The pane is the thing that scrolls.
|
|
const paneOverflows = await page.evaluate(() => {
|
|
const el = document.querySelector('.ledger__pane')
|
|
return el ? getComputedStyle(el).overflowY : null
|
|
})
|
|
expect(paneOverflows).toBe('auto')
|
|
})
|
|
|
|
test('the document itself does not scroll while the table does', async ({ page }) => {
|
|
// Screen-reader spans inside the table are position: absolute. Without a
|
|
// positioned scroller above them they escape every clip and stretch the
|
|
// document, so the whole window scrolls instead of the table.
|
|
// The shared fixture has a gallery long enough to scroll its table.
|
|
await page.unroute('**/api/models*')
|
|
await mockLedger(page)
|
|
await page.setViewportSize({ width: 1440, height: 900 })
|
|
await page.goto('/app/models')
|
|
await expect(page.locator('[data-testid="discover-rail-item"]').first()).toBeVisible({ timeout: 10_000 })
|
|
|
|
const m = await page.evaluate(() => {
|
|
const doc = document.scrollingElement
|
|
const wrap = document.querySelector('.ledger-wrap')
|
|
return { docScroll: doc.scrollHeight, docClient: doc.clientHeight, wrapScroll: wrap.scrollHeight, wrapClient: wrap.clientHeight }
|
|
})
|
|
expect(m.docScroll).toBe(m.docClient)
|
|
expect(m.wrapScroll).toBeGreaterThan(m.wrapClient)
|
|
})
|
|
|
|
test('stacked below the breakpoint it scrolls with the document again', async ({ page }) => {
|
|
// Pinning the height when the columns stack would trap both halves in short
|
|
// scrollers, so the constraint is lifted there on purpose.
|
|
await page.setViewportSize({ width: 700, height: 800 })
|
|
await page.goto('/app/models')
|
|
await expect(page.locator('[data-testid="discover-rail-item"]').first()).toBeVisible({ timeout: 10_000 })
|
|
|
|
const overflow = await page.evaluate(() => {
|
|
const el = document.querySelector('.ledger__pane')
|
|
return el ? getComputedStyle(el).overflowY : null
|
|
})
|
|
expect(overflow).toBe('visible')
|
|
})
|
|
})
|