mirror of
https://github.com/mudler/LocalAI.git
synced 2026-07-31 10:28:43 -04:00
ff299df453
Three measured HTTP-layer regressions on a live deployment, fixed together
because they all shape the bytes on the wire.
1. No compression. The server sent no Content-Encoding regardless of what
the client asked for, confirmed with curl straight at 127.0.0.1:8080 so
it was not an ingress artefact. Adds gzip middleware, on by default and
configurable via LOCALAI_DISABLE_HTTP_COMPRESSION and
LOCALAI_HTTP_COMPRESSION_MIN_LENGTH (default 1024 bytes so tiny bodies
are not wastefully wrapped). Streaming routes are skipped explicitly:
an SSE Accept header, a WebSocket upgrade, and the completion / SSE /
log-tail path prefixes, because whether a completion request streams is
decided by the request body, which the middleware runs too early to see.
Already-compressed formats (woff2, png, mp4, ...) are skipped too; gzip
made those marginally larger. Measured over the embedded React build:
JS+CSS 2815 KB raw to 808 KB gzipped (3.48x).
2. No cache headers on content-hashed assets. Vite hashes the filenames,
so a given /assets/ URL can never change content, yet they shipped with
no Cache-Control, ETag or Last-Modified, and the browser re-fetched the
whole bundle on every navigation with no conditional request available.
/assets/* now carries public, max-age=31536000, immutable. index.html
stays no-cache so a deploy is picked up, and the unhashed locale JSONs
get a short TTL rather than the immutable one.
3. Unbounded trace endpoints. /api/traces returned 21,033,606 bytes in
4.65s and /api/backend-traces 3,471,682 bytes in 1.50s, and the admin
UI polls both every few seconds. The ring buffer holds up to 1024
entries, each embedding full input_text payloads. Both list endpoints
now take limit / offset / full, default to 50 entries, and strip the
heavy fields (request and response bodies plus headers for API traces,
body and data for backend traces) unless full=true. Every trace gets a
process-lifetime ID and GET /api/traces/{id} and
/api/backend-traces/{id} serve the full record, which is what the UI
fetches when a row is expanded. The list body stays a JSON array;
paging metadata rides in X-Total-Count, X-Trace-Offset and
X-Trace-Limit. Reproducing the live shape in a test, the polled payload
goes from 21,131,097 bytes to 7,201 bytes.
Assisted-by: Claude:claude-opus-4-8 [Claude Code]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
45 lines
1.8 KiB
JavaScript
45 lines
1.8 KiB
JavaScript
import { test, expect } from './coverage-fixtures.js'
|
|
|
|
// Pin the API-trace metadata surface (issues #10886 / #10887): the API
|
|
// traces table exposes the requesting user in a dedicated column, and the
|
|
// expanded row detail lists User, Client IP and User Agent so an operator
|
|
// can tell who/what issued each request.
|
|
test.describe('Traces - API request metadata', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.route('**/api/traces?*', (route) => {
|
|
route.fulfill({
|
|
contentType: 'application/json',
|
|
body: JSON.stringify([
|
|
{
|
|
request: { method: 'POST', path: '/v1/chat/completions' },
|
|
response: { status: 200 },
|
|
user_id: 'user-123',
|
|
user_name: 'alice',
|
|
client_ip: '203.0.113.7',
|
|
user_agent: 'curl/8.4.0',
|
|
},
|
|
]),
|
|
})
|
|
})
|
|
await page.route('**/api/backend-traces?*', (route) => {
|
|
route.fulfill({ contentType: 'application/json', body: '[]' })
|
|
})
|
|
await page.goto('/app/traces')
|
|
await expect(page.locator('text=Tracing is')).toBeVisible({ timeout: 10_000 })
|
|
})
|
|
|
|
test('shows the User column value in the API traces table', async ({ page }) => {
|
|
await expect(page.locator('th', { hasText: 'User' })).toBeVisible()
|
|
await expect(page.locator('td', { hasText: 'alice' }).first()).toBeVisible()
|
|
})
|
|
|
|
test('expands the row to reveal Client IP and User Agent', async ({ page }) => {
|
|
await page.locator('tr', { hasText: '/v1/chat/completions' }).first().click()
|
|
|
|
await expect(page.locator('text=Client IP').first()).toBeVisible()
|
|
await expect(page.locator('text=203.0.113.7').first()).toBeVisible()
|
|
await expect(page.locator('text=User Agent').first()).toBeVisible()
|
|
await expect(page.locator('text=curl/8.4.0').first()).toBeVisible()
|
|
})
|
|
})
|