mirror of
https://github.com/mudler/LocalAI.git
synced 2026-08-03 12:00:43 -04:00
* chore(deps): bump cogito to v0.11 ahead of the nib harness nib is the agent harness that becomes 'local-ai chat'. It requires cogito v0.11, so pull that bump forward on its own: minimal version selection would apply it to LocalAI anyway, and both repos use cogito and cogito/clients. Landing it separately keeps the harness change reviewable. nib itself is not pinned yet. Nothing in LocalAI imports it, and 'go mod tidy' runs as a goreleaser before-hook in CI, so an unimported require line does not survive. It lands with its first importer. No LocalAI call site needed a change. Both cogito.WithMaxAttempts callers guard the argument above zero, so v0.11's new clamp is unreachable, and LocalAI's Multimedia values implement only URL(), so v0.11's new TypedMultimedia routing treats them as images exactly as v0.10 did. Binary size (cmd/local-ai): 200,301,381 -> 200,336,045 bytes (+34,664). A throwaway probe that links nib measured 201,042,243 bytes (+740,862 over the pre-change baseline). Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(chat): resolve and seed the agent state directory Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): write the agent config atomically and tighten its modes Replacing config.yaml in place truncated it first, so an interrupted write would have destroyed the api_key nib keeps in the same file. Stage through a sibling temp file and rename over the target instead, and match nib's 0700 directory mode. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(chat): probe the endpoint and classify failures Probe lists what a LocalAI endpoint advertises and separates the two failures that need different advice: nothing listening, and rejected credentials. go-openai reports a rejected key as one of two concrete types depending on the error body, and both occur against a real LocalAI. The normal error handler sends an OpenAI error envelope, which arrives as *openai.APIError; the opaque-errors handler replies with a bare status and no body, which arrives as *openai.RequestError. Classifying on only one of them misses half the cases, so the status is read from either. A cancelled probe is not reported as an unreachable server, because it learned nothing about the endpoint, and neither is a reply that could not be parsed, because something did answer. Both would otherwise send the user off to start a server that may already be running. The model list is returned verbatim and in server order. LocalAI lists whatever it finds in the models directory, including stray archives and dotfiles, and deciding which advertised ids are real belongs to whoever presents them. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(chat): resolve the model from flag, config, or the server Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(chat): pin that model resolution sorts a copy of the caller's slice The sort spec asserted only on what the chooser was offered, so replacing the defensive copy with an in-place sort of req.Available still passed all 37 specs. Assert the input slice's order after the call, so the guarantee cannot be dropped silently by a later refactor. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(chat): offer to start a server when none is reachable Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): bound the server wait and pin readiness and stop semantics Set cmd.WaitDelay so a backend subprocess holding the child's stderr pipe cannot block cmd.Wait forever, which would leave exited unclosed, burn the whole shutdown grace on a clean exit, and leak the waiter goroutine. Two test gaps closed alongside it: the readiness spec now counts polls, so treating 503 as ready is observable, and Stop's single-interrupt contract is pinned by giving StartedServer interrupt/kill hooks that a spec can count. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(chat): drive Stop through one process interface, hide exec plumbing Two independent interrupt/kill func fields plus a nil check admitted wirings no test could distinguish: the pair swapped, so a SIGKILL would strand the backends SIGINT exists to let local-ai run clean up, or kill left nil, so a wedged server never escalates. One two-method interface that *os.Process already satisfies leaves nothing to swap and nothing to nil. Also translate exec.ErrWaitDelay, whose text names an os/exec struct field, into what the user can act on. os/exec only substitutes that sentinel when the process exited without an error of its own, so no exit status is swallowed. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(chat): replace the REPL with the built-in agent local-ai chat is now the nib agent harness compiled into the binary: tool use behind an approval gate, sub-agents, MCP, plugins, and skills, all auto-configured against the local server. The REPL goes with it. Its model listing and its 401 classifier were duplicates of the ones Probe now owns, and the classifier was the version that misreads a bare 401 with no OpenAI error envelope, so keeping either would leave the package with two divergent answers to the same question. github.com/mudler/nib lands in go.mod in this commit rather than earlier: go mod tidy runs as a goreleaser before-hook on every PR, so a require line with no importer is stripped before it reaches CI. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(chat): split the pre-agent phase out of Run and pin it Everything before the handoff is testable and nothing after it is: once app.Run owns the terminal there is no seam left. prepare draws that line, takes interactivity as a parameter so the prompts can be driven over a pipe, and hands Run the state dir, the model, and any server it started. The questions move onto one prompter that owns its buffered reader. A fresh bufio.Reader per question reads ahead and discards what it buffered, so the model choice typed behind an answer to "start a server?" was lost and the next question saw EOF. choose answers with a list index and refuses an empty offer, so a value that was never on the list cannot reach ResolveModel, which persists it and starts every later run against it. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): bound each server check with a deadline Nothing bounded the model listing, so pointing chat at an address that accepts the connection and then never replies left the user with no output and no offer to start a server. The budget is context.WithTimeout rather than a cancel plus a timer. Probe deliberately refuses to call an endpoint unreachable on a context.Canceled, since a caller who gave up learned nothing about the server, and only honours a deadline. A cancel-based budget therefore expires as the one error that suppresses ErrUnreachable, exactly for the hung servers the offer exists to rescue. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): tell the user when their model choice cannot be saved The choice is meant to be asked for once. When saving it fails the user is silently asked again on the next run, and the only trace was an xlog.Warn: the agent runs at log level error, and a --log-level=error run swallows it entirely. ModelRequest gains Notify for exactly this class of problem, one that is worth telling the user about but not worth failing over, and the chat wiring points it at the same writer the question was asked on. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): stop a session's server when the process is signalled A server started for the session is stopped by a deferred call, and a signal skips deferred calls: a SIGTERM between the spawn and the exit left 'local-ai run' reparented to init with nothing left that knew to shut it down. Ctrl+C was already safe, but only incidentally, because the child shares this process' foreground process group. A signal handler rather than Pdeathsig on the child. Pdeathsig is Linux-only and, in Go, is delivered when the OS thread that forked exits rather than when the process does, so it can fire on a healthy parent. Setpgid would break the Ctrl+C that works today by taking the child out of the foreground group. SIGHUP joins SIGINT and SIGTERM: a terminal program whose terminal is gone has nobody left to talk to. The same context is what cancels the agent, which nib leaves to its embedder. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): only skip the server checks for work that stays local Two argument shapes were classified wrongly. Every 'mcp ...' invocation counted as management, so 'local-ai chat mcp --stdio', which serves the agent over MCP and needs a model like any other session, was handed an empty one. And --init, whose shell snippet a user pastes into an rc file long before any server exists, went the other way: it demanded a running server to print a static string. The mcp split is asked of nib's own IsMCPManageSubcommand rather than restated here, so a verb added upstream cannot drift out of this list. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): exit with the agent's status instead of reporting it twice nib writes what went wrong to stderr and returns nothing but an exit code, so returning that error unchanged had main log "Error running the application error=exit status 1" underneath the message the user had just read. The refusal to render the full-screen interface into a pipe is the one they meet in practice: it names --cli, and burying that hides the fix. ExitCodeError says "already reported, exit with this status". main honours it and prints nothing more, so a piped or redirected chat still fails a script the way it should. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * style(chat): route interactive chatter through one writer helper The prompts and notices all write to a terminal, where a failed write is not worth failing the session over and the read that follows the question reports the real problem. say says that once instead of five discarded error returns. The command's one-line help comes along: chat is no longer "an interactive chat session". Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(chat): record why the agent gets this process' streams Injecting them is what makes nib refuse to draw its full-screen interface into a pipe and name --cli, instead of rendering onto a terminal the caller may not own. The tradeoff is worth stating where the wiring is. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): stop the session's server on cancellation, not on the way out The deferred Stop is reached only if the agent returns, and cancelling the context does not make it: nib hands the TUI to bubbletea without the context, so what actually unwinds a running session today is bubbletea's own SIGINT and SIGTERM handler. SIGHUP has no such backstop, and registering for it removed the default disposition that used to end the process outright, so kill -HUP left a live TUI with a cancelled context and the started server still running. runSession watches the context alongside the agent and stops the server the moment it is cancelled, so the guarantee no longer depends on what the agent does with cancellation. Stop is idempotent, so the deferred call stays correct and free. The doc comment on shutdownContext described the mechanism it was supposed to work by rather than the one that does. Corrected, bubbletea's handler included. ResolveModel now checks the chooser's answer against what it offered. The shipped chooser answers by list index and cannot be wrong, but ModelChooser is exported, the answer is persisted, and every later run starts against it, so the invariant belongs at the consumer. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * chore(chat): bump nib to v0.5.1 v0.5.1 carries four fixes that matter to 'local-ai chat': - --init now names the embedder's command, so the emitted widget invokes 'local-ai chat' rather than a bare 'nib' the user does not have. - A piped CLI session that succeeds exits 0 instead of failing with EOF. - EOF at a tool-approval prompt denies the call rather than approving it, and the session exits 3 (app.ExitCodeApprovalNoInput) so a script can tell "answered" from "refused to act" without reading stdout. Read-only tools are unaffected and still run. ExitStatus already unwraps app.ExitError, so the code propagates with no change here. - RunTUI passes the context to bubbletea and gives up bubbletea's own signal handler, which makes shutdownContext the single owner of the signal and stops a SIGHUP leaving a wedged TUI behind. Verified against a live server on 127.0.0.1:8080: the three --init shells, a piped prompt exiting 0, a denied 'touch' that left no file and exited 3, a read-only 'ls' that still ran and exited 0, and a SIGHUP that unwound a TUI running under a pty. Two comment blocks in run.go described the old TUI behavior and are now wrong, so they are corrected in the same change. No behavior change: both shutdownContext and runSession are untouched, and stopping the server on cancellation is still worth keeping independent of how promptly nib unwinds. One known gap, not addressed here. The widget --init now emits runs 'output=$(local-ai chat --height 50%)', and runAgent injects Stdout unconditionally, so under $(...) nib refuses the TUI for a non-terminal stream. This is the cost the runAgent comment already anticipated, now that the snippets no longer hardcode standalone nib. Ctrl+Space should not be documented until that is decided. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): let nib own stdout, so the Ctrl+Space widget works The widget 'local-ai chat --init' emits runs 'output=$(local-ai chat --height 50%)', which puts a pipe on stdout by construction. runAgent injected os.Stdout unconditionally, and nib refuses every mode but --cli when a stream it was handed is not a terminal, so Ctrl+Space printed "Re-run with --cli to use the injected streams" and inserted nothing. Verified against a pty before and after. nib reads a nil stream as "not injected" and falls back to the process stream, which is how an embedder asks for nib's own behavior. That is what stdout needs: the interface renders on /dev/tty but writes the chosen command to stdout even when stdout is a pipe, and that write is the whole of the shell-capture idiom. Stdin is deliberately left injected. A piped or redirected stdin really is ignored by the interface, so the refusal is the honest answer there, and it is the one users meet: 'echo q | local-ai chat' still says to re-run with --cli, once, exit 1. Nilling stdin the way stdout is nilled would delete that silently. Stderr is not gated by nib at all and is unchanged. One case does change and cannot be kept: 'local-ai chat > out.txt' from a terminal no longer refuses, because it is indistinguishable from the widget. It renders on /dev/tty and writes the capture line to the file, which is what standalone nib does. The app.Options literal moves into agentOptions so the decision is reachable from a spec rather than being a detail of a function that takes the terminal. Both sides of the asymmetry are pinned: reinstating 'Stdout: opts.Out' fails "hands nib nothing for the process stdout", and nilling stdin fails "hands the process stdin over". Also rewrites the last comments describing the pre-v0.5.1 behavior. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(chat): say what the stream refusal actually keys on Two comments still called it the refusal to render the interface "into a pipe". That was true when both stdin and stdout were injected, but a pipe on stdout no longer refuses, so the wording now points at precisely the case that was un-refused to make Ctrl+Space work. Only a stdin that cannot be read triggers it, and both comments now say so and name the command a user meets it with, 'echo q | local-ai chat'. The agentOptions doc also said a "file a caller chose" stays injected and refused, which reads as though 'local-ai chat > out.txt' still refuses. It does not: a shell redirect arrives as os.Stdout and is nil-ed like the widget's pipe, because the two differ only in being a regular file rather than a FIFO and nib's gate does not look at that. What stays injected is a writer an in-process caller chose for itself. Says that now, in the doc and in the spec comment that had the same ambiguity. Comments only. No behavior change. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs: local-ai chat is now the built-in terminal agent `local-ai chat` was a plain chat prompt and is now an agent that runs shell commands behind an approval gate, so the pages that described a REPL were wrong rather than merely thin. Adds a Terminal agent feature page at /features/terminal-agent covering the approval gate, piped runs and their exit codes, Ctrl+Space, model resolution, state directory, and the pass-through management commands (including the `--yes` caveat that leaves a plugin installed but disabled in a script). The three-way "looking for something else" notice becomes four-way and moves into an agentic-routing shortcode. Four hand-kept copies of the same paragraph is what produced the drift the new page would otherwise have added to; the shortcode takes `current=` so each page still marks itself, and errors the build on a name that is not one of the four. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * website: the agent is in the binary, not a second install The nib section sold a separate tool you also install, with a GitHub link as the only way in, which is now the wrong order: the agent ships compiled into local-ai, and the standalone binary is the second reason to care rather than the first. Leads with `local-ai chat`, keeps nib as the SSH-anywhere story, and adds a docs CTA pointing at the new Terminal agent page. id="nib" is left alone because localai.io/#nib is linked from outside. The two credits on the demo clip named nib as the thing that drove the machine; they now credit the agent in LocalAI, which is the same agent. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * website: fix the exit keys, the plugin warning, and the redirect gap Three claims on the chat-agent pages that the code does not back. try-it-out told readers to press Ctrl+D. nib has no Ctrl+D handler: the full-screen interface quits on Esc or Ctrl+C, and Ctrl+D is only an exit in --cli, where it arrives as ordinary tty EOF. That sentence had replaced the removed /exit and /quit text, so the page was left with no working way to leave a session. Document both modes, since they differ. The plugin warning said nothing tells you the install stopped short. It does: the command prints that the plugin was left disabled. What it does not do is say so in its exit code, which is 0 either way. That is the part a script cannot work around, and it is the reason to pass --yes. Overstating it in the paragraph that gives the advice only makes the advice easier to dismiss. Redirecting stdout no longer refuses; the interface goes to /dev/tty and only the yanked command reaches the file. It is what lets the Ctrl+Space widget capture a command at all, since a redirect and out=$(...) are the same thing to the stream gate. It was documented nowhere. A non-terminal stdin is still refused, and the new text says which of the two it is. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): make the CLI flags outrank the agent config file local-ai chat routed --endpoint, --model, --api-key, --trace-dir and --yolo through nib's app.Options.Defaults. Defaults are seeds: they sit beneath the config file, so the file silently undoes them. That made the flags accepted and inert, and not in an edge case, since EnsureStateDir writes base_url on the first run and the interactive picker writes model, so from the second run on the file carried a value for both. Observed against a live server: with base_url: http://127.0.0.1:9999/v1 in the config and --endpoint http://127.0.0.1:8080 on the command line, the probe hit 8080 and every agent turn posted to 9999. With model: gemma-4-e2b-it-qat-q4_0 in the config, --model lfm2.5-8b-a1b was ignored on the wire. nib v0.6.0 adds app.Options.Overrides, applied above the config file and above the bare environment block. Move the whole block there: all five values are decisions this invocation already made on the user's behalf, and a flag the config file can undo is not a flag. Nothing is left in Defaults, because LocalAI's one genuine seed, the initial base_url, is written into the config file by EnsureStateDir rather than handed to nib. Two limits come with the channel and are documented on agentOptions rather than worked around. An override can only raise a field, since nib cannot tell "set to the zero value" from "not set", so --yolo can turn approval off but nothing on the command line turns it back on over an approval_mode: auto in the file. And nib's own NIB_TRACE_DIR and NIB_YOLO are resolved after the config load and still outrank these, deliberately, upstream. The existing spec pinned that the right values reach app.Options, which they always did, which is exactly why it could not see nib discarding them. The new specs resolve the config the way app.Run resolves it, against a real config file that disagrees with every flag, and one asserts Defaults stays empty. docs/content/features/terminal-agent.md already documented --model as winning over the saved model; that was false before this change and is true now, so no docs edit was needed. Assisted-by: Claude Code:claude-opus-5 [Bash] [Edit] [Write] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): document intentional config file read Assisted-by: Codex:gpt-5 [gosec] --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: localai-org-maint-bot <306269227+localai-org-maint-bot@users.noreply.github.com>
277 lines
10 KiB
Go
277 lines
10 KiB
Go
package chat
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/mudler/LocalAI/pkg/httpclient"
|
|
)
|
|
|
|
// ErrDeclined means no server was started, either because the session is not
|
|
// interactive or because the user said no.
|
|
var ErrDeclined = errors.New("no server started")
|
|
|
|
// errServerExited means the process we spawned died before it ever reported
|
|
// ready, so there is no point in polling out the rest of the budget.
|
|
var errServerExited = errors.New("the LocalAI server exited before it became ready")
|
|
|
|
const (
|
|
// defaultReadyTimeout bounds the wait for a freshly spawned server. A cold
|
|
// start probes hardware and may pull a backend, so the budget is generous.
|
|
defaultReadyTimeout = 2 * time.Minute
|
|
// readyPollInterval is how long to wait between readiness polls.
|
|
readyPollInterval = 500 * time.Millisecond
|
|
// readyProbeTimeout bounds a single readiness request, so one connection
|
|
// that hangs cannot swallow the whole budget.
|
|
readyProbeTimeout = 5 * time.Second
|
|
// shutdownGrace is how long a server we started gets to unload models and
|
|
// stop its backends after SIGINT before it is killed outright.
|
|
shutdownGrace = 10 * time.Second
|
|
// childOutputDrainDelay bounds how long cmd.Wait keeps copying the child's
|
|
// output after the child itself has exited.
|
|
//
|
|
// This is not a theoretical guard for LocalAI. 'local-ai run' spawns backend
|
|
// subprocesses, and they inherit the write end of the pipe exec created for
|
|
// the child's stderr. A backend that outlives its parent holds that pipe
|
|
// open, so an unbounded cmd.Wait would block on the copy goroutine long
|
|
// after the server itself is gone: exited would never close, Stop would burn
|
|
// its whole grace period even on a clean shutdown, and the waiter goroutine
|
|
// would leak.
|
|
//
|
|
// The value is long enough that a legitimate final burst of logs is never
|
|
// truncated even on a loaded machine, where the copy itself takes
|
|
// microseconds. It must stay strictly below shutdownGrace: at or above it,
|
|
// every wedged-pipe shutdown would exhaust the grace period and then SIGKILL
|
|
// a process that had already exited cleanly.
|
|
childOutputDrainDelay = 5 * time.Second
|
|
)
|
|
|
|
// Confirmer asks a yes/no question. Nil means the session is not interactive.
|
|
type Confirmer func(question string) (bool, error)
|
|
|
|
// StartOptions configures OfferToStart.
|
|
type StartOptions struct {
|
|
// Endpoint is the address the user expected a server on, used in the
|
|
// question and polled for readiness. This is the endpoint root, not the
|
|
// /v1 API base URL: readiness is served at the root.
|
|
Endpoint string
|
|
// Confirm asks whether to start a server. Nil means never start.
|
|
Confirm Confirmer
|
|
// Stderr receives the child's output.
|
|
Stderr io.Writer
|
|
// Executable overrides the binary to run. Empty means os.Executable().
|
|
Executable string
|
|
// ReadyTimeout bounds the wait for readiness. Zero means defaultReadyTimeout.
|
|
ReadyTimeout time.Duration
|
|
}
|
|
|
|
// StartedServer is a server this process started and is responsible for.
|
|
type StartedServer struct {
|
|
// exited is closed once the child has been reaped. One background waiter
|
|
// owns cmd.Wait: it may only be called once, and it is what closes the
|
|
// pipes exec created for Stdout/Stderr and joins the goroutines copying
|
|
// them, so calling os.Process.Wait directly instead would leak both.
|
|
exited chan struct{}
|
|
// waitErr is the child's exit status. It is written before exited is
|
|
// closed and must only be read after that channel is observed closed.
|
|
waitErr error
|
|
|
|
// proc is the child. It is an interface rather than *os.Process so that
|
|
// Stop's contract, in particular that the child is asked to stop exactly
|
|
// once however often Stop is called, can be pinned without a live process
|
|
// to signal. Nil means nothing was ever started.
|
|
proc processControl
|
|
|
|
stopOnce sync.Once
|
|
}
|
|
|
|
// processControl is the part of *os.Process that Stop needs.
|
|
//
|
|
// One interface rather than a pair of independent function fields: two fields
|
|
// can be wired to each other's operation, or one left nil, and no test can tell,
|
|
// because a fake satisfies any combination. There is nothing to swap or forget
|
|
// here, since the sole implementation is the real process and the method names
|
|
// carry the meaning.
|
|
type processControl interface {
|
|
Signal(os.Signal) error
|
|
Kill() error
|
|
}
|
|
|
|
// *os.Process satisfies processControl unmodified, so production needs no
|
|
// adapter and no nil branch: the wiring is a single assignment.
|
|
var _ processControl = (*os.Process)(nil)
|
|
|
|
// newServerCommand builds the child process. Split out from OfferToStart so the
|
|
// process' configuration can be asserted on without spawning anything.
|
|
func newServerCommand(bin string, stderr io.Writer) *exec.Cmd {
|
|
cmd := exec.Command(bin, "run")
|
|
// Stdin is left nil, so the child gets /dev/null: it is a background
|
|
// server, and sharing the terminal would have it stealing keystrokes from
|
|
// the agent.
|
|
cmd.Stdout = stderr // the child's logs are diagnostics, not chat output
|
|
cmd.Stderr = stderr
|
|
// Bound the wait for the child's output pipes; see childOutputDrainDelay.
|
|
cmd.WaitDelay = childOutputDrainDelay
|
|
return cmd
|
|
}
|
|
|
|
// OfferToStart asks whether to start a LocalAI server and, if allowed, spawns
|
|
// one and waits for it to report ready.
|
|
//
|
|
// A child process rather than an in-process boot: RunCMD.Run installs its own
|
|
// signal handling and blocks until shutdown, so re-entering it from a chat
|
|
// session would entangle two lifecycles in one process.
|
|
func OfferToStart(ctx context.Context, opts StartOptions) (*StartedServer, error) {
|
|
if opts.Confirm == nil {
|
|
// Not interactive. Spawning a server nobody asked for is the one thing
|
|
// this function must never do: in CI, in a pipeline, or under a
|
|
// supervisor there is no one to see it or shut it down.
|
|
return nil, ErrDeclined
|
|
}
|
|
ok, err := opts.Confirm(fmt.Sprintf("No LocalAI server at %s. Start one now?", opts.Endpoint))
|
|
if err != nil {
|
|
return nil, fmt.Errorf("asking whether to start a server: %w", err)
|
|
}
|
|
if !ok {
|
|
return nil, ErrDeclined
|
|
}
|
|
|
|
bin := opts.Executable
|
|
if bin == "" {
|
|
if bin, err = os.Executable(); err != nil {
|
|
return nil, fmt.Errorf("locating the local-ai binary: %w", err)
|
|
}
|
|
}
|
|
|
|
cmd := newServerCommand(bin, opts.Stderr)
|
|
if err := cmd.Start(); err != nil {
|
|
return nil, fmt.Errorf("starting a LocalAI server with %s: %w", bin, err)
|
|
}
|
|
|
|
s := &StartedServer{exited: make(chan struct{}), proc: cmd.Process}
|
|
go func() {
|
|
s.waitErr = cmd.Wait()
|
|
close(s.exited)
|
|
}()
|
|
|
|
timeout := opts.ReadyTimeout
|
|
if timeout <= 0 {
|
|
timeout = defaultReadyTimeout
|
|
}
|
|
if err := waitReady(ctx, opts.Endpoint, timeout, s.exited); err != nil {
|
|
if errors.Is(err, errServerExited) {
|
|
// Safe to read: errServerExited is only returned once exited has
|
|
// been observed closed, which happens after waitErr is written.
|
|
err = describeExit(err, s.waitErr)
|
|
}
|
|
s.Stop()
|
|
return nil, fmt.Errorf("%w. Run 'local-ai run' in another terminal to see why it did not come up", err)
|
|
}
|
|
return s, nil
|
|
}
|
|
|
|
// describeExit adds what is known about how the child died to exitErr, without
|
|
// putting os/exec's plumbing in front of the user.
|
|
//
|
|
// waitErr is exec.ErrWaitDelay when the child exited cleanly but something it
|
|
// spawned still held its output pipe open past childOutputDrainDelay. The
|
|
// sentinel's own text names the WaitDelay field, which is meaningless to a
|
|
// user, so it is translated. Nothing is swallowed: os/exec only substitutes
|
|
// ErrWaitDelay when the process itself exited without an error of its own (see
|
|
// Cmd.Wait, "Report an error from the copying goroutines only if the program
|
|
// otherwise exited normally"), so it can never stand in for an *ExitError.
|
|
func describeExit(exitErr, waitErr error) error {
|
|
switch {
|
|
case waitErr == nil:
|
|
return exitErr
|
|
case errors.Is(waitErr, exec.ErrWaitDelay):
|
|
return fmt.Errorf("%w, and left a subprocess of its own still running", exitErr)
|
|
default:
|
|
return fmt.Errorf("%w: %w", exitErr, waitErr)
|
|
}
|
|
}
|
|
|
|
// Stop terminates the server this process started, giving it a chance to shut
|
|
// down cleanly first. It is safe to call on a nil or never-started server, and
|
|
// safe to call more than once.
|
|
func (s *StartedServer) Stop() {
|
|
if s == nil || s.proc == nil {
|
|
return
|
|
}
|
|
s.stopOnce.Do(func() {
|
|
// SIGINT rather than SIGKILL: local-ai run installs its own handler and
|
|
// needs it to unload models and stop backend subprocesses. Killing it
|
|
// outright would strand those children.
|
|
_ = s.proc.Signal(os.Interrupt)
|
|
|
|
select {
|
|
case <-s.exited:
|
|
case <-time.After(shutdownGrace):
|
|
// It ignored the interrupt or wedged on the way down. The user is
|
|
// waiting on their shell prompt, so stop being polite.
|
|
_ = s.proc.Kill()
|
|
}
|
|
})
|
|
}
|
|
|
|
// waitReady polls the endpoint's /readyz until the server reports ready, the
|
|
// budget expires, the caller gives up, or exited signals that the process we
|
|
// are waiting on is gone. A nil exited channel means there is no process to
|
|
// watch.
|
|
//
|
|
// Readiness lives on the endpoint ROOT, not under the /v1 API base URL, and it
|
|
// answers 503 for as long as startup is still in progress.
|
|
func waitReady(ctx context.Context, endpoint string, timeout time.Duration, exited <-chan struct{}) error {
|
|
url := strings.TrimSuffix(endpoint, "/") + "/readyz"
|
|
|
|
// A real deadline rather than context.WithCancel plus a timer: the latter
|
|
// expires as context.Canceled, which every classifier here reads as "the
|
|
// caller gave up" rather than "the endpoint never answered".
|
|
waitCtx, cancel := context.WithTimeout(ctx, timeout)
|
|
defer cancel()
|
|
|
|
client := httpclient.NewWithTimeout(readyProbeTimeout)
|
|
ticker := time.NewTicker(readyPollInterval)
|
|
defer ticker.Stop()
|
|
|
|
for {
|
|
select {
|
|
case <-exited:
|
|
return errServerExited
|
|
case <-waitCtx.Done():
|
|
// Distinguish our budget from the caller's: only ours is advice
|
|
// about the server.
|
|
if err := ctx.Err(); err != nil {
|
|
return err
|
|
}
|
|
return fmt.Errorf("the LocalAI server did not become ready within %s", timeout)
|
|
case <-ticker.C:
|
|
}
|
|
|
|
req, err := http.NewRequestWithContext(waitCtx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("building the readiness request for %s: %w", url, err)
|
|
}
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
continue // nothing listening yet
|
|
}
|
|
// Drain before closing so the next poll can reuse the connection
|
|
// instead of opening a socket every 500ms for two minutes.
|
|
_, _ = io.Copy(io.Discard, resp.Body)
|
|
_ = resp.Body.Close()
|
|
if resp.StatusCode == http.StatusOK {
|
|
return nil
|
|
}
|
|
// Anything else means startup is still in progress; keep polling.
|
|
}
|
|
}
|