Files
LocalAI/core/config/model_artifact_inference.go
mudler's LocalAI [bot] 2dade4a9f9 fix(model-artifacts): gate inferred artifact materialization by backend (#10910)
The managed-artifact materializer stages a HuggingFace snapshot into a
directory (.artifacts/huggingface/<key>/snapshot/). That is the right load
target for directory-consuming backends (transformers, vLLM, diffusers, ...),
but PrimaryArtifactSpec inferred a managed artifact from ANY HuggingFace-shaped
model reference regardless of backend. A single-file backend such as llama.cpp
or whisper was therefore handed the snapshot directory instead of the weight
file and failed to load it.

The /import-model importer already guards this with a backend allow-list
(managedArtifactBackends), but the loader-side inference did not. Move the
allow-list into core/config as IsManagedArtifactBackend and apply it in
PrimaryArtifactSpec: only directory-consuming backends may have an artifact
inferred from a bare reference; every other backend stays on the legacy
download-to-file path. An explicit artifacts: block still bypasses the gate,
where single-file snapshot resolution handles the load path.

The importer now shares the same predicate, so both paths agree on which
backends auto-materialize.

Assisted-by: Claude:opus-4.8 [Claude Code]

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
2026-07-17 23:26:23 +00:00

91 lines
3.3 KiB
Go

package config
import (
"fmt"
"os"
"path/filepath"
"strings"
"github.com/mudler/LocalAI/pkg/modelartifacts"
)
// managedArtifactBackends is the set of backends that load a model from a
// snapshot *directory* (a HuggingFace repo consumed as a folder of weights,
// config, and tokenizer files). Only these backends may have a managed
// artifact *inferred* from a bare model reference: single-file backends such
// as llama.cpp or whisper would otherwise be handed the snapshot directory
// instead of the weight file and fail to load it. The importer relies on the
// same gate, so both paths agree on which backends auto-materialize.
var managedArtifactBackends = map[string]struct{}{
"transformers": {}, "huggingface-embeddings": {}, "sentencetransformers": {},
"transformers-musicgen": {}, "mamba": {}, "diffusers": {}, "qwen-asr": {},
"fish-speech": {}, "nemo": {}, "voxcpm": {}, "qwen-tts": {},
"liquid-audio": {}, "vllm": {}, "vllm-omni": {}, "sglang": {},
}
// IsManagedArtifactBackend reports whether backend consumes a model as a
// snapshot directory and is therefore eligible for inferred artifact
// materialization. An explicit artifacts: block bypasses this gate; single-file
// resolution handles the load path for single-file backends in that case.
func IsManagedArtifactBackend(backend string) bool {
_, ok := managedArtifactBackends[backend]
return ok
}
// PrimaryArtifactSpec returns the managed primary artifact to materialize for
// this config. The boolean return is false when the config should stay on the
// legacy path.
func (c ModelConfig) PrimaryArtifactSpec(modelsPath string) (modelartifacts.Spec, bool, bool, error) {
if len(c.Artifacts) > 0 {
return c.Artifacts[0], false, true, nil
}
modelRef := strings.TrimSpace(c.Model)
if modelRef == "" {
return modelartifacts.Spec{}, false, false, nil
}
if len(c.DownloadFiles) > 0 {
return modelartifacts.Spec{}, false, false, nil
}
// Only directory-consuming backends may have an artifact inferred from a
// bare reference; single-file backends stay on the legacy download-to-file
// path so the backend receives the weight file itself, not its directory.
if !IsManagedArtifactBackend(c.Backend) {
return modelartifacts.Spec{}, false, false, nil
}
if modelsPath != "" {
for _, candidate := range []string{
modelRef,
filepath.Join(modelsPath, modelRef),
} {
if info, err := os.Stat(candidate); err == nil && (info.IsDir() || info.Mode().IsRegular()) {
return modelartifacts.Spec{}, false, false, nil
}
}
}
spec, ok, err := modelartifacts.ParsePrimaryReference(modelRef)
if err != nil {
return modelartifacts.Spec{}, false, false, err
}
if !ok {
if strings.Contains(modelRef, "/") && !strings.HasPrefix(modelRef, ".") && !filepath.IsAbs(modelRef) {
repo, err := modelartifacts.CanonicalRepo(modelRef)
if err != nil {
if strings.Count(modelRef, "/") == 1 {
return modelartifacts.Spec{}, false, false, fmt.Errorf("invalid Hugging Face reference %q: %w", modelRef, err)
}
return modelartifacts.Spec{}, false, false, nil
}
return modelartifacts.Spec{
Name: modelartifacts.TargetModel,
Target: modelartifacts.TargetModel,
Source: modelartifacts.Source{Type: modelartifacts.SourceTypeHuggingFace, Repo: repo},
}, true, true, nil
}
return modelartifacts.Spec{}, false, false, nil
}
return spec, true, true, nil
}