Files
LocalAI/core/services/failover/prober_test.go
T
localai-org-maint-bot e62854c340 fix(failover): pass credential lookup from CLI
Pass the API key environment lookup through ApplicationConfig to satisfy
core configuration lint. Keep credential resolution dynamic and exclude
the callback from serialization.

Handle the five close results reported by errcheck.

Assisted-by: Codex:gpt-6 golangci-lint
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
2026-09-27 07:42:20 +00:00

217 lines
7.5 KiB
Go

package failover
import (
"context"
"encoding/json"
"errors"
"io"
"net/http"
"net/http/httptest"
"os"
"sync"
"github.com/mudler/LocalAI/core/config"
"github.com/mudler/LocalAI/pkg/grpc"
pb "github.com/mudler/LocalAI/pkg/grpc/proto"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
ggrpc "google.golang.org/grpc"
)
type fakeUpstream struct {
mu sync.Mutex
srv *httptest.Server
models []string
status int
paths []string
auth string
}
func newFakeUpstream() *fakeUpstream {
u := &fakeUpstream{status: http.StatusOK}
u.srv = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
u.mu.Lock()
u.paths = append(u.paths, r.Method+" "+r.URL.Path)
u.auth = r.Header.Get("Authorization")
status, models := u.status, u.models
u.mu.Unlock()
_, _ = io.Copy(io.Discard, r.Body)
if status != http.StatusOK {
w.WriteHeader(status)
return
}
if r.URL.Path == "/v1/models" {
var data []map[string]string
for _, m := range models {
data = append(data, map[string]string{"id": m})
}
_ = json.NewEncoder(w).Encode(map[string]any{"data": data})
return
}
_, _ = w.Write([]byte(`{}`))
}))
return u
}
type fakeBackend struct {
grpc.Backend
healthy bool
predictErr error
predicted bool
}
func (b *fakeBackend) HealthCheck(context.Context) (bool, error) { return b.healthy, nil }
func (b *fakeBackend) Predict(context.Context, *pb.PredictOptions, ...ggrpc.CallOption) (*pb.Reply, error) {
b.predicted = true
return &pb.Reply{}, b.predictErr
}
var _ = Describe("DefaultProber", func() {
var (
up *fakeUpstream
p *DefaultProber
ctx = context.Background()
)
BeforeEach(func() {
up = newFakeUpstream()
DeferCleanup(up.srv.Close)
p = NewProber(nil, os.Getenv)
})
proxied := func(name, upstreamModel string, usecases ...string) config.ModelConfig {
c := config.ModelConfig{Name: name, Backend: "cloud-proxy", KnownUsecaseStrings: usecases}
c.KnownUsecases = config.GetUsecasesFromYAML(usecases)
c.Proxy.UpstreamURL = up.srv.URL + "/v1/chat/completions"
c.Proxy.UpstreamModel = upstreamModel
return c
}
DescribeTable("UpstreamBase",
func(in, want string) {
got, err := UpstreamBase(in)
Expect(err).ToNot(HaveOccurred())
Expect(got).To(Equal(want))
},
Entry("full endpoint", "https://h:8080/v1/chat/completions", "https://h:8080"),
Entry("path prefix", "https://h/api/v1/chat/completions", "https://h/api"),
Entry("bare host", "https://h", "https://h"),
Entry("bare host slash", "https://h/", "https://h"),
)
It("passes liveness when the upstream lists the model", func() {
up.models = []string{"big-llm"}
Expect(p.Liveness(ctx, proxied("argus-llm", "big-llm"), KindRemote, false)).To(Succeed())
Expect(up.paths).To(ContainElement("GET /v1/models"))
})
It("uses the target name when upstream_model is empty", func() {
up.models = []string{"argus-llm"}
Expect(p.Liveness(ctx, proxied("argus-llm", ""), KindRemote, false)).To(Succeed())
})
It("fails liveness when the model is not listed or the upstream errors", func() {
up.models = []string{"other"}
Expect(p.Liveness(ctx, proxied("argus-llm", ""), KindRemote, false)).To(MatchError(ContainSubstring("does not list")))
up.status = http.StatusServiceUnavailable
Expect(p.Liveness(ctx, proxied("argus-llm", ""), KindRemote, false)).To(MatchError(ContainSubstring("503")))
})
It("sends the API key as a bearer token", func() {
GinkgoT().Setenv("FAILOVER_PROBE_KEY", "sekret")
up.models = []string{"argus-llm"}
c := proxied("argus-llm", "")
c.Proxy.APIKeyEnv = "FAILOVER_PROBE_KEY"
Expect(p.Liveness(ctx, c, KindRemote, false)).To(Succeed())
Expect(up.auth).To(Equal("Bearer sekret"))
})
It("does not follow a redirect, so the API key never leaves the upstream", func() {
GinkgoT().Setenv("FAILOVER_PROBE_KEY", "sekret")
other := newFakeUpstream()
DeferCleanup(other.srv.Close)
other.models = []string{"argus-llm"}
redirect := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
http.Redirect(w, r, other.srv.URL+r.URL.Path, http.StatusFound)
}))
DeferCleanup(redirect.Close)
c := proxied("argus-llm", "")
c.Proxy.UpstreamURL = redirect.URL + "/v1/chat/completions"
c.Proxy.APIKeyEnv = "FAILOVER_PROBE_KEY"
c.Proxy.Provider = config.ProxyProviderAnthropic
Expect(p.Liveness(ctx, c, KindRemote, false)).To(MatchError(ContainSubstring("302")))
Expect(other.paths).To(BeEmpty())
})
DescribeTable("remote inference hits the usecase endpoint",
func(usecase, path string) {
Expect(p.Inference(ctx, proxied("m", "", usecase), KindRemote, false)).To(Succeed())
Expect(up.paths).To(ContainElement("POST " + path))
},
Entry("chat", "chat", "/v1/chat/completions"),
Entry("embeddings", "embeddings", "/v1/embeddings"),
Entry("transcription", "transcript", "/v1/audio/transcriptions"),
Entry("tts", "tts", "/v1/audio/speech"),
)
It("uses HealthCheck for warm local liveness and Predict for local chat inference", func() {
b := &fakeBackend{healthy: true}
p = NewProber(func(config.ModelConfig) grpc.Backend { return b }, nil)
c := config.ModelConfig{Name: "gemma", Backend: "llama-cpp", KnownUsecaseStrings: []string{"chat"}}
c.KnownUsecases = config.GetUsecasesFromYAML(c.KnownUsecaseStrings)
Expect(p.Liveness(ctx, c, KindLocal, true)).To(Succeed())
b.healthy = false
Expect(p.Liveness(ctx, c, KindLocal, true)).To(HaveOccurred())
Expect(p.Inference(ctx, c, KindLocal, true)).To(Succeed())
Expect(b.predicted).To(BeTrue())
b.predictErr = errors.New("boom")
Expect(p.Inference(ctx, c, KindLocal, true)).To(HaveOccurred())
})
It("passes warm liveness for a target that is not loaded, and leaves recovery unconfirmed", func() {
// The warm preload loads the model; a probe that loaded it too would
// block until the load finished and then judge it on an expired ctx.
asked := 0
p = NewProber(func(config.ModelConfig) grpc.Backend { asked++; return nil }, nil)
for _, uc := range []string{"chat", "tts"} {
c := config.ModelConfig{Name: "gemma", Backend: "llama-cpp", KnownUsecaseStrings: []string{uc}}
c.KnownUsecases = config.GetUsecasesFromYAML(c.KnownUsecaseStrings)
Expect(p.Liveness(ctx, c, KindLocal, true)).To(Succeed())
Expect(p.Inference(ctx, c, KindLocal, true)).To(MatchError(ErrNotLoaded), uc)
}
Expect(asked).To(Equal(4))
})
It("passes cold local liveness without a model file and without loading", func() {
p = NewProber(func(config.ModelConfig) grpc.Backend {
Fail("cold liveness must not look up the backend")
return nil
}, nil)
// None of these files exist: a missing file says nothing about whether
// the target can serve (download on first use, dotted names, backends
// that need no file). Only a real request may trip a cold target.
for _, model := range []string{"weights.gguf", "Phi-3.5-mini", "org/some-hf-repo", ""} {
c := config.ModelConfig{Name: "cold", Backend: "llama-cpp"}
c.Model = model
Expect(p.Liveness(ctx, c, KindLocal, false)).To(Succeed(), model)
}
})
})
var _ = Describe("PrepareTarget", func() {
It("names the upstream model of a remote target the way the probe does", func() {
plain := config.ModelConfig{Name: "argus-llm", Backend: "cloud-proxy"}
PrepareTarget(&plain)
Expect(plain.Proxy.UpstreamModel).To(Equal("argus-llm"))
mapped := config.ModelConfig{Name: "argus-llm", Backend: "cloud-proxy"}
mapped.Proxy.UpstreamModel = "big-llm"
PrepareTarget(&mapped)
Expect(mapped.Proxy.UpstreamModel).To(Equal("big-llm"))
local := config.ModelConfig{Name: "gemma", Backend: "llama-cpp"}
PrepareTarget(&local)
Expect(local.Proxy.UpstreamModel).To(BeEmpty())
})
})