mirror of
https://github.com/mudler/LocalAI.git
synced 2026-11-05 20:13:23 -05:00
Ettore Di Giacinto
ef79f5336d
read_file and edit_file answered "X.docx is not a text file (43963 bytes)" and gave the model nothing to go on. Make the error typed and let the chat's tool list add the hint. If the chat has a skill for the file type (docx, xlsx, pptx, pdf), the error names it. Otherwise it suggests a script run with the commands tool, with a library for office types, when the chat can run commands. A chat with neither is told that no tool opens the file. The skills are resolved only when a read fails. Assisted-by: Claude Code:claude-sonnet-5-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
79 lines
2.5 KiB
Go
79 lines
2.5 KiB
Go
package studio
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"path"
|
|
"strings"
|
|
|
|
"github.com/mudler/LocalAI/core/services/studio/files"
|
|
"github.com/mudler/LocalAI/core/services/studio/session"
|
|
"github.com/mudler/LocalAI/core/services/studio/workspace"
|
|
)
|
|
|
|
// officeKinds are the binary document types a chat meets most: the words a
|
|
// skill of the type has in its name, and a library that reads the type in a
|
|
// script.
|
|
var officeKinds = map[string]struct {
|
|
skills []string
|
|
library string
|
|
}{
|
|
".docx": {[]string{"docx", "word"}, "python-docx"},
|
|
".xlsx": {[]string{"xlsx", "excel"}, "openpyxl"},
|
|
".pptx": {[]string{"pptx", "powerpoint"}, "python-pptx"},
|
|
".pdf": {[]string{"pdf"}, "pypdf"},
|
|
}
|
|
|
|
// binaryHintTools wraps the tools that read a file as text: when one meets a
|
|
// binary file, the error says what the chat can do with it. It names the
|
|
// skill that matches the file type when the chat has one, and a script when
|
|
// the chat can run commands. The skills are resolved only when a read fails.
|
|
func (s *Service) binaryHintTools(a workspace.Actor, canRun bool, tools []session.Tool) []session.Tool {
|
|
for i, tool := range tools {
|
|
switch tool.Name {
|
|
case "read_file", "edit_file":
|
|
default:
|
|
continue
|
|
}
|
|
run := tool.Run
|
|
tools[i].Run = func(ctx context.Context, args json.RawMessage) (string, error) {
|
|
out, err := run(ctx, args)
|
|
var nt *files.NotTextError
|
|
if !errors.As(err, &nt) {
|
|
return out, err
|
|
}
|
|
return out, errors.New(s.binaryAdvice(ctx, a, canRun, nt))
|
|
}
|
|
}
|
|
return tools
|
|
}
|
|
|
|
// binaryAdvice is the error for a binary file, short and true for the tools
|
|
// the chat has.
|
|
func (s *Service) binaryAdvice(ctx context.Context, a workspace.Actor, canRun bool, nt *files.NotTextError) string {
|
|
ext := strings.ToLower(path.Ext(nt.Name))
|
|
msg := fmt.Sprintf("%s is a binary file (%d bytes), not text.", nt.Name, nt.Size)
|
|
kind, office := officeKinds[ext]
|
|
if office {
|
|
if list, _, err := s.Skills(ctx, a.Principal, a.ChatID); err == nil {
|
|
for _, sk := range list {
|
|
name := strings.ToLower(sk.Name)
|
|
for _, w := range kind.skills {
|
|
if strings.Contains(name, w) {
|
|
return msg + fmt.Sprintf(" Use the %s skill for %s files (load_skill).", sk.Name, ext)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
switch {
|
|
case canRun && office:
|
|
return msg + fmt.Sprintf(" Run a script with the commands tool instead, for example with %s.", kind.library)
|
|
case canRun:
|
|
return msg + " Run a script with the commands tool instead."
|
|
}
|
|
return msg + " This chat has no tool that opens it."
|
|
}
|