mirror of
https://github.com/mudler/LocalAI.git
synced 2026-09-15 15:52:31 -04:00
* feat(credentials): parse and match download credential rules Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep secrets out of parse errors and tighten URL matching Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(credentials): resolve secrets lazily and authenticate HTTP per hop Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): redact secrets in nested and store formatting Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(credentials): add registry keychain and oras credential adapters Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): match repository rules for Docker Hub in the oras adapter Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(downloads): authenticate HTTP downloads and gallery reads from the credentials store Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(oci): authenticate registry pulls, resumes, blobs and cosign from the credentials store Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(cli): load download credentials from --credentials-file Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(credentials): correct the local-network registry rules Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep secrets out of match and YAML parse errors A match that fails to parse is no longer quoted in the Parse error, since it may be a URL with a token in it. Userinfo is detected before the scheme check, so ftp://user:token@host is refused as userinfo, and a match with a query string or fragment is refused because it can never apply and a query string is where signed URLs carry their token. Every YAML decode error is now redacted, not only type errors: quoted scalars such as a secret under a mismatched !!int tag are replaced and unquoted map keys are cut off. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(downloads): make auth errors name the real cause and never retry unresolved secrets AuthError now appends its cause, so a registry's DENIED or UNAUTHORIZED detail reaches the operator. HTTP auth errors print only the status text in place of the cause, because the downloader builds that cause from the requested URL, which can carry a signed query string. Registry pulls say that docker config credentials were tried too, and a download that carried a caller-provided credential (WithBearerToken, or an explicit authorization on gallery reads) reports that credential as rejected instead of blaming the store. The Range probe for a leftover partial file now returns an unresolved secret as a permanent error, like the download request already did. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep oras pulls anonymous on a broken docker helper and close bodies When docker config names a credsStore helper that cannot run, the oras credential func now logs at debug and returns no credential, so public pulls keep working as they did before the adapter existed. The transport closes the request body when a rule's secret cannot be resolved, as the RoundTripper contract requires. The redirect spec now uses a custom header rule on the origin, which net/http would not strip on its own, to prove the transport does not carry credentials to the next hop. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(oci): cover FetchImageBlob authentication against a private registry FetchImageBlob now has a spec that pulls a layer blob by digest from a basic-auth registry through the oras credential adapter, and one that shows the same fetch fails when no rule matches. oras only speaks HTTPS here, so the registry serves TLS and the spec points http.DefaultTransport, which retry.DefaultClient falls back to, at the test server's client for its duration instead of adding a transport seam to production code. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(credentials): document auth error wording, ollama manifests and registry tokens The errors section now lists the registry and provided-credential messages and says the server's reason is appended. ollama:// manifests are fetched without credentials, so only blob downloads use the file. GHCR, Docker Hub and Quay need basic auth with the token as password, and match rules must not carry a query string or fragment. The backend gallery docs and the container troubleshooting section now point to the private sources page. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): document trusted file path The credentials path comes from operator configuration. Mark the file read with a scoped G304 explanation to resolve the gosec false positive. Assisted-by: Codex:gpt-6 gosec --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: localai-org-maint-bot <306269227+localai-org-maint-bot@users.noreply.github.com>
170 lines
4.4 KiB
Go
170 lines
4.4 KiB
Go
package credentials
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"errors"
|
|
"fmt"
|
|
"log/slog"
|
|
"net/http"
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/mudler/xlog"
|
|
)
|
|
|
|
// Kind is how a credential authenticates.
|
|
type Kind int
|
|
|
|
const (
|
|
KindBasic Kind = iota + 1
|
|
KindBearer
|
|
KindHeader
|
|
)
|
|
|
|
func (k Kind) String() string {
|
|
switch k {
|
|
case KindBasic:
|
|
return "basic"
|
|
case KindBearer:
|
|
return "bearer"
|
|
case KindHeader:
|
|
return "header"
|
|
}
|
|
return "unknown"
|
|
}
|
|
|
|
// LookupEnvFunc has the signature of os.LookupEnv. It is injected because
|
|
// packages under pkg/ must not read the process environment directly; the CLI
|
|
// layer passes os.LookupEnv.
|
|
type LookupEnvFunc func(string) (string, bool)
|
|
|
|
type secretRef struct {
|
|
// literal is a pointer because fmt prints a nested pointer as an address.
|
|
// A Credential reached through an unexported field (inside Store, or any
|
|
// caller struct) bypasses String, so a plain string would print in full.
|
|
literal *string
|
|
env string
|
|
file string
|
|
}
|
|
|
|
func (r secretRef) set() bool {
|
|
return r.literal != nil || r.env != "" || r.file != ""
|
|
}
|
|
|
|
// Credential is one rule from the credentials file. Secret sources are
|
|
// unexported and resolved only when a request needs them.
|
|
type Credential struct {
|
|
// Match is the rule's match string as written. It never holds secret
|
|
// material, so it is what errors and logs use to name a rule.
|
|
Match string
|
|
Kind Kind
|
|
|
|
username string
|
|
password secretRef
|
|
bearer secretRef
|
|
headerName string
|
|
headerValue secretRef
|
|
|
|
allowInsecure bool
|
|
scheme string
|
|
host string
|
|
path string
|
|
lookupEnv LookupEnvFunc
|
|
}
|
|
|
|
// ErrUnresolvedSecret marks a failure to read a rule's secret. It is a
|
|
// configuration problem, so downloads must not retry it like a network error.
|
|
var ErrUnresolvedSecret = errors.New("credential secret unavailable")
|
|
|
|
type resolvedSecret struct {
|
|
username string
|
|
password string
|
|
bearer string
|
|
headerName string
|
|
headerValue string
|
|
}
|
|
|
|
func (r secretRef) resolve(lookupEnv LookupEnvFunc) (string, error) {
|
|
switch {
|
|
case r.literal != nil:
|
|
return *r.literal, nil
|
|
case r.env != "":
|
|
if lookupEnv != nil {
|
|
if v, ok := lookupEnv(r.env); ok && v != "" {
|
|
return v, nil
|
|
}
|
|
}
|
|
return "", fmt.Errorf("environment variable %s is not set", r.env)
|
|
case r.file != "":
|
|
b, err := os.ReadFile(r.file)
|
|
if err != nil {
|
|
return "", fmt.Errorf("reading secret file %s: %w", r.file, err)
|
|
}
|
|
// Secret mounts conventionally end with a newline that is not part
|
|
// of the value; sending it breaks the Authorization header.
|
|
return strings.TrimRight(string(b), "\r\n"), nil
|
|
}
|
|
return "", nil
|
|
}
|
|
|
|
// resolve reads secrets at use time rather than at load, so a rotated K8s
|
|
// secret mount is picked up without restarting LocalAI.
|
|
func (c Credential) resolve() (resolvedSecret, error) {
|
|
var out resolvedSecret
|
|
var err error
|
|
switch c.Kind {
|
|
case KindBasic:
|
|
out.username = c.username
|
|
out.password, err = c.password.resolve(c.lookupEnv)
|
|
case KindBearer:
|
|
out.bearer, err = c.bearer.resolve(c.lookupEnv)
|
|
case KindHeader:
|
|
out.headerName = c.headerName
|
|
out.headerValue, err = c.headerValue.resolve(c.lookupEnv)
|
|
}
|
|
if err != nil {
|
|
return resolvedSecret{}, fmt.Errorf("credential %q: %w: %w", c.Match, ErrUnresolvedSecret, err)
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
// ApplyHeaders adds the credential to h.
|
|
func (c Credential) ApplyHeaders(h http.Header) error {
|
|
r, err := c.resolve()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
switch c.Kind {
|
|
case KindBasic:
|
|
h.Set("Authorization", "Basic "+base64.StdEncoding.EncodeToString([]byte(r.username+":"+r.password)))
|
|
case KindBearer:
|
|
h.Set("Authorization", "Bearer "+r.bearer)
|
|
case KindHeader:
|
|
h.Set(r.headerName, r.headerValue)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// warnIfUnresolved keeps a rule whose secret is not available yet, because a
|
|
// secret mount can appear after startup, but tells the operator now instead of
|
|
// at the first failing download.
|
|
func (c Credential) warnIfUnresolved() {
|
|
if _, err := c.resolve(); err != nil {
|
|
xlog.Warn("Download credential cannot be resolved yet; matching downloads will fail until it can", "error", err)
|
|
}
|
|
}
|
|
|
|
// String, GoString and LogValue exist so that no fmt verb and no structured
|
|
// log call can print the unexported secret fields.
|
|
func (c Credential) String() string {
|
|
return fmt.Sprintf("credential(%s, %s)", c.Match, c.Kind)
|
|
}
|
|
|
|
func (c Credential) GoString() string {
|
|
return c.String()
|
|
}
|
|
|
|
func (c Credential) LogValue() slog.Value {
|
|
return slog.GroupValue(slog.String("match", c.Match), slog.String("kind", c.Kind.String()))
|
|
}
|