mirror of
https://github.com/mudler/LocalAI.git
synced 2026-09-15 15:52:31 -04:00
* feat(credentials): parse and match download credential rules Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep secrets out of parse errors and tighten URL matching Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(credentials): resolve secrets lazily and authenticate HTTP per hop Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): redact secrets in nested and store formatting Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(credentials): add registry keychain and oras credential adapters Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): match repository rules for Docker Hub in the oras adapter Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(downloads): authenticate HTTP downloads and gallery reads from the credentials store Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(oci): authenticate registry pulls, resumes, blobs and cosign from the credentials store Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(cli): load download credentials from --credentials-file Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(credentials): correct the local-network registry rules Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep secrets out of match and YAML parse errors A match that fails to parse is no longer quoted in the Parse error, since it may be a URL with a token in it. Userinfo is detected before the scheme check, so ftp://user:token@host is refused as userinfo, and a match with a query string or fragment is refused because it can never apply and a query string is where signed URLs carry their token. Every YAML decode error is now redacted, not only type errors: quoted scalars such as a secret under a mismatched !!int tag are replaced and unquoted map keys are cut off. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(downloads): make auth errors name the real cause and never retry unresolved secrets AuthError now appends its cause, so a registry's DENIED or UNAUTHORIZED detail reaches the operator. HTTP auth errors print only the status text in place of the cause, because the downloader builds that cause from the requested URL, which can carry a signed query string. Registry pulls say that docker config credentials were tried too, and a download that carried a caller-provided credential (WithBearerToken, or an explicit authorization on gallery reads) reports that credential as rejected instead of blaming the store. The Range probe for a leftover partial file now returns an unresolved secret as a permanent error, like the download request already did. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): keep oras pulls anonymous on a broken docker helper and close bodies When docker config names a credsStore helper that cannot run, the oras credential func now logs at debug and returns no credential, so public pulls keep working as they did before the adapter existed. The transport closes the request body when a rule's secret cannot be resolved, as the RoundTripper contract requires. The redirect spec now uses a custom header rule on the origin, which net/http would not strip on its own, to prove the transport does not carry credentials to the next hop. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(oci): cover FetchImageBlob authentication against a private registry FetchImageBlob now has a spec that pulls a layer blob by digest from a basic-auth registry through the oras credential adapter, and one that shows the same fetch fails when no rule matches. oras only speaks HTTPS here, so the registry serves TLS and the spec points http.DefaultTransport, which retry.DefaultClient falls back to, at the test server's client for its duration instead of adding a transport seam to production code. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * docs(credentials): document auth error wording, ollama manifests and registry tokens The errors section now lists the registry and provided-credential messages and says the server's reason is appended. ollama:// manifests are fetched without credentials, so only blob downloads use the file. GHCR, Docker Hub and Quay need basic auth with the token as password, and match rules must not carry a query string or fragment. The backend gallery docs and the container troubleshooting section now point to the private sources page. Assisted-by: Claude:claude-opus-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(credentials): document trusted file path The credentials path comes from operator configuration. Mark the file read with a scoped G304 explanation to resolve the gosec false positive. Assisted-by: Codex:gpt-6 gosec --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: localai-org-maint-bot <306269227+localai-org-maint-bot@users.noreply.github.com>
104 lines
3.6 KiB
Go
104 lines
3.6 KiB
Go
package credentials
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
)
|
|
|
|
// AuthError reports a 401 or 403 and whether a credentials rule was involved,
|
|
// because "add a credential" and "fix the credential" are different fixes.
|
|
type AuthError struct {
|
|
// Target identifies what was being fetched, without secrets or signed
|
|
// query strings.
|
|
Target string
|
|
Status int
|
|
// Match is the rule that was sent, or empty when none matched.
|
|
Match string
|
|
// Registry marks a registry pull, where docker config credentials are
|
|
// tried after the store, so an unmatched rule is not the whole story.
|
|
Registry bool
|
|
// Provided marks a request that carried a credential the caller chose.
|
|
// The store was not consulted, so it must not be blamed.
|
|
Provided bool
|
|
Err error
|
|
|
|
// causeText replaces Err in the message when Err may not be printed.
|
|
causeText string
|
|
}
|
|
|
|
func (e *AuthError) Error() string {
|
|
var msg string
|
|
switch {
|
|
case e.Provided:
|
|
msg = fmt.Sprintf("the provided credential was rejected by %s (status %d)", e.Target, e.Status)
|
|
case e.Match != "":
|
|
msg = fmt.Sprintf("credential %q was rejected by %s (status %d)", e.Match, e.Target, e.Status)
|
|
case e.Registry:
|
|
msg = fmt.Sprintf("authentication required for %s (status %d): no credentials rule matches it and docker config credentials, if any, were not accepted", e.Target, e.Status)
|
|
default:
|
|
msg = fmt.Sprintf("authentication required for %s (status %d): no credentials rule matches it", e.Target, e.Status)
|
|
}
|
|
// The cause carries what the server said (a registry's DENIED detail, for
|
|
// example), which is often the only hint at what is wrong with the rule.
|
|
switch {
|
|
case e.causeText != "":
|
|
msg += ": " + e.causeText
|
|
case e.Err != nil:
|
|
msg += ": " + e.Err.Error()
|
|
}
|
|
return msg
|
|
}
|
|
|
|
func (e *AuthError) Unwrap() error {
|
|
return e.Err
|
|
}
|
|
|
|
// NewAuthError looks matchURL up in the default store to tell the two cases
|
|
// apart. target is what the message shows.
|
|
func NewAuthError(matchURL, target string, status int, cause error) error {
|
|
return newAuthError(matchURL, target, status, cause)
|
|
}
|
|
|
|
func newAuthError(matchURL, target string, status int, cause error) *AuthError {
|
|
e := &AuthError{Target: target, Status: status, Err: cause}
|
|
if c, ok := Default().Match(matchURL); ok {
|
|
e.Match = c.Match
|
|
}
|
|
return e
|
|
}
|
|
|
|
// NewRegistryAuthError is NewAuthError for registry pulls, whose message also
|
|
// accounts for docker config credentials having been tried.
|
|
func NewRegistryAuthError(matchURL, target string, status int, cause error) error {
|
|
e := newAuthError(matchURL, target, status, cause)
|
|
e.Registry = true
|
|
return e
|
|
}
|
|
|
|
// HTTPAuthError builds an AuthError for an HTTP response. The query string is
|
|
// dropped because CDNs put signatures there.
|
|
func HTTPAuthError(u *url.URL, status int, cause error) error {
|
|
e := newAuthError(u.String(), httpTarget(u), status, cause)
|
|
e.causeText = httpCauseText(status)
|
|
return e
|
|
}
|
|
|
|
// HTTPProvidedCredentialError builds an AuthError for a request that carried
|
|
// a credential chosen by the caller, without consulting the store.
|
|
func HTTPProvidedCredentialError(u *url.URL, status int, cause error) error {
|
|
return &AuthError{Target: httpTarget(u), Status: status, Provided: true, Err: cause, causeText: httpCauseText(status)}
|
|
}
|
|
|
|
func httpTarget(u *url.URL) string {
|
|
return u.Scheme + "://" + u.Host + u.Path
|
|
}
|
|
|
|
// httpCauseText stands in for the cause of an HTTP auth error. Callers build
|
|
// that cause from the URL they requested, which can hold a signed query
|
|
// string, so only the status text is printed. The cause stays reachable
|
|
// through Unwrap for errors.Is and errors.As.
|
|
func httpCauseText(status int) string {
|
|
return fmt.Sprintf("%d %s", status, http.StatusText(status))
|
|
}
|