mirror of
https://github.com/mudler/LocalAI.git
synced 2026-09-20 05:07:07 -04:00
nodes.<id>.backend.stop was the last worker-facing NATS subject, and it existed only because ONE publisher had not moved. An agent worker already mounted workerctl.PathBackendStop on the tunnel it holds, and a backend worker already took its stop there, so RemoteUnloaderAdapter branched on NodeType to pick a carrier for a verb both kinds of worker served the same way. The branch is gone, and with it nodeTypeOf and its NodeTypeBackend default, which removes one of the ten NodeType branches left to sweep. The adapter loses its messaging.MessagingClient outright rather than keeping an unused field: it now holds no publisher, so re-routing any verb back onto the bus is a change to the struct and to every caller of the constructor, and does not compile until all of them agree. messaging.SubjectNodeBackendStop and subjectNodePrefix are deleted, the agent worker's subscription with them. pkg/natsauth drops the per-node backend.stop grant from the agent SUB list. That is a narrowing of eleven entries to ten, never to nothing: NATS reads an EMPTY allow list as unrestricted, so the coverage spec asserts both that the retired subject is no longer covered and that the queue subjects an agent worker lives on still are. The e2e half proves it against a real enforcing server: one spec subscribes successfully on an agent-minted JWT, the next is refused the retired subject on a JWT minted the same way. Both halves of the old split were pinned, so both pins are re-aimed rather than deleted, and the two node types are asserted separately rather than as one parameterised case, because only two cases can show that the two used to differ. Three assertions that the adapter published nothing are deleted instead: with no publisher to hold, no change could ever redden them. The CLI's handler set moves into agentWorkerControlHandlers so a spec can stand it up and post to it. That wiring was a bare literal no spec pinned, and deleting the subscription made it the ONLY carrier for backend.stop: a dropped field would have been a 404 the frontend reads as a worker too old to serve the verb, and nothing in the repo would have noticed. Mutations: the agent branch restored off the control route reddens two specs; the backend branch restored, separately, reddens five; PathBackendDelete in place of PathBackendStop reddens nine across both node types; dropping the CLI wiring line reddens the new wiring table; re-adding the allow-list entry reddens the unit spec and the JWT e2e spec; and restoring the publisher for real does not compile. Four comments this change falsified are fixed, in core/cli, pkg/model and the distributed-mode docs, which now say both kinds of worker serve POST /v1/control/backend/stop and what each does with it. Assisted-by: Claude Opus 5 [claude-code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
163 lines
6.2 KiB
Go
163 lines
6.2 KiB
Go
package model
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
|
|
grpc "github.com/mudler/LocalAI/pkg/grpc"
|
|
pb "github.com/mudler/LocalAI/pkg/grpc/proto"
|
|
"github.com/mudler/xlog"
|
|
ggrpc "google.golang.org/grpc"
|
|
)
|
|
|
|
// ConnectionEvictingClient wraps a grpc.Backend. When any inference method
|
|
// fails with a connection error (server unreachable), it calls the evict
|
|
// callback to remove the model from the ModelLoader's cache. The error is
|
|
// still returned to the caller — the NEXT request will trigger rescheduling
|
|
// via SmartRouter.
|
|
type ConnectionEvictingClient struct {
|
|
grpc.WrappedBackend
|
|
modelID string
|
|
evict func()
|
|
once sync.Once
|
|
}
|
|
|
|
var _ grpc.BackendUnwrapper = (*ConnectionEvictingClient)(nil)
|
|
|
|
func newConnectionEvictingClient(inner grpc.Backend, modelID string, evict func()) grpc.Backend {
|
|
return &ConnectionEvictingClient{
|
|
WrappedBackend: grpc.WrappedBackend{Backend: inner},
|
|
modelID: modelID,
|
|
evict: evict,
|
|
}
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) checkErr(err error) {
|
|
if err == nil || !isConnectionError(err) {
|
|
return
|
|
}
|
|
// The fifth site of the same shape, and the one reached during INFERENCE
|
|
// rather than a health check. evict() runs ShutdownModel, which for a remote
|
|
// model sends a backend.stop control RPC over the tunnel of every node
|
|
// holding it and deletes every replica row. In distributed mode the client underneath reaches the
|
|
// backend over the worker's tunnel, and a failure of THAT transport arrives
|
|
// as the same codes.Unavailable a dead backend produces; evicting on it
|
|
// stops a model that is loaded and serving, on a worker that is
|
|
// heartbeating. A locally spawned backend has no custom transport, so this
|
|
// reports nil and the behaviour there is exactly what it always was.
|
|
// transportFailure and not LastDialErrorOf: a refusal the WORKER wrote is
|
|
// the worker answering that it could not reach the process, which is what a
|
|
// crashed backend produces now that a worker listens on nothing. Treating
|
|
// that as a transport failure kept a genuinely dead model loaded and
|
|
// failing every request, which is the mirror image of the mistake this
|
|
// guard exists to prevent.
|
|
if dialErr := transportFailure(c.Backend); dialErr != nil {
|
|
xlog.Warn("Inference failed because the worker could not be reached; keeping the model",
|
|
"model", c.modelID, "error", dialErr)
|
|
return
|
|
}
|
|
c.once.Do(func() {
|
|
xlog.Warn("Connection error during inference, evicting model from cache",
|
|
"model", c.modelID, "error", err)
|
|
c.evict()
|
|
})
|
|
}
|
|
|
|
// --- Intercepted inference methods ---
|
|
|
|
func (c *ConnectionEvictingClient) Predict(ctx context.Context, in *pb.PredictOptions, opts ...ggrpc.CallOption) (*pb.Reply, error) {
|
|
reply, err := c.Backend.Predict(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return reply, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) PredictStream(ctx context.Context, in *pb.PredictOptions, f func(reply *pb.Reply), opts ...ggrpc.CallOption) error {
|
|
err := c.Backend.PredictStream(ctx, in, f, opts...)
|
|
c.checkErr(err)
|
|
return err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) Embeddings(ctx context.Context, in *pb.PredictOptions, opts ...ggrpc.CallOption) (*pb.EmbeddingResult, error) {
|
|
result, err := c.Backend.Embeddings(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) GenerateImage(ctx context.Context, in *pb.GenerateImageRequest, opts ...ggrpc.CallOption) (*pb.Result, error) {
|
|
result, err := c.Backend.GenerateImage(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) GenerateVideo(ctx context.Context, in *pb.GenerateVideoRequest, opts ...ggrpc.CallOption) (*pb.Result, error) {
|
|
result, err := c.Backend.GenerateVideo(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) Generate3D(ctx context.Context, in *pb.Generate3DRequest, opts ...ggrpc.CallOption) (*pb.Result, error) {
|
|
result, err := c.Backend.Generate3D(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) TTS(ctx context.Context, in *pb.TTSRequest, opts ...ggrpc.CallOption) (*pb.Result, error) {
|
|
result, err := c.Backend.TTS(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) TTSStream(ctx context.Context, in *pb.TTSRequest, f func(reply *pb.Reply), opts ...ggrpc.CallOption) error {
|
|
err := c.Backend.TTSStream(ctx, in, f, opts...)
|
|
c.checkErr(err)
|
|
return err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) SoundGeneration(ctx context.Context, in *pb.SoundGenerationRequest, opts ...ggrpc.CallOption) (*pb.Result, error) {
|
|
result, err := c.Backend.SoundGeneration(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) AudioTranscription(ctx context.Context, in *pb.TranscriptRequest, opts ...ggrpc.CallOption) (*pb.TranscriptResult, error) {
|
|
result, err := c.Backend.AudioTranscription(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) AudioTranscriptionStream(ctx context.Context, in *pb.TranscriptRequest, f func(chunk *pb.TranscriptStreamResponse), opts ...ggrpc.CallOption) error {
|
|
err := c.Backend.AudioTranscriptionStream(ctx, in, f, opts...)
|
|
c.checkErr(err)
|
|
return err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) Detect(ctx context.Context, in *pb.DetectOptions, opts ...ggrpc.CallOption) (*pb.DetectResponse, error) {
|
|
result, err := c.Backend.Detect(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) Depth(ctx context.Context, in *pb.DepthRequest, opts ...ggrpc.CallOption) (*pb.DepthResponse, error) {
|
|
result, err := c.Backend.Depth(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) Rerank(ctx context.Context, in *pb.RerankRequest, opts ...ggrpc.CallOption) (*pb.RerankResult, error) {
|
|
result, err := c.Backend.Rerank(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) TokenClassify(ctx context.Context, in *pb.TokenClassifyRequest, opts ...ggrpc.CallOption) (*pb.TokenClassifyResponse, error) {
|
|
result, err := c.Backend.TokenClassify(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|
|
|
|
func (c *ConnectionEvictingClient) Score(ctx context.Context, in *pb.ScoreRequest, opts ...ggrpc.CallOption) (*pb.ScoreResponse, error) {
|
|
result, err := c.Backend.Score(ctx, in, opts...)
|
|
c.checkErr(err)
|
|
return result, err
|
|
}
|