mirror of
https://github.com/mudler/LocalAI.git
synced 2026-09-13 06:45:26 -04:00
nodes.<id>.backend.stop was the last worker-facing NATS subject, and it existed only because ONE publisher had not moved. An agent worker already mounted workerctl.PathBackendStop on the tunnel it holds, and a backend worker already took its stop there, so RemoteUnloaderAdapter branched on NodeType to pick a carrier for a verb both kinds of worker served the same way. The branch is gone, and with it nodeTypeOf and its NodeTypeBackend default, which removes one of the ten NodeType branches left to sweep. The adapter loses its messaging.MessagingClient outright rather than keeping an unused field: it now holds no publisher, so re-routing any verb back onto the bus is a change to the struct and to every caller of the constructor, and does not compile until all of them agree. messaging.SubjectNodeBackendStop and subjectNodePrefix are deleted, the agent worker's subscription with them. pkg/natsauth drops the per-node backend.stop grant from the agent SUB list. That is a narrowing of eleven entries to ten, never to nothing: NATS reads an EMPTY allow list as unrestricted, so the coverage spec asserts both that the retired subject is no longer covered and that the queue subjects an agent worker lives on still are. The e2e half proves it against a real enforcing server: one spec subscribes successfully on an agent-minted JWT, the next is refused the retired subject on a JWT minted the same way. Both halves of the old split were pinned, so both pins are re-aimed rather than deleted, and the two node types are asserted separately rather than as one parameterised case, because only two cases can show that the two used to differ. Three assertions that the adapter published nothing are deleted instead: with no publisher to hold, no change could ever redden them. The CLI's handler set moves into agentWorkerControlHandlers so a spec can stand it up and post to it. That wiring was a bare literal no spec pinned, and deleting the subscription made it the ONLY carrier for backend.stop: a dropped field would have been a 404 the frontend reads as a worker too old to serve the verb, and nothing in the repo would have noticed. Mutations: the agent branch restored off the control route reddens two specs; the backend branch restored, separately, reddens five; PathBackendDelete in place of PathBackendStop reddens nine across both node types; dropping the CLI wiring line reddens the new wiring table; re-adding the allow-list entry reddens the unit spec and the JWT e2e spec; and restoring the publisher for real does not compile. Four comments this change falsified are fixed, in core/cli, pkg/model and the distributed-mode docs, which now say both kinds of worker serve POST /v1/control/backend/stop and what each does with it. Assisted-by: Claude Opus 5 [claude-code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
228 lines
9.0 KiB
Go
228 lines
9.0 KiB
Go
package distributed_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/mudler/LocalAI/core/services/messaging"
|
|
"github.com/mudler/LocalAI/core/services/nodes"
|
|
"github.com/mudler/LocalAI/core/services/workerctl"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
|
|
pgdriver "gorm.io/driver/postgres"
|
|
"gorm.io/gorm"
|
|
"gorm.io/gorm/logger"
|
|
)
|
|
|
|
var _ = Describe("Node Backend Lifecycle over the worker control plane", Label("Distributed"), func() {
|
|
var (
|
|
infra *TestInfra
|
|
db *gorm.DB
|
|
registry *nodes.NodeRegistry
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
infra = SetupInfra("localai_lifecycle_test")
|
|
|
|
var err error
|
|
db, err = gorm.Open(pgdriver.Open(infra.PGURL), &gorm.Config{
|
|
Logger: logger.Default.LogMode(logger.Silent),
|
|
})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
registry, err = nodes.NewNodeRegistry(db)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
})
|
|
|
|
Context("backend.install", func() {
|
|
It("should send backend.install to a specific node", func() {
|
|
node := &nodes.BackendNode{
|
|
Name: "gpu-node-1", Address: "h1:50051",
|
|
}
|
|
Expect(registry.Register(context.Background(), node, true)).To(Succeed())
|
|
|
|
// The worker serves backend.install on its own control plane.
|
|
workers := NewControlWorkers()
|
|
workers.On(node.ID, workerctl.PathBackendInstall, func(_ string, data []byte) any {
|
|
var req messaging.BackendInstallRequest
|
|
Expect(json.Unmarshal(data, &req)).To(Succeed())
|
|
Expect(req.Backend).To(Equal("llama-cpp"))
|
|
return messaging.BackendInstallReply{Success: true}
|
|
})
|
|
|
|
adapter := nodes.NewRemoteUnloaderAdapter(registry, workers.Client(), 3*time.Minute, 15*time.Minute)
|
|
installReply, err := adapter.InstallBackend(node.ID, "llama-cpp", "", "", "", "", "", 0, "", nil)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(installReply.Success).To(BeTrue())
|
|
})
|
|
|
|
It("should propagate error from worker on failed install", func() {
|
|
node := &nodes.BackendNode{
|
|
Name: "fail-node", Address: "h1:50051",
|
|
}
|
|
Expect(registry.Register(context.Background(), node, true)).To(Succeed())
|
|
|
|
// The worker's own verdict: an answer, not a transport failure.
|
|
workers := NewControlWorkers()
|
|
workers.On(node.ID, workerctl.PathBackendInstall, func(string, []byte) any {
|
|
return messaging.BackendInstallReply{Success: false, Error: "backend not found"}
|
|
})
|
|
|
|
adapter := nodes.NewRemoteUnloaderAdapter(registry, workers.Client(), 3*time.Minute, 15*time.Minute)
|
|
installReply, err := adapter.InstallBackend(node.ID, "nonexistent", "", "", "", "", "", 0, "", nil)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(installReply.Success).To(BeFalse())
|
|
Expect(installReply.Error).To(ContainSubstring("backend not found"))
|
|
})
|
|
})
|
|
|
|
Context("backend.stop (model unload)", func() {
|
|
It("should send backend.stop to nodes hosting the model", func() {
|
|
node := &nodes.BackendNode{
|
|
Name: "gpu-node-2", Address: "h2:50051",
|
|
}
|
|
Expect(registry.Register(context.Background(), node, true)).To(Succeed())
|
|
Expect(registry.SetNodeModel(context.Background(), node.ID, "whisper-large", 0, "loaded", "", 0)).To(Succeed())
|
|
|
|
var stopReceived atomic.Int32
|
|
workers := NewControlWorkers()
|
|
workers.On(node.ID, workerctl.PathBackendStop, func(string, []byte) any {
|
|
stopReceived.Add(1)
|
|
return nil
|
|
})
|
|
|
|
// Frontend calls UnloadRemoteModel (triggered by UI "Stop" or WatchDog)
|
|
adapter := nodes.NewRemoteUnloaderAdapter(registry, workers.Client(), 3*time.Minute, 15*time.Minute)
|
|
Expect(adapter.UnloadRemoteModel("whisper-large")).To(Succeed())
|
|
|
|
Eventually(func() int32 { return stopReceived.Load() }, "5s").Should(Equal(int32(1)))
|
|
|
|
// Model should be removed from registry
|
|
nodesWithModel, _ := registry.FindNodesWithModel(context.Background(), "whisper-large")
|
|
Expect(nodesWithModel).To(BeEmpty())
|
|
})
|
|
|
|
// The same verb, on an AGENT node, over the same route. Asserted as its
|
|
// own spec rather than folded into the backend-node one above, because
|
|
// the two used to take different carriers and only two specs can show
|
|
// that they no longer do. The body is read back off the transport: a
|
|
// stop that arrived naming no backend would tell the worker to stop
|
|
// everything, which is a different instruction entirely.
|
|
It("should send backend.stop to an AGENT node over its tunnel too", func() {
|
|
node := &nodes.BackendNode{
|
|
Name: "agent-node-1", NodeType: nodes.NodeTypeAgent,
|
|
}
|
|
Expect(registry.Register(context.Background(), node, true)).To(Succeed())
|
|
Expect(registry.SetNodeModel(context.Background(), node.ID, "agent-hosted", 0, "loaded", "127.0.0.1:59061", 0)).To(Succeed())
|
|
|
|
bodies := make(chan []byte, 1)
|
|
workers := NewControlWorkers()
|
|
workers.On(node.ID, workerctl.PathBackendStop, func(_ string, body []byte) any {
|
|
bodies <- body
|
|
return nil
|
|
})
|
|
|
|
adapter := nodes.NewRemoteUnloaderAdapter(registry, workers.Client(), 3*time.Minute, 15*time.Minute)
|
|
Expect(adapter.UnloadRemoteModel("agent-hosted")).To(Succeed())
|
|
|
|
var body []byte
|
|
Eventually(bodies, "5s").Should(Receive(&body))
|
|
var req messaging.BackendStopRequest
|
|
Expect(json.Unmarshal(body, &req)).To(Succeed())
|
|
Expect(req).To(Equal(messaging.BackendStopRequest{Backend: "agent-hosted"}))
|
|
})
|
|
|
|
It("should send backend.stop to all nodes hosting the model", func() {
|
|
node1 := &nodes.BackendNode{Name: "n1", Address: "h1:50051"}
|
|
node2 := &nodes.BackendNode{Name: "n2", Address: "h2:50051"}
|
|
registry.Register(context.Background(), node1, true)
|
|
registry.Register(context.Background(), node2, true)
|
|
registry.SetNodeModel(context.Background(), node1.ID, "shared-model", 0, "loaded", "", 0)
|
|
registry.SetNodeModel(context.Background(), node2.ID, "shared-model", 0, "loaded", "", 0)
|
|
|
|
var count atomic.Int32
|
|
workers := NewControlWorkers()
|
|
for _, id := range []string{node1.ID, node2.ID} {
|
|
workers.On(id, workerctl.PathBackendStop, func(string, []byte) any {
|
|
count.Add(1)
|
|
return nil
|
|
})
|
|
}
|
|
|
|
adapter := nodes.NewRemoteUnloaderAdapter(registry, workers.Client(), 3*time.Minute, 15*time.Minute)
|
|
adapter.UnloadRemoteModel("shared-model")
|
|
|
|
Eventually(func() int32 { return count.Load() }, "5s").Should(Equal(int32(2)))
|
|
})
|
|
|
|
It("should be no-op for models not on any node", func() {
|
|
// Unloading is idempotent by contract: cleanup paths (model
|
|
// deletion, config edits, watchdog eviction) legitimately run
|
|
// against an already-unloaded model, and the watchdog's LRU
|
|
// reclaimer only untracks a model when shutdown reports success.
|
|
// Callers needing to tell "stopped it" from "nothing to stop" —
|
|
// ShutdownModel, so it can answer 404 — use HasRemoteModel instead.
|
|
// The same contract is pinned at unit level by "with no nodes
|
|
// returns nil" in core/services/nodes/unloader_test.go; keep them
|
|
// in step.
|
|
adapter := nodes.NewRemoteUnloaderAdapter(registry, NewControlWorkers().Client(), 3*time.Minute, 15*time.Minute)
|
|
Expect(adapter.UnloadRemoteModel("nonexistent-model")).To(Succeed())
|
|
})
|
|
})
|
|
|
|
Context("node.stop (full shutdown)", func() {
|
|
It("should ask the node to shut down over its control plane", func() {
|
|
node := &nodes.BackendNode{
|
|
Name: "stop-me", Address: "h3:50051",
|
|
}
|
|
Expect(registry.Register(context.Background(), node, true)).To(Succeed())
|
|
|
|
var stopped atomic.Int32
|
|
workers := NewControlWorkers()
|
|
workers.On(node.ID, workerctl.PathNodeStop, func(string, []byte) any {
|
|
stopped.Add(1)
|
|
return nil
|
|
})
|
|
|
|
adapter := nodes.NewRemoteUnloaderAdapter(registry, workers.Client(), 3*time.Minute, 15*time.Minute)
|
|
Expect(adapter.StopNode(node.ID)).To(Succeed())
|
|
|
|
Eventually(func() int32 { return stopped.Load() }, "5s").Should(Equal(int32(1)))
|
|
})
|
|
})
|
|
|
|
Context("wire naming", func() {
|
|
// Written out BY HAND, and not derived from the constants: a frontend
|
|
// and a worker built from different commits reach each other over these
|
|
// literals, and a renamed path is a 404 that looks exactly like a
|
|
// broken tunnel.
|
|
It("should name the backend lifecycle control verbs", func() {
|
|
Expect(workerctl.PathBackendInstall).To(Equal("/v1/control/backend/install"))
|
|
Expect(workerctl.PathBackendStop).To(Equal("/v1/control/backend/stop"))
|
|
Expect(workerctl.PathNodeStop).To(Equal("/v1/control/node/stop"))
|
|
})
|
|
|
|
// backend.stop was the last worker-facing node subject, and it was
|
|
// addressed only to AGENT workers. It has no subject any more: an agent
|
|
// node's stop is a control RPC on the path named above, the same one a
|
|
// backend node takes. There is nothing to write out by hand here,
|
|
// because the builder is deleted; what an e2e spec can show instead is
|
|
// that an AGENT node's stop reaches a worker over its tunnel, which
|
|
// "should send backend.stop to an AGENT node over its tunnel too" does.
|
|
})
|
|
|
|
// Design note: LoadModel is a gRPC call through the worker's tunnel, not a
|
|
// control verb. The control plane installs and stops the process; the model
|
|
// is loaded into it over the `grpc` stream tag.
|
|
//
|
|
// Flow:
|
|
// 1. backend.install → worker installs backend + starts gRPC process
|
|
// 2. SmartRouter.Route() → LoadModel over the worker's tunnel
|
|
// 3. [inference over the tunnel]
|
|
// 4. backend.stop → worker stops gRPC process
|
|
})
|