mirror/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-05-24 06:40:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove getPacketId() from public interface

Browse Source 
- Remove getPacketId() from MessageSender interface (SDK owns packet IDs)
- Remove requestId parameter from requestTraceroute/requestNeighborInfo
- Make getPacketId() private in SdkRadioController (still used internally
  for delivery tracking correlation)
- Replace radioController.getPacketId() in map with local Random.nextInt()
  for waypoint ID generation (only needs uniqueness, not SDK correlation)
- Remove messageSender dependency from CommonNodeRequestActions

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
James Rich
2026-05-06 12:23:25 -05:00
parent f4c6cee332
commit 0b5791a61d
7 changed files with 11 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/testing/src/commonMain/kotlin/org/meshtastic/core/testing/FakeRadioController.kt
View File

@@ -140,11 +140,11 @@ class FakeRadioController :
override suspend fun requestUserInfo(destNum: Int) {}
override suspend fun requestTraceroute(requestId: Int, destNum: Int) {}
override suspend fun requestTraceroute(destNum: Int) {}
override suspend fun requestTelemetry(destNum: Int, type: TelemetryType) {}
override suspend fun requestNeighborInfo(requestId: Int, destNum: Int) {}
override suspend fun requestNeighborInfo(destNum: Int) {}
override suspend fun requestStoreForwardHistory(since: Int?, serverNodeNum: Int?): Boolean {
lastStoreForwardHistoryRequest = since to serverNodeNum
@@ -162,8 +162,6 @@ class FakeRadioController :
block(edit)
}
override fun getPacketId(): Int = 1
override fun startProvideLocation() {
startProvideLocationCalled = true
}