feat (#2105): debug panel (#2148)

Co-authored-by: James Rich <2199651+jamesarich@users.noreply.github.com>
2026-03-14 03:46:25 -04:00 · 2025-06-20 00:04:58 +10:00
parent e9f95dbf8c
commit 17e3e1a257
9 changed files with 1571 additions and 35 deletions
--- a/app/src/androidTest/java/com/geeksville/mesh/compose/DebugFiltersTest.kt
+++ b/app/src/androidTest/java/com/geeksville/mesh/compose/DebugFiltersTest.kt
@@ -0,0 +1,108 @@
+/*
+ * Copyright (c) 2025 Meshtastic LLC
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+package com.geeksville.mesh.compose
+
+import androidx.compose.ui.test.assertIsDisplayed
+import androidx.compose.ui.test.junit4.createComposeRule
+import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.onNodeWithContentDescription
+import androidx.compose.ui.test.performClick
+import androidx.compose.ui.test.performTextInput
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.geeksville.mesh.R
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import androidx.test.platform.app.InstrumentationRegistry
+import androidx.compose.runtime.getValue
+import androidx.compose.runtime.setValue
+
+@RunWith(AndroidJUnit4::class)
+class DebugFiltersTest {
+
+    @get:Rule
+    val composeTestRule = createComposeRule()
+
+    @Test
+    fun debugFilterBar_showsFilterButtonAndMenu() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val filterLabel = context.getString(R.string.debug_filters)
+        composeTestRule.setContent {
+            var filterTexts by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf(listOf<String>()) }
+            var customFilterText by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf("") }
+            val presetFilters = listOf("Error", "Warning", "Info")
+            com.geeksville.mesh.ui.debug.DebugFilterBar(
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it },
+                customFilterText = customFilterText,
+                onCustomFilterTextChange = { customFilterText = it },
+                presetFilters = presetFilters
+            )
+        }
+        // The filter button should be visible
+        composeTestRule.onNodeWithText(filterLabel).assertIsDisplayed()
+    }
+
+    @Test
+    fun debugFilterBar_addCustomFilter_displaysActiveFilter() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val activeFiltersLabel = context.getString(R.string.debug_active_filters)
+        composeTestRule.setContent {
+            var filterTexts by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf(listOf<String>()) }
+            var customFilterText by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf("") }
+            com.geeksville.mesh.ui.debug.DebugActiveFilters(
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it }
+            )
+            com.geeksville.mesh.ui.debug.DebugCustomFilterInput(
+                customFilterText = customFilterText,
+                onCustomFilterTextChange = { customFilterText = it },
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it }
+            )
+        }
+        // Add a custom filter
+        composeTestRule.onNodeWithText("Add custom filter").performTextInput("MyFilter")
+        composeTestRule.onNodeWithContentDescription("Add filter").performClick()
+        // The active filters label and the filter chip should be visible
+        composeTestRule.onNodeWithText(activeFiltersLabel).assertIsDisplayed()
+        composeTestRule.onNodeWithText("MyFilter").assertIsDisplayed()
+    }
+
+    @Test
+    fun debugActiveFilters_clearAllFilters_removesFilters() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val activeFiltersLabel = context.getString(R.string.debug_active_filters)
+        composeTestRule.setContent {
+            var filterTexts by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf(listOf("A", "B")) }
+            com.geeksville.mesh.ui.debug.DebugActiveFilters(
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it }
+            )
+        }
+        // The active filters label and chips should be visible
+        composeTestRule.onNodeWithText(activeFiltersLabel).assertIsDisplayed()
+        composeTestRule.onNodeWithText("A").assertIsDisplayed()
+        composeTestRule.onNodeWithText("B").assertIsDisplayed()
+        // Click the clear all filters button
+        composeTestRule.onNodeWithContentDescription("Clear all filters").performClick()
+        // The filter chips should no longer be visible
+        composeTestRule.onNodeWithText("A").assertDoesNotExist()
+        composeTestRule.onNodeWithText("B").assertDoesNotExist()
+    }
+} 
--- a/app/src/androidTest/java/com/geeksville/mesh/compose/DebugSearchTest.kt
+++ b/app/src/androidTest/java/com/geeksville/mesh/compose/DebugSearchTest.kt
@@ -0,0 +1,178 @@
+/*
+ * Copyright (c) 2025 Meshtastic LLC
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+package com.geeksville.mesh.compose
+
+import androidx.compose.ui.test.assertIsDisplayed
+import androidx.compose.ui.test.junit4.createComposeRule
+import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.onNodeWithContentDescription
+import androidx.compose.ui.test.onRoot
+import androidx.compose.ui.test.performClick
+import androidx.compose.ui.test.performTextInput
+import androidx.compose.ui.test.performTouchInput
+import androidx.compose.ui.test.printToLog
+import androidx.compose.ui.test.printToString
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.geeksville.mesh.R
+import com.geeksville.mesh.model.LogSearchManager.SearchState
+import com.geeksville.mesh.ui.debug.DebugSearchBar
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import androidx.test.platform.app.InstrumentationRegistry
+import androidx.compose.runtime.getValue
+import androidx.compose.runtime.setValue
+
+@RunWith(AndroidJUnit4::class)
+class DebugSearchTest {
+
+    @get:Rule
+    val composeTestRule = createComposeRule()
+
+    @Test
+    fun debugSearchBar_showsPlaceholder() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val placeholder = context.getString(R.string.debug_default_search)
+        composeTestRule.setContent {
+            DebugSearchBar(
+                searchState = SearchState(),
+                onSearchTextChange = {},
+                onNextMatch = {},
+                onPreviousMatch = {},
+                onClearSearch = {}
+            )
+        }
+        composeTestRule.onNodeWithText(placeholder).assertIsDisplayed()
+    }
+
+    @Test
+    fun debugSearchBar_showsClearButtonWhenTextEntered() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val placeholder = context.getString(R.string.debug_default_search)
+        composeTestRule.setContent {
+            var searchText by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf("test") }
+            DebugSearchBar(
+                searchState = SearchState(searchText = searchText),
+                onSearchTextChange = { searchText = it },
+                onNextMatch = {},
+                onPreviousMatch = {},
+                onClearSearch = { searchText = "" }
+            )
+        }
+        composeTestRule.onNodeWithContentDescription("Clear search").assertIsDisplayed()
+            .performClick()
+        composeTestRule.onNodeWithText(placeholder).assertIsDisplayed()
+    }
+
+    @Test
+    fun debugSearchBar_searchFor_showsArrowsClearAndValues() {
+        val searchText = "test"
+        val matchCount = 3
+        val currentMatchIndex = 1
+
+        composeTestRule.setContent {
+            DebugSearchBar(
+                searchState = SearchState(
+                    searchText = searchText,
+                    currentMatchIndex = currentMatchIndex,
+                    allMatches = List(matchCount) { com.geeksville.mesh.model.LogSearchManager.SearchMatch(it, 0, 6, "Packet") },
+                    hasMatches = true
+                ),
+                onSearchTextChange = {},
+                onNextMatch = {},
+                onPreviousMatch = {},
+                onClearSearch = {}
+            )
+        }
+        // Check the match count display (e.g., '2/3')
+        composeTestRule.onNodeWithText("${currentMatchIndex + 1}/$matchCount").assertIsDisplayed()
+        // Check the navigation arrows
+        composeTestRule.onNodeWithContentDescription("Previous match").assertIsDisplayed()
+        composeTestRule.onNodeWithContentDescription("Next match").assertIsDisplayed()
+        // Check the clear button
+        composeTestRule.onNodeWithContentDescription("Clear search").assertIsDisplayed()
+    }
+
+    @Test
+    fun debugFilterBar_showsFilterButtonAndMenu() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val filterLabel = context.getString(R.string.debug_filters)
+        composeTestRule.setContent {
+            var filterTexts by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf(listOf<String>()) }
+            var customFilterText by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf("") }
+            val presetFilters = listOf("Error", "Warning", "Info")
+            com.geeksville.mesh.ui.debug.DebugFilterBar(
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it },
+                customFilterText = customFilterText,
+                onCustomFilterTextChange = { customFilterText = it },
+                presetFilters = presetFilters
+            )
+        }
+        // The filter button should be visible
+        composeTestRule.onNodeWithText(filterLabel).assertIsDisplayed()
+    }
+
+    @Test
+    fun debugFilterBar_addCustomFilter_displaysActiveFilter() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val activeFiltersLabel = context.getString(R.string.debug_active_filters)
+        composeTestRule.setContent {
+            var filterTexts by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf(listOf<String>()) }
+            var customFilterText by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf("") }
+            com.geeksville.mesh.ui.debug.DebugActiveFilters(
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it }
+            )
+            com.geeksville.mesh.ui.debug.DebugCustomFilterInput(
+                customFilterText = customFilterText,
+                onCustomFilterTextChange = { customFilterText = it },
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it }
+            )
+        }
+        // Add a custom filter
+        composeTestRule.onNodeWithText("Add custom filter").performTextInput("MyFilter")
+        composeTestRule.onNodeWithContentDescription("Add filter").performClick()
+        // The active filters label and the filter chip should be visible
+        composeTestRule.onNodeWithText(activeFiltersLabel).assertIsDisplayed()
+        composeTestRule.onNodeWithText("MyFilter").assertIsDisplayed()
+    }
+
+    @Test
+    fun debugActiveFilters_clearAllFilters_removesFilters() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+        val activeFiltersLabel = context.getString(R.string.debug_active_filters)
+        composeTestRule.setContent {
+            var filterTexts by androidx.compose.runtime.remember { androidx.compose.runtime.mutableStateOf(listOf("A", "B")) }
+            com.geeksville.mesh.ui.debug.DebugActiveFilters(
+                filterTexts = filterTexts,
+                onFilterTextsChange = { filterTexts = it }
+            )
+        }
+        // The active filters label and chips should be visible
+        composeTestRule.onNodeWithText(activeFiltersLabel).assertIsDisplayed()
+        composeTestRule.onNodeWithText("A").assertIsDisplayed()
+        composeTestRule.onNodeWithText("B").assertIsDisplayed()
+        // Click the clear all filters button
+        composeTestRule.onNodeWithContentDescription("Clear all filters").performClick()
+        // The filter chips should no longer be visible
+        composeTestRule.onNodeWithText("A").assertDoesNotExist()
+        composeTestRule.onNodeWithText("B").assertDoesNotExist()
+    }
+}