feat: add MQTT Map Reporting consent (#2006)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-14 03:46:25 -04:00 · 2025-06-03 10:39:58 -05:00
parent e4313e0bd3
commit 3115bbe58d
6 changed files with 360 additions and 84 deletions
--- a/app/src/androidTest/java/com/geeksville/mesh/compose/MapReportingPreferenceTest.kt
+++ b/app/src/androidTest/java/com/geeksville/mesh/compose/MapReportingPreferenceTest.kt
@@ -0,0 +1,109 @@
+/*
+ * Copyright (c) 2025 Meshtastic LLC
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+package com.geeksville.mesh.compose
+
+import androidx.compose.foundation.layout.Column
+import androidx.compose.ui.platform.LocalFocusManager
+import androidx.compose.ui.test.assertIsDisplayed
+import androidx.compose.ui.test.assertIsNotDisplayed
+import androidx.compose.ui.test.junit4.createComposeRule
+import androidx.compose.ui.test.onNodeWithText
+import androidx.compose.ui.test.performClick
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import androidx.test.platform.app.InstrumentationRegistry
+import com.geeksville.mesh.R
+import com.geeksville.mesh.ui.radioconfig.components.MapReportingPreference
+import org.junit.Assert
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class MapReportingPreferenceTest {
+
+    @get:Rule
+    val composeTestRule = createComposeRule()
+
+    private fun getString(id: Int): String =
+        InstrumentationRegistry.getInstrumentation().targetContext.getString(id)
+
+    var mapReportingEnabled = false
+    var shouldReportLocation = false
+    var positionPrecision = 5
+    var positionReportingInterval = 60
+
+    var mapReportingEnabledChanged = { enabled: Boolean ->
+        mapReportingEnabled = enabled
+    }
+    var shouldReportLocationChanged = { enabled: Boolean ->
+        shouldReportLocation = enabled
+    }
+    var positionPrecisionChanged = { precision: Int ->
+        positionPrecision = precision
+    }
+    var positionReportingIntervalChanged = { interval: Int ->
+        positionReportingInterval = interval
+    }
+
+
+    private fun testMapReportingPreference() = composeTestRule.setContent {
+        Column {
+            MapReportingPreference(
+                mapReportingEnabled = mapReportingEnabled,
+                shouldReportLocation = shouldReportLocation,
+                positionPrecision = positionPrecision,
+                onMapReportingEnabledChanged = mapReportingEnabledChanged,
+                onShouldReportLocationChanged = shouldReportLocationChanged,
+                onPositionPrecisionChanged = positionPrecisionChanged,
+                publishIntervalSecs = positionReportingInterval,
+                onPublishIntervalSecsChanged = positionReportingIntervalChanged,
+                enabled = true,
+                focusManager = LocalFocusManager.current,
+            )
+        }
+    }
+
+    @Test
+    fun testMapReportingPreference_showsText() {
+        composeTestRule.apply {
+            testMapReportingPreference()
+            // Verify that the dialog title is displayed
+            onNodeWithText(getString(R.string.map_reporting)).assertIsDisplayed()
+            onNodeWithText(getString(R.string.map_reporting_summary)).assertIsDisplayed()
+        }
+    }
+
+    @Test
+    fun testMapReportingPreference_toggleMapReporting() {
+        composeTestRule.apply {
+            testMapReportingPreference()
+            onNodeWithText(getString(R.string.i_agree)).assertIsNotDisplayed()
+            onNodeWithText(getString(R.string.map_reporting)).performClick()
+            Assert.assertFalse(mapReportingEnabled)
+            Assert.assertFalse(shouldReportLocation)
+            onNodeWithText(getString(R.string.i_agree)).assertIsDisplayed()
+            onNodeWithText(getString(R.string.i_agree)).performClick()
+            Assert.assertTrue(shouldReportLocation)
+            Assert.assertTrue(mapReportingEnabled)
+            onNodeWithText(getString(R.string.map_reporting)).performClick()
+            onNodeWithText(getString(R.string.i_agree)).assertIsNotDisplayed()
+            Assert.assertTrue(shouldReportLocation)
+            Assert.assertFalse(mapReportingEnabled)
+        }
+    }
+}