From 77ca2d62f058e673d78ef4d236cb7fb36e922e41 Mon Sep 17 00:00:00 2001
From: James Rich <2199651+jamesarich@users.noreply.github.com>
Date: Tue, 27 May 2025 08:45:57 -0500
Subject: [PATCH] refactor: Move MIN_DEVICE_VERSION to build config (#1946)

---
 app/build.gradle                                             | 2 +-
 app/src/main/java/com/geeksville/mesh/service/MeshService.kt | 2 +-
 buildSrc/src/main/kotlin/Configs.kt                          | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/build.gradle b/app/build.gradle
index a91377a43..d80151c92 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -35,7 +35,7 @@ android {
         versionCode Configs.VERSION_CODE // format is Mmmss (where M is 1+the numeric major number
         versionName Configs.VERSION_NAME
         testInstrumentationRunner "com.geeksville.mesh.TestRunner"
-
+        buildConfigField("String", "MIN_DEVICE_VERSION", "\"${Configs.MIN_DEVICE_VERSION}\"")
         // per https://developer.android.com/studio/write/vector-asset-studio
         vectorDrawables.useSupportLibrary = true
     }
diff --git a/app/src/main/java/com/geeksville/mesh/service/MeshService.kt b/app/src/main/java/com/geeksville/mesh/service/MeshService.kt
index d1253b52d..0614fc15b 100644
--- a/app/src/main/java/com/geeksville/mesh/service/MeshService.kt
+++ b/app/src/main/java/com/geeksville/mesh/service/MeshService.kt
@@ -185,7 +185,7 @@ class MeshService : Service(), Logging {
         /** The minimum firmware version we know how to talk to. We'll still be able
          * to talk to 2.0 firmwares but only well enough to ask them to firmware update.
          */
-        val minDeviceVersion = DeviceVersion("2.3.15")
+        val minDeviceVersion = DeviceVersion(BuildConfig.MIN_DEVICE_VERSION)
     }
 
     enum class ConnectionState {
diff --git a/buildSrc/src/main/kotlin/Configs.kt b/buildSrc/src/main/kotlin/Configs.kt
index 5a90490f4..8d4a962f2 100644
--- a/buildSrc/src/main/kotlin/Configs.kt
+++ b/buildSrc/src/main/kotlin/Configs.kt
@@ -23,4 +23,5 @@ object Configs {
     const val VERSION_CODE = 30604 // format is Mmmss (where M is 1+the numeric major number
     const val VERSION_NAME = "2.6.4"
     const val USE_CRASHLYTICS = true // Set to false if you don't want to use Firebase Crashlytics
+    const val MIN_DEVICE_VERSION = "2.5.14" // Minimum device firmware version supported by this app
 }