From d89b20f6842f7ea0ab50fa48ca9f6cfc94861536 Mon Sep 17 00:00:00 2001 From: James Rich Date: Mon, 13 Apr 2026 11:53:03 -0500 Subject: [PATCH] docs: update ProGuard docs, build-logic guide, and agent skills - desktop/README.md: document animation anti-merge rule, Room KMP package path, and cross-target rule alignment - BUILD_LOGIC_CONVENTIONS_GUIDE.md: add PUBLISHED_MODULES and SHARED_COMPILER_ARGS as consolidation examples, update test config snippet to reflect centralized configureKotlinAndroid() - code-review SKILL: add ProGuard/R8 checklist section - implement-feature SKILL: add release build verification step for new reflection-heavy dependencies --- .skills/code-review/SKILL.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.skills/code-review/SKILL.md b/.skills/code-review/SKILL.md index b39e2d0d9..6a774297c 100644 --- a/.skills/code-review/SKILL.md +++ b/.skills/code-review/SKILL.md @@ -55,3 +55,9 @@ When reviewing code, meticulously verify the following categories. Flag any devi ### 8. ProGuard / R8 Rules - [ ] **New Dependencies:** If a new reflection-heavy dependency is added (DI, serialization, JNI, ServiceLoader), verify keep rules exist in **both** `app/proguard-rules.pro` (R8) and `desktop/proguard-rules.pro` (ProGuard). The two files must stay aligned. - [ ] **Release Smoke-Test:** For dependency or ProGuard rule changes, verify `assembleRelease` and `./gradlew :desktop:runRelease` succeed. + +## Review Output Guidelines +1. **Be Specific & Constructive:** Provide exact file references and code snippets illustrating the required project pattern. +2. **Reference the Docs:** Cite `AGENTS.md` and project architecture playbooks to justify change requests (e.g., "Per AGENTS.md, `java.io.*` cannot be used in `commonMain`; please migrate to Okio"). +3. **Enforce Build Health:** Remind authors to run `./gradlew test allTests` locally to verify changes, especially since KMP `test` tasks are ambiguous. +4. **Praise Good Patterns:** Acknowledge correct usage of complex architecture requirements, like proper Navigation 3 scene transitions or elegant `commonMain` helper extractions.