From df4716999740c64fbe05e1a69cfda122d31f38cd Mon Sep 17 00:00:00 2001 From: Mike Cumings Date: Fri, 8 Apr 2022 08:56:30 -0700 Subject: [PATCH] MapFragment crashes is analytics are not allowed `binding` is only set in `onCreateView` when analytics are enabled, leading to a crash in `onViewCreated` when `binding` - a lateinit var - is attempted to be accessed. --- .../com/geeksville/mesh/ui/MapFragment.kt | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/app/src/main/java/com/geeksville/mesh/ui/MapFragment.kt b/app/src/main/java/com/geeksville/mesh/ui/MapFragment.kt index 2381276e0..70159574d 100644 --- a/app/src/main/java/com/geeksville/mesh/ui/MapFragment.kt +++ b/app/src/main/java/com/geeksville/mesh/ui/MapFragment.kt @@ -6,7 +6,8 @@ import android.os.Bundle import android.view.LayoutInflater import android.view.View import android.view.ViewGroup -import android.widget.* +import android.widget.EditText +import android.widget.Toast import androidx.core.content.ContextCompat import androidx.core.graphics.drawable.toBitmap import androidx.core.view.isVisible @@ -249,16 +250,16 @@ class MapFragment : ScreenFragment("Map"), Logging { override fun onViewCreated(viewIn: View, savedInstanceState: Bundle?) { super.onViewCreated(viewIn, savedInstanceState) -// binding.fabStyleToggle.setOnClickListener { -// -// //TODO: Setup Style menu for satellite view, street view, & outdoor view -// } - binding.downloadRegion.setOnClickListener { - // Display menu for download region - this.downloadRegionDialogFragment() - } // We might not have a real mapview if running with analytics if ((requireContext().applicationContext as GeeksvilleApplication).isAnalyticsAllowed) { +// binding.fabStyleToggle.setOnClickListener { +// //TODO: Setup Style menu for satellite view, street view, & outdoor view +// } + binding.downloadRegion.setOnClickListener { + // Display menu for download region + this.downloadRegionDialogFragment() + } + val vIn = viewIn.findViewById(R.id.mapView) mapView = vIn mapView?.let { v ->