From dfa16aff6bb3beea386f70112ee2d4850b4d1dc7 Mon Sep 17 00:00:00 2001 From: James Rich <2199651+jamesarich@users.noreply.github.com> Date: Fri, 10 Jul 2026 12:47:11 -0500 Subject: [PATCH] fix(settings): keep the Debug Panel accessible while disconnected (#6199) Co-authored-by: Claude Fable 5 --- .../feature/settings/radio/RadioConfig.kt | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/feature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/radio/RadioConfig.kt b/feature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/radio/RadioConfig.kt index fcdb3ffbc..dd725cb83 100644 --- a/feature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/radio/RadioConfig.kt +++ b/feature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/radio/RadioConfig.kt @@ -80,8 +80,6 @@ fun RadioConfigItemList( onNavigate: (Route) -> Unit, ) { val enabled = state.connected && !state.responseState.isWaiting() && !isManaged - // ponytail: Debug Log/App Logs read local device data, not the radio, so they stay usable offline. - val debugPanelEnabled = !state.responseState.isWaiting() && !isManaged Column(verticalArrangement = Arrangement.spacedBy(16.dp)) { RadioConfigSection(isManaged, enabled, onRouteClick) @@ -95,7 +93,7 @@ fun RadioConfigItemList( AdministrationSection(enabled, onNavigate) if (state.isLocal) { - AdvancedSection(isManaged, isOtaCapable, enabled, debugPanelEnabled, onNavigate) + AdvancedSection(isManaged, isOtaCapable, enabled, onNavigate) } } } @@ -192,13 +190,7 @@ private fun AdministrationSection(enabled: Boolean, onNavigate: (Route) -> Unit) } @Composable -private fun AdvancedSection( - isManaged: Boolean, - isOtaCapable: Boolean, - enabled: Boolean, - debugPanelEnabled: Boolean, - onNavigate: (Route) -> Unit, -) { +private fun AdvancedSection(isManaged: Boolean, isOtaCapable: Boolean, enabled: Boolean, onNavigate: (Route) -> Unit) { ExpressiveSection(title = stringResource(Res.string.advanced_title)) { if (isManaged) { ManagedMessage() @@ -227,10 +219,11 @@ private fun AdvancedSection( onClick = { onNavigate(SettingsRoute.TakServer) }, ) + // Always enabled: the Debug Panel reads app-local logs only — no radio connection, + // pending config response, or managed-mode restriction applies to it. ListItem( text = stringResource(Res.string.debug_panel), leadingIcon = MeshtasticIcons.BugReport, - enabled = debugPanelEnabled, onClick = { onNavigate(SettingsRoute.DebugPanel) }, ) }