From eaef459fdeaae3994c7de32242069e12e7f56e16 Mon Sep 17 00:00:00 2001 From: James Rich <2199651+jamesarich@users.noreply.github.com> Date: Fri, 13 Jun 2025 11:35:21 +0000 Subject: [PATCH] Refactor: split position precision constants (#2099) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com> --- .../ui/common/components/PositionPrecisionPreference.kt | 6 +++--- .../ui/radioconfig/components/MapReportingPreference.kt | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/geeksville/mesh/ui/common/components/PositionPrecisionPreference.kt b/app/src/main/java/com/geeksville/mesh/ui/common/components/PositionPrecisionPreference.kt index 547dd4bc4..5a19ddd8d 100644 --- a/app/src/main/java/com/geeksville/mesh/ui/common/components/PositionPrecisionPreference.kt +++ b/app/src/main/java/com/geeksville/mesh/ui/common/components/PositionPrecisionPreference.kt @@ -39,9 +39,9 @@ import kotlin.math.roundToInt private const val PositionEnabled = 32 private const val PositionDisabled = 0 -const val PositionPrecisionMin = 12 -const val PositionPrecisionMax = 15 -const val PositionPrecisionDefault = 14 +private const val PositionPrecisionMin = 10 +private const val PositionPrecisionMax = 19 +private const val PositionPrecisionDefault = 13 @Suppress("MagicNumber") fun precisionBitsToMeters(bits: Int): Double = 23905787.925008 * 0.5.pow(bits.toDouble()) diff --git a/app/src/main/java/com/geeksville/mesh/ui/radioconfig/components/MapReportingPreference.kt b/app/src/main/java/com/geeksville/mesh/ui/radioconfig/components/MapReportingPreference.kt index b183d2130..664752761 100644 --- a/app/src/main/java/com/geeksville/mesh/ui/radioconfig/components/MapReportingPreference.kt +++ b/app/src/main/java/com/geeksville/mesh/ui/radioconfig/components/MapReportingPreference.kt @@ -42,14 +42,14 @@ import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.unit.dp import com.geeksville.mesh.R import com.geeksville.mesh.ui.common.components.EditTextPreference -import com.geeksville.mesh.ui.common.components.PositionPrecisionMax -import com.geeksville.mesh.ui.common.components.PositionPrecisionMin import com.geeksville.mesh.ui.common.components.SwitchPreference import com.geeksville.mesh.ui.common.components.precisionBitsToMeters import com.geeksville.mesh.util.DistanceUnit import com.geeksville.mesh.util.toDistanceString import kotlin.math.roundToInt +private const val PositionPrecisionMin = 12 +private const val PositionPrecisionMax = 15 @Suppress("LongMethod") @Composable fun MapReportingPreference(