From f8b01071db1b5d1f86a996d61c0126d6bb06b035 Mon Sep 17 00:00:00 2001 From: James Rich Date: Mon, 11 May 2026 13:47:55 -0500 Subject: [PATCH] docs: mark round 2 brownfield gap tasks complete Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- specs/007-node-detail-metrics/tasks.md | 4 ++-- specs/008-radio-app-settings/tasks.md | 2 +- specs/010-onboarding/tasks.md | 2 +- specs/011-wifi-provisioning/tasks.md | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/specs/007-node-detail-metrics/tasks.md b/specs/007-node-detail-metrics/tasks.md index 54fa60b2e..0d35ff867 100644 --- a/specs/007-node-detail-metrics/tasks.md +++ b/specs/007-node-detail-metrics/tasks.md @@ -297,7 +297,7 @@ - **Priority**: Medium ### NDM-T101: Missing — HostMetricsLogScreen chart+card test coverage -- [ ] Add unit tests for `HostMetricsChart` data model and `formatBytes` edge cases (exact boundaries) +- [x] Add unit tests for `HostMetricsChart` data model and `formatBytes` edge cases (exact boundaries) - **Rationale**: `formatBytes` is tested but chart data transformation and card selection sync are not. - **Priority**: Low @@ -308,7 +308,7 @@ - **Priority**: Medium ### NDM-T103: Missing — Environment NaN guard tests -- [ ] Add tests verifying that `NaN` temperature, humidity, and pressure values are correctly filtered (not rendered, not charted) +- [x] Add tests verifying that `NaN` temperature, humidity, and pressure values are correctly filtered (not rendered, not charted) - **Rationale**: The code has `isNaN()` guards but no tests validate them. - **Priority**: Low diff --git a/specs/008-radio-app-settings/tasks.md b/specs/008-radio-app-settings/tasks.md index 376622d28..6ba881faf 100644 --- a/specs/008-radio-app-settings/tasks.md +++ b/specs/008-radio-app-settings/tasks.md @@ -328,7 +328,7 @@ - Target: `commonTest/radio/CleanNodeDatabaseScreenTest.kt` - Gap: Only ViewModel is tested, not the composable -- [ ] **SET-T073**: Add integration test for profile import → export round-trip verifying `DeviceProfile` protobuf fidelity +- [x] **SET-T073**: Add integration test for profile import → export round-trip verifying `DeviceProfile` protobuf fidelity - Target: `commonTest/radio/ProfileRoundTripTest.kt` - Gap: Import and export are tested individually but not end-to-end diff --git a/specs/010-onboarding/tasks.md b/specs/010-onboarding/tasks.md index 98f9d4838..55f273081 100644 --- a/specs/010-onboarding/tasks.md +++ b/specs/010-onboarding/tasks.md @@ -81,7 +81,7 @@ ## Gaps — Uncompleted Tasks -- [ ] **OB-T100**: Extract hardcoded notification channel ID `"my_alerts"` to a shared constant or resource +- [x] **OB-T100**: Extract hardcoded notification channel ID `"my_alerts"` to a shared constant or resource - File: `feature/intro/src/androidMain/kotlin/org/meshtastic/feature/intro/IntroNavGraph.kt` (line 112) - Rationale: Hardcoded string is fragile; should reference the same constant used when the channel is created. diff --git a/specs/011-wifi-provisioning/tasks.md b/specs/011-wifi-provisioning/tasks.md index f10f9825d..0daf57e87 100644 --- a/specs/011-wifi-provisioning/tasks.md +++ b/specs/011-wifi-provisioning/tasks.md @@ -187,12 +187,12 @@ ## Identified Gaps (not yet implemented) ### WFP-T023: Expose hidden network provisioning in UI -- [ ] Add a "Hidden Network" toggle or option in `ConnectedContent` that sets `hidden = true` when calling `provisionWifi` +- [x] Add a "Hidden Network" toggle or option in `ConnectedContent` that sets `hidden = true` when calling `provisionWifi` - [ ] Domain layer already supports `CMD_CONNECT_HIDDEN` (2) — only UI wiring needed - **Priority**: Low — niche use case ### WFP-T024: Add retry mechanism for BLE scan timeout -- [ ] When BLE scan times out (10s), offer a "Retry" button instead of requiring the user to navigate back and re-enter +- [x] When BLE scan times out (10s), offer a "Retry" button instead of requiring the user to navigate back and re-enter - [ ] Consider exponential backoff or a manual retry count limit - **Priority**: Medium — improves UX for unreliable BLE environments