mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-09-12 21:30:02 -04:00
James Rich
1f532c7644
buildersOnly protos are constructed through Builder().also { }, and detekt
counts each lambda toward complexity, so a settings screen scores a point per
row it writes without gaining a branch. MQTTConfigScreen reads 33 against a
limit of 15; LoRaConfigScreen 27, DeviceConfigScreenCommon 23. Nothing there
got harder to follow, so raise allowedComplexity to 35, LongMethod to 70 and
LargeClass to 1100 rather than restructure twenty config screens to satisfy a
metric that is measuring the wrong thing.
MagicNumber has no threshold and was not loosened. Its seven reports were all
numbers that had been exempt as named arguments until the rewrite made them
assignments: two in CommandSenderImpl now use the MILLIS_PER_SECOND constant
that file already declares, and the rest are Compose preview sample data, so
MagicNumber gains the same ignoreAnnotated list LongMethod already carries.
One preview helper is not itself annotated and is suppressed in place.
Verified with --rerun-tasks: 1844 of 1844 tasks executed, no cache replay.
:core:data
Overview
The :core:data module holds the concrete implementations of the :core:repository contracts, serving as the primary data source for ViewModels in feature modules. It orchestrates data flow between the local database (core:database), remote services, and network repositories.
Key Components
1. Repository implementations (repository/)
NodeRepositoryImpl: High-level access to node information and mesh state (Room KMP backed).MeshLogRepositoryImpl: Access to historical logs and diagnostics.FirmwareReleaseRepositoryImpl: Manages the discovery and retrieval of firmware updates.
2. Manager implementations (manager/)
SessionManagerImpl: Per-node remote-admin passkey store.PacketHandlerImpl/MeshMessageProcessorImpl: Inbound mesh packet handling and message processing.
Dependency Graph
graph TB
:core:data[data]:::kmp-library
:core:data --> :core:repository
:core:data -.-> :core:common
:core:data -.-> :core:database
:core:data -.-> :core:datastore
:core:data -.-> :core:di
:core:data -.-> :core:model
:core:data -.-> :core:network
:core:data -.-> :core:prefs
:core:data -.-> :core:takserver
:core:data -.-> :core:testing
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;