mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-06-15 09:19:05 -04:00
037e3f549b
The node actions dropdown (favorite, mute, message, etc.) stopped
appearing after visiting a node detail screen and navigating back.
This is a known issue with Popup anchoring in adaptive navigation
layouts (ListDetailSceneStrategy).
Three fixes applied:
1. Move animateItem() from NodeItem/NodeItemCompact children to the
root Box — animateItem() must be on the root composable of the
LazyColumn item for correct layout tracking. Having it on a child
caused stale layout coordinates after pane transitions.
2. Wrap NodeContextMenu in Box(Modifier.matchParentSize()) to give
the DropdownMenu a properly-sized popup anchor that survives
ListDetailSceneStrategy pane deactivation/reactivation.
3. Replace stale remember(node) { ourNode?.num == node.num } with a
direct computation for isThisNode — the old version was missing
ourNode as a remember key, so it could return stale results when
ourNode loaded after initial composition.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
:feature:node
Overview
Targets: Android · JVM (Desktop) · iOS
The :feature:node module handles node-centric features, including the node list, detailed node information, telemetry charts, and the compass.
Key Components
1. NodeListScreen
Displays all nodes currently known to the application.
2. NodeDetailScreen
Shows exhaustive details for a specific node, including hardware info, position history, and last heard status.
3. MetricsViewModel
Manages the retrieval and display of telemetry data (e.g., battery, SNR, environment metrics) using charts.
4. CompassViewModel
Provides a compass interface to show the relative direction and distance to other nodes.
Dependency Graph
graph TB
:feature:node[node]:::kmp-feature
:feature:node -.-> :core:common
:feature:node -.-> :core:data
:feature:node -.-> :core:database
:feature:node -.-> :core:datastore
:feature:node -.-> :core:domain
:feature:node -.-> :core:model
:feature:node -.-> :core:navigation
:feature:node -.-> :core:proto
:feature:node -.-> :core:repository
:feature:node -.-> :core:resources
:feature:node -.-> :core:service
:feature:node -.-> :core:ui
:feature:node -.-> :core:di
:feature:node -.-> :feature:map
:feature:node -.-> :core:testing
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;