mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-09-18 17:19:42 -04:00
James RichandClaude Sonnet 5
59fc12b4a8
Root-caused via #6682/#6693: Node.hopsAway defaults to the sentinel -1
instead of null, and nothing distinguished a locally-retained node from
one the connected radio just reported this session. Together that made
a legitimately cached row (multi-radio use, or a radio with a smaller
NodeDB than the phone) render as if it were freshly heard with 0 hops,
0 SNR, 0 RSSI.
- Add Node.hopsAwayOrNull, extending the existing snrOrNull/rssiOrNull
pattern, and fix both copies of getRelayNode (the live one in
Packet.kt and the unused one in Node.kt) whose plain
minByOrNull { it.hopsAway } let the unresolved -1 sentinel look
closer than a real hop count.
- Track the current connection session's exact NodeDB membership via
NodeManager.currentSessionNodeNums, published right after each Stage
2 handshake and reconciled against the same generation-race window
already used for connectionIdentity.
- Add a "Saved on phone" badge (node list rows + detail screen) for any
node retained locally but absent from that snapshot, and stop those
rows from claiming "online" from a cached, no-longer-current
lastHeard (list rows, a11y description).
New/updated tests across core:model, core:data, core:ui, core:database
and feature:node; screenshot goldens regenerated for the new "Saved on
phone" previews. Full baseline
(spotlessApply/spotlessCheck/detekt/assembleDebug/test/allTests) and
:screenshot-tests:validateDebugScreenshotTest are green.
Fixes #6263
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
:core:model (Meshtastic Domain Models)
Overview
The :core:model module is a Kotlin Multiplatform (KMP) library containing the domain models and data classes used throughout the application and its API. These models are platform-agnostic and designed to be shared across Android, JVM, and future supported platforms.
Multiplatform Support
Models are plain commonMain Kotlin types — @Serializable (kotlinx.serialization) data classes and
@JvmInline value classes — with no Android Parcelable dependency, so they are shared verbatim
across Android, JVM, and iOS.
Key Models
DataPacket: Represents a mesh packet (text, telemetry, etc.).Node: Contains detailed information about a node (position, SNR, battery, etc.).NodeAddress/ContactKey: Type-safe node addressing (Broadcast/Local/ByNum/ById) and contact-key parsing, replacing stringly-typed"^all"/"!hex"handling.DeviceHardware: Represents supported Meshtastic hardware devices and their capabilities.Channel: Represents a mesh channel configuration.
Usage
This module is a core dependency of most feature modules.
// In commonMain
implementation(projects.core.model)
Structure
commonMain: Contains the majority of domain models and logic.androidMain: Contains Android-specific utilities and implementations forexpectdeclarations.androidUnitTest: Contains unit tests that require Android-specific features (likeParceltesting via Robolectric).
Dependency Graph
graph TB
:core:model[model]:::kmp-library
:core:model --> :core:common
:core:model --> :core:resources
:core:model -.-> :core:testing
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;