mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-06-04 20:15:13 -04:00
e6b08fff65
P3 — Pre-existing bugs surfaced when files were moved:
- MeshUser.hwModelString: the unconditional replace('p', '.') mangles any
hardware enum name containing a literal 'p' (HELTEC_WIRELESS_PAPER had
become 'heltec-wireless-.a.er'). Use a regex bounded by digits so version
markers like RAK4631_V1P0 → rak4631-v1.0 still work and other 'p's are
preserved.
- EnvironmentMetrics.relativeHumidity: document the special-case
`it != 0.0f` filter. It's intentional — firmware reports 0%RH when the
humidity sensor isn't fitted and a real outdoor 0%RH reading is
physically implausible. Other fields don't get this guard because their
zero values (0V, 0A, 0°C) are meaningful sensor data.
P4 — Performance regressions introduced by the AIDL refactor:
- NodeManagerImpl: restore the O(1) byId index. The refactor dropped the
secondary nodeDBbyID map and made getNodeById a linear scan over the
whole node DB. getNodeById is called per-incoming-packet from
MeshDataHandlerImpl (three times — shouldFilterMessage,
handleNotificationMessage, getSenderName) and per-outbound send from
CommandSenderImpl.resolveNodeNum.ById. The new NodeIndex holder maintains
byNum and byId together in a single atomic ref so concurrent readers
never see an inconsistent snapshot.
- NodeWithRelations.toModel: inline directly to a single Node(...)
constructor call. The previous form did `node.toModel().copy(metadata=…,
manuallyVerified=…)` which allocated the Node twice per DB row — wasteful
on every nodeDBbyNum emission.
- NodeRepositoryImpl.getUser: replace two NodeAddress.fromString(userId)
calls with a single string equality check against NodeAddress.ID_LOCAL.
getUser is on the hot path for paged contacts and message arrival.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
:core:data
Overview
The :core:data module implements the Repository pattern, serving as the primary data source for ViewModels in feature modules. It orchestrates data flow between the local database (core:database), remote services, and network repositories.
Key Components
1. Repositories
NodeRepository: High-level access to node information and mesh state.MeshLogRepository: Access to historical logs and diagnostics.FirmwareReleaseRepository: Manages the discovery and retrieval of firmware updates.
2. Data Sources
Internal components that handle raw data fetching from APIs or disk.
Dependency Graph
graph TB
:core:data[data]:::kmp-library
:core:data --> :core:repository
:core:data -.-> :core:common
:core:data -.-> :core:database
:core:data -.-> :core:datastore
:core:data -.-> :core:di
:core:data -.-> :core:model
:core:data -.-> :core:network
:core:data -.-> :core:prefs
:core:data -.-> :core:proto
:core:data -.-> :core:takserver
:core:data -.-> :core:testing
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;