Files
Meshtastic-Android/core/network
James Rich 62e2c731b0 test: add unit tests and fix constitution violations for specs 004-017
Brownfield gap remediation across multiple modules:

Constitution violation fixes:
- Replace hardcoded strings in Contacts.kt with stringResource()
- Add KDoc to ConnectionActionButtonStyle enum values
- Add missing string resources to strings.xml

Build-logic fix:
- Override javaLauncher for test tasks to JDK 21, fixing JVM class
  version mismatch when published modules target JVM 17

New test coverage:
- core/model: NodeTest, DataPacketTest, MeshDataMapperTest
- core/database: ConvertersTest, QuickChatActionDaoTest,
  DatabaseManagerWithDbRetryTest
- core/service: ServiceRepositoryImplTest,
  DirectRadioControllerImplTest
- core/network: HeartbeatSenderTest, MQTTRepositoryImplTest
- core/data: MeshRouterImplTest
- core/ble: KableBleConnectionTest
- feature/node: MetricsViewModelTest (CSV), CompassViewModelTest,
  NodeDetailViewModelTest (remote admin)
- feature/map: BaseMapViewModelTest (waypoint expiration)
- feature/settings: SettingsViewModelTest (saveDataCsv),
  RadioConfigViewModelTest (MQTT probe)
- feature/firmware: WifiOtaTransportTest

Test seams:
- NodeDetailViewModel: add NodeDetailUiTextResolver
- KableBleScanner: add filter behavior test seam

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-11 13:09:15 -05:00
..

:core:network

Overview

The :core:network module handles all internet-based communication, including fetching firmware metadata, device hardware definitions, and map tiles (in the fdroid flavor). It also provides the shared radio transport layer (TCPInterface, SerialTransport, BleRadioInterface).

Key Components

1. Ktor Client

The module uses Ktor as its primary HTTP client for high-performance, asynchronous networking.

2. Remote Data Sources

  • FirmwareReleaseRemoteDataSource: Fetches the latest firmware versions from GitHub or Meshtastic's metadata servers.
  • DeviceHardwareRemoteDataSource: Fetches definitions for supported Meshtastic hardware devices.

3. Shared Transports

  • BleRadioInterface: Multiplatform BLE transport powered by Kable.
  • TCPInterface: Multiplatform TCP transport.
  • SerialTransport: JVM-shared USB/Serial transport powered by jSerialComm.
  • BaseRadioTransportFactory: Common factory for instantiating the KMP transports.

Module dependency graph

graph TB
  :core:network[network]:::kmp-library

classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;