mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-05-30 17:47:55 -04:00
b97ff4d712
NodeController toggled favorite/ignore state by reading the current node then flipping it (read-modify-write), which races concurrent callers and forced a latent bug in SendMessageUseCase: it only ever wants to favorite a node, but called a toggle, so a node that became favorite between the guard and the call would have been un-favorited. Replace with explicit-target idempotent operations mirroring the SDK's AdminApi: - favoriteNode(num) -> setFavorite(num, Boolean) - ignoreNode(num) -> setIgnored(num, Boolean) - muteNode(num) -> toggleMuted(num) (mute is genuinely a firmware toggle) Impls no-op when the node is already in the requested state. Callers (NodeManagementActions confirm dialogs) pass !node.isFavorite from the state the UI showed the user; SendMessageUseCase passes favorite = true. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
:feature:node
Overview
Targets: Android · JVM (Desktop) · iOS
The :feature:node module handles node-centric features, including the node list, detailed node information, telemetry charts, and the compass.
Key Components
1. NodeListScreen
Displays all nodes currently known to the application.
2. NodeDetailScreen
Shows exhaustive details for a specific node, including hardware info, position history, and last heard status.
3. MetricsViewModel
Manages the retrieval and display of telemetry data (e.g., battery, SNR, environment metrics) using charts.
4. CompassViewModel
Provides a compass interface to show the relative direction and distance to other nodes.
Dependency Graph
graph TB
:feature:node[node]:::kmp-feature
:feature:node -.-> :core:common
:feature:node -.-> :core:data
:feature:node -.-> :core:database
:feature:node -.-> :core:datastore
:feature:node -.-> :core:domain
:feature:node -.-> :core:model
:feature:node -.-> :core:navigation
:feature:node -.-> :core:proto
:feature:node -.-> :core:repository
:feature:node -.-> :core:resources
:feature:node -.-> :core:service
:feature:node -.-> :core:ui
:feature:node -.-> :core:di
:feature:node -.-> :feature:map
:feature:node -.-> :core:testing
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;