mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-05-12 16:55:02 -04:00

Files

James Rich 74ba959b24 feat: DRY SDK integration — shared bridge, Desktop cutover, dead infra deletion

Major architectural changes:

1. SHARED KMP BRIDGE (core/data/radio/):
   - RadioClientAccessor: Platform-agnostic interface for SDK RadioClient
   - SdkRadioController: Shared RadioController impl (replaces per-platform copies)
   - SdkStateBridge: Shared SDK→repository bridge (event dispatch, node sync)
   - SdkPacketHandler: Thin SDK-backed PacketHandler for MQTT/XModem/History

2. DESKTOP SDK CUTOVER:
   - DesktopRadioClientProvider: TCP + Serial transport support
   - Removed DirectRadioControllerImpl (old desktop radio path)
   - Desktop now shares the same SDK bridge code as Android

3. DEAD INFRASTRUCTURE DELETION (~5,100 LOC removed):
   - PacketHandlerImpl, MeshDataHandlerImpl, MeshRouterImpl
   - CommandSenderImpl, MeshActionHandlerImpl, MeshConfigFlowManagerImpl
   - MeshConnectionManagerImpl, AdminPacketHandlerImpl
   - ServiceBroadcasts (Android intent-based pub/sub)
   - NodeRepositoryImpl (Room-backed, replaced by SdkNodeRepositoryImpl)
   - 8 trivial UseCases (SetLocale, SetTheme, ToggleAnalytics, etc.)
   - All associated test files for deleted impls
   - Deleted interfaces: AdminPacketHandler, CommandSender, MeshActionHandler,
     MeshConfigFlowManager, MeshConnectionManager, MeshRouter, ServiceBroadcasts

4. NEW FEATURES:
   - NodeMetadataEntity + Room migration 38→39 (persistent favorites/notes)
   - AppMetadataRepository (clean access to node metadata)
   - MessagePersistenceHandler (focused rememberDataPacket for StoreForward)

All three targets compile clean: :app:compileGoogleDebugKotlin,
:desktop:compileKotlin, :core:data:jvmTest passes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

2026-05-06 17:52:05 -05:00

schemas/org.meshtastic.core.database.MeshtasticDatabase

feat: DRY SDK integration — shared bridge, Desktop cutover, dead infra deletion

2026-05-06 17:52:05 -05:00

src

feat: DRY SDK integration — shared bridge, Desktop cutover, dead infra deletion

2026-05-06 17:52:05 -05:00

build.gradle.kts

refactor(build): build-logic cleanup, CC safety, and detekt 2.0 upgrade (#5311 )

2026-05-01 02:48:37 +00:00

detekt-baseline.xml

refactor: migrate core modules to Kotlin Multiplatform and consolidat… (#4735 )

2026-03-06 22:06:50 +00:00

README.md

refactor: BLE transport and UI for Kotlin Multiplatform unification (#4911 )

2026-03-25 02:15:51 +00:00

README.md

`:core:database`

This module provides the local Room database persistence layer for the application using Room Kotlin Multiplatform (KMP).

Key Components

MeshtasticDatabase: The main Room database class, defined in commonMain.
DAOs (Data Access Objects):
- NodeInfoDao: Manages storage and retrieval of node information (NodeEntity). Contains critical logic for handling Public Key Conflict (PKC) resolution and preventing identity wiping attacks.
- PacketDao: Handles storage of mesh packets, including text messages, waypoints, and reactions.
Entities:
- NodeEntity: Represents a node on the mesh.
- Packet: Represents a stored packet.
- ReactionEntity: Represents emoji reactions to packets.

Security Considerations

Public Key Conflict (PKC) Handling

The NodeInfoDao implements specific logic to protect against impersonation and "wipe" attacks:

Wipe Protection: Receiving an is_licensed=true packet (which normally clears the public key for compliance) will not clear an existing valid public key if one is already known. This prevents attackers from sending fake licensed packets to wipe keys from the DB.
Conflict Detection: If a new key arrives for an existing node ID that conflicts with a known valid key, the key is set to ERROR_BYTE_STRING to flag the potential impersonation.

Module dependency graph

graph TB
  :core:database[database]:::kmp-library

classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;