mirror/MuditaOS
1
0
Fork 0
mirror of https://github.com/mudita/MuditaOS.git synced 2026-06-14 03:25:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fied memory leak in destructor of database model.

Browse Source
This commit is contained in:
Robert Borzecki
2019-09-18 00:26:19 +02:00
parent e8047180b2
commit 8b7e7a7cca
7 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
module-apps/application-notes/NotesModel.cpp
View File

@@ -16,7 +16,6 @@ NotesModel::NotesModel( app::Application* app) : DatabaseModel(app, 3){
}
NotesModel::~NotesModel() {
// TODO Auto-generated destructor stub
}
void NotesModel::requestRecordsCount() {
@@ -40,10 +39,10 @@ void NotesModel::requestRecords( const uint32_t offset, const uint32_t limit ) {
bool NotesModel::updateRecords( std::unique_ptr<std::vector<NotesRecord>> records, const uint32_t offset, const uint32_t limit, uint32_t count ) {
LOG_INFO("Offset: %d, Limit: %d Count:%d", offset, limit, count);
for( uint32_t i=0; i<records.get()->size(); ++i ) {
LOG_INFO("id: %d, filename: %s", records.get()->operator [](i).ID, records.get()->operator [](i).path.c_str());
}
// LOG_INFO("Offset: %d, Limit: %d Count:%d", offset, limit, count);
// for( uint32_t i=0; i<records.get()->size(); ++i ) {
// LOG_INFO("id: %d, filename: %s", records.get()->operator [](i).ID, records.get()->operator [](i).path.c_str());
// }
DatabaseModel::updateRecords( std::move(records), offset, limit, count );
@@ -51,6 +50,7 @@ bool NotesModel::updateRecords( std::unique_ptr<std::vector<NotesRecord>> record
}
gui::ListItem* NotesModel::getItem( int index, int firstElement, int prevElement, uint32_t count, int remaining, bool topDown ) {
std::shared_ptr<NotesRecord> note = getRecord( index );
SettingsRecord& settings = application->getSettings();
@@ -58,8 +58,6 @@ gui::ListItem* NotesModel::getItem( int index, int firstElement, int prevElement
if( note == nullptr )
return nullptr;
LOG_INFO("Note item: %d", index);
gui::NotesItem* item = new gui::NotesItem(this, !settings.timeFormat12 );
if( item != nullptr ) {
item->setNote(note);