Add proper catch2 support:
- add catch2 as a submodule
- add cmake function to add test easily
- discover each test in test binary
- remove copies of catch.hpp
- do not try to process tests for rt1051
Do not test internals of utf8, only public interface (nasty bugs could
occur otherwise).
Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
Introduced format aware phone number comparison to allow improved
matching phone numbers with contacts.
Phone numbers are also displayed formatted on a phonebook/calllog
list view and on detailed contact info view.
Entered and e164 number are verified to match each other during
processing db request.
Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
Convert utf8 tests which were written with gtest help to catch2
framework.
Fix broken index operator test (index operator decodes to UTF-32).
Remove dead gtest dependency
Fix empty calllog title when number comes in national format. The
problem was caused by:
1. making assumption that every number from cellular network comes in
e164 format which is not true,
2. using e164 number when looking for contact matching calllog entry
without checking if e164 exists for calllog entry.
Fix problem by:
a.d.1 - replacing `PhoneNumber::viewFromE164` with less strict
`PhoneNumber::Parse` method which basically is a convenience method
which creates `PhoneNumber` entity and uses it to create a `View`.
a.d.2 - instead of fetching e164 directly introduce `getNonEmpty` method
of a View, which returns e164 number if it is present and entered number
otherwise.
Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
Bugs:
- invalid number validation
- no `const` qualifier in comparison operators
- lack of comparison operator for PhoneNumber::View
Add appropriate unit tests.
* [GED-2539] Timestamp : changed buffer to heap one
[EGD-2539] implemented 1st version of Duration class
[EGD-2539] added autoformating of the output
[EGD-2539] clean up
[EGD-2539] used duration in call and calllog
added Duration operators
[EGD-2539] add better duartions to calllog.db
[EGD-2539] format file
* [EGD-2539] fixes after rebase
* [EGD-2539] displayed format follows design guidline
* [EGD-2539] added UT for duration class and necessary FW fixes
* [EGD-2539] fixed tim_conversion UT
* [EGD-2539] PR fixes
* [EGD-2539] added move constructor to UTF8 class
* [EGD-2539] added checking for nullptr in fillContactData
* [EGD-2539] PR fixes
* [EGD-2420] tokenizer refactoring
new class CellularCall
* [EDG-2420] new file added
* [EGD-2420] fixed include
* [EGD-2420] added new ModemCall type and its usage in Sevice Cellular.
missing dep in module-cellular.
Fix in tokenizer.
* [EGD-2420] get calllogrecordID one adding new entry to DB
number as contact name
* [EGD-2420] fixes at DB level api for update and delete
Outgoing call seems to add proper calllog entries now
* [EGD-2420][fix] fix for HF during call before full modem init
* [EGD-2420] incoming and missed calls are handled
code clean-up
* [EGD-2420] ModemCall::to_string
* [EGD-2420] added proper exceptions
* [EGD-2420] minor clean up
* [EGD-2420] split string with multichar delimiter
* [EGD-2420] done some TODOs
* [EGD-2420] PR fixes
* [EGD-2420] separation between cellularcall and cellularservice
PR fixes
* [EGD-2420] duration based on timestamp instead of timer
* [EGD-2420] new to_strings
* [EGD-2420] fixes after rebase
* [EGD-2420] operator<<
* [EGD-2420] changed split params
* [EGD-2420] changed returned db id
* [EGD-2420] comment with explantaion
* utils::time::Locale - class for Locale loading/management for i18n
* Time generall class for time conversions
* SysTime specialized class for time conversion based on systime
