Commit Graph

111 Commits

Author SHA1 Message Date
Przemyslaw Brudny
fa3968a3ee [EGD-3451] PR Changes. 2020-08-07 12:26:44 +02:00
Przemyslaw Brudny
010ecf6b37 [EGD-3451] Notifications and db messages for list refresh added to Phonebook and Messages. 2020-08-07 12:26:44 +02:00
Pawel Olejniczak
021910ba0b [EGD-3488] Remove more not needed checks of contact numbers received from db 2020-08-07 10:14:38 +02:00
Pawel Olejniczak
7689f7dd2c [EGD-3488] Remove incorrect verification of contact numbers received from db 2020-08-07 10:14:38 +02:00
Marcin Smoczyński
885fe1083a db: improve query handling
Introduce a new way to handle query responses allowing to deal with
races:
 - bind reponse with request,
 - handle responses with an observer-like interface.

Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
2020-08-06 14:13:35 +02:00
Marcin Smoczyński
060df7e11f [EGD-3370] phonebook: fix alternative number
Enable handling of an alternative number in phonebook.

Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
2020-08-04 17:07:37 +02:00
Mateusz Grzywacz
49a296a0cf [EGD-3281] SMS converstion view - UT 2020-07-24 13:29:41 +02:00
Mateusz Grzywacz
db82cc2caa [EGD-3281] SMS converstion view - no try/catch 2020-07-24 13:29:41 +02:00
Mateusz Grzywacz
a401cb993a [EGD-3281] SMS converstion view - review notes
* extract update thread summary method
* move SmsTableRow → *$new* SmsRecord
2020-07-24 13:29:41 +02:00
Mateusz Grzywacz
b26315c8d9 [EGD-3281] SMS converstion view - refresh thread snippet on db change 2020-07-24 13:29:41 +02:00
Radoslaw Wicik
d30d135fba [EGD-3386] Add proper displaying in gui. 2020-07-24 11:26:29 +02:00
Radoslaw Wicik
ee685049ae [EGD-3386] Add contact flags to DB 2020-07-24 11:26:29 +02:00
Mateusz Grzywacz
6ebdc5f447 [EGD-3435] fix SMS send again (moved to Query) 2020-07-22 13:37:30 +02:00
Mateusz Grzywacz
e832fda678 [feature] small fixes in message types etc 2020-07-20 14:27:46 +02:00
Mateusz Grzywacz
17c9d3ee7b [feature] use .isValid() to validate all interface entires 2020-07-20 14:10:11 +02:00
Mateusz Grzywacz
8392a8948f [feature] move all remaining interfaces to Record 2020-07-20 14:10:11 +02:00
Mateusz Grzywacz
ac5bdf4c01 [feature] move ContactsAddressTableRow to Record 2020-07-20 14:10:11 +02:00
alek
cd5e381bc2 [EGD-3402] pr fixes 2020-07-16 13:49:44 +02:00
alek
e53982a968 [EGD-3402] added Record base class for sms and thread table classes 2020-07-16 13:49:44 +02:00
alek
edeb310b62 [EDG-3402] minor clean up and error handling 2020-07-16 13:49:44 +02:00
alek
c6f4a9f83e [EGD-3397] fix for HF on opening thread for deleted contact 2020-07-16 13:49:44 +02:00
Radoslaw Wicik
61db889b18 [EGD-3428] Fix db interface functions names - Update Tests 2020-07-16 10:55:07 +02:00
Radoslaw Wicik
c2b8a33d4b [EGD-3428] Fix db interface functions names - Database class 2020-07-16 10:55:07 +02:00
Radoslaw Wicik
ad84b981d9 [EGD-3428] Fix db interface functions names - Table class 2020-07-16 10:55:07 +02:00
Alek Rudnik
26431f41e2 [EGD-2810] Added sms option to mark conversation as read/unread (#522)
* [EGD-2810] SMS - Added option to mark conversation as read/unread

* [EGD-2810] PR fixes
2020-07-13 14:39:36 +02:00
Alek Rudnik
3baa85363d Egd 2835 sms unread vs unseen notifications (#514)
* [EGD-2835] thread table based sms not read notifications

* [EGD-2835] removed redundant read field from sms db table

* [EGD-2835] clear unread status of a thread if thre thread is open

* [EGD-2835] updated database documentation

* [EGD-2835] added changelog
2020-07-10 11:57:19 +02:00
Marcin Smoczyński
df60d9c240 [EGD-3251] phonebook: improved search
Refactor phonebook's models to merge both implementation. One model
class is used for both main and search results windows.

Improve search by matching entered string against:
 - first_name " " last_name
 - last_name " " fist_name
Sort results by last_name " " first_name, favs first.

Small improvement to the list view has been added to deal with
asynchronous db reads.

Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
2020-07-09 11:28:45 +02:00
Mateusz Grzywacz
194085de0a [EGD-3348] subclass ThreadRecord from Record struct 2020-07-07 16:56:46 +02:00
Alek Rudnik
019b5cf719 Egd 3338 missed calls home scree notifications (#463)
* [EGD-3338] Missed calls home screen notifications
2020-06-25 23:42:42 +02:00
Alek Rudnik
d5c8cb0c5b Egd 3343 add notifications database (#465)
* [EGD-3158] added UT for CallogTable and CalllogRecord

* [EGD-3343] added notifications db
2020-06-25 13:47:31 +02:00
Marcin Smoczyński
aeeafb43ca [EGD-2595] do not use string numbers in messaging
Use PhoneNumber::View instead.
Removed caching mechanism of ContactRecord, because it was causing
several problems and it was a bad place to put it anyway.

Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
2020-06-22 13:57:40 +02:00
Marcin Smoczyński
0936930063 [EGD-2593] improved matching contact by numbers
Introduced format aware phone number comparison to allow improved
matching phone numbers with contacts.

Phone numbers are also displayed formatted on a phonebook/calllog
list view and on detailed contact info view.

Entered and e164 number are verified to match each other during
processing db request.

Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
2020-06-17 14:01:38 +02:00
Alek Rudnik
44f7bbdf8a Egd 2799 unread message indication (#429)
* [EGD-2799] 
    Added unread thread indicator.
    Added last message in thread indicators:
    -Note sent:
    -You:
    -Draft:
2020-06-10 18:29:07 +02:00
Przemyslaw Brudny
5e72f8d006 [EGD-3094] Phonebook list redefined, lot of contact and search model fixes. 2020-06-03 19:23:16 +02:00
Przemyslaw Brudny
d2d97160e2 [EGD-3094] Basic Phonebook contact list migration to new ListView. 2020-06-03 19:23:16 +02:00
Pawel Olejniczak
bb3191ed73 [EGD-3126] Update tests of contact name formatting 2020-06-03 19:00:20 +02:00
Pawel Olejniczak
d47b837612 [EGD-3126] Fix printing number as a name 2020-06-03 19:00:20 +02:00
pholat
23df384c55 EGD-3087 SMS Search implemented (#374)
* EGD-3087 WIP adding SMS Querry

* EGD-3087 Added query virtual interface on Service top layer

Service shouldn't implement query logic and should be proxying that.

additionally:
- small fixes in includes
- shared service db name same way as apps and event manager

* EGD-3087 Query - want to work on interface not on db

* EGD-3087 Query gluecode works fine. Our query in SMS search calls getBySMSQuery

Changes cut off before any potential orm interface layer

* EGD-3087 WIP Interface in use

* EGD-3087 Query for SMS search works as designed

* EGD-3087 Query results should be on screen

* EGD-3087 BUG workaround - need to deep refresh display to show data

* EGD-3087 Searching for text from input works fine

* EGD-3087 Showing results / or empty results depending on query

* EGD-3087 Pre PR fixups

* EGD-3087 Empty search - getting back to prewious window ignore current

* EGD-3087 PR applied

* EGD-3087 PR - style fixed

* EGD-3087 Review - DB ListView handling moved to separate function

* EGD-3087 Workaround: crash on use after free fix

* EGD-3087 PR stylistic changes

* EGD-3087 PR cleanup applied

* EGD-3087 Added test for Query interface

* EGD-3087 renamed getByQuery to getQuery & finished tests

* EGD-3087 Post rebase fixup

* EGD-3087 PR - moved ListView request part to separate function

* EGD-3087 PR Fixups

* EGD-3087 Post rebase style fix

* EGD-3087 Added variable for DB service stack & const to getter function
2020-05-27 13:49:50 +02:00
Marcin Smoczyński
a4a8315b97 fix empty calllog list item
Fix empty calllog title when number comes in national format. The
problem was caused by:
 1. making assumption that every number from cellular network comes in
 e164 format which is not true,
 2. using e164 number when looking for contact matching calllog entry
 without checking if e164 exists for calllog entry.
Fix problem by:
a.d.1 - replacing `PhoneNumber::viewFromE164` with less strict
`PhoneNumber::Parse` method which basically is a convenience method
which creates `PhoneNumber` entity and uses it to create a `View`.
a.d.2 - instead of fetching e164 directly introduce `getNonEmpty` method
of a View, which returns e164 number if it is present and entered number
otherwise.

Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
2020-05-18 17:31:57 +02:00
Alek Rudnik
89eeba99eb Egd 3188 new sms enhancments (#355)
* [EGD-3188] new sms window - fix layout and functionalities

* [EGD-3188] sending sms from calllog and phonebook

* [EGD-3188] aborting the incoming call via sending sms template
Unufy sms ui common actions to use libphone number only
added default option to contactrecrord::getformattedname method

* [EGD-3188] fix for siwtching back from sms template window when the call is aborted

* [EGD-3188] PR fixes
2020-05-12 20:19:07 +02:00
Pawel Olejniczak
ed3eefa001 [EGD-3195] Add unit tests for contact name formatting 2020-05-12 11:54:36 +02:00
Pawel Olejniczak
700d44dd7c [EGD-3195] Fix contact name formatting 2020-05-11 13:30:16 +02:00
Pawel Olejniczak
443ea202e8 [EGD-3155] Remove label with second address line 2020-05-08 08:57:29 +02:00
Pawel Olejniczak
2014feabc7 [EGD-3155] Add changes suggested by reviewers 2020-05-08 08:57:29 +02:00
Pawel Olejniczak
6eed387019 [EGD-3155] Update db unit tests according to last changes with contact address 2020-05-08 08:57:29 +02:00
Pawel Olejniczak
c97d3201d9 [EGD-3155] Fix contact name formatting 2020-05-08 08:57:29 +02:00
Pawel Olejniczak
1656969f9a [EGD-3155] Unify formatting contact name 2020-05-08 08:57:29 +02:00
Pawel Olejniczak
f797b17b2a [EGD-3155] Adjust address id field names and change its type to integer 2020-05-08 08:57:29 +02:00
Pawel Olejniczak
8a713cf22b [EGD-3155] Adjust contact address in structures and DB api to be aligned with designs 2020-05-08 08:57:29 +02:00
Marcin Smoczyński
c47923d70a [EGD-3107] Call number validation
Use specialized class to to pass phone number between apps and services
instead of ambigious std::string. Introduced class (utils::PhoneNumber)
wraps calls to libphonenumber providing more convienient interface.
However using libphonenumber directly may be resource hungry in terms
of stack, heap and cpu usage, so helper class has been introduced to
pass information about phone numbers (utils::PhoneNumber::View). It is
designed to maintain integrity thus can be created from an instance of
utils::PhoneNumber only or moved/copied to.

Add new field to the calllog db holding e164 formatted number. Both
entered and e164 numbers will be needed to be able to match with
contacts correctly.

Add constexpr information about country codes (utils::country).
2020-05-05 00:51:53 +02:00