mirror of
https://github.com/mudita/MuditaOS.git
synced 2026-10-28 01:18:32 -04:00
Marcin Smoczyński
d0a43c0346
Fix duplicates detection when updating a contact. Before this change dupliates detection both for numbers and speed dial was not implemented at all. Fix contact update procedure - add unbinding procedure if a new number was bound to another contact before update. Do the same for speed dial. Fix invalid contact number tests (it wasn't taken into account that each section has clean db state). Signed-off-by: Marcin Smoczyński <smoczynski.marcin@gmail.com>
345 lines
15 KiB
C++
345 lines
15 KiB
C++
#include <catch2/catch.hpp>
|
|
|
|
#include "Interface/ContactRecord.hpp"
|
|
#include "i18/i18.hpp"
|
|
#include "vfs.hpp"
|
|
|
|
TEST_CASE("Contact Record tests")
|
|
{
|
|
Database::initialize();
|
|
|
|
vfs.remove(ContactsDB::GetDBName());
|
|
|
|
auto contactDB = std::make_unique<ContactsDB>();
|
|
REQUIRE(contactDB->isInitialized());
|
|
|
|
const char *primaryNameTest = "PrimaryNameTest";
|
|
const char *alternativeNameTest = "AlternativeNameTest";
|
|
const char *numberUserTest = "600123456";
|
|
const char *numberE164Test = "+48600123456";
|
|
const char *numberFormattedTest = "600 123 456";
|
|
const char *addressTest = "6 Czeczota St.\n02600 Warsaw";
|
|
const char *noteTest = "TestNote";
|
|
const char *mailTest = "TestMail";
|
|
const char *assetPath = "/Test/Path/To/Asset";
|
|
const char *speeddialTest = "100";
|
|
const ContactType contactTypeTest = ContactType ::USER;
|
|
const ContactNumberType contactNumberTypeTest = ContactNumberType ::PAGER;
|
|
|
|
ContactRecordInterface contRecInterface(contactDB.get());
|
|
|
|
ContactRecord recordIN;
|
|
|
|
recordIN.primaryName = primaryNameTest;
|
|
recordIN.alternativeName = alternativeNameTest;
|
|
recordIN.numbers = std::vector<ContactRecord::Number>({
|
|
ContactRecord::Number(numberUserTest, numberE164Test, contactNumberTypeTest),
|
|
});
|
|
recordIN.contactType = contactTypeTest;
|
|
recordIN.address = addressTest;
|
|
recordIN.note = noteTest;
|
|
recordIN.mail = mailTest;
|
|
recordIN.assetPath = assetPath;
|
|
recordIN.speeddial = speeddialTest;
|
|
|
|
REQUIRE(contRecInterface.Add(recordIN) == true);
|
|
REQUIRE(contRecInterface.Add(recordIN) == true);
|
|
REQUIRE(contRecInterface.Add(recordIN) == true);
|
|
REQUIRE(contRecInterface.Add(recordIN) == true);
|
|
REQUIRE(contRecInterface.Add(recordIN) == true);
|
|
|
|
SECTION("Get record by ID")
|
|
{
|
|
auto recordOUT = contRecInterface.GetByID(1);
|
|
|
|
REQUIRE(recordOUT.ID == 1);
|
|
|
|
REQUIRE(recordOUT.primaryName == primaryNameTest);
|
|
REQUIRE(recordOUT.alternativeName == alternativeNameTest);
|
|
REQUIRE(recordOUT.numbers.size() == 1);
|
|
REQUIRE(recordOUT.numbers[0].number.getEntered() == numberUserTest);
|
|
REQUIRE(recordOUT.numbers[0].number.getE164() == numberE164Test);
|
|
REQUIRE(recordOUT.numbers[0].numberType == contactNumberTypeTest);
|
|
REQUIRE(recordOUT.contactType == contactTypeTest);
|
|
REQUIRE(recordOUT.address == addressTest);
|
|
REQUIRE(recordOUT.note == noteTest);
|
|
REQUIRE(recordOUT.mail == mailTest);
|
|
REQUIRE(recordOUT.assetPath == assetPath);
|
|
REQUIRE(recordOUT.speeddial == speeddialTest);
|
|
}
|
|
|
|
REQUIRE(contRecInterface.RemoveByID(5) == true);
|
|
|
|
SECTION("Get records by limit offset")
|
|
{
|
|
auto recordList = contRecInterface.GetLimitOffset(0, 4);
|
|
REQUIRE(recordList->size() == 4);
|
|
|
|
uint32_t cnt = 1;
|
|
for (const auto w : *recordList) {
|
|
|
|
REQUIRE(w.ID == cnt++);
|
|
|
|
REQUIRE(w.primaryName == primaryNameTest);
|
|
REQUIRE(w.alternativeName == alternativeNameTest);
|
|
REQUIRE(w.numbers[0].number.getEntered() == numberUserTest);
|
|
REQUIRE(w.numbers[0].number.getE164() == numberE164Test);
|
|
REQUIRE(w.numbers[0].numberType == contactNumberTypeTest);
|
|
REQUIRE(w.contactType == contactTypeTest);
|
|
REQUIRE(w.address == addressTest);
|
|
REQUIRE(w.note == noteTest);
|
|
REQUIRE(w.mail == mailTest);
|
|
REQUIRE(w.assetPath == assetPath);
|
|
REQUIRE(w.speeddial == speeddialTest);
|
|
}
|
|
}
|
|
|
|
SECTION("Get records by limit offset by PrimaryName field")
|
|
{
|
|
auto recordList =
|
|
contRecInterface.GetLimitOffsetByField(0, 4, ContactRecordField::PrimaryName, primaryNameTest);
|
|
REQUIRE(recordList->size() == 4);
|
|
|
|
uint32_t cnt = 1;
|
|
for (const auto w : *recordList) {
|
|
|
|
REQUIRE(w.ID == cnt++);
|
|
|
|
REQUIRE(w.primaryName == primaryNameTest);
|
|
REQUIRE(w.alternativeName == alternativeNameTest);
|
|
REQUIRE(w.numbers[0].number.getEntered() == numberUserTest);
|
|
REQUIRE(w.numbers[0].number.getE164() == numberE164Test);
|
|
REQUIRE(w.numbers[0].numberType == contactNumberTypeTest);
|
|
REQUIRE(w.contactType == contactTypeTest);
|
|
REQUIRE(w.address == addressTest);
|
|
REQUIRE(w.note == noteTest);
|
|
REQUIRE(w.mail == mailTest);
|
|
REQUIRE(w.assetPath == assetPath);
|
|
REQUIRE(w.speeddial == speeddialTest);
|
|
}
|
|
}
|
|
|
|
SECTION("Get records by limit offset by NumberE164 filed")
|
|
{
|
|
auto recordList = contRecInterface.GetLimitOffsetByField(0, 2, ContactRecordField::NumberE164, numberE164Test);
|
|
REQUIRE(recordList->size() == 2);
|
|
|
|
uint32_t cnt = 1;
|
|
for (const auto w : *recordList) {
|
|
|
|
REQUIRE(w.ID == cnt++);
|
|
|
|
REQUIRE(w.primaryName == primaryNameTest);
|
|
REQUIRE(w.alternativeName == alternativeNameTest);
|
|
REQUIRE(w.numbers[0].number.getEntered() == numberUserTest);
|
|
REQUIRE(w.numbers[0].number.getE164() == numberE164Test);
|
|
REQUIRE(w.numbers[0].numberType == contactNumberTypeTest);
|
|
REQUIRE(w.contactType == contactTypeTest);
|
|
REQUIRE(w.address == addressTest);
|
|
REQUIRE(w.note == noteTest);
|
|
REQUIRE(w.mail == mailTest);
|
|
REQUIRE(w.assetPath == assetPath);
|
|
REQUIRE(w.speeddial == speeddialTest);
|
|
}
|
|
}
|
|
|
|
SECTION("Test contact name formatting")
|
|
{
|
|
ContactRecord testRecord;
|
|
|
|
testRecord.primaryName = primaryNameTest;
|
|
testRecord.alternativeName = alternativeNameTest;
|
|
testRecord.numbers = std::vector<ContactRecord::Number>({
|
|
ContactRecord::Number(numberUserTest, numberE164Test, contactNumberTypeTest),
|
|
});
|
|
|
|
std::stringstream primaryAlternativeNameFormat;
|
|
primaryAlternativeNameFormat << primaryNameTest << ' ' << alternativeNameTest;
|
|
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Default) ==
|
|
primaryAlternativeNameFormat.str());
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::List) == primaryAlternativeNameFormat.str());
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Title) ==
|
|
primaryAlternativeNameFormat.str());
|
|
|
|
testRecord.primaryName = "";
|
|
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Default) == alternativeNameTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::List) == alternativeNameTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Title) == alternativeNameTest);
|
|
|
|
testRecord.primaryName = primaryNameTest;
|
|
testRecord.alternativeName = "";
|
|
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Default) == primaryNameTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::List) == primaryNameTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Title) == primaryNameTest);
|
|
|
|
testRecord.primaryName = "";
|
|
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Default) == numberFormattedTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::List) == numberFormattedTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Title) ==
|
|
utils::localize.get("app_phonebook_contact_no_name"));
|
|
|
|
testRecord.numbers.clear();
|
|
testRecord.numbers = std::vector<ContactRecord::Number>({
|
|
ContactRecord::Number(),
|
|
ContactRecord::Number(numberUserTest, numberE164Test, contactNumberTypeTest),
|
|
});
|
|
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Default) == numberFormattedTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::List) == numberFormattedTest);
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Title) ==
|
|
utils::localize.get("app_phonebook_contact_no_name"));
|
|
|
|
testRecord.numbers.clear();
|
|
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Default) == "");
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::List) ==
|
|
utils::localize.get("app_phonebook_contact_no_name"));
|
|
REQUIRE(testRecord.getFormattedName(ContactRecord::NameFormatType::Title) ==
|
|
utils::localize.get("app_phonebook_contact_no_name"));
|
|
}
|
|
|
|
Database::deinitialize();
|
|
}
|
|
|
|
TEST_CASE("Contact record numbers update")
|
|
{
|
|
Database::initialize();
|
|
vfs.remove(ContactsDB::GetDBName());
|
|
|
|
auto contactDB = std::make_unique<ContactsDB>();
|
|
REQUIRE(contactDB->isInitialized());
|
|
|
|
auto records = ContactRecordInterface(contactDB.get());
|
|
|
|
ContactRecord testRecord, otherRecord;
|
|
std::array<std::string, 4> numbers = {{{"600100100"}, {"600100200"}, {"600100300"}, {"600100400"}}};
|
|
|
|
testRecord.primaryName = "number";
|
|
testRecord.alternativeName = "test";
|
|
testRecord.numbers = std::vector<ContactRecord::Number>(
|
|
{ContactRecord::Number(numbers[0], std::string("")), ContactRecord::Number(numbers[1], std::string(""))});
|
|
REQUIRE(records.Add(testRecord));
|
|
|
|
otherRecord.primaryName = "other";
|
|
otherRecord.alternativeName = "record";
|
|
otherRecord.numbers = std::vector<ContactRecord::Number>(
|
|
{ContactRecord::Number(numbers[2], std::string("")), ContactRecord::Number(numbers[3], std::string(""))});
|
|
REQUIRE(records.Add(otherRecord));
|
|
|
|
SECTION("No number update")
|
|
{
|
|
auto newRecord = records.GetByID(1);
|
|
REQUIRE(newRecord.numbers.size() == 2);
|
|
REQUIRE(records.Update(newRecord));
|
|
REQUIRE(contactDB->number.count() == 4);
|
|
|
|
auto validatationRecord = records.GetByID(1);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[0]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[1]);
|
|
|
|
validatationRecord = records.GetByID(2);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[2]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[3]);
|
|
}
|
|
|
|
SECTION("Remove and add number")
|
|
{
|
|
auto newRecord = records.GetByID(1);
|
|
REQUIRE(newRecord.numbers.size() == 2);
|
|
|
|
newRecord.numbers = std::vector<ContactRecord::Number>({ContactRecord::Number(numbers[1], std::string(""))});
|
|
REQUIRE(records.Update(newRecord));
|
|
|
|
REQUIRE(contactDB->number.count() == 3);
|
|
|
|
auto validatationRecord = records.GetByID(1);
|
|
REQUIRE(validatationRecord.numbers.size() == 1);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[1]);
|
|
|
|
validatationRecord = records.GetByID(2);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[2]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[3]);
|
|
|
|
newRecord.numbers = std::vector<ContactRecord::Number>(
|
|
{ContactRecord::Number(numbers[0], std::string("")), ContactRecord::Number(numbers[1], std::string(""))});
|
|
REQUIRE(records.Update(newRecord));
|
|
REQUIRE(contactDB->number.count() == 4);
|
|
|
|
validatationRecord = records.GetByID(1);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[0]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[1]);
|
|
|
|
validatationRecord = records.GetByID(2);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[2]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[3]);
|
|
}
|
|
|
|
SECTION("Change numbers positions")
|
|
{
|
|
auto newRecord = records.GetByID(1);
|
|
REQUIRE(newRecord.numbers.size() == 2);
|
|
REQUIRE(newRecord.numbers[0].number.getEntered() == numbers[0]);
|
|
REQUIRE(newRecord.numbers[1].number.getEntered() == numbers[1]);
|
|
|
|
newRecord.numbers = std::vector<ContactRecord::Number>(
|
|
{ContactRecord::Number(numbers[1], std::string("")), ContactRecord::Number(numbers[0], std::string(""))});
|
|
REQUIRE(records.Update(newRecord));
|
|
|
|
auto validatationRecord = records.GetByID(1);
|
|
REQUIRE(contactDB->number.count() == 4);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[1]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[0]);
|
|
}
|
|
|
|
SECTION("Single number update")
|
|
{
|
|
auto newRecord = records.GetByID(1);
|
|
REQUIRE(newRecord.numbers.size() == 2);
|
|
|
|
newRecord.numbers = std::vector<ContactRecord::Number>(
|
|
{ContactRecord::Number(numbers[2], std::string("")), ContactRecord::Number(numbers[1], std::string(""))});
|
|
REQUIRE(records.Update(newRecord));
|
|
REQUIRE(contactDB->number.count() == 3);
|
|
|
|
auto validatationRecord = records.GetByID(1);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[2]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[1]);
|
|
|
|
validatationRecord = records.GetByID(2);
|
|
REQUIRE(validatationRecord.numbers.size() == 1);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[3]);
|
|
}
|
|
|
|
SECTION("Change both numbers")
|
|
{
|
|
auto newRecord = records.GetByID(1);
|
|
REQUIRE(newRecord.numbers.size() == 2);
|
|
|
|
newRecord.numbers = std::vector<ContactRecord::Number>(
|
|
{ContactRecord::Number(numbers[2], std::string("")), ContactRecord::Number(numbers[3], std::string(""))});
|
|
REQUIRE(records.Update(newRecord));
|
|
REQUIRE(contactDB->number.count() == 2);
|
|
|
|
auto validatationRecord = records.GetByID(1);
|
|
REQUIRE(validatationRecord.numbers.size() == 2);
|
|
REQUIRE(validatationRecord.numbers[0].number.getEntered() == numbers[2]);
|
|
REQUIRE(validatationRecord.numbers[1].number.getEntered() == numbers[3]);
|
|
|
|
validatationRecord = records.GetByID(2);
|
|
REQUIRE(validatationRecord.numbers.size() == 0);
|
|
}
|
|
|
|
Database::deinitialize();
|
|
}
|