From e996c9eccc503d5ddd14d1e6dbcd6c8e4b56bfcd Mon Sep 17 00:00:00 2001
From: jokob-sk <jokob-sk@gmail.com>
Date: Sun, 23 Mar 2025 15:24:01 +1100
Subject: [PATCH] stop devParentMAC overwrite if specified  #1021

---
 server/scan/device_handling.py | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/server/scan/device_handling.py b/server/scan/device_handling.py
index 1a0d9623..3d8ef853 100755
--- a/server/scan/device_handling.py
+++ b/server/scan/device_handling.py
@@ -316,7 +316,10 @@ def update_devices_data_from_scan (db):
                     FROM CurrentScan        
                     WHERE Devices.devMac = CurrentScan.cur_MAC          
                 )
-                WHERE EXISTS (
+                WHERE 
+                    (devParentPort IS NULL OR devParentPort IN ("", "null", "(unknown)", "(Unknown)"))
+                    AND    
+                EXISTS (
                     SELECT 1
                     FROM CurrentScan
                     WHERE Devices.devMac = CurrentScan.cur_MAC
@@ -331,10 +334,13 @@ def update_devices_data_from_scan (db):
                     FROM CurrentScan
                     WHERE Devices.devMac = CurrentScan.cur_MAC
                 )
-                WHERE EXISTS (
-                    SELECT 1
-                    FROM CurrentScan
-                    WHERE Devices.devMac = CurrentScan.cur_MAC
+                  WHERE 
+                    (devParentMAC IS NULL OR devParentMAC IN ("", "null", "(unknown)", "(Unknown)"))
+                    AND                
+                    EXISTS (
+                        SELECT 1
+                        FROM CurrentScan
+                        WHERE Devices.devMac = CurrentScan.cur_MAC
                         AND CurrentScan.cur_NetworkNodeMAC IS NOT NULL AND CurrentScan.cur_NetworkNodeMAC NOT IN ("", "null")
                 )""")