Commit Graph

99 Commits

Author SHA1 Message Date
Jokob @NetAlertX
62c4833d0f Merge pull request #1672 from netalertx/next_release
BE: Removal of stdout.log
2026-06-14 10:58:09 +10:00
jokob-sk
76e7cc7b3d BE: Removal of stdout.log 2026-06-14 10:35:08 +10:00
Arvuno
6819f14448 feat(server): optional default for get_setting_value
get_setting_value returns an empty string when a key is not found,
which forces every call site to remember to treat '' as a sentinel
and provide its own fallback. The fallback is sometimes a hard-coded
default and sometimes a different code path entirely, leading to
inconsistent handling across the codebase.

Add an optional  argument that defaults to '' (preserves
the existing behaviour for every call site) and is returned when
the key is not present. New call sites can opt into a more
meaningful default without changing the function's signature for
existing callers.

Refs #1626.
2026-06-03 19:54:35 +00:00
jokob-sk
2d6e357fe5 BE+FE: new fields handling in views and skipping device heuristics for random macs
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2026-01-30 09:09:39 +11:00
jokob-sk
422a048806 feat: authoritative plugin fields
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2026-01-22 11:17:46 +11:00
Adam Outler
bb0c0e1c74 Coderabbit fixes:
- Mac
- Flask debug
- Threaded flask
- propagate token in GET requests
- enhance spec docs
- normalize MAC x2
- mcp disablement redundant private attribute
- run all tests imports
2026-01-19 01:12:48 +00:00
jokob-sk
5c9de70027 BE+FE: prefix|base64 implementation for SMTP_PASS #1337
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-12-12 12:56:56 +11:00
jokob-sk
139447b253 BE: mylog() better code radability
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-25 07:54:17 +11:00
jokob-sk
872ac1ce0f BE: linting fixes 3
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-22 21:06:03 +11:00
jokob-sk
ebeb7a07af BE: linting fixes 2
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-22 20:43:36 +11:00
jokob-sk
5c14b34a8b BE: linting fixes
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-22 13:14:06 +11:00
jokob-sk
a98bac331d MERGE: resolve conflicts
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-10 10:11:34 +11:00
Adam Outler
5b871865db /data and /tmp standarization 2025-11-09 17:03:25 +00:00
jokob-sk
cbe5a4a732 BE: version added to app_state
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-06 22:08:19 +11:00
jokob-sk
6374219e05 BE: github actions + dev version
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-06 20:47:28 +11:00
jokob-sk
c08eb1dbba BE: chore datetime_utils
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-05 16:08:04 +11:00
jokob-sk
0845b7f445 BE: name resolution did not apply regex cleanup
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-05 15:25:53 +11:00
jokob-sk
5452b7287b BE/PLG: TZ timestamp work #1251
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-04 19:52:19 +11:00
jokob-sk
80d7ef7f24 BE/PLG: TZ timestamp work #1251
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-04 19:46:50 +11:00
jokob-sk
dc4da5b4c9 BE/PLG: TZ timestamp work #1251
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-04 19:44:30 +11:00
jokob-sk
59477e7b38 BE/PLG: TZ timestamp work #1251
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-04 19:24:13 +11:00
jokob-sk
c52e44f90c BE/PLG: TZ timestamp work #1251
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-04 08:10:50 +11:00
jokob-sk
288427c939 BE/PLG: TZ timestamp work #1251
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-11-03 10:19:39 +11:00
jokob-sk
78ab0fbd2d PLG: SNMPDSC typo 2025-10-31 20:45:09 +11:00
jokob-sk
63d6410bb4 BE: handle missing buildtimestamp.txt
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-10-31 08:12:38 +11:00
Adam Outler
dfcc375fba Non-root launch 2025-09-25 14:10:06 -04:00
Claude Code
874b9b070e Security: Fix SQL injection vulnerabilities (Issue #1179)
This commit addresses multiple SQL injection vulnerabilities identified in the NetAlertX codebase:

1. **Primary Fix - reporting.py datetime injection**:
   - Fixed f-string SQL injection in down_devices section (line 98)
   - Replaced direct interpolation with validated integer casting
   - Added proper timezone offset handling

2. **Code Quality Improvements**:
   - Fixed type hint error in helper.py (datetime.datetime vs datetime)
   - Added security documentation and comments
   - Created comprehensive security test suite

3. **Security Enhancements**:
   - Documented remaining condition-based injection risks
   - Added input validation for numeric parameters
   - Implemented security testing framework

**Impact**: Prevents SQL injection attacks through datetime parameters
**Testing**: All security tests pass, including syntax validation
**Compliance**: Addresses security scan findings (Ruff S608)

Fixes #1179

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-17 22:26:47 -07:00
Ingo Ratsdorf
00c7bb65e1 Update server/helper.py
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-09-03 07:10:26 +12:00
Ingo Ratsdorf
5695f4f3e7 Adding secondary cache to settings
Caching get_setting_value independent from what backend is used.
2025-09-02 14:48:12 +12:00
jokob-sk
3a023a675f CPU optimization work 5 #1144
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-09-01 09:13:13 +10:00
jokob-sk
8c895864da CPU optimizartion work 4 #1144
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-09-01 08:45:41 +10:00
jokob-sk
90474a6b92 Merge branch 'main' of https://github.com/jokob-sk/NetAlertX 2025-09-01 08:33:38 +10:00
jokob-sk
98fdccb58f CPU optimizartion work 2 #1144
Signed-off-by: jokob-sk <jokob.sk@gmail.com>
2025-09-01 08:33:14 +10:00
Ingo Ratsdorf
36ea3e62fd Added cache to get_settings
The settings file  is read about 30 times per second and parsed from json. Cache function added for now.
2025-08-30 21:35:15 +12:00
jokob-sk
f78c84d9a8 api layer v0.3 - /events /sessions work 2025-08-21 22:36:22 +10:00
jokob-sk
915bb523d6 api layer v0.2.5 - /sessions + graphql tests 2025-08-21 15:10:47 +10:00
jokob-sk
962bbaa5a1 api layer v0.2.2 - CSV import/export, refactor 2025-08-19 07:56:54 +10:00
jokob-sk
b155fe2b06 api layer v0.1 2025-08-15 08:04:02 +10:00
jokob-sk
a6df204721 github timeout #1124, css fixes, change button on LOADED_PLUGINS 2025-08-05 21:32:35 +10:00
jokob-sk
e8e48a2cc4 integer causing normalization issue in MQTT #1102 2025-06-26 07:25:10 +10:00
jokob-sk
503027c06e debug Online_History #1020 2025-06-01 15:40:17 +10:00
jokob-sk
f4a3717859 FQDN, Dig refactor, docs #1065 2025-06-01 13:59:54 +10:00
jokob-sk
458577e071 mqtt and newdev name regex 2025-02-20 07:57:28 +11:00
jokob-sk
c8a40920b4 cleanup, faster devices screen update #967 #923 2025-01-20 23:42:24 +11:00
jokob-sk
729c24029f docs + fixes to CustomProps 2025-01-02 10:15:58 +11:00
jokob-sk
e52601e062 ENCRYPTION_KEY, docs 2024-12-31 10:14:01 +11:00
jokob-sk
7248e73e03 Respecting LOG_LEVEL in plugins 2024-12-22 13:18:08 +11:00
jokob-sk
89840906a0 ICMP plugin 🆕 2024-12-01 12:13:56 +11:00
jokob-sk
f1f40021ee chore:Settings DB table refactor 2024-11-23 09:28:40 +11:00
jokob-sk
0e438ffd57 chore:PHOLUS removal 2024-11-22 20:32:49 +11:00