mirror of
https://github.com/jokob-sk/NetAlertX.git
synced 2026-09-14 15:25:32 -04:00
copilot-swe-agent[bot]andjokob-sk
283bea21c9
When a parent device has NIC children, update_devPresentLastScan_based_on_nics previously replaced the parent's devPresentLastScan unconditionally with the NIC-derived value. This discarded any genuine direct detection of the parent: if the parent was found by ARP/save_own_device (present=1) but its NIC child was absent (present=0), the NIC step forced the parent back to 0. The next scan re-detected the parent → Connected event → NIC forced it down again, producing an endless one-directional Connected event stream. Fix: use max(original, nic_derived) so NIC children can only raise a parent's presence (bring an undetected parent online), never lower it when the parent itself was directly detected this cycle. Adds test/scan/test_nic_presence.py covering the exact regression scenario and surrounding cases (raise, no-NIC unchanged, req_all modes). Fixes #1736 Co-authored-by: jokob-sk <96159884+jokob-sk@users.noreply.github.com>
NetAlertX modules
The original pilaert.py code is now moved to this new folder and split into different modules.
| Module | Description |
|---|---|
__main__.py |
The MAIN program of NetAlertX |
__init__.py |
an empty init file |
README.md |
this readme file |
../server/plugins |
a folder containing all plugins that publish notifications or scan for devices |
api.py |
updating the API endpoints with the relevant data. |
appevent.py |
TBC |
const.py |
A place to define the constants for NetAlertX like log path or config path. |
conf.py |
conf.py holds the configuration variables and makes them available for all modules. It is also the workaround for global variables that need to be resolved at some point |
database.py |
This module connects to the DB, makes sure the DB is up to date and defines some standard queries and interfaces. |
device.py |
The device module looks after the devices and saves the scan results into the devices |
flows.py |
TBC |
helper.py |
Helper as the name suggest contains multiple little functions and methods used in many of the other modules and helps keep things clean |
initialise.py |
Initiatlise sets up the environment and makes everything ready to go |
logger.py |
Logger is there the keep all the logs organised and looking identical. |
networscan.py |
Networkscan collects the scan results (maybe to merge with reporting.py) |
notification.py |
Creates and handles the notification object and generates ther HTML and text variants of the message |
plugin.py |
This is where the plugins get integrated into the backend of NetAlertX |
plugin_utils.py |
Helper utilities for plugin.py |
reporting.py |
Reporting collects the data for the notification reports |
scheduler.py |
All things scheduling |