mirror of
https://github.com/jokob-sk/NetAlertX.git
synced 2026-09-16 08:10:15 -04:00
Mauricio CamayoandClaude Sonnet 5
091e648e88
resolve_host_mac() returns the manually configured MAC immediately, with no Socket Proxy /info call at all - the config.json text still described it as a fallback used only when auto-detection fails. Reworded both the setting's own description and the parent "Docker hosts" description to match actual behavior. The case-insensitivity regression test for lookup_device_mac() stubbed DeviceInstance.getByMac() to return a fixed row regardless of input, so it passed even without exercising real collation - functionally a duplicate of test_lookup_device_mac_found. Replaced it with a delegation check, and added real SQLite-backed coverage for DeviceInstance.getByMac()'s case-insensitivity in test/backend/test_device_instance.py. That surfaced a gap in the shared db_test_helpers.py fixture: its Devices.devMac column was missing the COLLATE NOCASE that the real schema declares, so it could not have exercised this behavior. Fixed the fixture to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011meLPKCzVpdZyAUfv5U6mm
97 lines
3.3 KiB
Python
97 lines
3.3 KiB
Python
"""
|
|
Unit tests for server/models/device_instance.py's DeviceInstance model methods.
|
|
|
|
Covers:
|
|
- DeviceInstance.getAllByName()
|
|
"""
|
|
|
|
import sys
|
|
import os
|
|
import unittest
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "server"))
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))
|
|
|
|
from db_test_helpers import make_db, make_device_dict, insert_device_from_dict
|
|
|
|
|
|
class TestGetAllByName(unittest.TestCase):
|
|
"""devName has no column-level collation (unlike devMac), so getAllByName()
|
|
must apply COLLATE NOCASE itself, and must return every match rather than
|
|
just one - callers (e.g. the dockerdisc plugin's resolve_host_mac()) rely
|
|
on the full set to detect an ambiguous (multiple-match) name."""
|
|
|
|
def setUp(self):
|
|
self.conn = make_db()
|
|
devices = [
|
|
make_device_dict("aa:bb:cc:dd:ee:01", devName="docker-host-1"),
|
|
make_device_dict("aa:bb:cc:dd:ee:02", devName="Docker-Host-1"),
|
|
make_device_dict("aa:bb:cc:dd:ee:03", devName="other-host"),
|
|
]
|
|
for d in devices:
|
|
insert_device_from_dict(self.conn, d)
|
|
self.conn.commit()
|
|
|
|
def _instance(self):
|
|
from models.device_instance import DeviceInstance
|
|
inst = DeviceInstance()
|
|
|
|
def _fetchall(q, p=()):
|
|
rows = self.conn.execute(q, p).fetchall()
|
|
return [dict(r) for r in rows]
|
|
inst._fetchall = _fetchall
|
|
return inst
|
|
|
|
def test_case_insensitive_match_returns_all_ambiguous_rows(self):
|
|
inst = self._instance()
|
|
results = inst.getAllByName("docker-host-1")
|
|
macs = {r["devMac"] for r in results}
|
|
self.assertEqual(macs, {"aa:bb:cc:dd:ee:01", "aa:bb:cc:dd:ee:02"})
|
|
|
|
def test_case_insensitive_match_different_case_query(self):
|
|
inst = self._instance()
|
|
results = inst.getAllByName("OTHER-HOST")
|
|
self.assertEqual(len(results), 1)
|
|
self.assertEqual(results[0]["devMac"], "aa:bb:cc:dd:ee:03")
|
|
|
|
def test_no_match_returns_empty_list(self):
|
|
inst = self._instance()
|
|
results = inst.getAllByName("does-not-exist")
|
|
self.assertEqual(results, [])
|
|
|
|
|
|
class TestGetByMac(unittest.TestCase):
|
|
"""devMac is declared COLLATE NOCASE at the column level (unlike
|
|
devName), so getByMac() relies on the schema rather than applying its
|
|
own COLLATE clause - this exercises that guarantee against a real
|
|
SQLite connection, not a mock."""
|
|
|
|
def setUp(self):
|
|
self.conn = make_db()
|
|
insert_device_from_dict(self.conn, make_device_dict("aa:bb:cc:dd:ee:ff"))
|
|
self.conn.commit()
|
|
|
|
def _instance(self):
|
|
from models.device_instance import DeviceInstance
|
|
inst = DeviceInstance()
|
|
|
|
def _fetchone(q, p=()):
|
|
row = self.conn.execute(q, p).fetchone()
|
|
return dict(row) if row else None
|
|
inst._fetchone = _fetchone
|
|
return inst
|
|
|
|
def test_case_insensitive_match(self):
|
|
inst = self._instance()
|
|
result = inst.getByMac("AA:BB:CC:DD:EE:FF")
|
|
self.assertIsNotNone(result)
|
|
self.assertEqual(result["devMac"], "aa:bb:cc:dd:ee:ff")
|
|
|
|
def test_no_match_returns_none(self):
|
|
inst = self._instance()
|
|
self.assertIsNone(inst.getByMac("00:00:00:00:00:00"))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|