diff --git a/app/src/main/kotlin/org/fossify/notes/adapters/ChecklistAdapter.kt b/app/src/main/kotlin/org/fossify/notes/adapters/ChecklistAdapter.kt index 561a35a5..4645b970 100644 --- a/app/src/main/kotlin/org/fossify/notes/adapters/ChecklistAdapter.kt +++ b/app/src/main/kotlin/org/fossify/notes/adapters/ChecklistAdapter.kt @@ -2,7 +2,6 @@ package org.fossify.notes.adapters import android.annotation.SuppressLint import android.graphics.Paint -import android.graphics.drawable.Drawable import android.util.TypedValue import android.view.Menu import android.view.MotionEvent @@ -14,7 +13,6 @@ import org.fossify.commons.activities.BaseSimpleActivity import org.fossify.commons.adapters.MyRecyclerViewAdapter import org.fossify.commons.extensions.applyColorFilter import org.fossify.commons.extensions.beVisibleIf -import org.fossify.commons.extensions.getColoredDrawableWithColor import org.fossify.commons.extensions.removeBit import org.fossify.commons.helpers.SORT_BY_CUSTOM import org.fossify.commons.interfaces.ItemMoveCallback @@ -40,14 +38,11 @@ class ChecklistAdapter( itemClick: (Any) -> Unit, ) : MyRecyclerViewAdapter(activity, recyclerView, itemClick), ItemTouchHelperContract { - private lateinit var crossDrawable: Drawable - private lateinit var checkDrawable: Drawable private var touchHelper: ItemTouchHelper? = null private var startReorderDragListener: StartReorderDragListener init { setupDragListener(true) - initDrawables() touchHelper = ItemTouchHelper(ItemMoveCallback(this)) touchHelper!!.attachToRecyclerView(recyclerView) @@ -116,18 +111,6 @@ class ChecklistAdapter( override fun getItemCount() = items.size - private fun initDrawables() { - val res = activity.resources - crossDrawable = res.getColoredDrawableWithColor( - org.fossify.commons.R.drawable.ic_cross_vector, - res.getColor(org.fossify.commons.R.color.md_red_700) - ) - checkDrawable = res.getColoredDrawableWithColor( - org.fossify.commons.R.drawable.ic_check_vector, - res.getColor(org.fossify.commons.R.color.md_green_700) - ) - } - private fun renameChecklistItem() { val item = getSelectedItems().first() RenameChecklistItemDialog(activity, item.title) { @@ -222,13 +205,14 @@ class ChecklistAdapter( } } - checklistImage.setImageDrawable(if (checklistItem.isDone) checkDrawable else crossDrawable) - checklistImage.beVisibleIf(showIcons && selectedKeys.isEmpty()) + checklistCross.applyColorFilter(textColor) + checklistCross.beVisibleIf(showIcons && selectedKeys.isEmpty()) + checklistCheckbox.isChecked = checklistItem.isDone checklistHolder.isSelected = isSelected checklistDragHandle.beVisibleIf(selectedKeys.isNotEmpty()) checklistDragHandle.applyColorFilter(textColor) - checklistDragHandle.setOnTouchListener { v, event -> + checklistDragHandle.setOnTouchListener { _, event -> if (event.action == MotionEvent.ACTION_DOWN) { startReorderDragListener.requestDrag(holder) } diff --git a/app/src/main/res/layout/fragment_checklist.xml b/app/src/main/res/layout/fragment_checklist.xml index 91e813cc..8d2b96ce 100644 --- a/app/src/main/res/layout/fragment_checklist.xml +++ b/app/src/main/res/layout/fragment_checklist.xml @@ -61,6 +61,7 @@ android:layout_height="match_parent" android:clipToPadding="false" android:overScrollMode="never" + android:paddingTop="@dimen/small_margin" android:paddingBottom="@dimen/secondary_fab_bottom_margin" android:visibility="gone" app:layoutManager="org.fossify.commons.views.MyLinearLayoutManager" /> diff --git a/app/src/main/res/layout/item_checklist.xml b/app/src/main/res/layout/item_checklist.xml index 73840d24..d6b13461 100644 --- a/app/src/main/res/layout/item_checklist.xml +++ b/app/src/main/res/layout/item_checklist.xml @@ -9,26 +9,41 @@ android:clickable="true" android:focusable="true" android:foreground="@drawable/selector" - android:paddingEnd="@dimen/normal_margin"> + android:minHeight="@dimen/checklist_height" + android:paddingStart="@dimen/normal_margin" + android:paddingEnd="@dimen/small_margin"> + + + tools:text="Apples 🍎" /> - 56dp + 56dp + 48dp 150dp 150dp 500dp