mirror of
https://github.com/ImranR98/Obtainium.git
synced 2026-07-31 01:17:08 -04:00
c911cba670
Critical fixes: - Remove setTrustedCertificatesBytes which replaced the entire TLS trust store - Fix late final async init race causing LateInitializationError crashes - Fix infinite recursion in ObtainiumError.message for MULTI_ERROR code High fixes: - Fix identical() always returning false on badge icon (update count never shown) - Clone form items before mutation to prevent cross-contamination between sources - Log transient errors before removing apps on load failure - Await uninstallApp calls instead of fire-and-forget - Revert optimistic install on background workaround failure - Log SAF errors before silently disabling export directory Medium fixes: - Remove dead GeneratedForm.fromDefinitions constructor and unused fields - Replace Shizuku-specific param with generic installOptions map in Installer interface - Add importable-keys allowlist to prevent arbitrary SharedPreferences writes - Guard against stale Shizuku permission check callbacks with sequence counter - Prevent ReceivePort leak in listenForDownloadCancelFromMain - Add 500MB tarball size guard to prevent OOM on large archives - Simplify ReDoS-vulnerable URL regex in html.dart - Fix TOCTOU race between existsSync and length calls - Log rename failures instead of empty catch blocks - Use safe null-aware defaults in setFormValuesFromMap
95 lines
3.7 KiB
Dart
95 lines
3.7 KiB
Dart
import 'package:obtainium/providers/settings_provider.dart';
|
|
import 'package:obtainium/providers/source_provider.dart';
|
|
|
|
/// Android PackageInstaller status codes: 0 = success, 3 = already installed / pending.
|
|
const int installSuccessCode = 0;
|
|
const int installAlreadyPendingCode = 3;
|
|
|
|
enum InstallOutcome { success, cancelled, alreadyInstalled, error }
|
|
|
|
/// Unified result of an install operation, replacing the previous
|
|
/// "nullable int code" pattern used by the platform install APIs.
|
|
class InstallResult {
|
|
final InstallOutcome outcome;
|
|
final int? errorCode;
|
|
|
|
const InstallResult({required this.outcome, this.errorCode});
|
|
|
|
factory InstallResult.success() =>
|
|
const InstallResult(outcome: InstallOutcome.success);
|
|
|
|
factory InstallResult.cancelled() =>
|
|
const InstallResult(outcome: InstallOutcome.cancelled);
|
|
|
|
factory InstallResult.alreadyInstalled() =>
|
|
const InstallResult(outcome: InstallOutcome.alreadyInstalled);
|
|
|
|
factory InstallResult.error(int code) =>
|
|
InstallResult(outcome: InstallOutcome.error, errorCode: code);
|
|
|
|
/// Maps a raw platform install status code to an [InstallResult].
|
|
/// [installSuccessCode] is a completed install, [installAlreadyPendingCode]
|
|
/// is a pending/no-op (e.g. already installed), a null code is treated as
|
|
/// cancelled, and any other value is an error carrying the original code.
|
|
factory InstallResult.fromPlatformCode(int? code) {
|
|
if (code == null) {
|
|
return InstallResult.cancelled();
|
|
}
|
|
if (code == installAlreadyPendingCode) {
|
|
return InstallResult.alreadyInstalled();
|
|
}
|
|
if (code == installSuccessCode) {
|
|
return InstallResult.success();
|
|
}
|
|
return InstallResult.error(code);
|
|
}
|
|
|
|
bool get isSuccess => outcome == InstallOutcome.success;
|
|
bool get isCancelled => outcome == InstallOutcome.cancelled;
|
|
bool get isAlreadyInstalled => outcome == InstallOutcome.alreadyInstalled;
|
|
bool get isError => outcome == InstallOutcome.error;
|
|
}
|
|
|
|
/// Strategy that performs the platform-specific parts of an app installation.
|
|
///
|
|
/// Implementations are intentionally thin: the surrounding harness in
|
|
/// [AppsProvider] handles download validation, downgrade checks, the background
|
|
/// completion workaround, persistence, file cleanup, and notifications. An
|
|
/// installer only decides silent-install eligibility, manages its own
|
|
/// permissions, and performs the terminal platform call.
|
|
abstract class Installer {
|
|
final SettingsProvider settingsProvider;
|
|
|
|
Installer(this.settingsProvider);
|
|
|
|
/// Unique key identifying this installer mode (e.g. 'stock', 'shizuku',
|
|
/// 'external').
|
|
String get modeKey;
|
|
|
|
/// Whether directory/bundle installs should hand off the original container
|
|
/// file (XAPK/ZIP/tarball) rather than extracted split APKs.
|
|
bool get wantsContainerHandoff => false;
|
|
|
|
/// The installer-specific portion of the silent-install decision. Shared
|
|
/// pre-checks (background updates enabled, exemptions, multi-URL, target SDK)
|
|
/// are handled by the caller before this is invoked.
|
|
Future<bool> canInstallSilently(App app);
|
|
|
|
/// Whether the installer currently has the privileges needed to install
|
|
/// without prompting the user. Does not prompt.
|
|
Future<bool> checkPermission();
|
|
|
|
/// Ensures the installer has the privileges needed to install, prompting the
|
|
/// user if necessary. Throws an [ObtainiumError] if permission is denied.
|
|
Future<void> ensurePermission();
|
|
|
|
/// Installs one or more APK file paths (a base APK plus optional splits).
|
|
/// [installOptions] carries installer-specific key-value flags (e.g. Shizuku's
|
|
/// `shizukuPretendToBeGooglePlay`).
|
|
Future<InstallResult> installApk(
|
|
List<String> apkFilePaths, {
|
|
required String appId,
|
|
Map<String, dynamic> installOptions = const {},
|
|
});
|
|
}
|